Re: [PATCH v3 6/9] ARM: mvebu: add pinctrl device in DT for Armada 370/XP SoCs
On 09/12/2012 12:56 AM, Thomas Petazzoni wrote: > Le Tue, 11 Sep 2012 16:23:19 -0600, > Stephen Warren a écrit : > >> On 09/10/2012 02:39 AM, Sebastian Hesselbarth wrote: >>> From: Thomas Petazzoni >>> >>> The Armada 370 and XP SoCs have configurable muxing for a certain >>> number of their pins, controlled through a pinctrl driver. >> >> Hmmm. I'd be tempted just to put the entire node definition there; >> putting in a .dtsi file just to share the reg property doesn't seem >> especially useful. > > When you say "here" you're mentioning the SoC-specific .dtsi files (i.e (s/here/there I assume). > the ones in PATCH 7/9 and PATCH 8/9), correct? Yes, I believe so. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3 6/9] ARM: mvebu: add pinctrl device in DT for Armada 370/XP SoCs
Le Tue, 11 Sep 2012 16:23:19 -0600,
Stephen Warren a écrit :
> On 09/10/2012 02:39 AM, Sebastian Hesselbarth wrote:
> > From: Thomas Petazzoni
> >
> > The Armada 370 and XP SoCs have configurable muxing for a certain
> > number of their pins, controlled through a pinctrl driver.
>
> Hmmm. I'd be tempted just to put the entire node definition there;
> putting in a .dtsi file just to share the reg property doesn't seem
> especially useful.
When you say "here" you're mentioning the SoC-specific .dtsi files (i.e
the ones in PATCH 7/9 and PATCH 8/9), correct?
> > The 'compatible' property is defined in the SoC-specific .dtsi files,
> > since the compatible string identifies the number of pins and other
> > SoC-specific properties.
>
> > diff --git a/arch/arm/boot/dts/armada-370-xp.dtsi
> > b/arch/arm/boot/dts/armada-370-xp.dtsi
>
> > + pinctrl@d0018000 {
>
> If this is the only pinctrl instance, you'd typically name the node just
> "pinctrl", since the "@d0018000" isn't needed to get unique node names.
Ack.
> > + reg = <0xd0018000 0x38>;
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + ranges;
>
> What is "ranges" for; this isn't a memory-mapped bus, right?
Ack.
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3 6/9] ARM: mvebu: add pinctrl device in DT for Armada 370/XP SoCs
Le Tue, 11 Sep 2012 16:23:19 -0600,
Stephen Warren swar...@wwwdotorg.org a écrit :
On 09/10/2012 02:39 AM, Sebastian Hesselbarth wrote:
From: Thomas Petazzoni thomas.petazz...@free-electrons.com
The Armada 370 and XP SoCs have configurable muxing for a certain
number of their pins, controlled through a pinctrl driver.
Hmmm. I'd be tempted just to put the entire node definition there;
putting in a .dtsi file just to share the reg property doesn't seem
especially useful.
When you say here you're mentioning the SoC-specific .dtsi files (i.e
the ones in PATCH 7/9 and PATCH 8/9), correct?
The 'compatible' property is defined in the SoC-specific .dtsi files,
since the compatible string identifies the number of pins and other
SoC-specific properties.
diff --git a/arch/arm/boot/dts/armada-370-xp.dtsi
b/arch/arm/boot/dts/armada-370-xp.dtsi
+ pinctrl@d0018000 {
If this is the only pinctrl instance, you'd typically name the node just
pinctrl, since the @d0018000 isn't needed to get unique node names.
Ack.
+ reg = 0xd0018000 0x38;
+ #address-cells = 1;
+ #size-cells = 1;
+ ranges;
What is ranges for; this isn't a memory-mapped bus, right?
Ack.
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3 6/9] ARM: mvebu: add pinctrl device in DT for Armada 370/XP SoCs
On 09/12/2012 12:56 AM, Thomas Petazzoni wrote: Le Tue, 11 Sep 2012 16:23:19 -0600, Stephen Warren swar...@wwwdotorg.org a écrit : On 09/10/2012 02:39 AM, Sebastian Hesselbarth wrote: From: Thomas Petazzoni thomas.petazz...@free-electrons.com The Armada 370 and XP SoCs have configurable muxing for a certain number of their pins, controlled through a pinctrl driver. Hmmm. I'd be tempted just to put the entire node definition there; putting in a .dtsi file just to share the reg property doesn't seem especially useful. When you say here you're mentioning the SoC-specific .dtsi files (i.e (s/here/there I assume). the ones in PATCH 7/9 and PATCH 8/9), correct? Yes, I believe so. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3 6/9] ARM: mvebu: add pinctrl device in DT for Armada 370/XP SoCs
On 09/10/2012 02:39 AM, Sebastian Hesselbarth wrote:
> From: Thomas Petazzoni
>
> The Armada 370 and XP SoCs have configurable muxing for a certain
> number of their pins, controlled through a pinctrl driver.
Hmmm. I'd be tempted just to put the entire node definition there;
putting in a .dtsi file just to share the reg property doesn't seem
especially useful.
> The 'compatible' property is defined in the SoC-specific .dtsi files,
> since the compatible string identifies the number of pins and other
> SoC-specific properties.
> diff --git a/arch/arm/boot/dts/armada-370-xp.dtsi
> b/arch/arm/boot/dts/armada-370-xp.dtsi
> + pinctrl@d0018000 {
If this is the only pinctrl instance, you'd typically name the node just
"pinctrl", since the "@d0018000" isn't needed to get unique node names.
> + reg = <0xd0018000 0x38>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
What is "ranges" for; this isn't a memory-mapped bus, right?
> + };
> };
> };
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3 6/9] ARM: mvebu: add pinctrl device in DT for Armada 370/XP SoCs
On 09/10/2012 02:39 AM, Sebastian Hesselbarth wrote:
From: Thomas Petazzoni thomas.petazz...@free-electrons.com
The Armada 370 and XP SoCs have configurable muxing for a certain
number of their pins, controlled through a pinctrl driver.
Hmmm. I'd be tempted just to put the entire node definition there;
putting in a .dtsi file just to share the reg property doesn't seem
especially useful.
The 'compatible' property is defined in the SoC-specific .dtsi files,
since the compatible string identifies the number of pins and other
SoC-specific properties.
diff --git a/arch/arm/boot/dts/armada-370-xp.dtsi
b/arch/arm/boot/dts/armada-370-xp.dtsi
+ pinctrl@d0018000 {
If this is the only pinctrl instance, you'd typically name the node just
pinctrl, since the @d0018000 isn't needed to get unique node names.
+ reg = 0xd0018000 0x38;
+ #address-cells = 1;
+ #size-cells = 1;
+ ranges;
What is ranges for; this isn't a memory-mapped bus, right?
+ };
};
};
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH v3 6/9] ARM: mvebu: add pinctrl device in DT for Armada 370/XP SoCs
From: Thomas Petazzoni
The Armada 370 and XP SoCs have configurable muxing for a certain
number of their pins, controlled through a pinctrl driver.
The 'compatible' property is defined in the SoC-specific .dtsi files,
since the compatible string identifies the number of pins and other
SoC-specific properties.
Signed-off-by: Thomas Petazzoni
Acked-by: Linus Walleij
---
v3:
- cleaned whitespaces
Cc: Sebastian Hesselbarth
Cc: Thomas Petazzoni
Cc: Grant Likely
Cc: Rob Herring
Cc: Rob Landley
Cc: Russell King
Cc: Lior Amsalem
Cc: Andrew Lunn
Cc: Jason Cooper
Cc: Gregory CLEMENT
Cc: Ben Dooks
Cc: Linus Walleij
Cc: Stephen Warren
Cc: devicetree-disc...@lists.ozlabs.org
Cc: linux-...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-arm-ker...@lists.infradead.org
---
arch/arm/boot/dts/armada-370-xp.dtsi |7 +++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/boot/dts/armada-370-xp.dtsi
b/arch/arm/boot/dts/armada-370-xp.dtsi
index 16cc82c..ff1c7a6 100644
--- a/arch/arm/boot/dts/armada-370-xp.dtsi
+++ b/arch/arm/boot/dts/armada-370-xp.dtsi
@@ -68,6 +68,13 @@
compatible = "marvell,armada-addr-decoding-controller";
reg = <0xd002 0x258>;
};
+
+ pinctrl@d0018000 {
+ reg = <0xd0018000 0x38>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges;
+ };
};
};
--
1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH v3 6/9] ARM: mvebu: add pinctrl device in DT for Armada 370/XP SoCs
From: Thomas Petazzoni thomas.petazz...@free-electrons.com
The Armada 370 and XP SoCs have configurable muxing for a certain
number of their pins, controlled through a pinctrl driver.
The 'compatible' property is defined in the SoC-specific .dtsi files,
since the compatible string identifies the number of pins and other
SoC-specific properties.
Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com
Acked-by: Linus Walleij linus.wall...@linaro.org
---
v3:
- cleaned whitespaces
Cc: Sebastian Hesselbarth sebastian.hesselba...@gmail.com
Cc: Thomas Petazzoni thomas.petazz...@free-electrons.com
Cc: Grant Likely grant.lik...@secretlab.ca
Cc: Rob Herring rob.herr...@calxeda.com
Cc: Rob Landley r...@landley.net
Cc: Russell King li...@arm.linux.org.uk
Cc: Lior Amsalem al...@marvell.com
Cc: Andrew Lunn and...@lunn.ch
Cc: Jason Cooper ja...@lakedaemon.net
Cc: Gregory CLEMENT gregory.clem...@free-electrons.com
Cc: Ben Dooks ben.do...@codethink.co.uk
Cc: Linus Walleij linus.wall...@linaro.org
Cc: Stephen Warren swar...@wwwdotorg.org
Cc: devicetree-disc...@lists.ozlabs.org
Cc: linux-...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-arm-ker...@lists.infradead.org
---
arch/arm/boot/dts/armada-370-xp.dtsi |7 +++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/boot/dts/armada-370-xp.dtsi
b/arch/arm/boot/dts/armada-370-xp.dtsi
index 16cc82c..ff1c7a6 100644
--- a/arch/arm/boot/dts/armada-370-xp.dtsi
+++ b/arch/arm/boot/dts/armada-370-xp.dtsi
@@ -68,6 +68,13 @@
compatible = marvell,armada-addr-decoding-controller;
reg = 0xd002 0x258;
};
+
+ pinctrl@d0018000 {
+ reg = 0xd0018000 0x38;
+ #address-cells = 1;
+ #size-cells = 1;
+ ranges;
+ };
};
};
--
1.7.10.4
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
