Re: [f2fs-dev] [PATCH v4] f2fs: introduce discard_granularity sysfs entry
Hi Ju Hyung, Jaegeuk,
On 2017/10/4 4:17, Jaegeuk Kim wrote:
> On 10/04, Ju Hyung Park wrote:
>> Hi Chao.
>>
>> Yep, that patch seems to have fixed it.
>> Doing "while true; do fstrim -v /; done" while "rm -rf"ing a 2GB
>> kbuild directory
>> (with lots of small .o files and stuff) ended flawlessly.
Thanks for the test. ;)
>>
>> I hope to see this patch merged with next 4.14 merge cycle.
>
> Cool! I'll merge this patch and submit for 4.14. :)
Thanks for the quick merging. ;)
Thanks,
>
> Thanks,
>
>>
>> Thanks :)
>>
>> On Tue, Oct 3, 2017 at 12:59 AM, Chao Yu wrote:
>>> Hi Park,
>>>
>>> Thanks for the report, could have a try with below patch:
>>>
>>> From 5fa30e8cdcb93f210e25142c48a884be383c6121 Mon Sep 17 00:00:00 2001
>>> From: Chao Yu
>>> Date: Mon, 2 Oct 2017 02:50:16 +0800
>>> Subject: [PATCH] f2fs: fix potential panic during fstrim
>>>
>>> As Ju Hyung Park reported:
>>>
>>> "When 'fstrim' is called for manual trim, a BUG() can be triggered
>>> randomly with this patch.
>>>
>>> I'm seeing this issue on both x86 Desktop and arm64 Android phone.
>>>
>>> On x86 Desktop, this was caused during Ubuntu boot-up. I have a
>>> cronjob installed which calls 'fstrim -v /' during boot. On arm64
>>> Android, this was caused during GC looping with 1ms gc_min_sleep_time
>>> & gc_max_sleep_time."
>>>
>>> Root cause of this issue is that f2fs_wait_discard_bios can only be
>>> used by f2fs_put_super, because during put_super there must be no
>>> other referrers, so it can ignore discard entry's reference count
>>> when removing the entry, otherwise in other caller we will hit bug_on
>>> in __remove_discard_cmd as there may be other issuer added reference
>>> count in discard entry.
>>>
>>> Thread AThread B
>>> - issue_discard_thread
>>> - f2fs_ioc_fitrim
>>> - f2fs_trim_fs
>>> - f2fs_wait_discard_bios
>>>- __issue_discard_cmd
>>> - __submit_discard_cmd
>>> - __wait_discard_cmd
>>> - dc->ref++
>>> - __wait_one_discard_bio
>>>- __wait_discard_cmd
>>> - __remove_discard_cmd
>>> - f2fs_bug_on(sbi, dc->ref)
>>>
>>> Fixes: 969d1b180d987c2be02de890d0fff0f66a0e80de
>>> Reported-by: Ju Hyung Park
>>> Signed-off-by: Chao Yu
>>> ---
>>> fs/f2fs/f2fs.h| 2 +-
>>> fs/f2fs/segment.c | 6 +++---
>>> fs/f2fs/super.c | 2 +-
>>> 3 files changed, 5 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
>>> index 9a7c90386947..4b4a72f392be 100644
>>> --- a/fs/f2fs/f2fs.h
>>> +++ b/fs/f2fs/f2fs.h
>>> @@ -2525,7 +2525,7 @@ void invalidate_blocks(struct f2fs_sb_info *sbi,
>>> block_t addr);
>>> bool is_checkpointed_data(struct f2fs_sb_info *sbi, block_t blkaddr);
>>> void refresh_sit_entry(struct f2fs_sb_info *sbi, block_t old, block_t new);
>>> void stop_discard_thread(struct f2fs_sb_info *sbi);
>>> -void f2fs_wait_discard_bios(struct f2fs_sb_info *sbi);
>>> +void f2fs_wait_discard_bios(struct f2fs_sb_info *sbi, bool umount);
>>> void clear_prefree_segments(struct f2fs_sb_info *sbi, struct cp_control
>>> *cpc);
>>> void release_discard_addrs(struct f2fs_sb_info *sbi);
>>> int npages_for_summary_flush(struct f2fs_sb_info *sbi, bool for_ra);
>>> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
>>> index dedf0209d820..e28245b7e44e 100644
>>> --- a/fs/f2fs/segment.c
>>> +++ b/fs/f2fs/segment.c
>>> @@ -1210,11 +1210,11 @@ void stop_discard_thread(struct f2fs_sb_info *sbi)
>>> }
>>>
>>> /* This comes from f2fs_put_super and f2fs_trim_fs */
>>> -void f2fs_wait_discard_bios(struct f2fs_sb_info *sbi)
>>> +void f2fs_wait_discard_bios(struct f2fs_sb_info *sbi, bool umount)
>>> {
>>> __issue_discard_cmd(sbi, false);
>>> __drop_discard_cmd(sbi);
>>> - __wait_discard_cmd(sbi, false);
>>> + __wait_discard_cmd(sbi, !umount);
>>> }
>>>
>>> static void mark_discard_range_all(struct f2fs_sb_info *sbi)
>>> @@ -2244,7 +2244,7 @@ int f2fs_trim_fs(struct f2fs_sb_info *sbi, struct
>>> fstrim_range *range)
>>> }
>>> /* It's time to issue all the filed discards */
>>> mark_discard_range_all(sbi);
>>> - f2fs_wait_discard_bios(sbi);
>>> + f2fs_wait_discard_bios(sbi, false);
>>> out:
>>> range->len = F2FS_BLK_TO_BYTES(cpc.trimmed);
>>> return err;
>>> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
>>> index 89f61eb3d167..933c3d529e65 100644
>>> --- a/fs/f2fs/super.c
>>> +++ b/fs/f2fs/super.c
>>> @@ -801,7 +801,7 @@ static void f2fs_put_super(struct super_block *sb)
>>> }
>>>
>>> /* be sure to wait for any on-going discard commands */
>>> - f2fs_wait_discard_bios(sbi);
>>> + f2fs_wait_discard_bios(sbi, true);
>>>
>>> if (f2fs_discard_en(sbi) && !sbi->discard_blks) {
>>> struct cp_control cpc = {
>>> --
>>> 2.14.1.145.gb3622a4ee
>>>
>>> On 2017/10/2 3:29, Ju Hy
Re: [f2fs-dev] [PATCH v4] f2fs: introduce discard_granularity sysfs entry
On 10/04, Ju Hyung Park wrote:
> Hi Chao.
>
> Yep, that patch seems to have fixed it.
> Doing "while true; do fstrim -v /; done" while "rm -rf"ing a 2GB
> kbuild directory
> (with lots of small .o files and stuff) ended flawlessly.
>
> I hope to see this patch merged with next 4.14 merge cycle.
Cool! I'll merge this patch and submit for 4.14. :)
Thanks,
>
> Thanks :)
>
> On Tue, Oct 3, 2017 at 12:59 AM, Chao Yu wrote:
> > Hi Park,
> >
> > Thanks for the report, could have a try with below patch:
> >
> > From 5fa30e8cdcb93f210e25142c48a884be383c6121 Mon Sep 17 00:00:00 2001
> > From: Chao Yu
> > Date: Mon, 2 Oct 2017 02:50:16 +0800
> > Subject: [PATCH] f2fs: fix potential panic during fstrim
> >
> > As Ju Hyung Park reported:
> >
> > "When 'fstrim' is called for manual trim, a BUG() can be triggered
> > randomly with this patch.
> >
> > I'm seeing this issue on both x86 Desktop and arm64 Android phone.
> >
> > On x86 Desktop, this was caused during Ubuntu boot-up. I have a
> > cronjob installed which calls 'fstrim -v /' during boot. On arm64
> > Android, this was caused during GC looping with 1ms gc_min_sleep_time
> > & gc_max_sleep_time."
> >
> > Root cause of this issue is that f2fs_wait_discard_bios can only be
> > used by f2fs_put_super, because during put_super there must be no
> > other referrers, so it can ignore discard entry's reference count
> > when removing the entry, otherwise in other caller we will hit bug_on
> > in __remove_discard_cmd as there may be other issuer added reference
> > count in discard entry.
> >
> > Thread AThread B
> > - issue_discard_thread
> > - f2fs_ioc_fitrim
> > - f2fs_trim_fs
> > - f2fs_wait_discard_bios
> >- __issue_discard_cmd
> > - __submit_discard_cmd
> > - __wait_discard_cmd
> > - dc->ref++
> > - __wait_one_discard_bio
> >- __wait_discard_cmd
> > - __remove_discard_cmd
> > - f2fs_bug_on(sbi, dc->ref)
> >
> > Fixes: 969d1b180d987c2be02de890d0fff0f66a0e80de
> > Reported-by: Ju Hyung Park
> > Signed-off-by: Chao Yu
> > ---
> > fs/f2fs/f2fs.h| 2 +-
> > fs/f2fs/segment.c | 6 +++---
> > fs/f2fs/super.c | 2 +-
> > 3 files changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> > index 9a7c90386947..4b4a72f392be 100644
> > --- a/fs/f2fs/f2fs.h
> > +++ b/fs/f2fs/f2fs.h
> > @@ -2525,7 +2525,7 @@ void invalidate_blocks(struct f2fs_sb_info *sbi,
> > block_t addr);
> > bool is_checkpointed_data(struct f2fs_sb_info *sbi, block_t blkaddr);
> > void refresh_sit_entry(struct f2fs_sb_info *sbi, block_t old, block_t new);
> > void stop_discard_thread(struct f2fs_sb_info *sbi);
> > -void f2fs_wait_discard_bios(struct f2fs_sb_info *sbi);
> > +void f2fs_wait_discard_bios(struct f2fs_sb_info *sbi, bool umount);
> > void clear_prefree_segments(struct f2fs_sb_info *sbi, struct cp_control
> > *cpc);
> > void release_discard_addrs(struct f2fs_sb_info *sbi);
> > int npages_for_summary_flush(struct f2fs_sb_info *sbi, bool for_ra);
> > diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> > index dedf0209d820..e28245b7e44e 100644
> > --- a/fs/f2fs/segment.c
> > +++ b/fs/f2fs/segment.c
> > @@ -1210,11 +1210,11 @@ void stop_discard_thread(struct f2fs_sb_info *sbi)
> > }
> >
> > /* This comes from f2fs_put_super and f2fs_trim_fs */
> > -void f2fs_wait_discard_bios(struct f2fs_sb_info *sbi)
> > +void f2fs_wait_discard_bios(struct f2fs_sb_info *sbi, bool umount)
> > {
> > __issue_discard_cmd(sbi, false);
> > __drop_discard_cmd(sbi);
> > - __wait_discard_cmd(sbi, false);
> > + __wait_discard_cmd(sbi, !umount);
> > }
> >
> > static void mark_discard_range_all(struct f2fs_sb_info *sbi)
> > @@ -2244,7 +2244,7 @@ int f2fs_trim_fs(struct f2fs_sb_info *sbi, struct
> > fstrim_range *range)
> > }
> > /* It's time to issue all the filed discards */
> > mark_discard_range_all(sbi);
> > - f2fs_wait_discard_bios(sbi);
> > + f2fs_wait_discard_bios(sbi, false);
> > out:
> > range->len = F2FS_BLK_TO_BYTES(cpc.trimmed);
> > return err;
> > diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> > index 89f61eb3d167..933c3d529e65 100644
> > --- a/fs/f2fs/super.c
> > +++ b/fs/f2fs/super.c
> > @@ -801,7 +801,7 @@ static void f2fs_put_super(struct super_block *sb)
> > }
> >
> > /* be sure to wait for any on-going discard commands */
> > - f2fs_wait_discard_bios(sbi);
> > + f2fs_wait_discard_bios(sbi, true);
> >
> > if (f2fs_discard_en(sbi) && !sbi->discard_blks) {
> > struct cp_control cpc = {
> > --
> > 2.14.1.145.gb3622a4ee
> >
> > On 2017/10/2 3:29, Ju Hyung Park wrote:
> >> When 'fstrim' is called for manual trim, a BUG() can be triggered
> >> randomly with this patch.
> >>
> >> I'm seeing this issue o
Re: [f2fs-dev] [PATCH v4] f2fs: introduce discard_granularity sysfs entry
Hi Chao.
Yep, that patch seems to have fixed it.
Doing "while true; do fstrim -v /; done" while "rm -rf"ing a 2GB
kbuild directory
(with lots of small .o files and stuff) ended flawlessly.
I hope to see this patch merged with next 4.14 merge cycle.
Thanks :)
On Tue, Oct 3, 2017 at 12:59 AM, Chao Yu wrote:
> Hi Park,
>
> Thanks for the report, could have a try with below patch:
>
> From 5fa30e8cdcb93f210e25142c48a884be383c6121 Mon Sep 17 00:00:00 2001
> From: Chao Yu
> Date: Mon, 2 Oct 2017 02:50:16 +0800
> Subject: [PATCH] f2fs: fix potential panic during fstrim
>
> As Ju Hyung Park reported:
>
> "When 'fstrim' is called for manual trim, a BUG() can be triggered
> randomly with this patch.
>
> I'm seeing this issue on both x86 Desktop and arm64 Android phone.
>
> On x86 Desktop, this was caused during Ubuntu boot-up. I have a
> cronjob installed which calls 'fstrim -v /' during boot. On arm64
> Android, this was caused during GC looping with 1ms gc_min_sleep_time
> & gc_max_sleep_time."
>
> Root cause of this issue is that f2fs_wait_discard_bios can only be
> used by f2fs_put_super, because during put_super there must be no
> other referrers, so it can ignore discard entry's reference count
> when removing the entry, otherwise in other caller we will hit bug_on
> in __remove_discard_cmd as there may be other issuer added reference
> count in discard entry.
>
> Thread AThread B
> - issue_discard_thread
> - f2fs_ioc_fitrim
> - f2fs_trim_fs
> - f2fs_wait_discard_bios
>- __issue_discard_cmd
> - __submit_discard_cmd
> - __wait_discard_cmd
> - dc->ref++
> - __wait_one_discard_bio
>- __wait_discard_cmd
> - __remove_discard_cmd
> - f2fs_bug_on(sbi, dc->ref)
>
> Fixes: 969d1b180d987c2be02de890d0fff0f66a0e80de
> Reported-by: Ju Hyung Park
> Signed-off-by: Chao Yu
> ---
> fs/f2fs/f2fs.h| 2 +-
> fs/f2fs/segment.c | 6 +++---
> fs/f2fs/super.c | 2 +-
> 3 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> index 9a7c90386947..4b4a72f392be 100644
> --- a/fs/f2fs/f2fs.h
> +++ b/fs/f2fs/f2fs.h
> @@ -2525,7 +2525,7 @@ void invalidate_blocks(struct f2fs_sb_info *sbi,
> block_t addr);
> bool is_checkpointed_data(struct f2fs_sb_info *sbi, block_t blkaddr);
> void refresh_sit_entry(struct f2fs_sb_info *sbi, block_t old, block_t new);
> void stop_discard_thread(struct f2fs_sb_info *sbi);
> -void f2fs_wait_discard_bios(struct f2fs_sb_info *sbi);
> +void f2fs_wait_discard_bios(struct f2fs_sb_info *sbi, bool umount);
> void clear_prefree_segments(struct f2fs_sb_info *sbi, struct cp_control
> *cpc);
> void release_discard_addrs(struct f2fs_sb_info *sbi);
> int npages_for_summary_flush(struct f2fs_sb_info *sbi, bool for_ra);
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index dedf0209d820..e28245b7e44e 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -1210,11 +1210,11 @@ void stop_discard_thread(struct f2fs_sb_info *sbi)
> }
>
> /* This comes from f2fs_put_super and f2fs_trim_fs */
> -void f2fs_wait_discard_bios(struct f2fs_sb_info *sbi)
> +void f2fs_wait_discard_bios(struct f2fs_sb_info *sbi, bool umount)
> {
> __issue_discard_cmd(sbi, false);
> __drop_discard_cmd(sbi);
> - __wait_discard_cmd(sbi, false);
> + __wait_discard_cmd(sbi, !umount);
> }
>
> static void mark_discard_range_all(struct f2fs_sb_info *sbi)
> @@ -2244,7 +2244,7 @@ int f2fs_trim_fs(struct f2fs_sb_info *sbi, struct
> fstrim_range *range)
> }
> /* It's time to issue all the filed discards */
> mark_discard_range_all(sbi);
> - f2fs_wait_discard_bios(sbi);
> + f2fs_wait_discard_bios(sbi, false);
> out:
> range->len = F2FS_BLK_TO_BYTES(cpc.trimmed);
> return err;
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 89f61eb3d167..933c3d529e65 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -801,7 +801,7 @@ static void f2fs_put_super(struct super_block *sb)
> }
>
> /* be sure to wait for any on-going discard commands */
> - f2fs_wait_discard_bios(sbi);
> + f2fs_wait_discard_bios(sbi, true);
>
> if (f2fs_discard_en(sbi) && !sbi->discard_blks) {
> struct cp_control cpc = {
> --
> 2.14.1.145.gb3622a4ee
>
> On 2017/10/2 3:29, Ju Hyung Park wrote:
>> When 'fstrim' is called for manual trim, a BUG() can be triggered
>> randomly with this patch.
>>
>> I'm seeing this issue on both x86 Desktop and arm64 Android phone.
>>
>> On x86 Desktop, this was caused during Ubuntu boot-up. I have a
>> cronjob installed
>> which calls 'fstrim -v /' during boot.
>> On arm64 Android, this was caused during GC looping with
>> 1ms gc_min_sleep_time & gc_max_sleep_time.
>>
>> Thanks.
>>
>> [26671.666421] [ cut here ]--
Re: [f2fs-dev] [PATCH v4] f2fs: introduce discard_granularity sysfs entry
Hi Park,
Thanks for the report, could have a try with below patch:
>From 5fa30e8cdcb93f210e25142c48a884be383c6121 Mon Sep 17 00:00:00 2001
From: Chao Yu
Date: Mon, 2 Oct 2017 02:50:16 +0800
Subject: [PATCH] f2fs: fix potential panic during fstrim
As Ju Hyung Park reported:
"When 'fstrim' is called for manual trim, a BUG() can be triggered
randomly with this patch.
I'm seeing this issue on both x86 Desktop and arm64 Android phone.
On x86 Desktop, this was caused during Ubuntu boot-up. I have a
cronjob installed which calls 'fstrim -v /' during boot. On arm64
Android, this was caused during GC looping with 1ms gc_min_sleep_time
& gc_max_sleep_time."
Root cause of this issue is that f2fs_wait_discard_bios can only be
used by f2fs_put_super, because during put_super there must be no
other referrers, so it can ignore discard entry's reference count
when removing the entry, otherwise in other caller we will hit bug_on
in __remove_discard_cmd as there may be other issuer added reference
count in discard entry.
Thread AThread B
- issue_discard_thread
- f2fs_ioc_fitrim
- f2fs_trim_fs
- f2fs_wait_discard_bios
- __issue_discard_cmd
- __submit_discard_cmd
- __wait_discard_cmd
- dc->ref++
- __wait_one_discard_bio
- __wait_discard_cmd
- __remove_discard_cmd
- f2fs_bug_on(sbi, dc->ref)
Fixes: 969d1b180d987c2be02de890d0fff0f66a0e80de
Reported-by: Ju Hyung Park
Signed-off-by: Chao Yu
---
fs/f2fs/f2fs.h| 2 +-
fs/f2fs/segment.c | 6 +++---
fs/f2fs/super.c | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index 9a7c90386947..4b4a72f392be 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -2525,7 +2525,7 @@ void invalidate_blocks(struct f2fs_sb_info *sbi, block_t
addr);
bool is_checkpointed_data(struct f2fs_sb_info *sbi, block_t blkaddr);
void refresh_sit_entry(struct f2fs_sb_info *sbi, block_t old, block_t new);
void stop_discard_thread(struct f2fs_sb_info *sbi);
-void f2fs_wait_discard_bios(struct f2fs_sb_info *sbi);
+void f2fs_wait_discard_bios(struct f2fs_sb_info *sbi, bool umount);
void clear_prefree_segments(struct f2fs_sb_info *sbi, struct cp_control *cpc);
void release_discard_addrs(struct f2fs_sb_info *sbi);
int npages_for_summary_flush(struct f2fs_sb_info *sbi, bool for_ra);
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index dedf0209d820..e28245b7e44e 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -1210,11 +1210,11 @@ void stop_discard_thread(struct f2fs_sb_info *sbi)
}
/* This comes from f2fs_put_super and f2fs_trim_fs */
-void f2fs_wait_discard_bios(struct f2fs_sb_info *sbi)
+void f2fs_wait_discard_bios(struct f2fs_sb_info *sbi, bool umount)
{
__issue_discard_cmd(sbi, false);
__drop_discard_cmd(sbi);
- __wait_discard_cmd(sbi, false);
+ __wait_discard_cmd(sbi, !umount);
}
static void mark_discard_range_all(struct f2fs_sb_info *sbi)
@@ -2244,7 +2244,7 @@ int f2fs_trim_fs(struct f2fs_sb_info *sbi, struct
fstrim_range *range)
}
/* It's time to issue all the filed discards */
mark_discard_range_all(sbi);
- f2fs_wait_discard_bios(sbi);
+ f2fs_wait_discard_bios(sbi, false);
out:
range->len = F2FS_BLK_TO_BYTES(cpc.trimmed);
return err;
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 89f61eb3d167..933c3d529e65 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -801,7 +801,7 @@ static void f2fs_put_super(struct super_block *sb)
}
/* be sure to wait for any on-going discard commands */
- f2fs_wait_discard_bios(sbi);
+ f2fs_wait_discard_bios(sbi, true);
if (f2fs_discard_en(sbi) && !sbi->discard_blks) {
struct cp_control cpc = {
--
2.14.1.145.gb3622a4ee
On 2017/10/2 3:29, Ju Hyung Park wrote:
> When 'fstrim' is called for manual trim, a BUG() can be triggered
> randomly with this patch.
>
> I'm seeing this issue on both x86 Desktop and arm64 Android phone.
>
> On x86 Desktop, this was caused during Ubuntu boot-up. I have a
> cronjob installed
> which calls 'fstrim -v /' during boot.
> On arm64 Android, this was caused during GC looping with
> 1ms gc_min_sleep_time & gc_max_sleep_time.
>
> Thanks.
>
> [26671.666421] [ cut here ]
> [26671.666426] WARNING: CPU: 8 PID: 103479 at fs/f2fs/segment.c:797
> __remove_discard_cmd+0xb9/0xd0
> [26671.666427] Modules linked in: ftdi_sio usbserial uas usb_storage
> vmnet(O) vmw_vsock_vmci_transport vsock vmw_vmci vmmon(O) rfcomm
> xt_CHECKSUM iptable_mangle ipt_MASQUERADE nf_nat_masquerade_ipv4
> iptable_nat nf_nat_ipv4 nf_nat nf_conntrack_ipv4 nf_defrag_ipv4
> xt_conntrack nf_conntrack ipt_REJECT nf_reject_ipv4 xt_tcpudp bridge
> stp llc bnep ebtable_filter ebtables ip6table_filter ip6_tables
> xt_multi
Re: [f2fs-dev] [PATCH v4] f2fs: introduce discard_granularity sysfs entry
When 'fstrim' is called for manual trim, a BUG() can be triggered randomly with this patch. I'm seeing this issue on both x86 Desktop and arm64 Android phone. On x86 Desktop, this was caused during Ubuntu boot-up. I have a cronjob installed which calls 'fstrim -v /' during boot. On arm64 Android, this was caused during GC looping with 1ms gc_min_sleep_time & gc_max_sleep_time. Thanks. [26671.666421] [ cut here ] [26671.666426] WARNING: CPU: 8 PID: 103479 at fs/f2fs/segment.c:797 __remove_discard_cmd+0xb9/0xd0 [26671.666427] Modules linked in: ftdi_sio usbserial uas usb_storage vmnet(O) vmw_vsock_vmci_transport vsock vmw_vmci vmmon(O) rfcomm xt_CHECKSUM iptable_mangle ipt_MASQUERADE nf_nat_masquerade_ipv4 iptable_nat nf_nat_ipv4 nf_nat nf_conntrack_ipv4 nf_defrag_ipv4 xt_conntrack nf_conntrack ipt_REJECT nf_reject_ipv4 xt_tcpudp bridge stp llc bnep ebtable_filter ebtables ip6table_filter ip6_tables xt_multiport iptable_filter binfmt_misc snd_hda_codec_hdmi eeepc_wmi asus_wmi sparse_keymap video wmi_bmof mxm_wmi nls_iso8859_1 btusb btrtl joydev btbcm btintel input_leds bluetooth edac_mce_amd snd_hda_codec_realtek snd_hda_codec_generic kvm_amd kvm irqbypass snd_seq_dummy snd_hda_intel snd_hda_codec snd_seq_oss snd_seq_midi snd_hda_core snd_seq_midi_event snd_hwdep snd_pcm snd_rawmidi snd_seq snd_seq_device [26671.666450] snd_timer snd soundcore k10temp i2c_piix4 nvidia_uvm(PO) shpchp wmi 8250_dw mac_hid parport_pc ppdev nfsd lp auth_rpcgss parport oid_registry nfs_acl lockd grace sunrpc ip_tables x_tables autofs4 raid10 raid456 async_raid6_recov async_memcpy async_pq async_xor async_tx raid1 multipath linear hid_generic hid_apple usbhid nvidia_drm(PO) nvidia_modeset(PO) nvidia(PO) drm_kms_helper syscopyarea sysfillrect sysimgblt igb fb_sys_fops dca ptp drm pps_core i2c_algo_bit ahci libahci gpio_amdpt gpio_generic [26671.666471] CPU: 8 PID: 103479 Comm: fstrim Tainted: P O 4.13.4-zen+ #1 [26671.666472] Hardware name: System manufacturer System Product Name/PRIME X399-A, BIOS 0318 08/11/2017 [26671.666472] task: 8804ad535800 task.stack: 88047ee38000 [26671.666474] RIP: 0010:__remove_discard_cmd+0xb9/0xd0 [26671.666474] RSP: 0018:88047ee3bd00 EFLAGS: 00010202 [26671.666475] RAX: 88081801a500 RBX: 88047eeaed00 RCX: 88047eeaedf8 [26671.666475] RDX: 0001 RSI: 88047eeaed00 RDI: 880802555800 [26671.666476] RBP: 8808134d R08: 8804ad535800 R09: 0001 [26671.666476] R10: 88047ee3bd18 R11: R12: 880802555800 [26671.666476] R13: R14: 88047eeaedd0 R15: 8808134d [26671.666477] FS: 7f44cddad2c0() GS:88081ca0() knlGS: [26671.666478] CS: 0010 DS: ES: CR0: 80050033 [26671.666478] CR2: 7f88f5776328 CR3: 00058ce4a000 CR4: 003406e0 [26671.666479] Call Trace: [26671.666481] ? __wait_discard_cmd+0x7a/0xc0 [26671.666482] ? f2fs_trim_fs+0x1c1/0x210 [26671.666484] ? f2fs_ioctl+0x75a/0x2320 [26671.666486] ? do_filp_open+0x99/0xe0 [26671.666487] ? cp_new_stat+0x138/0x150 [26671.666489] ? do_vfs_ioctl+0x88/0x5c0 [26671.666490] ? SyS_newfstat+0x29/0x40 [26671.666491] ? SyS_ioctl+0x6f/0x80 [26671.666493] ? entry_SYSCALL_64_fastpath+0x1e/0xa9 [26671.666493] Code: 48 89 de 8b 43 1c 48 8b 3d 4d 8c 31 01 29 85 74 22 00 00 e8 fa 01 d5 ff f0 ff 8d 80 22 00 00 5b 5d c3 c7 43 64 00 00 00 00 eb 92 <0f> ff f0 80 4f 20 04 e9 53 ff ff ff 90 66 2e 0f 1f 84 00 00 00 [26671.666506] ---[ end trace 613553f7a4728b5a ]--- [26672.553742] general protection fault: [#1] PREEMPT SMP [26672.553746] Modules linked in: ftdi_sio usbserial uas usb_storage vmnet(O) vmw_vsock_vmci_transport vsock vmw_vmci vmmon(O) rfcomm xt_CHECKSUM iptable_mangle ipt_MASQUERADE nf_nat_masquerade_ipv4 iptable_nat nf_nat_ipv4 nf_nat nf_conntrack_ipv4 nf_defrag_ipv4 xt_conntrack nf_conntrack ipt_REJECT nf_reject_ipv4 xt_tcpudp bridge stp llc bnep ebtable_filter ebtables ip6table_filter ip6_tables xt_multiport iptable_filter binfmt_misc snd_hda_codec_hdmi eeepc_wmi asus_wmi sparse_keymap video wmi_bmof mxm_wmi nls_iso8859_1 btusb btrtl joydev btbcm btintel input_leds bluetooth edac_mce_amd snd_hda_codec_realtek snd_hda_codec_generic kvm_amd kvm irqbypass snd_seq_dummy snd_hda_intel snd_hda_codec snd_seq_oss snd_seq_midi snd_hda_core snd_seq_midi_event snd_hwdep snd_pcm snd_rawmidi snd_seq snd_seq_device [26672.553771] snd_timer snd soundcore k10temp i2c_piix4 nvidia_uvm(PO) shpchp wmi 8250_dw mac_hid parport_pc ppdev nfsd lp auth_rpcgss parport oid_registry nfs_acl lockd grace sunrpc ip_tables x_tables autofs4 raid10 raid456 async_raid6_recov async_memcpy async_pq async_xor async_tx raid1 multipath linear hid_generic hid_apple usbhid nvidia_drm(PO) nvidia_modeset(PO) nvidia(PO) drm_kms_helper syscopyarea sysfillrect sysimgblt igb fb_sys_fops dca ptp drm pps_core i2c_algo_bit ahci libahci gpio_amdpt gpio_generic [26672.553792] CPU: 10 PID: 1287 C
Re: [PATCH v4] f2fs: introduce discard_granularity sysfs entry
On 08/18, Chao Yu wrote:
> Hi Jaegeuk,
>
> Sorry for the delay, the modification looks good to me. ;)
We must avoid waking up discard thread caused by # of pending commands
which are never issued.
>From a73f8807248c2f42328a2204eab16a3b8d32c83e Mon Sep 17 00:00:00 2001
From: Chao Yu
Date: Mon, 7 Aug 2017 23:09:56 +0800
Subject: [PATCH] f2fs: introduce discard_granularity sysfs entry
Commit d618ebaf0aa8 ("f2fs: enable small discard by default") enables
f2fs to issue 4K size discard in real-time discard mode. However, issuing
smaller discard may cost more lifetime but releasing less free space in
flash device. Since f2fs has ability of separating hot/cold data and
garbage collection, we can expect that small-sized invalid region would
expand soon with OPU, deletion or garbage collection on valid datas, so
it's better to delay or skip issuing smaller size discards, it could help
to reduce overmuch consumption of IO bandwidth and lifetime of flash
storage.
This patch makes f2fs selectng 64K size as its default minimal
granularity, and issue discard with the size which is not smaller than
minimal granularity. Also it exposes discard granularity as sysfs entry
for configuration in different scenario.
Jaegeuk Kim:
We must issue all the accumulated discard commands when fstrim is called.
So, I've added pend_list_tag[] to indicate whether we should issue the
commands or not. If tag sets P_ACTIVE or P_TRIM, we have to issue them.
P_TRIM is set once at a time, given fstrim trigger.
In addition, issue_discard_thread is calling too much due to the number of
discard commands remaining in the pending list. I added a timer to control
it likewise gc_thread.
Signed-off-by: Chao Yu
Signed-off-by: Jaegeuk Kim
---
Documentation/ABI/testing/sysfs-fs-f2fs | 9
fs/f2fs/f2fs.h | 12 +
fs/f2fs/segment.c | 91 -
fs/f2fs/sysfs.c | 23 +
4 files changed, 121 insertions(+), 14 deletions(-)
diff --git a/Documentation/ABI/testing/sysfs-fs-f2fs
b/Documentation/ABI/testing/sysfs-fs-f2fs
index 621da3fc56c5..11b7f4ebea7c 100644
--- a/Documentation/ABI/testing/sysfs-fs-f2fs
+++ b/Documentation/ABI/testing/sysfs-fs-f2fs
@@ -57,6 +57,15 @@ Contact: "Jaegeuk Kim"
Description:
Controls the issue rate of small discard commands.
+What: /sys/fs/f2fs//discard_granularity
+Date: July 2017
+Contact: "Chao Yu"
+Description:
+ Controls discard granularity of inner discard thread, inner
thread
+ will not issue discards with size that is smaller than
granularity.
+ The unit size is one block, now only support configuring in
range
+ of [1, 512].
+
What: /sys/fs/f2fs//max_victim_search
Date: January 2014
Contact: "Jaegeuk Kim"
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index e252e5bf9791..4b993961d81d 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -148,6 +148,8 @@ enum {
(BATCHED_TRIM_SEGMENTS(sbi) << (sbi)->log_blocks_per_seg)
#define MAX_DISCARD_BLOCKS(sbi)BLKS_PER_SEC(sbi)
#define DISCARD_ISSUE_RATE 8
+#define DEF_MIN_DISCARD_ISSUE_TIME 50 /* 50 ms, if exists */
+#define DEF_MAX_DISCARD_ISSUE_TIME 6 /* 60 s, if no candidates */
#define DEF_CP_INTERVAL60 /* 60 secs */
#define DEF_IDLE_INTERVAL 5 /* 5 secs */
@@ -196,11 +198,18 @@ struct discard_entry {
unsigned char discard_map[SIT_VBLOCK_MAP_SIZE]; /* segment discard
bitmap */
};
+/* default discard granularity of inner discard thread, unit: block count */
+#define DEFAULT_DISCARD_GRANULARITY16
+
/* max discard pend list number */
#define MAX_PLIST_NUM 512
#define plist_idx(blk_num) ((blk_num) >= MAX_PLIST_NUM ? \
(MAX_PLIST_NUM - 1) : (blk_num - 1))
+#define P_ACTIVE 0x01
+#define P_TRIM 0x02
+#define plist_issue(tag) (((tag) & P_ACTIVE) || ((tag) & P_TRIM))
+
enum {
D_PREP,
D_SUBMIT,
@@ -236,11 +245,14 @@ struct discard_cmd_control {
struct task_struct *f2fs_issue_discard; /* discard thread */
struct list_head entry_list;/* 4KB discard entry list */
struct list_head pend_list[MAX_PLIST_NUM];/* store pending entries */
+ unsigned char pend_list_tag[MAX_PLIST_NUM];/* tag for pending entries */
struct list_head wait_list; /* store on-flushing entries */
wait_queue_head_t discard_wait_queue; /* waiting queue for wake-up */
+ unsigned int discard_wake; /* to wake up discard thread */
struct mutex cmd_lock;
unsigned int nr_discards; /* # of discards in the list */
unsigned int max_discards; /* max. discards to be issued */
+ unsigned int discar
Re: [PATCH v4] f2fs: introduce discard_granularity sysfs entry
Hi Jaegeuk,
Sorry for the delay, the modification looks good to me. ;)
Thanks,
On 2017/8/16 1:54, Jaegeuk Kim wrote:
> On 08/15, Chao Yu wrote:
>> On 2017/8/15 11:45, Jaegeuk Kim wrote:
>>> On 08/07, Chao Yu wrote:
From: Chao Yu
Commit d618ebaf0aa8 ("f2fs: enable small discard by default") enables
f2fs to issue 4K size discard in real-time discard mode. However, issuing
smaller discard may cost more lifetime but releasing less free space in
flash device. Since f2fs has ability of separating hot/cold data and
garbage collection, we can expect that small-sized invalid region would
expand soon with OPU, deletion or garbage collection on valid datas, so
it's better to delay or skip issuing smaller size discards, it could help
to reduce overmuch consumption of IO bandwidth and lifetime of flash
storage.
This patch makes f2fs selectng 64K size as its default minimal
granularity, and issue discard with the size which is not smaller than
minimal granularity. Also it exposes discard granularity as sysfs entry
for configuration in different scenario.
>>>
>>> Hi Chao,
>>>
>>> I'd like to change the default value to 1 in order to keep the original
>>> behavior, since we must avoid performance fluctuation after this single
>>> patch. Instead, you probably can change the value through sysfs.
>>
>> As I know, in fragmented filesystem space, there are may dozens of thousand
>> discard, in scenario of cellphone user are using, 30% is above 64K size, but
>> occupy 75% space of all undiscard space, so I changed discard_granularity to
>> 64K
>> just to release bulk space in device. For other small-sized discards, I
>> expect
>> that they may extend and cross the granularity threshold soon, and fstrim of
>> android could cover them in the night.
>
> Yup, I thought that, but this patch prevents fstrim from issuing small
> discards
> due to the granularity check. And, low-end device likes to issue small
> discards
> much more. How about this?
>
> From a0f38a8574a35995ba9e9e81ae5138919bb672a8 Mon Sep 17 00:00:00 2001
> From: Chao Yu
> Date: Mon, 7 Aug 2017 23:09:56 +0800
> Subject: [PATCH] f2fs: introduce discard_granularity sysfs entry
>
> Commit d618ebaf0aa8 ("f2fs: enable small discard by default") enables
> f2fs to issue 4K size discard in real-time discard mode. However, issuing
> smaller discard may cost more lifetime but releasing less free space in
> flash device. Since f2fs has ability of separating hot/cold data and
> garbage collection, we can expect that small-sized invalid region would
> expand soon with OPU, deletion or garbage collection on valid datas, so
> it's better to delay or skip issuing smaller size discards, it could help
> to reduce overmuch consumption of IO bandwidth and lifetime of flash
> storage.
>
> This patch makes f2fs selectng 64K size as its default minimal
> granularity, and issue discard with the size which is not smaller than
> minimal granularity. Also it exposes discard granularity as sysfs entry
> for configuration in different scenario.
>
> Jaegeuk Kim:
> We must issue all the accumulated discard commands when fstrim is called.
> So, I've added pend_list_tag[] to indicate whether we should issue the
> commands or not. If tag sets P_ACTIVE or P_TRIM, we have to issue them.
> P_TRIM is set once at a time, given fstrim trigger.
>
> Signed-off-by: Chao Yu
> Signed-off-by: Jaegeuk Kim
> ---
> Documentation/ABI/testing/sysfs-fs-f2fs | 9 +++
> fs/f2fs/f2fs.h | 9 +++
> fs/f2fs/segment.c | 43
> +++--
> fs/f2fs/sysfs.c | 23 ++
> 4 files changed, 82 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-fs-f2fs
> b/Documentation/ABI/testing/sysfs-fs-f2fs
> index 621da3fc56c5..11b7f4ebea7c 100644
> --- a/Documentation/ABI/testing/sysfs-fs-f2fs
> +++ b/Documentation/ABI/testing/sysfs-fs-f2fs
> @@ -57,6 +57,15 @@ Contact: "Jaegeuk Kim"
> Description:
>Controls the issue rate of small discard commands.
>
> +What: /sys/fs/f2fs//discard_granularity
> +Date: July 2017
> +Contact: "Chao Yu"
> +Description:
> + Controls discard granularity of inner discard thread, inner
> thread
> + will not issue discards with size that is smaller than
> granularity.
> + The unit size is one block, now only support configuring in
> range
> + of [1, 512].
> +
> What:/sys/fs/f2fs//max_victim_search
> Date:January 2014
> Contact: "Jaegeuk Kim"
> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> index e252e5bf9791..336021b9b93e 100644
> --- a/fs/f2fs/f2fs.h
> +++ b/fs/f2fs/f2fs.h
> @@ -196,11 +196,18 @@ struct discard_entry {
> unsigned char discard_map[SIT_VBLOCK_MAP_SIZE]; /* segment discard
> bitmap */
> };
>
> +/* default discar
Re: [PATCH v4] f2fs: introduce discard_granularity sysfs entry
On 08/15, Chao Yu wrote:
> On 2017/8/15 11:45, Jaegeuk Kim wrote:
> > On 08/07, Chao Yu wrote:
> >> From: Chao Yu
> >>
> >> Commit d618ebaf0aa8 ("f2fs: enable small discard by default") enables
> >> f2fs to issue 4K size discard in real-time discard mode. However, issuing
> >> smaller discard may cost more lifetime but releasing less free space in
> >> flash device. Since f2fs has ability of separating hot/cold data and
> >> garbage collection, we can expect that small-sized invalid region would
> >> expand soon with OPU, deletion or garbage collection on valid datas, so
> >> it's better to delay or skip issuing smaller size discards, it could help
> >> to reduce overmuch consumption of IO bandwidth and lifetime of flash
> >> storage.
> >>
> >> This patch makes f2fs selectng 64K size as its default minimal
> >> granularity, and issue discard with the size which is not smaller than
> >> minimal granularity. Also it exposes discard granularity as sysfs entry
> >> for configuration in different scenario.
> >
> > Hi Chao,
> >
> > I'd like to change the default value to 1 in order to keep the original
> > behavior, since we must avoid performance fluctuation after this single
> > patch. Instead, you probably can change the value through sysfs.
>
> As I know, in fragmented filesystem space, there are may dozens of thousand
> discard, in scenario of cellphone user are using, 30% is above 64K size, but
> occupy 75% space of all undiscard space, so I changed discard_granularity to
> 64K
> just to release bulk space in device. For other small-sized discards, I expect
> that they may extend and cross the granularity threshold soon, and fstrim of
> android could cover them in the night.
Yup, I thought that, but this patch prevents fstrim from issuing small discards
due to the granularity check. And, low-end device likes to issue small discards
much more. How about this?
>From a0f38a8574a35995ba9e9e81ae5138919bb672a8 Mon Sep 17 00:00:00 2001
From: Chao Yu
Date: Mon, 7 Aug 2017 23:09:56 +0800
Subject: [PATCH] f2fs: introduce discard_granularity sysfs entry
Commit d618ebaf0aa8 ("f2fs: enable small discard by default") enables
f2fs to issue 4K size discard in real-time discard mode. However, issuing
smaller discard may cost more lifetime but releasing less free space in
flash device. Since f2fs has ability of separating hot/cold data and
garbage collection, we can expect that small-sized invalid region would
expand soon with OPU, deletion or garbage collection on valid datas, so
it's better to delay or skip issuing smaller size discards, it could help
to reduce overmuch consumption of IO bandwidth and lifetime of flash
storage.
This patch makes f2fs selectng 64K size as its default minimal
granularity, and issue discard with the size which is not smaller than
minimal granularity. Also it exposes discard granularity as sysfs entry
for configuration in different scenario.
Jaegeuk Kim:
We must issue all the accumulated discard commands when fstrim is called.
So, I've added pend_list_tag[] to indicate whether we should issue the
commands or not. If tag sets P_ACTIVE or P_TRIM, we have to issue them.
P_TRIM is set once at a time, given fstrim trigger.
Signed-off-by: Chao Yu
Signed-off-by: Jaegeuk Kim
---
Documentation/ABI/testing/sysfs-fs-f2fs | 9 +++
fs/f2fs/f2fs.h | 9 +++
fs/f2fs/segment.c | 43 +++--
fs/f2fs/sysfs.c | 23 ++
4 files changed, 82 insertions(+), 2 deletions(-)
diff --git a/Documentation/ABI/testing/sysfs-fs-f2fs
b/Documentation/ABI/testing/sysfs-fs-f2fs
index 621da3fc56c5..11b7f4ebea7c 100644
--- a/Documentation/ABI/testing/sysfs-fs-f2fs
+++ b/Documentation/ABI/testing/sysfs-fs-f2fs
@@ -57,6 +57,15 @@ Contact: "Jaegeuk Kim"
Description:
Controls the issue rate of small discard commands.
+What: /sys/fs/f2fs//discard_granularity
+Date: July 2017
+Contact: "Chao Yu"
+Description:
+ Controls discard granularity of inner discard thread, inner
thread
+ will not issue discards with size that is smaller than
granularity.
+ The unit size is one block, now only support configuring in
range
+ of [1, 512].
+
What: /sys/fs/f2fs//max_victim_search
Date: January 2014
Contact: "Jaegeuk Kim"
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index e252e5bf9791..336021b9b93e 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -196,11 +196,18 @@ struct discard_entry {
unsigned char discard_map[SIT_VBLOCK_MAP_SIZE]; /* segment discard
bitmap */
};
+/* default discard granularity of inner discard thread, unit: block count */
+#define DEFAULT_DISCARD_GRANULARITY16
+
/* max discard pend list number */
#define MAX_PLIST_NUM 512
#define plist_idx(blk_num) ((blk_num) >= MAX_PLIST_NUM ? \
Re: [PATCH v4] f2fs: introduce discard_granularity sysfs entry
On 2017/8/15 11:45, Jaegeuk Kim wrote:
> On 08/07, Chao Yu wrote:
>> From: Chao Yu
>>
>> Commit d618ebaf0aa8 ("f2fs: enable small discard by default") enables
>> f2fs to issue 4K size discard in real-time discard mode. However, issuing
>> smaller discard may cost more lifetime but releasing less free space in
>> flash device. Since f2fs has ability of separating hot/cold data and
>> garbage collection, we can expect that small-sized invalid region would
>> expand soon with OPU, deletion or garbage collection on valid datas, so
>> it's better to delay or skip issuing smaller size discards, it could help
>> to reduce overmuch consumption of IO bandwidth and lifetime of flash
>> storage.
>>
>> This patch makes f2fs selectng 64K size as its default minimal
>> granularity, and issue discard with the size which is not smaller than
>> minimal granularity. Also it exposes discard granularity as sysfs entry
>> for configuration in different scenario.
>
> Hi Chao,
>
> I'd like to change the default value to 1 in order to keep the original
> behavior, since we must avoid performance fluctuation after this single
> patch. Instead, you probably can change the value through sysfs.
As I know, in fragmented filesystem space, there are may dozens of thousand
discard, in scenario of cellphone user are using, 30% is above 64K size, but
occupy 75% space of all undiscard space, so I changed discard_granularity to 64K
just to release bulk space in device. For other small-sized discards, I expect
that they may extend and cross the granularity threshold soon, and fstrim of
android could cover them in the night.
Do you encounter performance degression due to holding 64k-below size discard?
thank,
>
> Thanks,
>
>>
>> Signed-off-by: Chao Yu
>> ---
>> v4: minor change in commit log.
>> Documentation/ABI/testing/sysfs-fs-f2fs | 9 +
>> fs/f2fs/f2fs.h | 4
>> fs/f2fs/segment.c | 23 ++-
>> fs/f2fs/sysfs.c | 7 +++
>> 4 files changed, 42 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/ABI/testing/sysfs-fs-f2fs
>> b/Documentation/ABI/testing/sysfs-fs-f2fs
>> index 84c606fb3ca4..c579ce5e0ef5 100644
>> --- a/Documentation/ABI/testing/sysfs-fs-f2fs
>> +++ b/Documentation/ABI/testing/sysfs-fs-f2fs
>> @@ -57,6 +57,15 @@ Contact: "Jaegeuk Kim"
>> Description:
>> Controls the issue rate of small discard commands.
>>
>> +What: /sys/fs/f2fs//discard_granularity
>> +Date: July 2017
>> +Contact: "Chao Yu"
>> +Description:
>> +Controls discard granularity of inner discard thread, inner
>> thread
>> +will not issue discards with size that is smaller than
>> granularity.
>> +The unit size is one block, now only support configuring in
>> range
>> +of [1, 512].
>> +
>> What: /sys/fs/f2fs//max_victim_search
>> Date: January 2014
>> Contact:"Jaegeuk Kim"
>> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
>> index 0bfdeeab..1bcaa93bfed7 100644
>> --- a/fs/f2fs/f2fs.h
>> +++ b/fs/f2fs/f2fs.h
>> @@ -195,6 +195,9 @@ struct discard_entry {
>> unsigned char discard_map[SIT_VBLOCK_MAP_SIZE]; /* segment discard
>> bitmap */
>> };
>>
>> +/* default discard granularity of inner discard thread, unit: block count */
>> +#define DEFAULT_DISCARD_GRANULARITY 16
>> +
>> /* max discard pend list number */
>> #define MAX_PLIST_NUM 512
>> #define plist_idx(blk_num) ((blk_num) >= MAX_PLIST_NUM ? \
>> @@ -240,6 +243,7 @@ struct discard_cmd_control {
>> struct mutex cmd_lock;
>> unsigned int nr_discards; /* # of discards in the list */
>> unsigned int max_discards; /* max. discards to be issued */
>> +unsigned int discard_granularity; /* discard granularity */
>> unsigned int undiscard_blks;/* # of undiscard blocks */
>> atomic_t issued_discard;/* # of issued discard */
>> atomic_t issing_discard;/* # of issing discard */
>> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
>> index 71c2e0ac13d7..f336f8c541f0 100644
>> --- a/fs/f2fs/segment.c
>> +++ b/fs/f2fs/segment.c
>> @@ -1019,7 +1019,8 @@ static void __issue_discard_cmd(struct f2fs_sb_info
>> *sbi, bool issue_cond)
>> f2fs_bug_on(sbi,
>> !__check_rb_tree_consistence(sbi, &dcc->root));
>> blk_start_plug(&plug);
>> -for (i = MAX_PLIST_NUM - 1; i >= 0; i--) {
>> +for (i = MAX_PLIST_NUM - 1; i >= 0 &&
>> +i >= dcc->discard_granularity - 1; i--) {
>> pend_list = &dcc->pend_list[i];
>> list_for_each_entry_safe(dc, tmp, pend_list, list) {
>> f2fs_bug_on(sbi, dc->state != D_PREP);
>> @@ -1035,6 +1036,24 @@ static void __issue_discard_cmd(struct f2fs_sb_info
>> *sbi, bool issue_cond)
>> mutex_unlock(&dcc->cmd_
Re: [PATCH v4] f2fs: introduce discard_granularity sysfs entry
On 08/07, Chao Yu wrote:
> From: Chao Yu
>
> Commit d618ebaf0aa8 ("f2fs: enable small discard by default") enables
> f2fs to issue 4K size discard in real-time discard mode. However, issuing
> smaller discard may cost more lifetime but releasing less free space in
> flash device. Since f2fs has ability of separating hot/cold data and
> garbage collection, we can expect that small-sized invalid region would
> expand soon with OPU, deletion or garbage collection on valid datas, so
> it's better to delay or skip issuing smaller size discards, it could help
> to reduce overmuch consumption of IO bandwidth and lifetime of flash
> storage.
>
> This patch makes f2fs selectng 64K size as its default minimal
> granularity, and issue discard with the size which is not smaller than
> minimal granularity. Also it exposes discard granularity as sysfs entry
> for configuration in different scenario.
Hi Chao,
I'd like to change the default value to 1 in order to keep the original
behavior, since we must avoid performance fluctuation after this single
patch. Instead, you probably can change the value through sysfs.
Thanks,
>
> Signed-off-by: Chao Yu
> ---
> v4: minor change in commit log.
> Documentation/ABI/testing/sysfs-fs-f2fs | 9 +
> fs/f2fs/f2fs.h | 4
> fs/f2fs/segment.c | 23 ++-
> fs/f2fs/sysfs.c | 7 +++
> 4 files changed, 42 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-fs-f2fs
> b/Documentation/ABI/testing/sysfs-fs-f2fs
> index 84c606fb3ca4..c579ce5e0ef5 100644
> --- a/Documentation/ABI/testing/sysfs-fs-f2fs
> +++ b/Documentation/ABI/testing/sysfs-fs-f2fs
> @@ -57,6 +57,15 @@ Contact: "Jaegeuk Kim"
> Description:
>Controls the issue rate of small discard commands.
>
> +What: /sys/fs/f2fs//discard_granularity
> +Date: July 2017
> +Contact: "Chao Yu"
> +Description:
> + Controls discard granularity of inner discard thread, inner
> thread
> + will not issue discards with size that is smaller than
> granularity.
> + The unit size is one block, now only support configuring in
> range
> + of [1, 512].
> +
> What:/sys/fs/f2fs//max_victim_search
> Date:January 2014
> Contact: "Jaegeuk Kim"
> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> index 0bfdeeab..1bcaa93bfed7 100644
> --- a/fs/f2fs/f2fs.h
> +++ b/fs/f2fs/f2fs.h
> @@ -195,6 +195,9 @@ struct discard_entry {
> unsigned char discard_map[SIT_VBLOCK_MAP_SIZE]; /* segment discard
> bitmap */
> };
>
> +/* default discard granularity of inner discard thread, unit: block count */
> +#define DEFAULT_DISCARD_GRANULARITY 16
> +
> /* max discard pend list number */
> #define MAX_PLIST_NUM512
> #define plist_idx(blk_num) ((blk_num) >= MAX_PLIST_NUM ? \
> @@ -240,6 +243,7 @@ struct discard_cmd_control {
> struct mutex cmd_lock;
> unsigned int nr_discards; /* # of discards in the list */
> unsigned int max_discards; /* max. discards to be issued */
> + unsigned int discard_granularity; /* discard granularity */
> unsigned int undiscard_blks;/* # of undiscard blocks */
> atomic_t issued_discard;/* # of issued discard */
> atomic_t issing_discard;/* # of issing discard */
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index 71c2e0ac13d7..f336f8c541f0 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -1019,7 +1019,8 @@ static void __issue_discard_cmd(struct f2fs_sb_info
> *sbi, bool issue_cond)
> f2fs_bug_on(sbi,
> !__check_rb_tree_consistence(sbi, &dcc->root));
> blk_start_plug(&plug);
> - for (i = MAX_PLIST_NUM - 1; i >= 0; i--) {
> + for (i = MAX_PLIST_NUM - 1; i >= 0 &&
> + i >= dcc->discard_granularity - 1; i--) {
> pend_list = &dcc->pend_list[i];
> list_for_each_entry_safe(dc, tmp, pend_list, list) {
> f2fs_bug_on(sbi, dc->state != D_PREP);
> @@ -1035,6 +1036,24 @@ static void __issue_discard_cmd(struct f2fs_sb_info
> *sbi, bool issue_cond)
> mutex_unlock(&dcc->cmd_lock);
> }
>
> +static void __drop_discard_cmd(struct f2fs_sb_info *sbi)
> +{
> + struct discard_cmd_control *dcc = SM_I(sbi)->dcc_info;
> + struct list_head *pend_list;
> + struct discard_cmd *dc, *tmp;
> + int i;
> +
> + mutex_lock(&dcc->cmd_lock);
> + for (i = MAX_PLIST_NUM - 1; i >= 0; i--) {
> + pend_list = &dcc->pend_list[i];
> + list_for_each_entry_safe(dc, tmp, pend_list, list) {
> + f2fs_bug_on(sbi, dc->state != D_PREP);
> + __remove_discard_cmd(sbi, dc);
> + }
> + }
> + mutex_unlock(&dcc->cmd_lock);
> +}
> +
[PATCH v4] f2fs: introduce discard_granularity sysfs entry
From: Chao Yu
Commit d618ebaf0aa8 ("f2fs: enable small discard by default") enables
f2fs to issue 4K size discard in real-time discard mode. However, issuing
smaller discard may cost more lifetime but releasing less free space in
flash device. Since f2fs has ability of separating hot/cold data and
garbage collection, we can expect that small-sized invalid region would
expand soon with OPU, deletion or garbage collection on valid datas, so
it's better to delay or skip issuing smaller size discards, it could help
to reduce overmuch consumption of IO bandwidth and lifetime of flash
storage.
This patch makes f2fs selectng 64K size as its default minimal
granularity, and issue discard with the size which is not smaller than
minimal granularity. Also it exposes discard granularity as sysfs entry
for configuration in different scenario.
Signed-off-by: Chao Yu
---
v4: minor change in commit log.
Documentation/ABI/testing/sysfs-fs-f2fs | 9 +
fs/f2fs/f2fs.h | 4
fs/f2fs/segment.c | 23 ++-
fs/f2fs/sysfs.c | 7 +++
4 files changed, 42 insertions(+), 1 deletion(-)
diff --git a/Documentation/ABI/testing/sysfs-fs-f2fs
b/Documentation/ABI/testing/sysfs-fs-f2fs
index 84c606fb3ca4..c579ce5e0ef5 100644
--- a/Documentation/ABI/testing/sysfs-fs-f2fs
+++ b/Documentation/ABI/testing/sysfs-fs-f2fs
@@ -57,6 +57,15 @@ Contact: "Jaegeuk Kim"
Description:
Controls the issue rate of small discard commands.
+What: /sys/fs/f2fs//discard_granularity
+Date: July 2017
+Contact: "Chao Yu"
+Description:
+ Controls discard granularity of inner discard thread, inner
thread
+ will not issue discards with size that is smaller than
granularity.
+ The unit size is one block, now only support configuring in
range
+ of [1, 512].
+
What: /sys/fs/f2fs//max_victim_search
Date: January 2014
Contact: "Jaegeuk Kim"
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index 0bfdeeab..1bcaa93bfed7 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -195,6 +195,9 @@ struct discard_entry {
unsigned char discard_map[SIT_VBLOCK_MAP_SIZE]; /* segment discard
bitmap */
};
+/* default discard granularity of inner discard thread, unit: block count */
+#define DEFAULT_DISCARD_GRANULARITY16
+
/* max discard pend list number */
#define MAX_PLIST_NUM 512
#define plist_idx(blk_num) ((blk_num) >= MAX_PLIST_NUM ? \
@@ -240,6 +243,7 @@ struct discard_cmd_control {
struct mutex cmd_lock;
unsigned int nr_discards; /* # of discards in the list */
unsigned int max_discards; /* max. discards to be issued */
+ unsigned int discard_granularity; /* discard granularity */
unsigned int undiscard_blks;/* # of undiscard blocks */
atomic_t issued_discard;/* # of issued discard */
atomic_t issing_discard;/* # of issing discard */
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 71c2e0ac13d7..f336f8c541f0 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -1019,7 +1019,8 @@ static void __issue_discard_cmd(struct f2fs_sb_info *sbi,
bool issue_cond)
f2fs_bug_on(sbi,
!__check_rb_tree_consistence(sbi, &dcc->root));
blk_start_plug(&plug);
- for (i = MAX_PLIST_NUM - 1; i >= 0; i--) {
+ for (i = MAX_PLIST_NUM - 1; i >= 0 &&
+ i >= dcc->discard_granularity - 1; i--) {
pend_list = &dcc->pend_list[i];
list_for_each_entry_safe(dc, tmp, pend_list, list) {
f2fs_bug_on(sbi, dc->state != D_PREP);
@@ -1035,6 +1036,24 @@ static void __issue_discard_cmd(struct f2fs_sb_info
*sbi, bool issue_cond)
mutex_unlock(&dcc->cmd_lock);
}
+static void __drop_discard_cmd(struct f2fs_sb_info *sbi)
+{
+ struct discard_cmd_control *dcc = SM_I(sbi)->dcc_info;
+ struct list_head *pend_list;
+ struct discard_cmd *dc, *tmp;
+ int i;
+
+ mutex_lock(&dcc->cmd_lock);
+ for (i = MAX_PLIST_NUM - 1; i >= 0; i--) {
+ pend_list = &dcc->pend_list[i];
+ list_for_each_entry_safe(dc, tmp, pend_list, list) {
+ f2fs_bug_on(sbi, dc->state != D_PREP);
+ __remove_discard_cmd(sbi, dc);
+ }
+ }
+ mutex_unlock(&dcc->cmd_lock);
+}
+
static void __wait_one_discard_bio(struct f2fs_sb_info *sbi,
struct discard_cmd *dc)
{
@@ -1117,6 +1136,7 @@ void stop_discard_thread(struct f2fs_sb_info *sbi)
void f2fs_wait_discard_bios(struct f2fs_sb_info *sbi)
{
__issue_discard_cmd(sbi, false);
+ __drop_discard_cmd(sbi);
__wait_discard_cmd(sbi, false);
}
@@ -1449,6 +1469,7 @
