Re: [PATCH v4 0/3] usb: chipidea: msm: Clean and fix glue layer driver
On Tue, 2014-04-29 at 08:45 +0800, Peter Chen wrote: > > Applied, thanks Thank you, Ivan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v4 0/3] usb: chipidea: msm: Clean and fix glue layer driver
On Mon, Apr 28, 2014 at 05:03:35PM +0300, Ivan T. Ivanov wrote: > On Fri, 2014-04-25 at 03:10 +, Peter Chen wrote: > > > > > > > > On Thu, 2014-04-24 at 08:38 +0800, Peter Chen wrote: > > > > On Wed, Apr 23, 2014 at 03:28:01PM +0300, Ivan T. Ivanov wrote: > > > > > From: "Ivan T. Ivanov" > > > > > > > > > > This series intend to fix driver, which was broken for a while. > > > > > It is used to create peripheral role device, which in coordination > > > > > with phy-usb-msm driver could provide USB2.0 gadget support for > > > > > Qualcomm targets. > > > > > > > > > > Changes since version 3. > > > > > > > > > > - Fix typo in devicetree description file. > > > > > > > > > > Previews version can be found here: > > > > > > > > Since in your phy's patchset, you also access portsc which is in > > > > chipidea register region, it is not a standard way. > > > > In case, you will change something at chipidea driver in future when > > > > you re-work your next revision phy's patchset, I do not send this > > > > patchset to Greg right now. > > > > > > > > > > Did you see problems with _this_ particular patch set? There is no direct > > > dependency between PHY patches and these changes. > > > > > > > I have not seen problems for this patch set, if you make sure the current > > phy operation (eg, "phy_type) at chipidea core does not affect you, > > I am glad to accept this. > > You mean phy_mode? Peripheral functionality is tested on top of > current linus/master and it looks fine. > Applied, thanks -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v4 0/3] usb: chipidea: msm: Clean and fix glue layer driver
On Fri, 2014-04-25 at 03:10 +, Peter Chen wrote: > > > > > On Thu, 2014-04-24 at 08:38 +0800, Peter Chen wrote: > > > On Wed, Apr 23, 2014 at 03:28:01PM +0300, Ivan T. Ivanov wrote: > > > > From: "Ivan T. Ivanov" > > > > > > > > This series intend to fix driver, which was broken for a while. > > > > It is used to create peripheral role device, which in coordination > > > > with phy-usb-msm driver could provide USB2.0 gadget support for > > > > Qualcomm targets. > > > > > > > > Changes since version 3. > > > > > > > > - Fix typo in devicetree description file. > > > > > > > > Previews version can be found here: > > > > > > Since in your phy's patchset, you also access portsc which is in > > > chipidea register region, it is not a standard way. > > > In case, you will change something at chipidea driver in future when > > > you re-work your next revision phy's patchset, I do not send this > > > patchset to Greg right now. > > > > > > > Did you see problems with _this_ particular patch set? There is no direct > > dependency between PHY patches and these changes. > > > > I have not seen problems for this patch set, if you make sure the current > phy operation (eg, "phy_type) at chipidea core does not affect you, > I am glad to accept this. You mean phy_mode? Peripheral functionality is tested on top of current linus/master and it looks fine. Regards, Ivan > > Peter > NrybXǧv^){.n+{zXܨ}Ơz&j:+vzZ++zfh~izw?&)ߢf^jǫym@Aa0hi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH v4 0/3] usb: chipidea: msm: Clean and fix glue layer driver
> > On Thu, 2014-04-24 at 08:38 +0800, Peter Chen wrote: > > On Wed, Apr 23, 2014 at 03:28:01PM +0300, Ivan T. Ivanov wrote: > > > From: "Ivan T. Ivanov" > > > > > > This series intend to fix driver, which was broken for a while. > > > It is used to create peripheral role device, which in coordination > > > with phy-usb-msm driver could provide USB2.0 gadget support for > > > Qualcomm targets. > > > > > > Changes since version 3. > > > > > > - Fix typo in devicetree description file. > > > > > > Previews version can be found here: > > > > Since in your phy's patchset, you also access portsc which is in > > chipidea register region, it is not a standard way. > > In case, you will change something at chipidea driver in future when > > you re-work your next revision phy's patchset, I do not send this > > patchset to Greg right now. > > > > Did you see problems with _this_ particular patch set? There is no direct > dependency between PHY patches and these changes. > I have not seen problems for this patch set, if you make sure the current phy operation (eg, "phy_type) at chipidea core does not affect you, I am glad to accept this. Peter
Re: [PATCH v4 0/3] usb: chipidea: msm: Clean and fix glue layer driver
Hi Peter, On Thu, 2014-04-24 at 08:38 +0800, Peter Chen wrote: > On Wed, Apr 23, 2014 at 03:28:01PM +0300, Ivan T. Ivanov wrote: > > From: "Ivan T. Ivanov" > > > > This series intend to fix driver, which was broken for a while. > > It is used to create peripheral role device, which in coordination > > with phy-usb-msm driver could provide USB2.0 gadget support for > > Qualcomm targets. > > > > Changes since version 3. > > > > - Fix typo in devicetree description file. > > > > Previews version can be found here: > > Since in your phy's patchset, you also access portsc which is in > chipidea register region, it is not a standard way. > In case, you will change something at chipidea driver in future > when you re-work your next revision phy's patchset, I do not > send this patchset to Greg right now. > Did you see problems with _this_ particular patch set? There is no direct dependency between PHY patches and these changes. Regards, Ivan > Once your phy's patchset has accepted, notify me. I will send > this patchset to Greg. > > Peter > > > > > https://lkml.org/lkml/2014/4/22/195 > > > > Ivan T. Ivanov (3): > > usb: chipidea: msm: Add device tree binding information > > usb: chipidea: msm: Add device tree support > > usb: chipidea: msm: Initialize offset of the capability registers > > > > .../devicetree/bindings/usb/ci-hdrc-qcom.txt | 17 +++ > > drivers/usb/chipidea/ci_hdrc_msm.c | 24 > > +- > > 2 files changed, 40 insertions(+), 1 deletion(-) > > create mode 100644 Documentation/devicetree/bindings/usb/ci-hdrc-qcom.txt > > > > -- > > 1.8.3.2 > > > > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v4 0/3] usb: chipidea: msm: Clean and fix glue layer driver
On Wed, Apr 23, 2014 at 03:28:01PM +0300, Ivan T. Ivanov wrote: > From: "Ivan T. Ivanov" > > This series intend to fix driver, which was broken for a while. > It is used to create peripheral role device, which in coordination > with phy-usb-msm driver could provide USB2.0 gadget support for > Qualcomm targets. > > Changes since version 3. > > - Fix typo in devicetree description file. > > Previews version can be found here: Since in your phy's patchset, you also access portsc which is in chipidea register region, it is not a standard way. In case, you will change something at chipidea driver in future when you re-work your next revision phy's patchset, I do not send this patchset to Greg right now. Once your phy's patchset has accepted, notify me. I will send this patchset to Greg. Peter > > https://lkml.org/lkml/2014/4/22/195 > > Ivan T. Ivanov (3): > usb: chipidea: msm: Add device tree binding information > usb: chipidea: msm: Add device tree support > usb: chipidea: msm: Initialize offset of the capability registers > > .../devicetree/bindings/usb/ci-hdrc-qcom.txt | 17 +++ > drivers/usb/chipidea/ci_hdrc_msm.c | 24 > +- > 2 files changed, 40 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/usb/ci-hdrc-qcom.txt > > -- > 1.8.3.2 > > > -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v4 0/3] usb: chipidea: msm: Clean and fix glue layer driver
From: "Ivan T. Ivanov" This series intend to fix driver, which was broken for a while. It is used to create peripheral role device, which in coordination with phy-usb-msm driver could provide USB2.0 gadget support for Qualcomm targets. Changes since version 3. - Fix typo in devicetree description file. Previews version can be found here: https://lkml.org/lkml/2014/4/22/195 Ivan T. Ivanov (3): usb: chipidea: msm: Add device tree binding information usb: chipidea: msm: Add device tree support usb: chipidea: msm: Initialize offset of the capability registers .../devicetree/bindings/usb/ci-hdrc-qcom.txt | 17 +++ drivers/usb/chipidea/ci_hdrc_msm.c | 24 +- 2 files changed, 40 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/usb/ci-hdrc-qcom.txt -- 1.8.3.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/