The sock counting (sock_update_netprioidx() and sock_update_classid()) was
missing from pidfd's implementation of received fd installation.  Replace
the open-coded version with a call to the new fd_install_received()
helper.

Fixes: 8649c322f75c ("pid: Implement pidfd_getfd syscall")
Signed-off-by: Kees Cook <keesc...@chromium.org>
---
 kernel/pid.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/kernel/pid.c b/kernel/pid.c
index f1496b757162..24924ec5df0e 100644
--- a/kernel/pid.c
+++ b/kernel/pid.c
@@ -635,18 +635,9 @@ static int pidfd_getfd(struct pid *pid, int fd)
        if (IS_ERR(file))
                return PTR_ERR(file);
 
-       ret = security_file_receive(file);
-       if (ret) {
-               fput(file);
-               return ret;
-       }
-
-       ret = get_unused_fd_flags(O_CLOEXEC);
+       ret = fd_install_received(file, O_CLOEXEC);
        if (ret < 0)
                fput(file);
-       else
-               fd_install(ret, file);
-
        return ret;
 }
 
-- 
2.25.1

Reply via email to