Re: [PATCH v4 05/20] clk: tegra: pll: update warning msg
On Mon, May 4, 2015 at 9:37 AM, Rhyland Klein wrote: > Swap out the generic WARN_ON with a WARN which gives more > information about what is happening. > > Signed-off-by: Rhyland Klein Reviewed-by: Benson Leung -- Benson Leung Software Engineer, Chrom* OS ble...@chromium.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v4 05/20] clk: tegra: pll: update warning msg
Swap out the generic WARN_ON with a WARN which gives more
information about what is happening.
Signed-off-by: Rhyland Klein
---
drivers/clk/tegra/clk-pll.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/tegra/clk-pll.c b/drivers/clk/tegra/clk-pll.c
index 1e1018dd466f..0282d9f4f2d7 100644
--- a/drivers/clk/tegra/clk-pll.c
+++ b/drivers/clk/tegra/clk-pll.c
@@ -692,7 +692,8 @@ static unsigned long clk_pll_recalc_rate(struct clk_hw *hw,
pdiv = _hw_to_p_div(hw, cfg.p);
if (pdiv < 0) {
- WARN_ON(1);
+ WARN(1, "Clock %s has invalid pdiv value : 0x%x\n",
+ __clk_get_name(hw->clk), cfg.p);
pdiv = 1;
}
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH v4 05/20] clk: tegra: pll: update warning msg
Swap out the generic WARN_ON with a WARN which gives more
information about what is happening.
Signed-off-by: Rhyland Klein rkl...@nvidia.com
---
drivers/clk/tegra/clk-pll.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/tegra/clk-pll.c b/drivers/clk/tegra/clk-pll.c
index 1e1018dd466f..0282d9f4f2d7 100644
--- a/drivers/clk/tegra/clk-pll.c
+++ b/drivers/clk/tegra/clk-pll.c
@@ -692,7 +692,8 @@ static unsigned long clk_pll_recalc_rate(struct clk_hw *hw,
pdiv = _hw_to_p_div(hw, cfg.p);
if (pdiv 0) {
- WARN_ON(1);
+ WARN(1, Clock %s has invalid pdiv value : 0x%x\n,
+ __clk_get_name(hw-clk), cfg.p);
pdiv = 1;
}
--
1.7.9.5
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v4 05/20] clk: tegra: pll: update warning msg
On Mon, May 4, 2015 at 9:37 AM, Rhyland Klein rkl...@nvidia.com wrote: Swap out the generic WARN_ON with a WARN which gives more information about what is happening. Signed-off-by: Rhyland Klein rkl...@nvidia.com Reviewed-by: Benson Leung ble...@chromium.org -- Benson Leung Software Engineer, Chrom* OS ble...@chromium.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
