Re: [PATCH v4 1/2] dt-bindings: gpio: davinci: Add keystone-k2g compatible

[Linus Walleij]

On Fri, Aug 4, 2017 at 7:47 AM, Keerthy  wrote:

> The patch adds keystone-k2g compatible, specific properties and
> an example. The patch also adds the details of supported SoCs
> for each compatible.
>
> Signed-off-by: Keerthy 
> Acked-by: Rob Herring 
> ---
>
> Changes in v4:
>
>   * Changed documentation links.
>   * Added Rob's Ack.
>   * Replaced keystone-k2g with 66AK2G
>   * Corrected the $Subject
>   * Changed compatible to ti,k2g-gpio

Patch applied.

Yours,
Linus Walleij

Re: [PATCH v4 1/2] dt-bindings: gpio: davinci: Add keystone-k2g compatible

[Linus Walleij]

On Fri, Aug 4, 2017 at 7:47 AM, Keerthy  wrote:

> The patch adds keystone-k2g compatible, specific properties and
> an example. The patch also adds the details of supported SoCs
> for each compatible.
>
> Signed-off-by: Keerthy 
> Acked-by: Rob Herring 
> ---
>
> Changes in v4:
>
>   * Changed documentation links.
>   * Added Rob's Ack.
>   * Replaced keystone-k2g with 66AK2G
>   * Corrected the $Subject
>   * Changed compatible to ti,k2g-gpio

Patch applied.

Yours,
Linus Walleij

[PATCH v4 1/2] dt-bindings: gpio: davinci: Add keystone-k2g compatible

[Keerthy]

The patch adds keystone-k2g compatible, specific properties and
an example. The patch also adds the details of supported SoCs
for each compatible.

Signed-off-by: Keerthy 
Acked-by: Rob Herring 
---

Changes in v4:

  * Changed documentation links.
  * Added Rob's Ack.
  * Replaced keystone-k2g with 66AK2G
  * Corrected the $Subject
  * Changed compatible to ti,k2g-gpio

Changes in v3:

  * Added details about family of SoCs corresponding to compatibles.

 .../devicetree/bindings/gpio/gpio-davinci.txt  | 91 +-
 1 file changed, 89 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/gpio/gpio-davinci.txt 
b/Documentation/devicetree/bindings/gpio/gpio-davinci.txt
index 5079ba7..5ad08b2 100644
--- a/Documentation/devicetree/bindings/gpio/gpio-davinci.txt
+++ b/Documentation/devicetree/bindings/gpio/gpio-davinci.txt
@@ -1,7 +1,10 @@
 Davinci/Keystone GPIO controller bindings
 
 Required Properties:
-- compatible: should be "ti,dm6441-gpio", "ti,keystone-gpio"
+- compatible: should be "ti,dm6441-gpio": for Davinci da850 SoCs
+   "ti,keystone-gpio": for Keystone 2 66AK2H/K, 66AK2L,
+   66AK2E SoCs
+   "ti,k2g-gpio", "ti,keystone-gpio": for 66AK2G
 
 - reg: Physical base address of the controller and the size of memory mapped
registers.
@@ -20,7 +23,21 @@ Required Properties:
 - ti,ngpio: The number of GPIO pins supported.
 
 - ti,davinci-gpio-unbanked: The number of GPIOs that have an individual 
interrupt
-line to processor.
+   line to processor.
+
+- clocks: Should contain the device's input clock, and should be defined as per
+  the appropriate clock bindings consumer usage in,
+
+  Documentation/devicetree/bindings/clock/keystone-gate.txt
+for 66AK2HK/66AK2L/66AK2E SoCs or,
+
+  Documentation/devicetree/bindings/clock/ti,sci-clk.txt
+for 66AK2G SoCs
+
+- clock-names: Name should be "gpio";
+
+Currently clock-names and clocks are needed for all keystone 2 platforms
+Davinci platforms do not have DT clocks as of now.
 
 The GPIO controller also acts as an interrupt controller. It uses the default
 two cells specifier as described in Documentation/devicetree/bindings/
@@ -60,3 +77,73 @@ leds {
...
};
 };
+
+Example for 66AK2G:
+
+gpio0: gpio@2603000 {
+   compatible = "ti,k2g-gpio", "ti,keystone-gpio";
+   reg = <0x02603000 0x100>;
+   gpio-controller;
+   #gpio-cells = <2>;
+   interrupts = ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ;
+   interrupt-controller;
+   #interrupt-cells = <2>;
+   ti,ngpio = <144>;
+   ti,davinci-gpio-unbanked = <0>;
+   clocks = <_clks 0x001b 0x0>;
+   clock-names = "gpio";
+};
+
+Example for 66AK2HK/66AK2L/66AK2E:
+
+gpio0: gpio@260bf00 {
+   compatible = "ti,keystone-gpio";
+   reg = <0x0260bf00 0x100>;
+   gpio-controller;
+   #gpio-cells = <2>;
+   /* HW Interrupts mapped to GPIO pins */
+   interrupts = ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ;
+   clocks = <>;
+   clock-names = "gpio";
+   ti,ngpio = <32>;
+   ti,davinci-gpio-unbanked = <32>;
+};
-- 
1.9.1

[PATCH v4 1/2] dt-bindings: gpio: davinci: Add keystone-k2g compatible

[Keerthy]

The patch adds keystone-k2g compatible, specific properties and
an example. The patch also adds the details of supported SoCs
for each compatible.

Signed-off-by: Keerthy 
Acked-by: Rob Herring 
---

Changes in v4:

  * Changed documentation links.
  * Added Rob's Ack.
  * Replaced keystone-k2g with 66AK2G
  * Corrected the $Subject
  * Changed compatible to ti,k2g-gpio

Changes in v3:

  * Added details about family of SoCs corresponding to compatibles.

 .../devicetree/bindings/gpio/gpio-davinci.txt  | 91 +-
 1 file changed, 89 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/gpio/gpio-davinci.txt 
b/Documentation/devicetree/bindings/gpio/gpio-davinci.txt
index 5079ba7..5ad08b2 100644
--- a/Documentation/devicetree/bindings/gpio/gpio-davinci.txt
+++ b/Documentation/devicetree/bindings/gpio/gpio-davinci.txt
@@ -1,7 +1,10 @@
 Davinci/Keystone GPIO controller bindings
 
 Required Properties:
-- compatible: should be "ti,dm6441-gpio", "ti,keystone-gpio"
+- compatible: should be "ti,dm6441-gpio": for Davinci da850 SoCs
+   "ti,keystone-gpio": for Keystone 2 66AK2H/K, 66AK2L,
+   66AK2E SoCs
+   "ti,k2g-gpio", "ti,keystone-gpio": for 66AK2G
 
 - reg: Physical base address of the controller and the size of memory mapped
registers.
@@ -20,7 +23,21 @@ Required Properties:
 - ti,ngpio: The number of GPIO pins supported.
 
 - ti,davinci-gpio-unbanked: The number of GPIOs that have an individual 
interrupt
-line to processor.
+   line to processor.
+
+- clocks: Should contain the device's input clock, and should be defined as per
+  the appropriate clock bindings consumer usage in,
+
+  Documentation/devicetree/bindings/clock/keystone-gate.txt
+for 66AK2HK/66AK2L/66AK2E SoCs or,
+
+  Documentation/devicetree/bindings/clock/ti,sci-clk.txt
+for 66AK2G SoCs
+
+- clock-names: Name should be "gpio";
+
+Currently clock-names and clocks are needed for all keystone 2 platforms
+Davinci platforms do not have DT clocks as of now.
 
 The GPIO controller also acts as an interrupt controller. It uses the default
 two cells specifier as described in Documentation/devicetree/bindings/
@@ -60,3 +77,73 @@ leds {
...
};
 };
+
+Example for 66AK2G:
+
+gpio0: gpio@2603000 {
+   compatible = "ti,k2g-gpio", "ti,keystone-gpio";
+   reg = <0x02603000 0x100>;
+   gpio-controller;
+   #gpio-cells = <2>;
+   interrupts = ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ;
+   interrupt-controller;
+   #interrupt-cells = <2>;
+   ti,ngpio = <144>;
+   ti,davinci-gpio-unbanked = <0>;
+   clocks = <_clks 0x001b 0x0>;
+   clock-names = "gpio";
+};
+
+Example for 66AK2HK/66AK2L/66AK2E:
+
+gpio0: gpio@260bf00 {
+   compatible = "ti,keystone-gpio";
+   reg = <0x0260bf00 0x100>;
+   gpio-controller;
+   #gpio-cells = <2>;
+   /* HW Interrupts mapped to GPIO pins */
+   interrupts = ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ,
+   ;
+   clocks = <>;
+   clock-names = "gpio";
+   ti,ngpio = <32>;
+   ti,davinci-gpio-unbanked = <32>;
+};
-- 
1.9.1