Re: [PATCH v4 1/7] MFD: add bindings for STM32 General Purpose Timer driver

[Benjamin Gaignard]

[snip]
>
> I'm not going to push too hard, but I still thing "advanced-control"
> would suit better, since this is not *just* a timer.  In fact, the
> parent device (the MFD) doesn't have any timer functionality.  That's
> what "timer@0" does.
>
> The IP is called "Advanced Control" in the datasheet, no?

In datasheet only timers 1 and 8 are called "advanced-control" timers
Timers 2 to 5 and 9 to 14 are called "general purpose" timers.
Timers 6 and 7 are named "basic" timers.

I have ask around in ST and it seems that "general purpose" name was the
best to describe all the timers, so I would like to keep using it.

>
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + compatible = "st,stm32-gptimer";
>> + reg = <0x4001 0x400>;
>> + clocks = < 0 160>;
>> + clock-names = "clk_int";
>> +
>> + pwm@0 {
>> + compatible = "st,stm32-pwm";
>> + pinctrl-0   = <_pins>;
>> + pinctrl-names   = "default";
>> + };
>> +
>> + timer@0 {
>> + compatible = "st,stm32-timer-trigger";
>> + reg = <0>;
>> + };
>> + };
>
> --
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v4 1/7] MFD: add bindings for STM32 General Purpose Timer driver

[Benjamin Gaignard]

[snip]
>
> I'm not going to push too hard, but I still thing "advanced-control"
> would suit better, since this is not *just* a timer.  In fact, the
> parent device (the MFD) doesn't have any timer functionality.  That's
> what "timer@0" does.
>
> The IP is called "Advanced Control" in the datasheet, no?

In datasheet only timers 1 and 8 are called "advanced-control" timers
Timers 2 to 5 and 9 to 14 are called "general purpose" timers.
Timers 6 and 7 are named "basic" timers.

I have ask around in ST and it seems that "general purpose" name was the
best to describe all the timers, so I would like to keep using it.

>
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + compatible = "st,stm32-gptimer";
>> + reg = <0x4001 0x400>;
>> + clocks = < 0 160>;
>> + clock-names = "clk_int";
>> +
>> + pwm@0 {
>> + compatible = "st,stm32-pwm";
>> + pinctrl-0   = <_pins>;
>> + pinctrl-names   = "default";
>> + };
>> +
>> + timer@0 {
>> + compatible = "st,stm32-timer-trigger";
>> + reg = <0>;
>> + };
>> + };
>
> --
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v4 1/7] MFD: add bindings for STM32 General Purpose Timer driver

[Lee Jones]

On Tue, 06 Dec 2016, Benjamin Gaignard wrote:

> Add bindings information for STM32 General Purpose Timer
> 
> version 2:
> - rename stm32-mfd-timer to stm32-gptimer
> - only keep one compatible string
> 
> Signed-off-by: Benjamin Gaignard 
> ---
>  .../bindings/mfd/stm32-general-purpose-timer.txt   | 39 
> ++
>  1 file changed, 39 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/mfd/stm32-general-purpose-timer.txt
> 
> diff --git 
> a/Documentation/devicetree/bindings/mfd/stm32-general-purpose-timer.txt 
> b/Documentation/devicetree/bindings/mfd/stm32-general-purpose-timer.txt
> new file mode 100644
> index 000..e92c8be
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/stm32-general-purpose-timer.txt
> @@ -0,0 +1,39 @@
> +STM32 General Purpose Timer driver bindings
> +
> +Required parameters:
> +- compatible: must be "st,stm32-gptimer"
> +
> +- reg:   Physical base address and length of the 
> controller's
> + registers.
> +- clock-names:   Set to "clk_int".
> +- clocks:Phandle to the clock used by the timer module.
> + For Clk properties, please refer to 
> ../clock/clock-bindings.txt
> +
> +Optional parameters:
> +- resets:Phandle to the parent reset controller.
> + See ../reset/st,stm32-rcc.txt
> +
> +Optional subnodes:
> +- pwm:   See ../pwm/pwm-stm32.txt
> +- timer: See ../iio/timer/stm32-timer-trigger.txt
> +
> +Example:
> + gptimer@4001 {

I'm not going to push too hard, but I still thing "advanced-control"
would suit better, since this is not *just* a timer.  In fact, the
parent device (the MFD) doesn't have any timer functionality.  That's
what "timer@0" does.

The IP is called "Advanced Control" in the datasheet, no?

> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "st,stm32-gptimer";
> + reg = <0x4001 0x400>;
> + clocks = < 0 160>;
> + clock-names = "clk_int";
> +
> + pwm@0 {
> + compatible = "st,stm32-pwm";
> + pinctrl-0   = <_pins>;
> + pinctrl-names   = "default";
> + };
> +
> + timer@0 {
> + compatible = "st,stm32-timer-trigger";
> + reg = <0>;
> + };
> + };

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v4 1/7] MFD: add bindings for STM32 General Purpose Timer driver

[Lee Jones]

On Tue, 06 Dec 2016, Benjamin Gaignard wrote:

> Add bindings information for STM32 General Purpose Timer
> 
> version 2:
> - rename stm32-mfd-timer to stm32-gptimer
> - only keep one compatible string
> 
> Signed-off-by: Benjamin Gaignard 
> ---
>  .../bindings/mfd/stm32-general-purpose-timer.txt   | 39 
> ++
>  1 file changed, 39 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/mfd/stm32-general-purpose-timer.txt
> 
> diff --git 
> a/Documentation/devicetree/bindings/mfd/stm32-general-purpose-timer.txt 
> b/Documentation/devicetree/bindings/mfd/stm32-general-purpose-timer.txt
> new file mode 100644
> index 000..e92c8be
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/stm32-general-purpose-timer.txt
> @@ -0,0 +1,39 @@
> +STM32 General Purpose Timer driver bindings
> +
> +Required parameters:
> +- compatible: must be "st,stm32-gptimer"
> +
> +- reg:   Physical base address and length of the 
> controller's
> + registers.
> +- clock-names:   Set to "clk_int".
> +- clocks:Phandle to the clock used by the timer module.
> + For Clk properties, please refer to 
> ../clock/clock-bindings.txt
> +
> +Optional parameters:
> +- resets:Phandle to the parent reset controller.
> + See ../reset/st,stm32-rcc.txt
> +
> +Optional subnodes:
> +- pwm:   See ../pwm/pwm-stm32.txt
> +- timer: See ../iio/timer/stm32-timer-trigger.txt
> +
> +Example:
> + gptimer@4001 {

I'm not going to push too hard, but I still thing "advanced-control"
would suit better, since this is not *just* a timer.  In fact, the
parent device (the MFD) doesn't have any timer functionality.  That's
what "timer@0" does.

The IP is called "Advanced Control" in the datasheet, no?

> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "st,stm32-gptimer";
> + reg = <0x4001 0x400>;
> + clocks = < 0 160>;
> + clock-names = "clk_int";
> +
> + pwm@0 {
> + compatible = "st,stm32-pwm";
> + pinctrl-0   = <_pins>;
> + pinctrl-names   = "default";
> + };
> +
> + timer@0 {
> + compatible = "st,stm32-timer-trigger";
> + reg = <0>;
> + };
> + };

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[PATCH v4 1/7] MFD: add bindings for STM32 General Purpose Timer driver

[Benjamin Gaignard]

Add bindings information for STM32 General Purpose Timer

version 2:
- rename stm32-mfd-timer to stm32-gptimer
- only keep one compatible string

Signed-off-by: Benjamin Gaignard 
---
 .../bindings/mfd/stm32-general-purpose-timer.txt   | 39 ++
 1 file changed, 39 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/mfd/stm32-general-purpose-timer.txt

diff --git 
a/Documentation/devicetree/bindings/mfd/stm32-general-purpose-timer.txt 
b/Documentation/devicetree/bindings/mfd/stm32-general-purpose-timer.txt
new file mode 100644
index 000..e92c8be
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/stm32-general-purpose-timer.txt
@@ -0,0 +1,39 @@
+STM32 General Purpose Timer driver bindings
+
+Required parameters:
+- compatible: must be "st,stm32-gptimer"
+
+- reg: Physical base address and length of the controller's
+   registers.
+- clock-names: Set to "clk_int".
+- clocks:  Phandle to the clock used by the timer module.
+   For Clk properties, please refer to 
../clock/clock-bindings.txt
+
+Optional parameters:
+- resets:  Phandle to the parent reset controller.
+   See ../reset/st,stm32-rcc.txt
+
+Optional subnodes:
+- pwm: See ../pwm/pwm-stm32.txt
+- timer:   See ../iio/timer/stm32-timer-trigger.txt
+
+Example:
+   gptimer@4001 {
+   #address-cells = <1>;
+   #size-cells = <0>;
+   compatible = "st,stm32-gptimer";
+   reg = <0x4001 0x400>;
+   clocks = < 0 160>;
+   clock-names = "clk_int";
+
+   pwm@0 {
+   compatible = "st,stm32-pwm";
+   pinctrl-0   = <_pins>;
+   pinctrl-names   = "default";
+   };
+
+   timer@0 {
+   compatible = "st,stm32-timer-trigger";
+   reg = <0>;
+   };
+   };
-- 
1.9.1

[PATCH v4 1/7] MFD: add bindings for STM32 General Purpose Timer driver

[Benjamin Gaignard]

Add bindings information for STM32 General Purpose Timer

version 2:
- rename stm32-mfd-timer to stm32-gptimer
- only keep one compatible string

Signed-off-by: Benjamin Gaignard 
---
 .../bindings/mfd/stm32-general-purpose-timer.txt   | 39 ++
 1 file changed, 39 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/mfd/stm32-general-purpose-timer.txt

diff --git 
a/Documentation/devicetree/bindings/mfd/stm32-general-purpose-timer.txt 
b/Documentation/devicetree/bindings/mfd/stm32-general-purpose-timer.txt
new file mode 100644
index 000..e92c8be
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/stm32-general-purpose-timer.txt
@@ -0,0 +1,39 @@
+STM32 General Purpose Timer driver bindings
+
+Required parameters:
+- compatible: must be "st,stm32-gptimer"
+
+- reg: Physical base address and length of the controller's
+   registers.
+- clock-names: Set to "clk_int".
+- clocks:  Phandle to the clock used by the timer module.
+   For Clk properties, please refer to 
../clock/clock-bindings.txt
+
+Optional parameters:
+- resets:  Phandle to the parent reset controller.
+   See ../reset/st,stm32-rcc.txt
+
+Optional subnodes:
+- pwm: See ../pwm/pwm-stm32.txt
+- timer:   See ../iio/timer/stm32-timer-trigger.txt
+
+Example:
+   gptimer@4001 {
+   #address-cells = <1>;
+   #size-cells = <0>;
+   compatible = "st,stm32-gptimer";
+   reg = <0x4001 0x400>;
+   clocks = < 0 160>;
+   clock-names = "clk_int";
+
+   pwm@0 {
+   compatible = "st,stm32-pwm";
+   pinctrl-0   = <_pins>;
+   pinctrl-names   = "default";
+   };
+
+   timer@0 {
+   compatible = "st,stm32-timer-trigger";
+   reg = <0>;
+   };
+   };
-- 
1.9.1