Re: [PATCH v4 2/2] dt-bindings: iio: adc: Add docs for AD7606 ADC

2018-12-10 Thread Rob Herring
On Mon, 10 Dec 2018 13:04:25 +0200, Stefan Popa wrote:
> Document support for AD7606 Analog to Digital Converter.
> 
> Signed-off-by: Stefan Popa 
> ---
> Changes in v2:
>   - fixed indentation issues.
>   - used gpios instead of gpio.
>   - added vendor prefix for conversion-start-gpios, first-data-gpios,
>   and range-gpios.
> Changes in v3:
>   - Added adi,oversampling-ratio-gpios.
> Changes in v4:
>   - Specified if the gpios are active high or low and set the flag
>   appropriately.
> 
>  .../devicetree/bindings/iio/adc/adi,ad7606.txt | 65 
> ++
>  MAINTAINERS|  1 +
>  2 files changed, 66 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7606.txt
> 

Reviewed-by: Rob Herring 


[PATCH v4 2/2] dt-bindings: iio: adc: Add docs for AD7606 ADC

2018-12-10 Thread Stefan Popa
Document support for AD7606 Analog to Digital Converter.

Signed-off-by: Stefan Popa 
---
Changes in v2:
- fixed indentation issues.
- used gpios instead of gpio.
- added vendor prefix for conversion-start-gpios, first-data-gpios,
and range-gpios.
Changes in v3:
- Added adi,oversampling-ratio-gpios.
Changes in v4:
- Specified if the gpios are active high or low and set the flag
appropriately.

 .../devicetree/bindings/iio/adc/adi,ad7606.txt | 65 ++
 MAINTAINERS|  1 +
 2 files changed, 66 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7606.txt

diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.txt 
b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.txt
new file mode 100644
index 000..d7b6241
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.txt
@@ -0,0 +1,65 @@
+Analog Devices AD7606 Simultaneous Sampling ADC
+
+Required properties for the AD7606:
+
+- compatible: Must be one of
+   * "adi,ad7605-4"
+   * "adi,ad7606-8"
+   * "adi,ad7606-6"
+   * "adi,ad7606-4"
+- reg: SPI chip select number for the device
+- spi-max-frequency: Max SPI frequency to use
+   see: Documentation/devicetree/bindings/spi/spi-bus.txt
+- spi-cpha: See Documentation/devicetree/bindings/spi/spi-bus.txt
+- avcc-supply: phandle to the Avcc power supply
+- interrupts: IRQ line for the ADC
+   see: 
Documentation/devicetree/bindings/interrupt-controller/interrupts.txt
+- adi,conversion-start-gpios: must be the device tree identifier of the CONVST 
pin.
+ This logic input is used to initiate conversions on the analog
+ input channels. As the line is active high, it should be 
marked
+ GPIO_ACTIVE_HIGH.
+
+Optional properties:
+
+- reset-gpios: must be the device tree identifier of the RESET pin. If 
specified,
+  it will be asserted during driver probe. As the line is active 
high,
+  it should be marked GPIO_ACTIVE_HIGH.
+- standby-gpios: must be the device tree identifier of the STBY pin. This pin 
is used
+   to place the AD7606 into one of two power-down modes, Standby 
mode or
+   Shutdown mode. As the line is active low, it should be marked
+   GPIO_ACTIVE_LOW.
+- adi,first-data-gpios: must be the device tree identifier of the FRSTDATA pin.
+   The FRSTDATA output indicates when the first channel, V1, is
+   being read back on either the parallel, byte or serial 
interface.
+   As the line is active high, it should be marked 
GPIO_ACTIVE_HIGH.
+- adi,range-gpios: must be the device tree identifier of the RANGE pin. The 
polarity on
+ this pin determines the input range of the analog input channels. 
If
+ this pin is tied to a logic high, the analog input range is ±10V 
for
+ all channels. If this pin is tied to a logic low, the analog 
input range
+ is ±5V for all channels. As the line is active high, it should be 
marked
+ GPIO_ACTIVE_HIGH.
+- adi,oversampling-ratio-gpios: must be the device tree identifier of the 
over-sampling
+   mode pins. As the line is active high, it 
should be marked
+   GPIO_ACTIVE_HIGH.
+
+Example:
+
+   adc@0 {
+   compatible = "adi,ad7606-8";
+   reg = <0>;
+   spi-max-frequency = <100>;
+   spi-cpol;
+
+   avcc-supply = <_vref>;
+
+   interrupts = <25 IRQ_TYPE_EDGE_FALLING>;
+   interrupt-parent = <>;
+
+   adi,conversion-start-gpios = < 17 GPIO_ACTIVE_HIGH>;
+   reset-gpios = < 27 GPIO_ACTIVE_HIGH>;
+   adi,first-data-gpios = < 22 GPIO_ACTIVE_HIGH>;
+   adi,oversampling-ratio-gpios = < 18 GPIO_ACTIVE_HIGH
+23 GPIO_ACTIVE_HIGH
+26 GPIO_ACTIVE_HIGH>;
+   standby-gpios = < 24 GPIO_ACTIVE_LOW>;
+   };
diff --git a/MAINTAINERS b/MAINTAINERS
index 843545d..6d63db4 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -845,6 +845,7 @@ L:  linux-...@vger.kernel.org
 W: http://ez.analog.com/community/linux-device-drivers
 S: Supported
 F: drivers/iio/adc/ad7606.c
+F: Documentation/devicetree/bindings/iio/adc/ad7606.txt
 
 ANALOG DEVICES INC AD9389B DRIVER
 M: Hans Verkuil 
-- 
2.7.4