Re: [PATCH v4 2/2] usbip: tools: add usage of device mode in usbip_list.c

[Shuah Khan]

On 3/23/21 7:01 AM, Hongren Zheng (Zenithal) wrote:

The option '-d/--device' was implemented in 'usbip list' but not
shown in usage. Hence this commit adds this option to usage.

Signed-off-by: Hongren Zheng 
---
  tools/usb/usbip/src/usbip_list.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

PATCH v2:
 Add signed-off-by line

PATCH v3:
 Move patch changelog after the marker line
 Remove nickname in signed-off-by line

PATCH v4:
 Use commit short hash and message instead of long hash only when
   referring to commit in the kernel

diff --git a/tools/usb/usbip/src/usbip_list.c b/tools/usb/usbip/src/usbip_list.c
index 8625b0f514ee..3d810bcca02f 100644
--- a/tools/usb/usbip/src/usbip_list.c
+++ b/tools/usb/usbip/src/usbip_list.c
@@ -33,7 +33,8 @@ static const char usbip_list_usage_string[] =
"usbip list [-p|--parsable] \n"
"-p, --parsable Parsable list format\n"
"-r, --remote=List the exportable USB devices on \n"
-   "-l, --localList the local USB devices\n";
+   "-l, --localList the local USB devices\n"
+   "-d, --device   List the local USB gadgets bound to 
usbip-vudc\n";
  
  void usbip_list_usage(void)

  {



Looks good to me. Thanks for adding this.

Acked-by: Shuah Khan 

thanks,
-- Shuah

[PATCH v4 2/2] usbip: tools: add usage of device mode in usbip_list.c

[Hongren Zheng (Zenithal)]

The option '-d/--device' was implemented in 'usbip list' but not
shown in usage. Hence this commit adds this option to usage.

Signed-off-by: Hongren Zheng 
---
 tools/usb/usbip/src/usbip_list.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

PATCH v2:
Add signed-off-by line

PATCH v3:
Move patch changelog after the marker line
Remove nickname in signed-off-by line

PATCH v4:
Use commit short hash and message instead of long hash only when
  referring to commit in the kernel

diff --git a/tools/usb/usbip/src/usbip_list.c b/tools/usb/usbip/src/usbip_list.c
index 8625b0f514ee..3d810bcca02f 100644
--- a/tools/usb/usbip/src/usbip_list.c
+++ b/tools/usb/usbip/src/usbip_list.c
@@ -33,7 +33,8 @@ static const char usbip_list_usage_string[] =
"usbip list [-p|--parsable] \n"
"-p, --parsable Parsable list format\n"
"-r, --remote=List the exportable USB devices on \n"
-   "-l, --localList the local USB devices\n";
+   "-l, --localList the local USB devices\n"
+   "-d, --device   List the local USB gadgets bound to 
usbip-vudc\n";
 
 void usbip_list_usage(void)
 {
-- 
2.30.1