[PATCH v4 6/7] leds: leds-pwm: Simplify cleanup code

2012-12-12 Thread Peter Ujfalusi 
The code looks more nicer if we use:

while (i--)

instead:
if (i > 0)
for (i = i - 1; i >= 0; i--)

Signed-off-by: Peter Ujfalusi 
---
 drivers/leds/leds-pwm.c | 6 ++
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/leds/leds-pwm.c b/drivers/leds/leds-pwm.c
index c767837..46f4e44 100644
--- a/drivers/leds/leds-pwm.c
+++ b/drivers/leds/leds-pwm.c
@@ -104,10 +104,8 @@ static int led_pwm_probe(struct platform_device *pdev)
return 0;
 
 err:
-   if (i > 0) {
-   for (i = i - 1; i >= 0; i--)
-   led_classdev_unregister(>leds[i].cdev);
-   }
+   while (i--)
+   led_classdev_unregister(>leds[i].cdev);
 
return ret;
 }
-- 
1.8.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v4 6/7] leds: leds-pwm: Simplify cleanup code

2012-12-12 Thread Peter Ujfalusi 
The code looks more nicer if we use:

while (i--)

instead:
if (i  0)
for (i = i - 1; i = 0; i--)

Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
 drivers/leds/leds-pwm.c | 6 ++
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/leds/leds-pwm.c b/drivers/leds/leds-pwm.c
index c767837..46f4e44 100644
--- a/drivers/leds/leds-pwm.c
+++ b/drivers/leds/leds-pwm.c
@@ -104,10 +104,8 @@ static int led_pwm_probe(struct platform_device *pdev)
return 0;
 
 err:
-   if (i  0) {
-   for (i = i - 1; i = 0; i--)
-   led_classdev_unregister(priv-leds[i].cdev);
-   }
+   while (i--)
+   led_classdev_unregister(priv-leds[i].cdev);
 
return ret;
 }
-- 
1.8.0

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/