Re: [PATCH v4 9/9] cpufreq: scpi: Use auto-registration of thermal cooling device

[Daniel Lezcano]

On 28/01/2019 07:41, Amit Kucheria wrote:
> Use the CPUFREQ_AUTO_REGISTER_COOLING_DEV flag to allow cpufreq core to
> automatically register as a thermal cooling device.
> 
> This allows removal of boiler plate code from the driver.
> 
> Signed-off-by: Amit Kucheria 
> Acked-by: Sudeep Holla 

Reviewed-by: Daniel Lezcano 


> ---
>  drivers/cpufreq/scpi-cpufreq.c | 14 ++
>  1 file changed, 2 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/cpufreq/scpi-cpufreq.c b/drivers/cpufreq/scpi-cpufreq.c
> index 99449738faa4..82420e8e5f0d 100644
> --- a/drivers/cpufreq/scpi-cpufreq.c
> +++ b/drivers/cpufreq/scpi-cpufreq.c
> @@ -22,7 +22,6 @@
>  #include 
>  #include 
>  #include 
> -#include 
>  #include 
>  #include 
>  #include 
> @@ -34,7 +33,6 @@
>  struct scpi_data {
>   struct clk *clk;
>   struct device *cpu_dev;
> - struct thermal_cooling_device *cdev;
>  };
>  
>  static struct scpi_ops *scpi_ops;
> @@ -186,7 +184,6 @@ static int scpi_cpufreq_exit(struct cpufreq_policy 
> *policy)
>  {
>   struct scpi_data *priv = policy->driver_data;
>  
> - cpufreq_cooling_unregister(priv->cdev);
>   clk_put(priv->clk);
>   dev_pm_opp_free_cpufreq_table(priv->cpu_dev, &policy->freq_table);
>   kfree(priv);
> @@ -195,23 +192,16 @@ static int scpi_cpufreq_exit(struct cpufreq_policy 
> *policy)
>   return 0;
>  }
>  
> -static void scpi_cpufreq_ready(struct cpufreq_policy *policy)
> -{
> - struct scpi_data *priv = policy->driver_data;
> -
> - priv->cdev = of_cpufreq_cooling_register(policy);
> -}
> -
>  static struct cpufreq_driver scpi_cpufreq_driver = {
>   .name   = "scpi-cpufreq",
>   .flags  = CPUFREQ_STICKY | CPUFREQ_HAVE_GOVERNOR_PER_POLICY |
> -   CPUFREQ_NEED_INITIAL_FREQ_CHECK,
> +   CPUFREQ_NEED_INITIAL_FREQ_CHECK |
> +   CPUFREQ_AUTO_REGISTER_COOLING_DEV,
>   .verify = cpufreq_generic_frequency_table_verify,
>   .attr   = cpufreq_generic_attr,
>   .get= scpi_cpufreq_get_rate,
>   .init   = scpi_cpufreq_init,
>   .exit   = scpi_cpufreq_exit,
> - .ready  = scpi_cpufreq_ready,
>   .target_index   = scpi_cpufreq_set_target,
>  };
>  
> 


-- 
  Linaro.org │ Open source software for ARM SoCs

Follow Linaro:   Facebook |
 Twitter |
 Blog

[PATCH v4 9/9] cpufreq: scpi: Use auto-registration of thermal cooling device

[Amit Kucheria]

Use the CPUFREQ_AUTO_REGISTER_COOLING_DEV flag to allow cpufreq core to
automatically register as a thermal cooling device.

This allows removal of boiler plate code from the driver.

Signed-off-by: Amit Kucheria 
Acked-by: Sudeep Holla 
---
 drivers/cpufreq/scpi-cpufreq.c | 14 ++
 1 file changed, 2 insertions(+), 12 deletions(-)

diff --git a/drivers/cpufreq/scpi-cpufreq.c b/drivers/cpufreq/scpi-cpufreq.c
index 99449738faa4..82420e8e5f0d 100644
--- a/drivers/cpufreq/scpi-cpufreq.c
+++ b/drivers/cpufreq/scpi-cpufreq.c
@@ -22,7 +22,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -34,7 +33,6 @@
 struct scpi_data {
struct clk *clk;
struct device *cpu_dev;
-   struct thermal_cooling_device *cdev;
 };
 
 static struct scpi_ops *scpi_ops;
@@ -186,7 +184,6 @@ static int scpi_cpufreq_exit(struct cpufreq_policy *policy)
 {
struct scpi_data *priv = policy->driver_data;
 
-   cpufreq_cooling_unregister(priv->cdev);
clk_put(priv->clk);
dev_pm_opp_free_cpufreq_table(priv->cpu_dev, &policy->freq_table);
kfree(priv);
@@ -195,23 +192,16 @@ static int scpi_cpufreq_exit(struct cpufreq_policy 
*policy)
return 0;
 }
 
-static void scpi_cpufreq_ready(struct cpufreq_policy *policy)
-{
-   struct scpi_data *priv = policy->driver_data;
-
-   priv->cdev = of_cpufreq_cooling_register(policy);
-}
-
 static struct cpufreq_driver scpi_cpufreq_driver = {
.name   = "scpi-cpufreq",
.flags  = CPUFREQ_STICKY | CPUFREQ_HAVE_GOVERNOR_PER_POLICY |
- CPUFREQ_NEED_INITIAL_FREQ_CHECK,
+ CPUFREQ_NEED_INITIAL_FREQ_CHECK |
+ CPUFREQ_AUTO_REGISTER_COOLING_DEV,
.verify = cpufreq_generic_frequency_table_verify,
.attr   = cpufreq_generic_attr,
.get= scpi_cpufreq_get_rate,
.init   = scpi_cpufreq_init,
.exit   = scpi_cpufreq_exit,
-   .ready  = scpi_cpufreq_ready,
.target_index   = scpi_cpufreq_set_target,
 };
 
-- 
2.17.1