Re: [PATCH v5 0/5] stmmac: pci: Refactor DMI probing

[David Miller]

From: Jan Kiszka 
Date: Thu, 22 Jun 2017 19:43:51 +0200

> On 2017-06-22 19:40, David Miller wrote:
>> From: Jan Kiszka 
>> Date: Thu, 22 Jun 2017 08:17:56 +0200
>> 
>>> Some cleanups of the way we probe DMI platforms in the driver. Reduces
>>> a bit of open-coding and makes the logic easier reusable for any
>>> potential DMI platform != Quark.
>>>
>>> Tested on IOT2000 and Galileo Gen2.
>>>
>>> Changes in v5:
>>>  - fixed a remaining issue in patch 5
>>>  - dropped patch 6 for now
>> 
>> Series applied to net-next.
>> 
>> Any chance the DMI table can be marked const as well?
>> 
> 
> Hmm, they are all const - or which one do you mean?

Indeed, they are, I misread the patches.

Nothing to see here, move along :)

Re: [PATCH v5 0/5] stmmac: pci: Refactor DMI probing

[David Miller]

From: Jan Kiszka 
Date: Thu, 22 Jun 2017 19:43:51 +0200

> On 2017-06-22 19:40, David Miller wrote:
>> From: Jan Kiszka 
>> Date: Thu, 22 Jun 2017 08:17:56 +0200
>> 
>>> Some cleanups of the way we probe DMI platforms in the driver. Reduces
>>> a bit of open-coding and makes the logic easier reusable for any
>>> potential DMI platform != Quark.
>>>
>>> Tested on IOT2000 and Galileo Gen2.
>>>
>>> Changes in v5:
>>>  - fixed a remaining issue in patch 5
>>>  - dropped patch 6 for now
>> 
>> Series applied to net-next.
>> 
>> Any chance the DMI table can be marked const as well?
>> 
> 
> Hmm, they are all const - or which one do you mean?

Indeed, they are, I misread the patches.

Nothing to see here, move along :)

Re: [PATCH v5 0/5] stmmac: pci: Refactor DMI probing

[Jan Kiszka]

On 2017-06-22 19:40, David Miller wrote:
> From: Jan Kiszka 
> Date: Thu, 22 Jun 2017 08:17:56 +0200
> 
>> Some cleanups of the way we probe DMI platforms in the driver. Reduces
>> a bit of open-coding and makes the logic easier reusable for any
>> potential DMI platform != Quark.
>>
>> Tested on IOT2000 and Galileo Gen2.
>>
>> Changes in v5:
>>  - fixed a remaining issue in patch 5
>>  - dropped patch 6 for now
> 
> Series applied to net-next.
> 
> Any chance the DMI table can be marked const as well?
> 

Hmm, they are all const - or which one do you mean?

Jan

-- 
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux

Re: [PATCH v5 0/5] stmmac: pci: Refactor DMI probing

[Jan Kiszka]

On 2017-06-22 19:40, David Miller wrote:
> From: Jan Kiszka 
> Date: Thu, 22 Jun 2017 08:17:56 +0200
> 
>> Some cleanups of the way we probe DMI platforms in the driver. Reduces
>> a bit of open-coding and makes the logic easier reusable for any
>> potential DMI platform != Quark.
>>
>> Tested on IOT2000 and Galileo Gen2.
>>
>> Changes in v5:
>>  - fixed a remaining issue in patch 5
>>  - dropped patch 6 for now
> 
> Series applied to net-next.
> 
> Any chance the DMI table can be marked const as well?
> 

Hmm, they are all const - or which one do you mean?

Jan

-- 
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux

Re: [PATCH v5 0/5] stmmac: pci: Refactor DMI probing

[David Miller]

From: Jan Kiszka 
Date: Thu, 22 Jun 2017 08:17:56 +0200

> Some cleanups of the way we probe DMI platforms in the driver. Reduces
> a bit of open-coding and makes the logic easier reusable for any
> potential DMI platform != Quark.
> 
> Tested on IOT2000 and Galileo Gen2.
> 
> Changes in v5:
>  - fixed a remaining issue in patch 5
>  - dropped patch 6 for now

Series applied to net-next.

Any chance the DMI table can be marked const as well?

Re: [PATCH v5 0/5] stmmac: pci: Refactor DMI probing

[David Miller]

From: Jan Kiszka 
Date: Thu, 22 Jun 2017 08:17:56 +0200

> Some cleanups of the way we probe DMI platforms in the driver. Reduces
> a bit of open-coding and makes the logic easier reusable for any
> potential DMI platform != Quark.
> 
> Tested on IOT2000 and Galileo Gen2.
> 
> Changes in v5:
>  - fixed a remaining issue in patch 5
>  - dropped patch 6 for now

Series applied to net-next.

Any chance the DMI table can be marked const as well?

[PATCH v5 0/5] stmmac: pci: Refactor DMI probing

[Jan Kiszka]

Some cleanups of the way we probe DMI platforms in the driver. Reduces
a bit of open-coding and makes the logic easier reusable for any
potential DMI platform != Quark.

Tested on IOT2000 and Galileo Gen2.

Changes in v5:
 - fixed a remaining issue in patch 5
 - dropped patch 6 for now

Jan

Jan Kiszka (5):
  stmmac: pci: Make stmmac_pci_info structure constant
  stmmac: pci: Use stmmac_pci_info for all devices
  stmmac: pci: Make stmmac_pci_find_phy_addr truly generic
  stmmac: pci: Select quark_pci_dmi_data from quark_default_data
  stmmac: pci: Use dmi_system_id table for retrieving PHY addresses

 drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c | 203 ++-
 1 file changed, 122 insertions(+), 81 deletions(-)

-- 
2.12.3

[PATCH v5 0/5] stmmac: pci: Refactor DMI probing

[Jan Kiszka]

Some cleanups of the way we probe DMI platforms in the driver. Reduces
a bit of open-coding and makes the logic easier reusable for any
potential DMI platform != Quark.

Tested on IOT2000 and Galileo Gen2.

Changes in v5:
 - fixed a remaining issue in patch 5
 - dropped patch 6 for now

Jan

Jan Kiszka (5):
  stmmac: pci: Make stmmac_pci_info structure constant
  stmmac: pci: Use stmmac_pci_info for all devices
  stmmac: pci: Make stmmac_pci_find_phy_addr truly generic
  stmmac: pci: Select quark_pci_dmi_data from quark_default_data
  stmmac: pci: Use dmi_system_id table for retrieving PHY addresses

 drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c | 203 ++-
 1 file changed, 122 insertions(+), 81 deletions(-)

-- 
2.12.3