Re: [PATCH v5 0/7] Add interrupt support to FPGA DFL drivers
Hi Moritz: Thanks for your comments for first 3 patches. And do you have more comments on last 4 patches? I have done the changes for those fixes. I'm not sure if I should send the v6 patchset now? Thanks, Yilun. On Wed, May 06, 2020 at 06:17:27PM -0700, Moritz Fischer wrote: > Hi Xu, > > On Tue, May 5, 2020 at 10:13 PM Xu Yilun wrote: > > > > Hi Moritz: > > > > Hao and I did several rounds of review and fix in the mailing list. Now > > the patches are all acked by Hao. > > > > Could you please help review it when you have time? > > I'll get to it this weekend. Sorry for the delay, > > Moritz > > > > Thanks! :) > > > > On Mon, Apr 20, 2020 at 04:11:36PM +0800, Xu Yilun wrote: > > > This patchset add interrupt support to FPGA DFL drivers. > > > > > > With these patches, DFL driver will parse and assign interrupt resources > > > for enumerated feature devices and their sub features. > > > > > > This patchset also introduces a set of APIs for user to monitor DFL > > > interrupts. Three sub features (DFL FME error, DFL AFU error and user > > > interrupt) drivers now support these APIs. > > > > > > Patch #1: DFL framework change. Accept interrupt info input from DFL bus > > > driver, and add interrupt parsing and assignment for feature > > > sub devices. > > > Patch #2: DFL pci driver change, add interrupt info on DFL enumeration. > > > Patch #3: DFL framework change. Add helper functions for feature sub > > > device drivers to handle interrupt and notify users. > > > Patch #4: Add interrupt support for AFU error reporting sub feature. > > > Patch #5: Add interrupt support for FME global error reporting sub > > > feature. > > > Patch #6: Add interrupt support for a new sub feature, to handle user > > > interrupts implemented in AFU. > > > Patch #7: Documentation for DFL interrupt handling. > > > > > > Main changes from v1: > > > - Early validating irq table for each feature in parse_feature_irq() > > >in Patch #1. > > > - Changes IOCTL interfaces. use DFL_FPGA_FME/PORT_XXX_GET_IRQ_NUM > > >instead of DFL_FPGA_FME/PORT_XXX_GET_INFO, delete flag field for > > >DFL_FPGA_FME/PORT_XXX_SET_IRQ param > > > > > > Main changes from v2: > > > - put parse_feature_irqs() inside create_feature_instance(). > > > - refines code for dfl_fpga_set_irq_triggers, delete local variable j. > > > - put_user() instead of copy_to_user() for DFL_FPGA_XXX_GET_IRQ_NUM IOCTL > > > > > > Main changes from v3: > > > - rebased to 5.7-rc1. > > > - fail the dfl enumeration when irq parsing error happens. > > > - Add 2 helper functions in dfl.c to handle generic irq ioctls in feature > > >drivers. > > > > > > Main changes from v4: > > > - Minor fixes for Hao's comments. > > > > > > Xu Yilun (7): > > > fpga: dfl: parse interrupt info for feature devices on enumeration > > > fpga: dfl: pci: add irq info for feature devices enumeration > > > fpga: dfl: introduce interrupt trigger setting API > > > fpga: dfl: afu: add interrupt support for port error reporting > > > fpga: dfl: fme: add interrupt support for global error reporting > > > fpga: dfl: afu: add AFU interrupt support > > > Documentation: fpga: dfl: add descriptions for interrupt related > > > interfaces. > > > > > > Documentation/fpga/dfl.rst| 19 +++ > > > drivers/fpga/dfl-afu-error.c | 17 +++ > > > drivers/fpga/dfl-afu-main.c | 32 + > > > drivers/fpga/dfl-fme-error.c | 18 +++ > > > drivers/fpga/dfl-fme-main.c | 6 + > > > drivers/fpga/dfl-pci.c| 80 +-- > > > drivers/fpga/dfl.c| 310 > > > ++ > > > drivers/fpga/dfl.h| 57 > > > include/uapi/linux/fpga-dfl.h | 82 +++ > > > 9 files changed, 612 insertions(+), 9 deletions(-) > > > > > > -- > > > 2.7.4
Re: [PATCH v5 0/7] Add interrupt support to FPGA DFL drivers
Hi Xu, On Tue, May 5, 2020 at 10:13 PM Xu Yilun wrote: > > Hi Moritz: > > Hao and I did several rounds of review and fix in the mailing list. Now > the patches are all acked by Hao. > > Could you please help review it when you have time? I'll get to it this weekend. Sorry for the delay, Moritz > > Thanks! :) > > On Mon, Apr 20, 2020 at 04:11:36PM +0800, Xu Yilun wrote: > > This patchset add interrupt support to FPGA DFL drivers. > > > > With these patches, DFL driver will parse and assign interrupt resources > > for enumerated feature devices and their sub features. > > > > This patchset also introduces a set of APIs for user to monitor DFL > > interrupts. Three sub features (DFL FME error, DFL AFU error and user > > interrupt) drivers now support these APIs. > > > > Patch #1: DFL framework change. Accept interrupt info input from DFL bus > > driver, and add interrupt parsing and assignment for feature > > sub devices. > > Patch #2: DFL pci driver change, add interrupt info on DFL enumeration. > > Patch #3: DFL framework change. Add helper functions for feature sub > > device drivers to handle interrupt and notify users. > > Patch #4: Add interrupt support for AFU error reporting sub feature. > > Patch #5: Add interrupt support for FME global error reporting sub > > feature. > > Patch #6: Add interrupt support for a new sub feature, to handle user > > interrupts implemented in AFU. > > Patch #7: Documentation for DFL interrupt handling. > > > > Main changes from v1: > > - Early validating irq table for each feature in parse_feature_irq() > >in Patch #1. > > - Changes IOCTL interfaces. use DFL_FPGA_FME/PORT_XXX_GET_IRQ_NUM > >instead of DFL_FPGA_FME/PORT_XXX_GET_INFO, delete flag field for > >DFL_FPGA_FME/PORT_XXX_SET_IRQ param > > > > Main changes from v2: > > - put parse_feature_irqs() inside create_feature_instance(). > > - refines code for dfl_fpga_set_irq_triggers, delete local variable j. > > - put_user() instead of copy_to_user() for DFL_FPGA_XXX_GET_IRQ_NUM IOCTL > > > > Main changes from v3: > > - rebased to 5.7-rc1. > > - fail the dfl enumeration when irq parsing error happens. > > - Add 2 helper functions in dfl.c to handle generic irq ioctls in feature > >drivers. > > > > Main changes from v4: > > - Minor fixes for Hao's comments. > > > > Xu Yilun (7): > > fpga: dfl: parse interrupt info for feature devices on enumeration > > fpga: dfl: pci: add irq info for feature devices enumeration > > fpga: dfl: introduce interrupt trigger setting API > > fpga: dfl: afu: add interrupt support for port error reporting > > fpga: dfl: fme: add interrupt support for global error reporting > > fpga: dfl: afu: add AFU interrupt support > > Documentation: fpga: dfl: add descriptions for interrupt related > > interfaces. > > > > Documentation/fpga/dfl.rst| 19 +++ > > drivers/fpga/dfl-afu-error.c | 17 +++ > > drivers/fpga/dfl-afu-main.c | 32 + > > drivers/fpga/dfl-fme-error.c | 18 +++ > > drivers/fpga/dfl-fme-main.c | 6 + > > drivers/fpga/dfl-pci.c| 80 +-- > > drivers/fpga/dfl.c| 310 > > ++ > > drivers/fpga/dfl.h| 57 > > include/uapi/linux/fpga-dfl.h | 82 +++ > > 9 files changed, 612 insertions(+), 9 deletions(-) > > > > -- > > 2.7.4
Re: [PATCH v5 0/7] Add interrupt support to FPGA DFL drivers
Hi Moritz: Hao and I did several rounds of review and fix in the mailing list. Now the patches are all acked by Hao. Could you please help review it when you have time? Thanks! :) On Mon, Apr 20, 2020 at 04:11:36PM +0800, Xu Yilun wrote: > This patchset add interrupt support to FPGA DFL drivers. > > With these patches, DFL driver will parse and assign interrupt resources > for enumerated feature devices and their sub features. > > This patchset also introduces a set of APIs for user to monitor DFL > interrupts. Three sub features (DFL FME error, DFL AFU error and user > interrupt) drivers now support these APIs. > > Patch #1: DFL framework change. Accept interrupt info input from DFL bus > driver, and add interrupt parsing and assignment for feature > sub devices. > Patch #2: DFL pci driver change, add interrupt info on DFL enumeration. > Patch #3: DFL framework change. Add helper functions for feature sub > device drivers to handle interrupt and notify users. > Patch #4: Add interrupt support for AFU error reporting sub feature. > Patch #5: Add interrupt support for FME global error reporting sub > feature. > Patch #6: Add interrupt support for a new sub feature, to handle user > interrupts implemented in AFU. > Patch #7: Documentation for DFL interrupt handling. > > Main changes from v1: > - Early validating irq table for each feature in parse_feature_irq() >in Patch #1. > - Changes IOCTL interfaces. use DFL_FPGA_FME/PORT_XXX_GET_IRQ_NUM >instead of DFL_FPGA_FME/PORT_XXX_GET_INFO, delete flag field for >DFL_FPGA_FME/PORT_XXX_SET_IRQ param > > Main changes from v2: > - put parse_feature_irqs() inside create_feature_instance(). > - refines code for dfl_fpga_set_irq_triggers, delete local variable j. > - put_user() instead of copy_to_user() for DFL_FPGA_XXX_GET_IRQ_NUM IOCTL > > Main changes from v3: > - rebased to 5.7-rc1. > - fail the dfl enumeration when irq parsing error happens. > - Add 2 helper functions in dfl.c to handle generic irq ioctls in feature >drivers. > > Main changes from v4: > - Minor fixes for Hao's comments. > > Xu Yilun (7): > fpga: dfl: parse interrupt info for feature devices on enumeration > fpga: dfl: pci: add irq info for feature devices enumeration > fpga: dfl: introduce interrupt trigger setting API > fpga: dfl: afu: add interrupt support for port error reporting > fpga: dfl: fme: add interrupt support for global error reporting > fpga: dfl: afu: add AFU interrupt support > Documentation: fpga: dfl: add descriptions for interrupt related > interfaces. > > Documentation/fpga/dfl.rst| 19 +++ > drivers/fpga/dfl-afu-error.c | 17 +++ > drivers/fpga/dfl-afu-main.c | 32 + > drivers/fpga/dfl-fme-error.c | 18 +++ > drivers/fpga/dfl-fme-main.c | 6 + > drivers/fpga/dfl-pci.c| 80 +-- > drivers/fpga/dfl.c| 310 > ++ > drivers/fpga/dfl.h| 57 > include/uapi/linux/fpga-dfl.h | 82 +++ > 9 files changed, 612 insertions(+), 9 deletions(-) > > -- > 2.7.4
