Re: [PATCH v5 0/8] omap: dmtimer: Move driver out of plat-omap
On Mon, Dec 18, 2017 at 06:24:42PM +0530, Keerthy wrote: > On Monday 18 December 2017 04:46 PM, Ladislav Michl wrote: > > Keerthy, > > > > On Tue, Dec 12, 2017 at 11:42:09AM +0530, Keerthy wrote: > >> The series moves dmtimer out of plat-omap to drivers/clocksource. > >> The series also does a bunch of changes to pwm-omap-dmtimer code > >> to adapt to the driver migration and clean up plat specific > >> pdata-quirks and use the dmtimer platform data. > > > > thanks for nice work. I'll send two more patches as a reply to this > > one. I'd be glad if you could make them part of your serie. One of > > them would be nice to have for pwm driver prescaler fix which will > > be send independently. > > Also, if that helps you can have my > > Tested-by: Ladislav Michl > > on IGEPv2 (OMAP3430 based) > > Thanks a bunch! :-). I will take the pwm driver fix along with mine. > > should i also take the two patches which you sent: > > [PATCH 1/2] clocksource: timer-dm: Make unexported functions static > [PATCH 2/2] clocksource: timer-dm: Check prescaler value It would be great, if you could add those above to your serie. > Also what about this: > [PATCH] pwm: omap-dmtimer: Fix frequency when using prescaler This one is independent of your serie, just "[PATCH 2/2] clocksource: timer-dm: Check prescaler value" makes it a bit more error prone, but there is no compile nor runtime dependency. Perhaps it could me merged directly via pwm tree after some review? I have few more patches to add event capture support, based on top of those already sent, which I'll send separately. > Let me know. I plan to send v6 with your Tested-by. > > Thanks, > Keerthy Thank you, ladis
Re: [PATCH v5 0/8] omap: dmtimer: Move driver out of plat-omap
On Monday 18 December 2017 04:46 PM, Ladislav Michl wrote: > Keerthy, > > On Tue, Dec 12, 2017 at 11:42:09AM +0530, Keerthy wrote: >> The series moves dmtimer out of plat-omap to drivers/clocksource. >> The series also does a bunch of changes to pwm-omap-dmtimer code >> to adapt to the driver migration and clean up plat specific >> pdata-quirks and use the dmtimer platform data. > > thanks for nice work. I'll send two more patches as a reply to this > one. I'd be glad if you could make them part of your serie. One of > them would be nice to have for pwm driver prescaler fix which will > be send independently. > Also, if that helps you can have my > Tested-by: Ladislav Michl > on IGEPv2 (OMAP3430 based) Thanks a bunch! :-). I will take the pwm driver fix along with mine. should i also take the two patches which you sent: [PATCH 1/2] clocksource: timer-dm: Make unexported functions static [PATCH 2/2] clocksource: timer-dm: Check prescaler value Also what about this: [PATCH] pwm: omap-dmtimer: Fix frequency when using prescaler Let me know. I plan to send v6 with your Tested-by. Thanks, Keerthy > >> Boot tested on DRA7-EVM and AM437X-GP-EVM. > > I guess PWM driver was not tested, right? See comment to PATCH 7/8. > >> Compile tested omap1_defconfig. Yes! Thanks for your feedback. > > Thank you, > ladis >
Re: [PATCH v5 0/8] omap: dmtimer: Move driver out of plat-omap
Keerthy, On Tue, Dec 12, 2017 at 11:42:09AM +0530, Keerthy wrote: > The series moves dmtimer out of plat-omap to drivers/clocksource. > The series also does a bunch of changes to pwm-omap-dmtimer code > to adapt to the driver migration and clean up plat specific > pdata-quirks and use the dmtimer platform data. thanks for nice work. I'll send two more patches as a reply to this one. I'd be glad if you could make them part of your serie. One of them would be nice to have for pwm driver prescaler fix which will be send independently. Also, if that helps you can have my Tested-by: Ladislav Michl on IGEPv2 (OMAP3430 based) > Boot tested on DRA7-EVM and AM437X-GP-EVM. I guess PWM driver was not tested, right? See comment to PATCH 7/8. > Compile tested omap1_defconfig. Thank you, ladis
[PATCH v5 0/8] omap: dmtimer: Move driver out of plat-omap
The series moves dmtimer out of plat-omap to drivers/clocksource.
The series also does a bunch of changes to pwm-omap-dmtimer code
to adapt to the driver migration and clean up plat specific
pdata-quirks and use the dmtimer platform data.
Boot tested on DRA7-EVM and AM437X-GP-EVM.
Compile tested omap1_defconfig.
This is based on top of linux-next branch.
Changes from v4:
* Made OMAP_DM_TIMER config option silent.
* Changed the driver name to timer-dm.c
Changes from v3:
* Reverted to v2 approach of using dev_get_platdata to fetch dmtimer ops.
Changes from V2:
* Wrapped the inline functions in header file under OMAP2PLUS
* Added a new of helper function to fetch plat_data from of node.
Keerthy (8):
clocksource: dmtimer: Remove all the exports
arm: omap: timer: Wrap the inline functions under OMAP2PLUS define
arm: omap: Move dmtimer.h out of plat-omap
arm: OMAP: Move dmtimer driver out of plat-omap to drivers under
clocksource
dmtimer: Add timer ops to the platform data structure
clocksource: dmtimer: Populate the timer ops to the pdata
pwm: pwm-omap-dmtimer: Adapt driver to utilize dmtimer pdata ops
arm: omap: pdata-quirks: Remove unused timer pdata
arch/arm/mach-omap1/pm.c | 2 +-
arch/arm/mach-omap1/timer.c| 2 +-
arch/arm/mach-omap2/omap_hwmod_2420_data.c | 2 +-
arch/arm/mach-omap2/omap_hwmod_2430_data.c | 2 +-
arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c | 2 +-
arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 2 +-
arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 2 +-
arch/arm/mach-omap2/omap_hwmod_54xx_data.c | 2 +-
arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 2 +-
arch/arm/mach-omap2/omap_hwmod_81xx_data.c | 2 +-
arch/arm/mach-omap2/pdata-quirks.c | 32 -
arch/arm/mach-omap2/timer.c| 2 +-
arch/arm/plat-omap/Kconfig | 6 ---
arch/arm/plat-omap/Makefile| 1 -
drivers/clocksource/Kconfig| 3 ++
drivers/clocksource/Makefile | 1 +
.../dmtimer.c => drivers/clocksource/timer-dm.c| 54 +++---
drivers/pwm/pwm-omap-dmtimer.c | 39 +---
.../include/plat => include/clocksource}/dmtimer.h | 8 +++-
include/linux/platform_data/dmtimer-omap.h | 38 +++
20 files changed, 108 insertions(+), 96 deletions(-)
rename arch/arm/plat-omap/dmtimer.c => drivers/clocksource/timer-dm.c (95%)
rename {arch/arm/plat-omap/include/plat => include/clocksource}/dmtimer.h (97%)
--
1.9.1
