Re: [PATCH v5 01/14] Documentation: of: add type property

[Kuninori Morimoto]

Hi Rob

> > From: Kuninori Morimoto 
> > 
> > OF graph indicates each devices connection. But it doesn't support type
> > of each port. For example HDMI case, it has video port and sound port
> > in one device node.
> > In this case, current driver can't handle each port correctly.
> > This patch enables to use type property on OF graph.
> 
> I still don't think this is necessary. Simply define which port number 
> is which for each HDMI chip.
> 
> If this is necessary, then the types, video and sound, are too generic.

About this, if OF-graph can have "query" function to each port,
I can remove this "type" property from DT, and driver can answer
each port feature.
But is this OK approach ?

Best regards
---
Kuninori Morimoto

Re: [PATCH v5 01/14] Documentation: of: add type property

[Kuninori Morimoto]

Hi Rob

> > From: Kuninori Morimoto 
> > 
> > OF graph indicates each devices connection. But it doesn't support type
> > of each port. For example HDMI case, it has video port and sound port
> > in one device node.
> > In this case, current driver can't handle each port correctly.
> > This patch enables to use type property on OF graph.
> 
> I still don't think this is necessary. Simply define which port number 
> is which for each HDMI chip.
> 
> If this is necessary, then the types, video and sound, are too generic.

About this, if OF-graph can have "query" function to each port,
I can remove this "type" property from DT, and driver can answer
each port feature.
But is this OK approach ?

Best regards
---
Kuninori Morimoto

Re: [PATCH v5 01/14] Documentation: of: add type property

[Rob Herring]

On Mon, Nov 28, 2016 at 02:44:46AM +, Kuninori Morimoto wrote:
> 
> From: Kuninori Morimoto 
> 
> OF graph indicates each devices connection. But it doesn't support type
> of each port. For example HDMI case, it has video port and sound port
> in one device node.
> In this case, current driver can't handle each port correctly.
> This patch enables to use type property on OF graph.

I still don't think this is necessary. Simply define which port number 
is which for each HDMI chip.

If this is necessary, then the types, video and sound, are too generic.

> 
> Signed-off-by: Kuninori Morimoto 
> ---
>  Documentation/devicetree/bindings/graph.txt | 21 +
>  1 file changed, 21 insertions(+)

Re: [PATCH v5 01/14] Documentation: of: add type property

[Rob Herring]

On Mon, Nov 28, 2016 at 02:44:46AM +, Kuninori Morimoto wrote:
> 
> From: Kuninori Morimoto 
> 
> OF graph indicates each devices connection. But it doesn't support type
> of each port. For example HDMI case, it has video port and sound port
> in one device node.
> In this case, current driver can't handle each port correctly.
> This patch enables to use type property on OF graph.

I still don't think this is necessary. Simply define which port number 
is which for each HDMI chip.

If this is necessary, then the types, video and sound, are too generic.

> 
> Signed-off-by: Kuninori Morimoto 
> ---
>  Documentation/devicetree/bindings/graph.txt | 21 +
>  1 file changed, 21 insertions(+)

[PATCH v5 01/14] Documentation: of: add type property

[Kuninori Morimoto]

From: Kuninori Morimoto 

OF graph indicates each devices connection. But it doesn't support type
of each port. For example HDMI case, it has video port and sound port
in one device node.
In this case, current driver can't handle each port correctly.
This patch enables to use type property on OF graph.

Signed-off-by: Kuninori Morimoto 
---
 Documentation/devicetree/bindings/graph.txt | 21 +
 1 file changed, 21 insertions(+)

diff --git a/Documentation/devicetree/bindings/graph.txt 
b/Documentation/devicetree/bindings/graph.txt
index fcb1c6a..fe6c8ce 100644
--- a/Documentation/devicetree/bindings/graph.txt
+++ b/Documentation/devicetree/bindings/graph.txt
@@ -110,6 +110,27 @@ device-2 {
 };
 };
 
+port / endpoint type
+
+
+Each port can have its type if needed.
+For example HDMI case, it has video port and sound port.
+Below example indicates that port@0 is HDMI-video port,
+and port@1 is HDMI-sound port.
+
+HDMI {
+   port@0 {
+   type = "video";
+   endpoint {
+   };
+   };
+   port@1 {
+   type = "sound";
+   endpoint {
+   };
+   };
+};
+
 
 Required properties
 ---
-- 
1.9.1

[PATCH v5 01/14] Documentation: of: add type property

[Kuninori Morimoto]

From: Kuninori Morimoto 

OF graph indicates each devices connection. But it doesn't support type
of each port. For example HDMI case, it has video port and sound port
in one device node.
In this case, current driver can't handle each port correctly.
This patch enables to use type property on OF graph.

Signed-off-by: Kuninori Morimoto 
---
 Documentation/devicetree/bindings/graph.txt | 21 +
 1 file changed, 21 insertions(+)

diff --git a/Documentation/devicetree/bindings/graph.txt 
b/Documentation/devicetree/bindings/graph.txt
index fcb1c6a..fe6c8ce 100644
--- a/Documentation/devicetree/bindings/graph.txt
+++ b/Documentation/devicetree/bindings/graph.txt
@@ -110,6 +110,27 @@ device-2 {
 };
 };
 
+port / endpoint type
+
+
+Each port can have its type if needed.
+For example HDMI case, it has video port and sound port.
+Below example indicates that port@0 is HDMI-video port,
+and port@1 is HDMI-sound port.
+
+HDMI {
+   port@0 {
+   type = "video";
+   endpoint {
+   };
+   };
+   port@1 {
+   type = "sound";
+   endpoint {
+   };
+   };
+};
+
 
 Required properties
 ---
-- 
1.9.1