Re: [PATCH v5 07/11] staging: iio: ad7780: move regulator to after GPIO init

[Jonathan Cameron]

On Fri, 15 Mar 2019 23:14:59 -0300
Renato Lui Geh  wrote:

> To maintain consistency between ad7780_probe and ad7780_remove orders,
> regulator initialization has been moved to after GPIO initializations.
> 
> Signed-off-by: Renato Lui Geh 
Applied,

Thanks,

Jonathan

> ---
>  drivers/staging/iio/adc/ad7780.c | 20 ++--
>  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/staging/iio/adc/ad7780.c 
> b/drivers/staging/iio/adc/ad7780.c
> index 977b381c1260..568c5b4472ff 100644
> --- a/drivers/staging/iio/adc/ad7780.c
> +++ b/drivers/staging/iio/adc/ad7780.c
> @@ -295,16 +295,6 @@ static int ad7780_probe(struct spi_device *spi)
>  
>   ad_sd_init(>sd, indio_dev, spi, _sigma_delta_info);
>  
> - st->reg = devm_regulator_get(>dev, "avdd");
> - if (IS_ERR(st->reg))
> - return PTR_ERR(st->reg);
> -
> - ret = regulator_enable(st->reg);
> - if (ret) {
> - dev_err(>dev, "Failed to enable specified AVdd supply\n");
> - return ret;
> - }
> -
>   st->chip_info =
>   _chip_info_tbl[spi_get_device_id(spi)->driver_data];
>  
> @@ -321,6 +311,16 @@ static int ad7780_probe(struct spi_device *spi)
>   if (ret)
>   goto error_cleanup_buffer_and_trigger;
>  
> + st->reg = devm_regulator_get(>dev, "avdd");
> + if (IS_ERR(st->reg))
> + return PTR_ERR(st->reg);
> +
> + ret = regulator_enable(st->reg);
> + if (ret) {
> + dev_err(>dev, "Failed to enable specified AVdd supply\n");
> + return ret;
> + }
> +
>   ret = ad_sd_setup_buffer_and_trigger(indio_dev);
>   if (ret)
>   goto error_disable_reg;

[PATCH v5 07/11] staging: iio: ad7780: move regulator to after GPIO init

[Renato Lui Geh]

To maintain consistency between ad7780_probe and ad7780_remove orders,
regulator initialization has been moved to after GPIO initializations.

Signed-off-by: Renato Lui Geh 
---
drivers/staging/iio/adc/ad7780.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/iio/adc/ad7780.c b/drivers/staging/iio/adc/ad7780.c
index 977b381c1260..568c5b4472ff 100644
--- a/drivers/staging/iio/adc/ad7780.c
+++ b/drivers/staging/iio/adc/ad7780.c
@@ -295,16 +295,6 @@ static int ad7780_probe(struct spi_device *spi)

ad_sd_init(>sd, indio_dev, spi, _sigma_delta_info);

-   st->reg = devm_regulator_get(>dev, "avdd");
-   if (IS_ERR(st->reg))
-   return PTR_ERR(st->reg);
-
-   ret = regulator_enable(st->reg);
-   if (ret) {
-   dev_err(>dev, "Failed to enable specified AVdd supply\n");
-   return ret;
-   }
-
st->chip_info =
_chip_info_tbl[spi_get_device_id(spi)->driver_data];

@@ -321,6 +311,16 @@ static int ad7780_probe(struct spi_device *spi)
if (ret)
goto error_cleanup_buffer_and_trigger;

+   st->reg = devm_regulator_get(>dev, "avdd");
+   if (IS_ERR(st->reg))
+   return PTR_ERR(st->reg);
+
+   ret = regulator_enable(st->reg);
+   if (ret) {
+   dev_err(>dev, "Failed to enable specified AVdd supply\n");
+   return ret;
+   }
+
ret = ad_sd_setup_buffer_and_trigger(indio_dev);
if (ret)
goto error_disable_reg;
--
2.21.0