Re: [PATCH v5 2/3] livepatch: move transition "complete" notice into klp_complete_transition()

[Petr Mladek]

On Thu 2017-08-31 10:53:52, Joe Lawrence wrote:
> klp_complete_transition() performs a bit of housework before a
> transition to KLP_PATCHED or KLP_UNPATCHED is actually completed
> (including post-(un)patch callbacks).  To be consistent, move the
> transition "complete" kernel log notice out of
> klp_try_complete_transition() and into klp_complete_transition().
> 
> Suggested-by: Josh Poimboeuf 
> Signed-off-by: Joe Lawrence 

Looks fine.

Reviewed-by: Petr Mladek 

Best Regards,
Petr

Re: [PATCH v5 2/3] livepatch: move transition "complete" notice into klp_complete_transition()

[Petr Mladek]

On Thu 2017-08-31 10:53:52, Joe Lawrence wrote:
> klp_complete_transition() performs a bit of housework before a
> transition to KLP_PATCHED or KLP_UNPATCHED is actually completed
> (including post-(un)patch callbacks).  To be consistent, move the
> transition "complete" kernel log notice out of
> klp_try_complete_transition() and into klp_complete_transition().
> 
> Suggested-by: Josh Poimboeuf 
> Signed-off-by: Joe Lawrence 

Looks fine.

Reviewed-by: Petr Mladek 

Best Regards,
Petr

Re: [PATCH v5 2/3] livepatch: move transition "complete" notice into klp_complete_transition()

[Miroslav Benes]

On Thu, 31 Aug 2017, Joe Lawrence wrote:

> klp_complete_transition() performs a bit of housework before a
> transition to KLP_PATCHED or KLP_UNPATCHED is actually completed
> (including post-(un)patch callbacks).  To be consistent, move the
> transition "complete" kernel log notice out of
> klp_try_complete_transition() and into klp_complete_transition().
> 
> Suggested-by: Josh Poimboeuf 
> Signed-off-by: Joe Lawrence 

Acked-by: Miroslav Benes 

Miroslav

Re: [PATCH v5 2/3] livepatch: move transition "complete" notice into klp_complete_transition()

[Miroslav Benes]

On Thu, 31 Aug 2017, Joe Lawrence wrote:

> klp_complete_transition() performs a bit of housework before a
> transition to KLP_PATCHED or KLP_UNPATCHED is actually completed
> (including post-(un)patch callbacks).  To be consistent, move the
> transition "complete" kernel log notice out of
> klp_try_complete_transition() and into klp_complete_transition().
> 
> Suggested-by: Josh Poimboeuf 
> Signed-off-by: Joe Lawrence 

Acked-by: Miroslav Benes 

Miroslav

[PATCH v5 2/3] livepatch: move transition "complete" notice into klp_complete_transition()

[Joe Lawrence]

klp_complete_transition() performs a bit of housework before a
transition to KLP_PATCHED or KLP_UNPATCHED is actually completed
(including post-(un)patch callbacks).  To be consistent, move the
transition "complete" kernel log notice out of
klp_try_complete_transition() and into klp_complete_transition().

Suggested-by: Josh Poimboeuf 
Signed-off-by: Joe Lawrence 
---
 kernel/livepatch/transition.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel/livepatch/transition.c b/kernel/livepatch/transition.c
index 7bf55b7f3687..53887f0bca10 100644
--- a/kernel/livepatch/transition.c
+++ b/kernel/livepatch/transition.c
@@ -136,6 +136,9 @@ static void klp_complete_transition(void)
klp_post_unpatch_callback(obj);
}
 
+   pr_notice("'%s': %s complete\n", klp_transition_patch->mod->name,
+ klp_target_state == KLP_PATCHED ? "patching" : "unpatching");
+
/*
 * See complementary comment in __klp_enable_patch() for why we
 * keep the module reference for immediate patches.
@@ -423,9 +426,6 @@ void klp_try_complete_transition(void)
}
 
 success:
-   pr_notice("'%s': %s complete\n", klp_transition_patch->mod->name,
- klp_target_state == KLP_PATCHED ? "patching" : "unpatching");
-
/* we're done, now cleanup the data structures */
klp_complete_transition();
 }
-- 
1.8.3.1

[PATCH v5 2/3] livepatch: move transition "complete" notice into klp_complete_transition()

[Joe Lawrence]

klp_complete_transition() performs a bit of housework before a
transition to KLP_PATCHED or KLP_UNPATCHED is actually completed
(including post-(un)patch callbacks).  To be consistent, move the
transition "complete" kernel log notice out of
klp_try_complete_transition() and into klp_complete_transition().

Suggested-by: Josh Poimboeuf 
Signed-off-by: Joe Lawrence 
---
 kernel/livepatch/transition.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel/livepatch/transition.c b/kernel/livepatch/transition.c
index 7bf55b7f3687..53887f0bca10 100644
--- a/kernel/livepatch/transition.c
+++ b/kernel/livepatch/transition.c
@@ -136,6 +136,9 @@ static void klp_complete_transition(void)
klp_post_unpatch_callback(obj);
}
 
+   pr_notice("'%s': %s complete\n", klp_transition_patch->mod->name,
+ klp_target_state == KLP_PATCHED ? "patching" : "unpatching");
+
/*
 * See complementary comment in __klp_enable_patch() for why we
 * keep the module reference for immediate patches.
@@ -423,9 +426,6 @@ void klp_try_complete_transition(void)
}
 
 success:
-   pr_notice("'%s': %s complete\n", klp_transition_patch->mod->name,
- klp_target_state == KLP_PATCHED ? "patching" : "unpatching");
-
/* we're done, now cleanup the data structures */
klp_complete_transition();
 }
-- 
1.8.3.1