[PATCH v5 2/6] perf config: Add '--system' and '--user' options to select which config file is used
Which config file is used is decided in only perf_config().
And a perf-confg command depend on perf_config()
getting config file path. So add '--system' and '--user' options
to select which config file to be used without perf_config().
If file-options isn't used, default config file path is
$HOME/.perfconfig.
Signed-off-by: Taeung Song
---
tools/perf/Documentation/perf-config.txt | 14 +-
tools/perf/builtin-config.c | 23 +--
tools/perf/util/cache.h | 2 ++
tools/perf/util/config.c | 4 ++--
4 files changed, 38 insertions(+), 5 deletions(-)
diff --git a/tools/perf/Documentation/perf-config.txt
b/tools/perf/Documentation/perf-config.txt
index a3a12cc..b2abb16 100644
--- a/tools/perf/Documentation/perf-config.txt
+++ b/tools/perf/Documentation/perf-config.txt
@@ -8,7 +8,7 @@ perf-config - Get and set variables in a configuration file.
SYNOPSIS
[verse]
-'perf config' -l | --list
+'perf config' [] -l | --list
DESCRIPTION
---
@@ -21,6 +21,14 @@ OPTIONS
--list::
Show current config variables with key and value into each sections.
+--user::
+ For writing and reading options: write to user
+ '$HOME/.perfconfig' file or read it.
+
+--system::
+ For writing and reading options: write to system-wide
+ '$(sysconfdir)/perfconfig' or read it.
+
CONFIGURATION FILE
--
@@ -33,6 +41,10 @@ store a system-wide default configuration.
The variables are divided into sections. In each section, the variables
can are composed of a key and value.
+When reading or writing, the values are read from the system and user
+configuration files by default, and options '--system' and '--user'
+can be used to tell the command to read from or write to only that location.
+
Syntax
~~
diff --git a/tools/perf/builtin-config.c b/tools/perf/builtin-config.c
index 02c2ba2..df70b90 100644
--- a/tools/perf/builtin-config.c
+++ b/tools/perf/builtin-config.c
@@ -13,6 +13,9 @@
#include "util/util.h"
#include "util/debug.h"
+static bool use_system_config, use_user_config;
+static const char *config_file_name;
+
static const char * const config_usage[] = {
"perf config [options]",
NULL
@@ -23,6 +26,9 @@ enum actions {
} actions;
static const struct option config_options[] = {
+ OPT_GROUP("Config file location"),
+ OPT_BOOLEAN(0, "system", _system_config, "use system config file"),
+ OPT_BOOLEAN(0, "user", _user_config, "use user config file"),
OPT_GROUP("Action"),
OPT_SET_UINT('l', "list", ,
"show current config variables", ACTION_LIST),
@@ -47,15 +53,28 @@ int cmd_config(int argc, const char **argv, const char
*prefix __maybe_unused)
argc = parse_options(argc, argv, config_options, config_usage,
PARSE_OPT_STOP_AT_NON_OPTION);
+ if (use_system_config && use_user_config) {
+ pr_err("Error: only one config file at a time\n");
+ goto out_err;
+ }
+ config_file_name = mkpath("%s/.perfconfig", getenv("HOME"));
+ if (use_system_config || (!use_user_config &&
+ access(config_file_name, R_OK) == -1))
+ config_file_name = perf_etc_perfconfig();
+
switch (actions) {
case ACTION_LIST:
default:
if (argc) {
pr_err("Error: unknown argument\n");
- usage_with_options(config_usage, config_options);
+ goto out_err;
} else
- ret = perf_config(show_config, NULL);
+ ret = perf_config_from_file(show_config,
config_file_name, NULL);
}
return ret;
+
+out_err:
+ usage_with_options(config_usage, config_options);
+ return -1;
}
diff --git a/tools/perf/util/cache.h b/tools/perf/util/cache.h
index c861373..bad3e4e 100644
--- a/tools/perf/util/cache.h
+++ b/tools/perf/util/cache.h
@@ -22,11 +22,13 @@
typedef int (*config_fn_t)(const char *, const char *, void *);
extern int perf_default_config(const char *, const char *, void *);
extern int perf_config(config_fn_t fn, void *);
+extern int perf_config_from_file(config_fn_t fn, const char *filename, void
*data);
extern int perf_config_int(const char *, const char *);
extern u64 perf_config_u64(const char *, const char *);
extern int perf_config_bool(const char *, const char *);
extern int config_error_nonbool(const char *);
extern const char *perf_config_dirname(const char *, const char *);
+extern const char *perf_etc_perfconfig(void);
/* pager.c */
extern void setup_pager(void);
diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c
index 2e452ac..23fa8c5 100644
--- a/tools/perf/util/config.c
+++ b/tools/perf/util/config.c
@@ -416,7 +416,7 @@ int perf_default_config(const char *var, const char *value,
return 0;
}
[PATCH v5 2/6] perf config: Add '--system' and '--user' options to select which config file is used
Which config file is used is decided in only perf_config().
And a perf-confg command depend on perf_config()
getting config file path. So add '--system' and '--user' options
to select which config file to be used without perf_config().
If file-options isn't used, default config file path is
$HOME/.perfconfig.
Signed-off-by: Taeung Song treeze.tae...@gmail.com
---
tools/perf/Documentation/perf-config.txt | 14 +-
tools/perf/builtin-config.c | 23 +--
tools/perf/util/cache.h | 2 ++
tools/perf/util/config.c | 4 ++--
4 files changed, 38 insertions(+), 5 deletions(-)
diff --git a/tools/perf/Documentation/perf-config.txt
b/tools/perf/Documentation/perf-config.txt
index a3a12cc..b2abb16 100644
--- a/tools/perf/Documentation/perf-config.txt
+++ b/tools/perf/Documentation/perf-config.txt
@@ -8,7 +8,7 @@ perf-config - Get and set variables in a configuration file.
SYNOPSIS
[verse]
-'perf config' -l | --list
+'perf config' [file-option] -l | --list
DESCRIPTION
---
@@ -21,6 +21,14 @@ OPTIONS
--list::
Show current config variables with key and value into each sections.
+--user::
+ For writing and reading options: write to user
+ '$HOME/.perfconfig' file or read it.
+
+--system::
+ For writing and reading options: write to system-wide
+ '$(sysconfdir)/perfconfig' or read it.
+
CONFIGURATION FILE
--
@@ -33,6 +41,10 @@ store a system-wide default configuration.
The variables are divided into sections. In each section, the variables
can are composed of a key and value.
+When reading or writing, the values are read from the system and user
+configuration files by default, and options '--system' and '--user'
+can be used to tell the command to read from or write to only that location.
+
Syntax
~~
diff --git a/tools/perf/builtin-config.c b/tools/perf/builtin-config.c
index 02c2ba2..df70b90 100644
--- a/tools/perf/builtin-config.c
+++ b/tools/perf/builtin-config.c
@@ -13,6 +13,9 @@
#include util/util.h
#include util/debug.h
+static bool use_system_config, use_user_config;
+static const char *config_file_name;
+
static const char * const config_usage[] = {
perf config [options],
NULL
@@ -23,6 +26,9 @@ enum actions {
} actions;
static const struct option config_options[] = {
+ OPT_GROUP(Config file location),
+ OPT_BOOLEAN(0, system, use_system_config, use system config file),
+ OPT_BOOLEAN(0, user, use_user_config, use user config file),
OPT_GROUP(Action),
OPT_SET_UINT('l', list, actions,
show current config variables, ACTION_LIST),
@@ -47,15 +53,28 @@ int cmd_config(int argc, const char **argv, const char
*prefix __maybe_unused)
argc = parse_options(argc, argv, config_options, config_usage,
PARSE_OPT_STOP_AT_NON_OPTION);
+ if (use_system_config use_user_config) {
+ pr_err(Error: only one config file at a time\n);
+ goto out_err;
+ }
+ config_file_name = mkpath(%s/.perfconfig, getenv(HOME));
+ if (use_system_config || (!use_user_config
+ access(config_file_name, R_OK) == -1))
+ config_file_name = perf_etc_perfconfig();
+
switch (actions) {
case ACTION_LIST:
default:
if (argc) {
pr_err(Error: unknown argument\n);
- usage_with_options(config_usage, config_options);
+ goto out_err;
} else
- ret = perf_config(show_config, NULL);
+ ret = perf_config_from_file(show_config,
config_file_name, NULL);
}
return ret;
+
+out_err:
+ usage_with_options(config_usage, config_options);
+ return -1;
}
diff --git a/tools/perf/util/cache.h b/tools/perf/util/cache.h
index c861373..bad3e4e 100644
--- a/tools/perf/util/cache.h
+++ b/tools/perf/util/cache.h
@@ -22,11 +22,13 @@
typedef int (*config_fn_t)(const char *, const char *, void *);
extern int perf_default_config(const char *, const char *, void *);
extern int perf_config(config_fn_t fn, void *);
+extern int perf_config_from_file(config_fn_t fn, const char *filename, void
*data);
extern int perf_config_int(const char *, const char *);
extern u64 perf_config_u64(const char *, const char *);
extern int perf_config_bool(const char *, const char *);
extern int config_error_nonbool(const char *);
extern const char *perf_config_dirname(const char *, const char *);
+extern const char *perf_etc_perfconfig(void);
/* pager.c */
extern void setup_pager(void);
diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c
index 2e452ac..23fa8c5 100644
--- a/tools/perf/util/config.c
+++ b/tools/perf/util/config.c
@@ -416,7 +416,7 @@ int perf_default_config(const char *var, const char *value,
return
