Re: [PATCH v6 00/10] rockchip: kevin: Enable edp display

2017-11-10 Thread Enric Balletbo Serra 
Dear all,

2017-11-01 20:33 GMT+01:00 Sean Paul :
> On Tue, Oct 31, 2017 at 12:37:43PM +0800, JeffyChen wrote:
>> Hi Heiko,
>>
>> On 10/31/2017 07:01 AM, Heiko Stuebner wrote:
>> > As I was just looking at the edp dts change in patch1 again, does this
>> > series also contain a fix for the issue below [0] ?
>> >
>> > I'm still seeing this on 4.14-rc6 with the most recent drm tree merged in.
>> >
>> i saw that too, it should due to our psr code...i think Zain has solved
>> these in chromeos kernel, i will ask Zain if he have time to upstream them,
>> or maybe i'll try to upstream them.
>
> You need the patchset where I've refactored the psr locking/workers. I have a
> version of it based on Heiko's tree at
> https://cgit.freedesktop.org/~seanpaul/dogwood/log/?h=rk3399-display
>
> With this kernel, the backlight comes on, but I don't have anything on the
> display (which is why I didn't post it). I'll try putting this set on top and
> see what happens.
>

There is a patch in the ML sent by Emil [1], similar to the Sean
patch, that solves the issue.

And I can confirm that the Jeffy's patches + Emil patch makes the
display work on kevin or current rc8

[1] https://patchwork.kernel.org/patch/9985237/

Enric

> Sean
>
>> >
>> > Heiko
>> >
>> > [0]
>> >
>> > [   27.960120] BUG: scheduling while atomic: kworker/1:1/68/0x0002
>> > [   27.974429] Modules linked in: rockchipdrm dw_hdmi analogix_dp 
>> > drm_kms_helper panel_simple crc32_ce drm crct10dif_ce rockchip_saradc 
>> > pwm_bl pwm_cros_ec rockchip_thermal ip_tables x_tabl
>> > es ipv6 smsc95xx smsc75xx ax88179_178a asix usbnet phy_rockchip_pcie 
>> > pcie_rockchip
>> > [   28.008769] CPU: 1 PID: 68 Comm: kworker/1:1 Tainted: GW   
>> > 4.14.0-rc7-03201-g12490811b353 #559
>> > [   28.008774] Hardware name: Google Kevin (DT)
>> > [   28.008825] Workqueue: events analogix_dp_psr_work [rockchipdrm]
>> > [   28.008828] Call trace:
>> > [   28.008838] [] dump_backtrace+0x0/0x378
>> > [   28.008842] [] show_stack+0x14/0x20
>> > [   28.008847] [] dump_stack+0x9c/0xbc
>> > [   28.008852] [] __schedule_bug+0x4c/0x70
>> > [   28.008856] [] __schedule+0x558/0x5e8
>> > [   28.008859] [] schedule+0x38/0xa0
>> > [   28.008864] [] 
>> > schedule_hrtimeout_range_clock+0x84/0xe8
>> > [   28.008867] [] schedule_hrtimeout_range+0x10/0x18
>> > [   28.008870] [] usleep_range+0x64/0x78
>> > [   28.008882] [] analogix_dp_transfer+0x16c/0xa88 
>> > [analogix_dp]
>> > [   28.008891] [] analogix_dpaux_transfer+0x10/0x18 
>> > [analogix_dp]
>> > [   28.008950] [] drm_dp_dpcd_access+0x4c/0xf8 
>> > [drm_kms_helper]
>> > [   28.008994] [] drm_dp_dpcd_write+0x1c/0x28 
>> > [drm_kms_helper]
>> > [   28.009002] [] analogix_dp_disable_psr+0x60/0xb0 
>> > [analogix_dp]
>> > [   28.009036] [] analogix_dp_psr_work+0x4c/0xc0 
>> > [rockchipdrm]
>> > [   28.009040] [] process_one_work+0x1d4/0x348
>> > [   28.009043] [] worker_thread+0x48/0x470
>> > [   28.009048] [] kthread+0x12c/0x130
>> > [   28.009052] [] ret_from_fork+0x10/0x18
>> >
>> >
>> >
>> >
>>
>>
>
> --
> Sean Paul, Software Engineer, Google / Chromium OS
> ___
> dri-devel mailing list
> dri-de...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v6 00/10] rockchip: kevin: Enable edp display

2017-11-10 Thread Enric Balletbo Serra 
Dear all,

2017-11-01 20:33 GMT+01:00 Sean Paul :
> On Tue, Oct 31, 2017 at 12:37:43PM +0800, JeffyChen wrote:
>> Hi Heiko,
>>
>> On 10/31/2017 07:01 AM, Heiko Stuebner wrote:
>> > As I was just looking at the edp dts change in patch1 again, does this
>> > series also contain a fix for the issue below [0] ?
>> >
>> > I'm still seeing this on 4.14-rc6 with the most recent drm tree merged in.
>> >
>> i saw that too, it should due to our psr code...i think Zain has solved
>> these in chromeos kernel, i will ask Zain if he have time to upstream them,
>> or maybe i'll try to upstream them.
>
> You need the patchset where I've refactored the psr locking/workers. I have a
> version of it based on Heiko's tree at
> https://cgit.freedesktop.org/~seanpaul/dogwood/log/?h=rk3399-display
>
> With this kernel, the backlight comes on, but I don't have anything on the
> display (which is why I didn't post it). I'll try putting this set on top and
> see what happens.
>

There is a patch in the ML sent by Emil [1], similar to the Sean
patch, that solves the issue.

And I can confirm that the Jeffy's patches + Emil patch makes the
display work on kevin or current rc8

[1] https://patchwork.kernel.org/patch/9985237/

Enric

> Sean
>
>> >
>> > Heiko
>> >
>> > [0]
>> >
>> > [   27.960120] BUG: scheduling while atomic: kworker/1:1/68/0x0002
>> > [   27.974429] Modules linked in: rockchipdrm dw_hdmi analogix_dp 
>> > drm_kms_helper panel_simple crc32_ce drm crct10dif_ce rockchip_saradc 
>> > pwm_bl pwm_cros_ec rockchip_thermal ip_tables x_tabl
>> > es ipv6 smsc95xx smsc75xx ax88179_178a asix usbnet phy_rockchip_pcie 
>> > pcie_rockchip
>> > [   28.008769] CPU: 1 PID: 68 Comm: kworker/1:1 Tainted: GW   
>> > 4.14.0-rc7-03201-g12490811b353 #559
>> > [   28.008774] Hardware name: Google Kevin (DT)
>> > [   28.008825] Workqueue: events analogix_dp_psr_work [rockchipdrm]
>> > [   28.008828] Call trace:
>> > [   28.008838] [] dump_backtrace+0x0/0x378
>> > [   28.008842] [] show_stack+0x14/0x20
>> > [   28.008847] [] dump_stack+0x9c/0xbc
>> > [   28.008852] [] __schedule_bug+0x4c/0x70
>> > [   28.008856] [] __schedule+0x558/0x5e8
>> > [   28.008859] [] schedule+0x38/0xa0
>> > [   28.008864] [] 
>> > schedule_hrtimeout_range_clock+0x84/0xe8
>> > [   28.008867] [] schedule_hrtimeout_range+0x10/0x18
>> > [   28.008870] [] usleep_range+0x64/0x78
>> > [   28.008882] [] analogix_dp_transfer+0x16c/0xa88 
>> > [analogix_dp]
>> > [   28.008891] [] analogix_dpaux_transfer+0x10/0x18 
>> > [analogix_dp]
>> > [   28.008950] [] drm_dp_dpcd_access+0x4c/0xf8 
>> > [drm_kms_helper]
>> > [   28.008994] [] drm_dp_dpcd_write+0x1c/0x28 
>> > [drm_kms_helper]
>> > [   28.009002] [] analogix_dp_disable_psr+0x60/0xb0 
>> > [analogix_dp]
>> > [   28.009036] [] analogix_dp_psr_work+0x4c/0xc0 
>> > [rockchipdrm]
>> > [   28.009040] [] process_one_work+0x1d4/0x348
>> > [   28.009043] [] worker_thread+0x48/0x470
>> > [   28.009048] [] kthread+0x12c/0x130
>> > [   28.009052] [] ret_from_fork+0x10/0x18
>> >
>> >
>> >
>> >
>>
>>
>
> --
> Sean Paul, Software Engineer, Google / Chromium OS
> ___
> dri-devel mailing list
> dri-de...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v6 00/10] rockchip: kevin: Enable edp display

2017-11-01 Thread Sean Paul 
On Tue, Oct 31, 2017 at 12:37:43PM +0800, JeffyChen wrote:
> Hi Heiko,
> 
> On 10/31/2017 07:01 AM, Heiko Stuebner wrote:
> > As I was just looking at the edp dts change in patch1 again, does this
> > series also contain a fix for the issue below [0] ?
> > 
> > I'm still seeing this on 4.14-rc6 with the most recent drm tree merged in.
> > 
> i saw that too, it should due to our psr code...i think Zain has solved
> these in chromeos kernel, i will ask Zain if he have time to upstream them,
> or maybe i'll try to upstream them.

You need the patchset where I've refactored the psr locking/workers. I have a
version of it based on Heiko's tree at
https://cgit.freedesktop.org/~seanpaul/dogwood/log/?h=rk3399-display

With this kernel, the backlight comes on, but I don't have anything on the
display (which is why I didn't post it). I'll try putting this set on top and
see what happens.

Sean

> > 
> > Heiko
> > 
> > [0]
> > 
> > [   27.960120] BUG: scheduling while atomic: kworker/1:1/68/0x0002
> > [   27.974429] Modules linked in: rockchipdrm dw_hdmi analogix_dp 
> > drm_kms_helper panel_simple crc32_ce drm crct10dif_ce rockchip_saradc 
> > pwm_bl pwm_cros_ec rockchip_thermal ip_tables x_tabl
> > es ipv6 smsc95xx smsc75xx ax88179_178a asix usbnet phy_rockchip_pcie 
> > pcie_rockchip
> > [   28.008769] CPU: 1 PID: 68 Comm: kworker/1:1 Tainted: GW   
> > 4.14.0-rc7-03201-g12490811b353 #559
> > [   28.008774] Hardware name: Google Kevin (DT)
> > [   28.008825] Workqueue: events analogix_dp_psr_work [rockchipdrm]
> > [   28.008828] Call trace:
> > [   28.008838] [] dump_backtrace+0x0/0x378
> > [   28.008842] [] show_stack+0x14/0x20
> > [   28.008847] [] dump_stack+0x9c/0xbc
> > [   28.008852] [] __schedule_bug+0x4c/0x70
> > [   28.008856] [] __schedule+0x558/0x5e8
> > [   28.008859] [] schedule+0x38/0xa0
> > [   28.008864] [] schedule_hrtimeout_range_clock+0x84/0xe8
> > [   28.008867] [] schedule_hrtimeout_range+0x10/0x18
> > [   28.008870] [] usleep_range+0x64/0x78
> > [   28.008882] [] analogix_dp_transfer+0x16c/0xa88 
> > [analogix_dp]
> > [   28.008891] [] analogix_dpaux_transfer+0x10/0x18 
> > [analogix_dp]
> > [   28.008950] [] drm_dp_dpcd_access+0x4c/0xf8 
> > [drm_kms_helper]
> > [   28.008994] [] drm_dp_dpcd_write+0x1c/0x28 
> > [drm_kms_helper]
> > [   28.009002] [] analogix_dp_disable_psr+0x60/0xb0 
> > [analogix_dp]
> > [   28.009036] [] analogix_dp_psr_work+0x4c/0xc0 
> > [rockchipdrm]
> > [   28.009040] [] process_one_work+0x1d4/0x348
> > [   28.009043] [] worker_thread+0x48/0x470
> > [   28.009048] [] kthread+0x12c/0x130
> > [   28.009052] [] ret_from_fork+0x10/0x18
> > 
> > 
> > 
> > 
> 
> 

-- 
Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH v6 00/10] rockchip: kevin: Enable edp display

2017-11-01 Thread Sean Paul 
On Tue, Oct 31, 2017 at 12:37:43PM +0800, JeffyChen wrote:
> Hi Heiko,
> 
> On 10/31/2017 07:01 AM, Heiko Stuebner wrote:
> > As I was just looking at the edp dts change in patch1 again, does this
> > series also contain a fix for the issue below [0] ?
> > 
> > I'm still seeing this on 4.14-rc6 with the most recent drm tree merged in.
> > 
> i saw that too, it should due to our psr code...i think Zain has solved
> these in chromeos kernel, i will ask Zain if he have time to upstream them,
> or maybe i'll try to upstream them.

You need the patchset where I've refactored the psr locking/workers. I have a
version of it based on Heiko's tree at
https://cgit.freedesktop.org/~seanpaul/dogwood/log/?h=rk3399-display

With this kernel, the backlight comes on, but I don't have anything on the
display (which is why I didn't post it). I'll try putting this set on top and
see what happens.

Sean

> > 
> > Heiko
> > 
> > [0]
> > 
> > [   27.960120] BUG: scheduling while atomic: kworker/1:1/68/0x0002
> > [   27.974429] Modules linked in: rockchipdrm dw_hdmi analogix_dp 
> > drm_kms_helper panel_simple crc32_ce drm crct10dif_ce rockchip_saradc 
> > pwm_bl pwm_cros_ec rockchip_thermal ip_tables x_tabl
> > es ipv6 smsc95xx smsc75xx ax88179_178a asix usbnet phy_rockchip_pcie 
> > pcie_rockchip
> > [   28.008769] CPU: 1 PID: 68 Comm: kworker/1:1 Tainted: GW   
> > 4.14.0-rc7-03201-g12490811b353 #559
> > [   28.008774] Hardware name: Google Kevin (DT)
> > [   28.008825] Workqueue: events analogix_dp_psr_work [rockchipdrm]
> > [   28.008828] Call trace:
> > [   28.008838] [] dump_backtrace+0x0/0x378
> > [   28.008842] [] show_stack+0x14/0x20
> > [   28.008847] [] dump_stack+0x9c/0xbc
> > [   28.008852] [] __schedule_bug+0x4c/0x70
> > [   28.008856] [] __schedule+0x558/0x5e8
> > [   28.008859] [] schedule+0x38/0xa0
> > [   28.008864] [] schedule_hrtimeout_range_clock+0x84/0xe8
> > [   28.008867] [] schedule_hrtimeout_range+0x10/0x18
> > [   28.008870] [] usleep_range+0x64/0x78
> > [   28.008882] [] analogix_dp_transfer+0x16c/0xa88 
> > [analogix_dp]
> > [   28.008891] [] analogix_dpaux_transfer+0x10/0x18 
> > [analogix_dp]
> > [   28.008950] [] drm_dp_dpcd_access+0x4c/0xf8 
> > [drm_kms_helper]
> > [   28.008994] [] drm_dp_dpcd_write+0x1c/0x28 
> > [drm_kms_helper]
> > [   28.009002] [] analogix_dp_disable_psr+0x60/0xb0 
> > [analogix_dp]
> > [   28.009036] [] analogix_dp_psr_work+0x4c/0xc0 
> > [rockchipdrm]
> > [   28.009040] [] process_one_work+0x1d4/0x348
> > [   28.009043] [] worker_thread+0x48/0x470
> > [   28.009048] [] kthread+0x12c/0x130
> > [   28.009052] [] ret_from_fork+0x10/0x18
> > 
> > 
> > 
> > 
> 
> 

-- 
Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH v6 00/10] rockchip: kevin: Enable edp display

2017-10-30 Thread JeffyChen 

Hi Heiko,

On 10/31/2017 07:01 AM, Heiko Stuebner wrote:

As I was just looking at the edp dts change in patch1 again, does this
series also contain a fix for the issue below [0] ?

I'm still seeing this on 4.14-rc6 with the most recent drm tree merged in.

i saw that too, it should due to our psr code...i think Zain has solved 
these in chromeos kernel, i will ask Zain if he have time to upstream 
them, or maybe i'll try to upstream them.


Heiko

[0]

[   27.960120] BUG: scheduling while atomic: kworker/1:1/68/0x0002
[   27.974429] Modules linked in: rockchipdrm dw_hdmi analogix_dp 
drm_kms_helper panel_simple crc32_ce drm crct10dif_ce rockchip_saradc pwm_bl 
pwm_cros_ec rockchip_thermal ip_tables x_tabl
es ipv6 smsc95xx smsc75xx ax88179_178a asix usbnet phy_rockchip_pcie 
pcie_rockchip
[   28.008769] CPU: 1 PID: 68 Comm: kworker/1:1 Tainted: GW   
4.14.0-rc7-03201-g12490811b353 #559
[   28.008774] Hardware name: Google Kevin (DT)
[   28.008825] Workqueue: events analogix_dp_psr_work [rockchipdrm]
[   28.008828] Call trace:
[   28.008838] [] dump_backtrace+0x0/0x378
[   28.008842] [] show_stack+0x14/0x20
[   28.008847] [] dump_stack+0x9c/0xbc
[   28.008852] [] __schedule_bug+0x4c/0x70
[   28.008856] [] __schedule+0x558/0x5e8
[   28.008859] [] schedule+0x38/0xa0
[   28.008864] [] schedule_hrtimeout_range_clock+0x84/0xe8
[   28.008867] [] schedule_hrtimeout_range+0x10/0x18
[   28.008870] [] usleep_range+0x64/0x78
[   28.008882] [] analogix_dp_transfer+0x16c/0xa88 
[analogix_dp]
[   28.008891] [] analogix_dpaux_transfer+0x10/0x18 
[analogix_dp]
[   28.008950] [] drm_dp_dpcd_access+0x4c/0xf8 
[drm_kms_helper]
[   28.008994] [] drm_dp_dpcd_write+0x1c/0x28 [drm_kms_helper]
[   28.009002] [] analogix_dp_disable_psr+0x60/0xb0 
[analogix_dp]
[   28.009036] [] analogix_dp_psr_work+0x4c/0xc0 [rockchipdrm]
[   28.009040] [] process_one_work+0x1d4/0x348
[   28.009043] [] worker_thread+0x48/0x470
[   28.009048] [] kthread+0x12c/0x130
[   28.009052] [] ret_from_fork+0x10/0x18

Re: [PATCH v6 00/10] rockchip: kevin: Enable edp display

2017-10-30 Thread JeffyChen 

Hi Heiko,

On 10/31/2017 07:01 AM, Heiko Stuebner wrote:

As I was just looking at the edp dts change in patch1 again, does this
series also contain a fix for the issue below [0] ?

I'm still seeing this on 4.14-rc6 with the most recent drm tree merged in.

i saw that too, it should due to our psr code...i think Zain has solved 
these in chromeos kernel, i will ask Zain if he have time to upstream 
them, or maybe i'll try to upstream them.


Heiko

[0]

[   27.960120] BUG: scheduling while atomic: kworker/1:1/68/0x0002
[   27.974429] Modules linked in: rockchipdrm dw_hdmi analogix_dp 
drm_kms_helper panel_simple crc32_ce drm crct10dif_ce rockchip_saradc pwm_bl 
pwm_cros_ec rockchip_thermal ip_tables x_tabl
es ipv6 smsc95xx smsc75xx ax88179_178a asix usbnet phy_rockchip_pcie 
pcie_rockchip
[   28.008769] CPU: 1 PID: 68 Comm: kworker/1:1 Tainted: GW   
4.14.0-rc7-03201-g12490811b353 #559
[   28.008774] Hardware name: Google Kevin (DT)
[   28.008825] Workqueue: events analogix_dp_psr_work [rockchipdrm]
[   28.008828] Call trace:
[   28.008838] [] dump_backtrace+0x0/0x378
[   28.008842] [] show_stack+0x14/0x20
[   28.008847] [] dump_stack+0x9c/0xbc
[   28.008852] [] __schedule_bug+0x4c/0x70
[   28.008856] [] __schedule+0x558/0x5e8
[   28.008859] [] schedule+0x38/0xa0
[   28.008864] [] schedule_hrtimeout_range_clock+0x84/0xe8
[   28.008867] [] schedule_hrtimeout_range+0x10/0x18
[   28.008870] [] usleep_range+0x64/0x78
[   28.008882] [] analogix_dp_transfer+0x16c/0xa88 
[analogix_dp]
[   28.008891] [] analogix_dpaux_transfer+0x10/0x18 
[analogix_dp]
[   28.008950] [] drm_dp_dpcd_access+0x4c/0xf8 
[drm_kms_helper]
[   28.008994] [] drm_dp_dpcd_write+0x1c/0x28 [drm_kms_helper]
[   28.009002] [] analogix_dp_disable_psr+0x60/0xb0 
[analogix_dp]
[   28.009036] [] analogix_dp_psr_work+0x4c/0xc0 [rockchipdrm]
[   28.009040] [] process_one_work+0x1d4/0x348
[   28.009043] [] worker_thread+0x48/0x470
[   28.009048] [] kthread+0x12c/0x130
[   28.009052] [] ret_from_fork+0x10/0x18

Re: [PATCH v6 00/10] rockchip: kevin: Enable edp display

2017-10-30 Thread Heiko Stuebner 
Hi Jeffy, Sean,

Am Donnerstag, 19. Oktober 2017, 11:48:02 CET schrieb Jeffy Chen:
> 
> Make edp display works on chromebook kevin(at least for boot animation).
> 
> Also solve some issues i meet during the bringup.
> 
> Changes in v6:
> Don't change order of rockchip_drm_psr_register().
> 
> Changes in v5:
> Call the destroy hook in the error handling path like in unbind().
> Call the destroy hook in the error handling path like in unbind().
> Update cleanup order in unbind().
> Add disable to unbind(), and inline clk_prepare_enable() with bind().
> 
> Jeffy Chen (10):
>   arm64: dts: rockchip: Enable edp disaplay on kevin
>   drm/rockchip: analogix_dp: Remove unnecessary init code
>   drm/bridge: analogix: Do not use device's drvdata
>   drm/bridge: analogix_dp: Fix connector and encoder cleanup
>   drm/rockchip: analogix_dp: Add a sanity check for
> rockchip_drm_psr_register()
>   drm/rockchip: dw-mipi-dsi: Fix error handling path
>   drm/rockchip: inno_hdmi: Fix error handling path
>   drm/bridge/synopsys: dw-hdmi: Add missing bridge detach
>   drm/bridge/synopsys: dw-hdmi: Do not use device's drvdata
>   drm/rockchip: dw_hdmi: Fix error handling path

As I was just looking at the edp dts change in patch1 again, does this
series also contain a fix for the issue below [0] ?

I'm still seeing this on 4.14-rc6 with the most recent drm tree merged in.


Heiko

[0]

[   27.960120] BUG: scheduling while atomic: kworker/1:1/68/0x0002
[   27.974429] Modules linked in: rockchipdrm dw_hdmi analogix_dp 
drm_kms_helper panel_simple crc32_ce drm crct10dif_ce rockchip_saradc pwm_bl 
pwm_cros_ec rockchip_thermal ip_tables x_tabl
es ipv6 smsc95xx smsc75xx ax88179_178a asix usbnet phy_rockchip_pcie 
pcie_rockchip
[   28.008769] CPU: 1 PID: 68 Comm: kworker/1:1 Tainted: GW   
4.14.0-rc7-03201-g12490811b353 #559
[   28.008774] Hardware name: Google Kevin (DT)
[   28.008825] Workqueue: events analogix_dp_psr_work [rockchipdrm]
[   28.008828] Call trace:
[   28.008838] [] dump_backtrace+0x0/0x378
[   28.008842] [] show_stack+0x14/0x20
[   28.008847] [] dump_stack+0x9c/0xbc
[   28.008852] [] __schedule_bug+0x4c/0x70
[   28.008856] [] __schedule+0x558/0x5e8
[   28.008859] [] schedule+0x38/0xa0
[   28.008864] [] schedule_hrtimeout_range_clock+0x84/0xe8
[   28.008867] [] schedule_hrtimeout_range+0x10/0x18
[   28.008870] [] usleep_range+0x64/0x78
[   28.008882] [] analogix_dp_transfer+0x16c/0xa88 
[analogix_dp]
[   28.008891] [] analogix_dpaux_transfer+0x10/0x18 
[analogix_dp]
[   28.008950] [] drm_dp_dpcd_access+0x4c/0xf8 
[drm_kms_helper]
[   28.008994] [] drm_dp_dpcd_write+0x1c/0x28 [drm_kms_helper]
[   28.009002] [] analogix_dp_disable_psr+0x60/0xb0 
[analogix_dp]
[   28.009036] [] analogix_dp_psr_work+0x4c/0xc0 [rockchipdrm]
[   28.009040] [] process_one_work+0x1d4/0x348
[   28.009043] [] worker_thread+0x48/0x470
[   28.009048] [] kthread+0x12c/0x130
[   28.009052] [] ret_from_fork+0x10/0x18

Re: [PATCH v6 00/10] rockchip: kevin: Enable edp display

2017-10-30 Thread Heiko Stuebner 
Hi Jeffy, Sean,

Am Donnerstag, 19. Oktober 2017, 11:48:02 CET schrieb Jeffy Chen:
> 
> Make edp display works on chromebook kevin(at least for boot animation).
> 
> Also solve some issues i meet during the bringup.
> 
> Changes in v6:
> Don't change order of rockchip_drm_psr_register().
> 
> Changes in v5:
> Call the destroy hook in the error handling path like in unbind().
> Call the destroy hook in the error handling path like in unbind().
> Update cleanup order in unbind().
> Add disable to unbind(), and inline clk_prepare_enable() with bind().
> 
> Jeffy Chen (10):
>   arm64: dts: rockchip: Enable edp disaplay on kevin
>   drm/rockchip: analogix_dp: Remove unnecessary init code
>   drm/bridge: analogix: Do not use device's drvdata
>   drm/bridge: analogix_dp: Fix connector and encoder cleanup
>   drm/rockchip: analogix_dp: Add a sanity check for
> rockchip_drm_psr_register()
>   drm/rockchip: dw-mipi-dsi: Fix error handling path
>   drm/rockchip: inno_hdmi: Fix error handling path
>   drm/bridge/synopsys: dw-hdmi: Add missing bridge detach
>   drm/bridge/synopsys: dw-hdmi: Do not use device's drvdata
>   drm/rockchip: dw_hdmi: Fix error handling path

As I was just looking at the edp dts change in patch1 again, does this
series also contain a fix for the issue below [0] ?

I'm still seeing this on 4.14-rc6 with the most recent drm tree merged in.


Heiko

[0]

[   27.960120] BUG: scheduling while atomic: kworker/1:1/68/0x0002
[   27.974429] Modules linked in: rockchipdrm dw_hdmi analogix_dp 
drm_kms_helper panel_simple crc32_ce drm crct10dif_ce rockchip_saradc pwm_bl 
pwm_cros_ec rockchip_thermal ip_tables x_tabl
es ipv6 smsc95xx smsc75xx ax88179_178a asix usbnet phy_rockchip_pcie 
pcie_rockchip
[   28.008769] CPU: 1 PID: 68 Comm: kworker/1:1 Tainted: GW   
4.14.0-rc7-03201-g12490811b353 #559
[   28.008774] Hardware name: Google Kevin (DT)
[   28.008825] Workqueue: events analogix_dp_psr_work [rockchipdrm]
[   28.008828] Call trace:
[   28.008838] [] dump_backtrace+0x0/0x378
[   28.008842] [] show_stack+0x14/0x20
[   28.008847] [] dump_stack+0x9c/0xbc
[   28.008852] [] __schedule_bug+0x4c/0x70
[   28.008856] [] __schedule+0x558/0x5e8
[   28.008859] [] schedule+0x38/0xa0
[   28.008864] [] schedule_hrtimeout_range_clock+0x84/0xe8
[   28.008867] [] schedule_hrtimeout_range+0x10/0x18
[   28.008870] [] usleep_range+0x64/0x78
[   28.008882] [] analogix_dp_transfer+0x16c/0xa88 
[analogix_dp]
[   28.008891] [] analogix_dpaux_transfer+0x10/0x18 
[analogix_dp]
[   28.008950] [] drm_dp_dpcd_access+0x4c/0xf8 
[drm_kms_helper]
[   28.008994] [] drm_dp_dpcd_write+0x1c/0x28 [drm_kms_helper]
[   28.009002] [] analogix_dp_disable_psr+0x60/0xb0 
[analogix_dp]
[   28.009036] [] analogix_dp_psr_work+0x4c/0xc0 [rockchipdrm]
[   28.009040] [] process_one_work+0x1d4/0x348
[   28.009043] [] worker_thread+0x48/0x470
[   28.009048] [] kthread+0x12c/0x130
[   28.009052] [] ret_from_fork+0x10/0x18

Re: [PATCH v6 00/10] rockchip: kevin: Enable edp display

2017-10-20 Thread Sean Paul 
On Thu, Oct 19, 2017 at 11:48:02AM +0800, Jeffy Chen wrote:
> 
> Make edp display works on chromebook kevin(at least for boot animation).
> 
> Also solve some issues i meet during the bringup.
> 
> Changes in v6:
> Don't change order of rockchip_drm_psr_register().
> 
> Changes in v5:
> Call the destroy hook in the error handling path like in unbind().
> Call the destroy hook in the error handling path like in unbind().
> Update cleanup order in unbind().
> Add disable to unbind(), and inline clk_prepare_enable() with bind().
> 
> Jeffy Chen (10):
>   arm64: dts: rockchip: Enable edp disaplay on kevin
>   drm/rockchip: analogix_dp: Remove unnecessary init code
>   drm/bridge: analogix: Do not use device's drvdata
>   drm/bridge: analogix_dp: Fix connector and encoder cleanup
>   drm/rockchip: analogix_dp: Add a sanity check for
> rockchip_drm_psr_register()
>   drm/rockchip: dw-mipi-dsi: Fix error handling path
>   drm/rockchip: inno_hdmi: Fix error handling path
>   drm/bridge/synopsys: dw-hdmi: Add missing bridge detach
>   drm/bridge/synopsys: dw-hdmi: Do not use device's drvdata
>   drm/rockchip: dw_hdmi: Fix error handling path

Hi Jeffy,
I've pushed 2/10. Once you fix 3/10, I can push 3-7. I'd like someone familiar
with synopsys to review 8-9 before pushing those. Since 10 depends on 9, it'll
be blocked on synopsys review.

Sean

> 
>  arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts  | 29 +++
>  arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi   | 16 
>  drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 52 +---
>  drivers/gpu/drm/bridge/synopsys/dw-hdmi.c  | 53 ++--
>  drivers/gpu/drm/exynos/exynos_dp.c | 29 ---
>  drivers/gpu/drm/imx/dw_hdmi-imx.c  | 22 +++--
>  drivers/gpu/drm/meson/meson_dw_hdmi.c  | 20 +++--
>  drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c | 14 +++-
>  drivers/gpu/drm/rockchip/analogix_dp-rockchip.c| 95 
> +++---
>  drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 21 +++--
>  drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c| 39 +
>  drivers/gpu/drm/rockchip/inno_hdmi.c   | 22 +++--
>  include/drm/bridge/analogix_dp.h   | 19 +++--
>  include/drm/bridge/dw_hdmi.h   | 17 ++--
>  14 files changed, 265 insertions(+), 183 deletions(-)
> 
> -- 
> 2.11.0
> 
> 

-- 
Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH v6 00/10] rockchip: kevin: Enable edp display

2017-10-20 Thread Sean Paul 
On Thu, Oct 19, 2017 at 11:48:02AM +0800, Jeffy Chen wrote:
> 
> Make edp display works on chromebook kevin(at least for boot animation).
> 
> Also solve some issues i meet during the bringup.
> 
> Changes in v6:
> Don't change order of rockchip_drm_psr_register().
> 
> Changes in v5:
> Call the destroy hook in the error handling path like in unbind().
> Call the destroy hook in the error handling path like in unbind().
> Update cleanup order in unbind().
> Add disable to unbind(), and inline clk_prepare_enable() with bind().
> 
> Jeffy Chen (10):
>   arm64: dts: rockchip: Enable edp disaplay on kevin
>   drm/rockchip: analogix_dp: Remove unnecessary init code
>   drm/bridge: analogix: Do not use device's drvdata
>   drm/bridge: analogix_dp: Fix connector and encoder cleanup
>   drm/rockchip: analogix_dp: Add a sanity check for
> rockchip_drm_psr_register()
>   drm/rockchip: dw-mipi-dsi: Fix error handling path
>   drm/rockchip: inno_hdmi: Fix error handling path
>   drm/bridge/synopsys: dw-hdmi: Add missing bridge detach
>   drm/bridge/synopsys: dw-hdmi: Do not use device's drvdata
>   drm/rockchip: dw_hdmi: Fix error handling path

Hi Jeffy,
I've pushed 2/10. Once you fix 3/10, I can push 3-7. I'd like someone familiar
with synopsys to review 8-9 before pushing those. Since 10 depends on 9, it'll
be blocked on synopsys review.

Sean

> 
>  arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts  | 29 +++
>  arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi   | 16 
>  drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 52 +---
>  drivers/gpu/drm/bridge/synopsys/dw-hdmi.c  | 53 ++--
>  drivers/gpu/drm/exynos/exynos_dp.c | 29 ---
>  drivers/gpu/drm/imx/dw_hdmi-imx.c  | 22 +++--
>  drivers/gpu/drm/meson/meson_dw_hdmi.c  | 20 +++--
>  drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c | 14 +++-
>  drivers/gpu/drm/rockchip/analogix_dp-rockchip.c| 95 
> +++---
>  drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 21 +++--
>  drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c| 39 +
>  drivers/gpu/drm/rockchip/inno_hdmi.c   | 22 +++--
>  include/drm/bridge/analogix_dp.h   | 19 +++--
>  include/drm/bridge/dw_hdmi.h   | 17 ++--
>  14 files changed, 265 insertions(+), 183 deletions(-)
> 
> -- 
> 2.11.0
> 
> 

-- 
Sean Paul, Software Engineer, Google / Chromium OS

[PATCH v6 00/10] rockchip: kevin: Enable edp display

2017-10-18 Thread Jeffy Chen 

Make edp display works on chromebook kevin(at least for boot animation).

Also solve some issues i meet during the bringup.

Changes in v6:
Don't change order of rockchip_drm_psr_register().

Changes in v5:
Call the destroy hook in the error handling path like in unbind().
Call the destroy hook in the error handling path like in unbind().
Update cleanup order in unbind().
Add disable to unbind(), and inline clk_prepare_enable() with bind().

Jeffy Chen (10):
  arm64: dts: rockchip: Enable edp disaplay on kevin
  drm/rockchip: analogix_dp: Remove unnecessary init code
  drm/bridge: analogix: Do not use device's drvdata
  drm/bridge: analogix_dp: Fix connector and encoder cleanup
  drm/rockchip: analogix_dp: Add a sanity check for
rockchip_drm_psr_register()
  drm/rockchip: dw-mipi-dsi: Fix error handling path
  drm/rockchip: inno_hdmi: Fix error handling path
  drm/bridge/synopsys: dw-hdmi: Add missing bridge detach
  drm/bridge/synopsys: dw-hdmi: Do not use device's drvdata
  drm/rockchip: dw_hdmi: Fix error handling path

 arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts  | 29 +++
 arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi   | 16 
 drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 52 +---
 drivers/gpu/drm/bridge/synopsys/dw-hdmi.c  | 53 ++--
 drivers/gpu/drm/exynos/exynos_dp.c | 29 ---
 drivers/gpu/drm/imx/dw_hdmi-imx.c  | 22 +++--
 drivers/gpu/drm/meson/meson_dw_hdmi.c  | 20 +++--
 drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c | 14 +++-
 drivers/gpu/drm/rockchip/analogix_dp-rockchip.c| 95 +++---
 drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 21 +++--
 drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c| 39 +
 drivers/gpu/drm/rockchip/inno_hdmi.c   | 22 +++--
 include/drm/bridge/analogix_dp.h   | 19 +++--
 include/drm/bridge/dw_hdmi.h   | 17 ++--
 14 files changed, 265 insertions(+), 183 deletions(-)

-- 
2.11.0

[PATCH v6 00/10] rockchip: kevin: Enable edp display

2017-10-18 Thread Jeffy Chen 

Make edp display works on chromebook kevin(at least for boot animation).

Also solve some issues i meet during the bringup.

Changes in v6:
Don't change order of rockchip_drm_psr_register().

Changes in v5:
Call the destroy hook in the error handling path like in unbind().
Call the destroy hook in the error handling path like in unbind().
Update cleanup order in unbind().
Add disable to unbind(), and inline clk_prepare_enable() with bind().

Jeffy Chen (10):
  arm64: dts: rockchip: Enable edp disaplay on kevin
  drm/rockchip: analogix_dp: Remove unnecessary init code
  drm/bridge: analogix: Do not use device's drvdata
  drm/bridge: analogix_dp: Fix connector and encoder cleanup
  drm/rockchip: analogix_dp: Add a sanity check for
rockchip_drm_psr_register()
  drm/rockchip: dw-mipi-dsi: Fix error handling path
  drm/rockchip: inno_hdmi: Fix error handling path
  drm/bridge/synopsys: dw-hdmi: Add missing bridge detach
  drm/bridge/synopsys: dw-hdmi: Do not use device's drvdata
  drm/rockchip: dw_hdmi: Fix error handling path

 arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts  | 29 +++
 arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi   | 16 
 drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 52 +---
 drivers/gpu/drm/bridge/synopsys/dw-hdmi.c  | 53 ++--
 drivers/gpu/drm/exynos/exynos_dp.c | 29 ---
 drivers/gpu/drm/imx/dw_hdmi-imx.c  | 22 +++--
 drivers/gpu/drm/meson/meson_dw_hdmi.c  | 20 +++--
 drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c | 14 +++-
 drivers/gpu/drm/rockchip/analogix_dp-rockchip.c| 95 +++---
 drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 21 +++--
 drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c| 39 +
 drivers/gpu/drm/rockchip/inno_hdmi.c   | 22 +++--
 include/drm/bridge/analogix_dp.h   | 19 +++--
 include/drm/bridge/dw_hdmi.h   | 17 ++--
 14 files changed, 265 insertions(+), 183 deletions(-)

-- 
2.11.0