[PATCH v6 08/25] usb: chipidea: Remove locking in ci_udc_start()

[Stephen Boyd]

We don't call hw_device_reset() with the ci->lock held, so it
doesn't seem like this lock here is protecting anything. Let's
just remove it. This allows us to call sleeping functions like
phy_init() from within the CI_HDRC_CONTROLLER_RESET_EVENT hook.

Acked-by: Peter Chen 
Cc: Greg Kroah-Hartman 
Signed-off-by: Stephen Boyd 
---
 drivers/usb/chipidea/udc.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c
index cf132f057137..732b281485de 100644
--- a/drivers/usb/chipidea/udc.c
+++ b/drivers/usb/chipidea/udc.c
@@ -1725,7 +1725,6 @@ static int ci_udc_start(struct usb_gadget *gadget,
 struct usb_gadget_driver *driver)
 {
struct ci_hdrc *ci = container_of(gadget, struct ci_hdrc, gadget);
-   unsigned long flags;
int retval = -ENOMEM;
 
if (driver->disconnect == NULL)
@@ -1752,7 +1751,6 @@ static int ci_udc_start(struct usb_gadget *gadget,
 
pm_runtime_get_sync(>gadget.dev);
if (ci->vbus_active) {
-   spin_lock_irqsave(>lock, flags);
hw_device_reset(ci);
} else {
usb_udc_vbus_handler(>gadget, false);
@@ -1761,7 +1759,6 @@ static int ci_udc_start(struct usb_gadget *gadget,
}
 
retval = hw_device_state(ci, ci->ep0out->qh.dma);
-   spin_unlock_irqrestore(>lock, flags);
if (retval)
pm_runtime_put_sync(>gadget.dev);
 
-- 
2.10.0.297.gf6727b0

[PATCH v6 08/25] usb: chipidea: Remove locking in ci_udc_start()

[Stephen Boyd]

We don't call hw_device_reset() with the ci->lock held, so it
doesn't seem like this lock here is protecting anything. Let's
just remove it. This allows us to call sleeping functions like
phy_init() from within the CI_HDRC_CONTROLLER_RESET_EVENT hook.

Acked-by: Peter Chen 
Cc: Greg Kroah-Hartman 
Signed-off-by: Stephen Boyd 
---
 drivers/usb/chipidea/udc.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c
index cf132f057137..732b281485de 100644
--- a/drivers/usb/chipidea/udc.c
+++ b/drivers/usb/chipidea/udc.c
@@ -1725,7 +1725,6 @@ static int ci_udc_start(struct usb_gadget *gadget,
 struct usb_gadget_driver *driver)
 {
struct ci_hdrc *ci = container_of(gadget, struct ci_hdrc, gadget);
-   unsigned long flags;
int retval = -ENOMEM;
 
if (driver->disconnect == NULL)
@@ -1752,7 +1751,6 @@ static int ci_udc_start(struct usb_gadget *gadget,
 
pm_runtime_get_sync(>gadget.dev);
if (ci->vbus_active) {
-   spin_lock_irqsave(>lock, flags);
hw_device_reset(ci);
} else {
usb_udc_vbus_handler(>gadget, false);
@@ -1761,7 +1759,6 @@ static int ci_udc_start(struct usb_gadget *gadget,
}
 
retval = hw_device_state(ci, ci->ep0out->qh.dma);
-   spin_unlock_irqrestore(>lock, flags);
if (retval)
pm_runtime_put_sync(>gadget.dev);
 
-- 
2.10.0.297.gf6727b0