Re: [PATCH v6 1/1] dt-bindings: dw-apb-ictl: convert to json-schema

2020-09-29 Thread Rob Herring
On Tue, 29 Sep 2020 10:48:11 +0800, Zhen Lei wrote:
> Convert the Synopsys DesignWare APB interrupt controller (dw_apb_ictl)
> binding to DT schema format using json-schema.
> 
> Signed-off-by: Zhen Lei 
> ---
>  .../interrupt-controller/snps,dw-apb-ictl.txt  | 43 --
>  .../interrupt-controller/snps,dw-apb-ictl.yaml | 68 
> ++
>  2 files changed, 68 insertions(+), 43 deletions(-)
>  delete mode 100644 
> Documentation/devicetree/bindings/interrupt-controller/snps,dw-apb-ictl.txt
>  create mode 100644 
> Documentation/devicetree/bindings/interrupt-controller/snps,dw-apb-ictl.yaml
> 

Reviewed-by: Rob Herring 


[PATCH v6 1/1] dt-bindings: dw-apb-ictl: convert to json-schema

2020-09-28 Thread Zhen Lei
Convert the Synopsys DesignWare APB interrupt controller (dw_apb_ictl)
binding to DT schema format using json-schema.

Signed-off-by: Zhen Lei 
---
 .../interrupt-controller/snps,dw-apb-ictl.txt  | 43 --
 .../interrupt-controller/snps,dw-apb-ictl.yaml | 68 ++
 2 files changed, 68 insertions(+), 43 deletions(-)
 delete mode 100644 
Documentation/devicetree/bindings/interrupt-controller/snps,dw-apb-ictl.txt
 create mode 100644 
Documentation/devicetree/bindings/interrupt-controller/snps,dw-apb-ictl.yaml

diff --git 
a/Documentation/devicetree/bindings/interrupt-controller/snps,dw-apb-ictl.txt 
b/Documentation/devicetree/bindings/interrupt-controller/snps,dw-apb-ictl.txt
deleted file mode 100644
index 2db59df9408f4c6..000
--- 
a/Documentation/devicetree/bindings/interrupt-controller/snps,dw-apb-ictl.txt
+++ /dev/null
@@ -1,43 +0,0 @@
-Synopsys DesignWare APB interrupt controller (dw_apb_ictl)
-
-Synopsys DesignWare provides interrupt controller IP for APB known as
-dw_apb_ictl. The IP is used as secondary interrupt controller in some SoCs with
-APB bus, e.g. Marvell Armada 1500. It can also be used as primary interrupt
-controller in some SoCs, e.g. Hisilicon SD5203.
-
-Required properties:
-- compatible: shall be "snps,dw-apb-ictl"
-- reg: physical base address of the controller and length of memory mapped
-  region starting with ENABLE_LOW register
-- interrupt-controller: identifies the node as an interrupt controller
-- #interrupt-cells: number of cells to encode an interrupt-specifier, shall be 
1
-
-Additional required property when it's used as secondary interrupt controller:
-- interrupts: interrupt reference to primary interrupt controller
-
-The interrupt sources map to the corresponding bits in the interrupt
-registers, i.e.
-- 0 maps to bit 0 of low interrupts,
-- 1 maps to bit 1 of low interrupts,
-- 32 maps to bit 0 of high interrupts,
-- 33 maps to bit 1 of high interrupts,
-- (optional) fast interrupts start at 64.
-
-Example:
-   /* dw_apb_ictl is used as secondary interrupt controller */
-   aic: interrupt-controller@3000 {
-   compatible = "snps,dw-apb-ictl";
-   reg = <0x3000 0xc00>;
-   interrupt-controller;
-   #interrupt-cells = <1>;
-   interrupt-parent = <>;
-   interrupts = ;
-   };
-
-   /* dw_apb_ictl is used as primary interrupt controller */
-   vic: interrupt-controller@1013 {
-   compatible = "snps,dw-apb-ictl";
-   reg = <0x1013 0x1000>;
-   interrupt-controller;
-   #interrupt-cells = <1>;
-   };
diff --git 
a/Documentation/devicetree/bindings/interrupt-controller/snps,dw-apb-ictl.yaml 
b/Documentation/devicetree/bindings/interrupt-controller/snps,dw-apb-ictl.yaml
new file mode 100644
index 000..33b3992d1c27c63
--- /dev/null
+++ 
b/Documentation/devicetree/bindings/interrupt-controller/snps,dw-apb-ictl.yaml
@@ -0,0 +1,68 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/interrupt-controller/snps,dw-apb-ictl.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Synopsys DesignWare APB interrupt controller (dw_apb_ictl)
+
+maintainers:
+  - Sebastian Hesselbarth 
+
+description: |
+  Synopsys DesignWare provides interrupt controller IP for APB known as
+  dw_apb_ictl. The IP is used as secondary interrupt controller in some SoCs
+  with APB bus, e.g. Marvell Armada 1500. It can also be used as primary
+  interrupt controller in some SoCs, e.g. Hisilicon SD5203.
+
+  The interrupt sources map to the corresponding bits in the interrupt
+  registers, i.e.
+  - 0 maps to bit 0 of low interrupts,
+  - 1 maps to bit 1 of low interrupts,
+  - 32 maps to bit 0 of high interrupts,
+  - 33 maps to bit 1 of high interrupts,
+  - (optional) fast interrupts start at 64.
+
+properties:
+  compatible:
+const: snps,dw-apb-ictl
+
+  interrupt-controller: true
+
+  reg:
+maxItems: 1
+
+  interrupts:
+maxItems: 1
+
+  "#interrupt-cells":
+const: 1
+
+required:
+  - compatible
+  - reg
+  - interrupt-controller
+  - '#interrupt-cells'
+
+additionalProperties: false
+
+examples:
+  - |
+/* dw_apb_ictl is used as secondary interrupt controller */
+interrupt-controller@3000 {
+compatible = "snps,dw-apb-ictl";
+reg = <0x3000 0xc00>;
+interrupt-controller;
+#interrupt-cells = <1>;
+interrupt-parent = <>;
+interrupts = <0 3 4>;
+};
+
+/* dw_apb_ictl is used as primary interrupt controller */
+interrupt-controller@1013 {
+compatible = "snps,dw-apb-ictl";
+reg = <0x1013 0x1000>;
+interrupt-controller;
+#interrupt-cells = <1>;
+};
+...
-- 
1.8.3