Re: [PATCH v6 2/8] mfd: stpmic1: add stpmic1 driver

2018-11-28 Thread Lee Jones
On Tue, 27 Nov 2018, Pascal PAILLET-LME wrote:

> STPMIC1 is a PMIC from STMicroelectronics. The STPMIC1 integrates 10
> regulators, 3 power switches, a watchdog and an input for a power on key.
> 
> Signed-off-by: Pascal Paillet 
> ---
> changes in v6:
> * replace i2c_device_id by of_device_id
> * fix commit message and Kconfig description
> 
>  drivers/mfd/Kconfig |  16 
>  drivers/mfd/Makefile|   1 +
>  drivers/mfd/stpmic1.c   | 213 
> 
>  include/linux/mfd/stpmic1.h | 212 +++
>  4 files changed, 442 insertions(+)
>  create mode 100644 drivers/mfd/stpmic1.c
>  create mode 100644 include/linux/mfd/stpmic1.h

For my own reference:
  Acked-for-MFD-by: Lee Jones 

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog


Re: [PATCH v6 2/8] mfd: stpmic1: add stpmic1 driver

2018-11-28 Thread Lee Jones
On Tue, 27 Nov 2018, Pascal PAILLET-LME wrote:

> STPMIC1 is a PMIC from STMicroelectronics. The STPMIC1 integrates 10
> regulators, 3 power switches, a watchdog and an input for a power on key.
> 
> Signed-off-by: Pascal Paillet 
> ---
> changes in v6:
> * replace i2c_device_id by of_device_id
> * fix commit message and Kconfig description
> 
>  drivers/mfd/Kconfig |  16 
>  drivers/mfd/Makefile|   1 +
>  drivers/mfd/stpmic1.c   | 213 
> 
>  include/linux/mfd/stpmic1.h | 212 +++
>  4 files changed, 442 insertions(+)
>  create mode 100644 drivers/mfd/stpmic1.c
>  create mode 100644 include/linux/mfd/stpmic1.h

For my own reference:
  Acked-for-MFD-by: Lee Jones 

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog


[PATCH v6 2/8] mfd: stpmic1: add stpmic1 driver

2018-11-27 Thread Pascal PAILLET-LME
STPMIC1 is a PMIC from STMicroelectronics. The STPMIC1 integrates 10
regulators, 3 power switches, a watchdog and an input for a power on key.

Signed-off-by: Pascal Paillet 
---
changes in v6:
* replace i2c_device_id by of_device_id
* fix commit message and Kconfig description

 drivers/mfd/Kconfig |  16 
 drivers/mfd/Makefile|   1 +
 drivers/mfd/stpmic1.c   | 213 
 include/linux/mfd/stpmic1.h | 212 +++
 4 files changed, 442 insertions(+)
 create mode 100644 drivers/mfd/stpmic1.c
 create mode 100644 include/linux/mfd/stpmic1.h

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 11841f4..0677bac 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -1855,6 +1855,22 @@ config MFD_STM32_TIMERS
  for PWM and IIO Timer. This driver allow to share the
  registers between the others drivers.
 
+config MFD_STPMIC1
+   tristate "Support for STPMIC1 PMIC"
+   depends on (I2C=y && OF)
+   select REGMAP_I2C
+   select REGMAP_IRQ
+   select MFD_CORE
+   help
+ Support for ST Microelectronics STPMIC1 PMIC. STPMIC1 has power on
+ key, watchdog and regulator functionalities which are supported via
+ the relevant subsystems. This driver provides core support for the
+ STPMIC1. In order to use the actual functionaltiy of the device other
+ drivers must be enabled.
+
+ To compile this driver as a module, choose M here: the
+ module will be called stpmic1.
+
 menu "Multimedia Capabilities Port drivers"
depends on ARCH_SA1100
 
diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
index 5856a94..76fff14 100644
--- a/drivers/mfd/Makefile
+++ b/drivers/mfd/Makefile
@@ -232,6 +232,7 @@ obj-$(CONFIG_INTEL_SOC_PMIC_CHTDC_TI)   += 
intel_soc_pmic_chtdc_ti.o
 obj-$(CONFIG_MFD_MT6397)   += mt6397-core.o
 
 obj-$(CONFIG_MFD_ALTERA_A10SR) += altera-a10sr.o
+obj-$(CONFIG_MFD_STPMIC1)  += stpmic1.o
 obj-$(CONFIG_MFD_SUN4I_GPADC)  += sun4i-gpadc.o
 
 obj-$(CONFIG_MFD_STM32_LPTIMER)+= stm32-lptimer.o
diff --git a/drivers/mfd/stpmic1.c b/drivers/mfd/stpmic1.c
new file mode 100644
index 000..7dfbe89
--- /dev/null
+++ b/drivers/mfd/stpmic1.c
@@ -0,0 +1,213 @@
+// SPDX-License-Identifier: GPL-2.0
+// Copyright (C) STMicroelectronics 2018
+// Author: Pascal Paillet 
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include 
+
+#define STPMIC1_MAIN_IRQ 0
+
+static const struct regmap_range stpmic1_readable_ranges[] = {
+   regmap_reg_range(TURN_ON_SR, VERSION_SR),
+   regmap_reg_range(SWOFF_PWRCTRL_CR, LDO6_STDBY_CR),
+   regmap_reg_range(BST_SW_CR, BST_SW_CR),
+   regmap_reg_range(INT_PENDING_R1, INT_PENDING_R4),
+   regmap_reg_range(INT_CLEAR_R1, INT_CLEAR_R4),
+   regmap_reg_range(INT_MASK_R1, INT_MASK_R4),
+   regmap_reg_range(INT_SET_MASK_R1, INT_SET_MASK_R4),
+   regmap_reg_range(INT_CLEAR_MASK_R1, INT_CLEAR_MASK_R4),
+   regmap_reg_range(INT_SRC_R1, INT_SRC_R1),
+};
+
+static const struct regmap_range stpmic1_writeable_ranges[] = {
+   regmap_reg_range(SWOFF_PWRCTRL_CR, LDO6_STDBY_CR),
+   regmap_reg_range(BST_SW_CR, BST_SW_CR),
+   regmap_reg_range(INT_CLEAR_R1, INT_CLEAR_R4),
+   regmap_reg_range(INT_SET_MASK_R1, INT_SET_MASK_R4),
+   regmap_reg_range(INT_CLEAR_MASK_R1, INT_CLEAR_MASK_R4),
+};
+
+static const struct regmap_range stpmic1_volatile_ranges[] = {
+   regmap_reg_range(TURN_ON_SR, VERSION_SR),
+   regmap_reg_range(WCHDG_CR, WCHDG_CR),
+   regmap_reg_range(INT_PENDING_R1, INT_PENDING_R4),
+   regmap_reg_range(INT_SRC_R1, INT_SRC_R4),
+};
+
+static const struct regmap_access_table stpmic1_readable_table = {
+   .yes_ranges = stpmic1_readable_ranges,
+   .n_yes_ranges = ARRAY_SIZE(stpmic1_readable_ranges),
+};
+
+static const struct regmap_access_table stpmic1_writeable_table = {
+   .yes_ranges = stpmic1_writeable_ranges,
+   .n_yes_ranges = ARRAY_SIZE(stpmic1_writeable_ranges),
+};
+
+static const struct regmap_access_table stpmic1_volatile_table = {
+   .yes_ranges = stpmic1_volatile_ranges,
+   .n_yes_ranges = ARRAY_SIZE(stpmic1_volatile_ranges),
+};
+
+const struct regmap_config stpmic1_regmap_config = {
+   .reg_bits = 8,
+   .val_bits = 8,
+   .cache_type = REGCACHE_RBTREE,
+   .max_register = PMIC_MAX_REGISTER_ADDRESS,
+   .rd_table = _readable_table,
+   .wr_table = _writeable_table,
+   .volatile_table = _volatile_table,
+};
+
+static const struct regmap_irq stpmic1_irqs[] = {
+   REGMAP_IRQ_REG(IT_PONKEY_F, 0, 0x01),
+   REGMAP_IRQ_REG(IT_PONKEY_R, 0, 0x02),
+   REGMAP_IRQ_REG(IT_WAKEUP_F, 0, 0x04),
+   REGMAP_IRQ_REG(IT_WAKEUP_R, 0, 0x08),
+   REGMAP_IRQ_REG(IT_VBUS_OTG_F, 0, 0x10),
+   REGMAP_IRQ_REG(IT_VBUS_OTG_R, 0, 0x20),
+   

[PATCH v6 2/8] mfd: stpmic1: add stpmic1 driver

2018-11-27 Thread Pascal PAILLET-LME
STPMIC1 is a PMIC from STMicroelectronics. The STPMIC1 integrates 10
regulators, 3 power switches, a watchdog and an input for a power on key.

Signed-off-by: Pascal Paillet 
---
changes in v6:
* replace i2c_device_id by of_device_id
* fix commit message and Kconfig description

 drivers/mfd/Kconfig |  16 
 drivers/mfd/Makefile|   1 +
 drivers/mfd/stpmic1.c   | 213 
 include/linux/mfd/stpmic1.h | 212 +++
 4 files changed, 442 insertions(+)
 create mode 100644 drivers/mfd/stpmic1.c
 create mode 100644 include/linux/mfd/stpmic1.h

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 11841f4..0677bac 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -1855,6 +1855,22 @@ config MFD_STM32_TIMERS
  for PWM and IIO Timer. This driver allow to share the
  registers between the others drivers.
 
+config MFD_STPMIC1
+   tristate "Support for STPMIC1 PMIC"
+   depends on (I2C=y && OF)
+   select REGMAP_I2C
+   select REGMAP_IRQ
+   select MFD_CORE
+   help
+ Support for ST Microelectronics STPMIC1 PMIC. STPMIC1 has power on
+ key, watchdog and regulator functionalities which are supported via
+ the relevant subsystems. This driver provides core support for the
+ STPMIC1. In order to use the actual functionaltiy of the device other
+ drivers must be enabled.
+
+ To compile this driver as a module, choose M here: the
+ module will be called stpmic1.
+
 menu "Multimedia Capabilities Port drivers"
depends on ARCH_SA1100
 
diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
index 5856a94..76fff14 100644
--- a/drivers/mfd/Makefile
+++ b/drivers/mfd/Makefile
@@ -232,6 +232,7 @@ obj-$(CONFIG_INTEL_SOC_PMIC_CHTDC_TI)   += 
intel_soc_pmic_chtdc_ti.o
 obj-$(CONFIG_MFD_MT6397)   += mt6397-core.o
 
 obj-$(CONFIG_MFD_ALTERA_A10SR) += altera-a10sr.o
+obj-$(CONFIG_MFD_STPMIC1)  += stpmic1.o
 obj-$(CONFIG_MFD_SUN4I_GPADC)  += sun4i-gpadc.o
 
 obj-$(CONFIG_MFD_STM32_LPTIMER)+= stm32-lptimer.o
diff --git a/drivers/mfd/stpmic1.c b/drivers/mfd/stpmic1.c
new file mode 100644
index 000..7dfbe89
--- /dev/null
+++ b/drivers/mfd/stpmic1.c
@@ -0,0 +1,213 @@
+// SPDX-License-Identifier: GPL-2.0
+// Copyright (C) STMicroelectronics 2018
+// Author: Pascal Paillet 
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include 
+
+#define STPMIC1_MAIN_IRQ 0
+
+static const struct regmap_range stpmic1_readable_ranges[] = {
+   regmap_reg_range(TURN_ON_SR, VERSION_SR),
+   regmap_reg_range(SWOFF_PWRCTRL_CR, LDO6_STDBY_CR),
+   regmap_reg_range(BST_SW_CR, BST_SW_CR),
+   regmap_reg_range(INT_PENDING_R1, INT_PENDING_R4),
+   regmap_reg_range(INT_CLEAR_R1, INT_CLEAR_R4),
+   regmap_reg_range(INT_MASK_R1, INT_MASK_R4),
+   regmap_reg_range(INT_SET_MASK_R1, INT_SET_MASK_R4),
+   regmap_reg_range(INT_CLEAR_MASK_R1, INT_CLEAR_MASK_R4),
+   regmap_reg_range(INT_SRC_R1, INT_SRC_R1),
+};
+
+static const struct regmap_range stpmic1_writeable_ranges[] = {
+   regmap_reg_range(SWOFF_PWRCTRL_CR, LDO6_STDBY_CR),
+   regmap_reg_range(BST_SW_CR, BST_SW_CR),
+   regmap_reg_range(INT_CLEAR_R1, INT_CLEAR_R4),
+   regmap_reg_range(INT_SET_MASK_R1, INT_SET_MASK_R4),
+   regmap_reg_range(INT_CLEAR_MASK_R1, INT_CLEAR_MASK_R4),
+};
+
+static const struct regmap_range stpmic1_volatile_ranges[] = {
+   regmap_reg_range(TURN_ON_SR, VERSION_SR),
+   regmap_reg_range(WCHDG_CR, WCHDG_CR),
+   regmap_reg_range(INT_PENDING_R1, INT_PENDING_R4),
+   regmap_reg_range(INT_SRC_R1, INT_SRC_R4),
+};
+
+static const struct regmap_access_table stpmic1_readable_table = {
+   .yes_ranges = stpmic1_readable_ranges,
+   .n_yes_ranges = ARRAY_SIZE(stpmic1_readable_ranges),
+};
+
+static const struct regmap_access_table stpmic1_writeable_table = {
+   .yes_ranges = stpmic1_writeable_ranges,
+   .n_yes_ranges = ARRAY_SIZE(stpmic1_writeable_ranges),
+};
+
+static const struct regmap_access_table stpmic1_volatile_table = {
+   .yes_ranges = stpmic1_volatile_ranges,
+   .n_yes_ranges = ARRAY_SIZE(stpmic1_volatile_ranges),
+};
+
+const struct regmap_config stpmic1_regmap_config = {
+   .reg_bits = 8,
+   .val_bits = 8,
+   .cache_type = REGCACHE_RBTREE,
+   .max_register = PMIC_MAX_REGISTER_ADDRESS,
+   .rd_table = _readable_table,
+   .wr_table = _writeable_table,
+   .volatile_table = _volatile_table,
+};
+
+static const struct regmap_irq stpmic1_irqs[] = {
+   REGMAP_IRQ_REG(IT_PONKEY_F, 0, 0x01),
+   REGMAP_IRQ_REG(IT_PONKEY_R, 0, 0x02),
+   REGMAP_IRQ_REG(IT_WAKEUP_F, 0, 0x04),
+   REGMAP_IRQ_REG(IT_WAKEUP_R, 0, 0x08),
+   REGMAP_IRQ_REG(IT_VBUS_OTG_F, 0, 0x10),
+   REGMAP_IRQ_REG(IT_VBUS_OTG_R, 0, 0x20),
+