Re: [PATCH v6 3/4] dt-bindings: arm: fsl: Add Kontron i.MX6UL N6310 compatibles
On Thu, 22 Aug 2019 at 14:52, Rob Herring wrote: > > On Wed, Aug 21, 2019 at 12:55 PM Krzysztof Kozlowski wrote: > > > > On Tue, Aug 20, 2019 at 03:27:39PM -0500, Rob Herring wrote: > > > > I see. If I understand the schema correctly, this should look like: > > > > > > Looks correct, but a couple of comments. > > > > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml > > > > b/Documentation/devicetree/bindings/arm/fsl.yaml > > > > index 7294ac36f4c0..eb263d1ccf13 100644 > > > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > > > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > > > > @@ -161,6 +161,22 @@ properties: > > > > items: > > > >- enum: > > > >- fsl,imx6ul-14x14-evk # i.MX6 UltraLite 14x14 EVK > > > > Board > > > > + - kontron,imx6ul-n6310-som # Kontron N6310 SOM > > > > > > Is the SOM ever used alone? If not, then no point in listing this here. > > > > SoM alone: no, because it requires some type of base board. However it > > will be used by some customer designs with some amount of > > changes/addons. > > > > Looking at other aproaches, usually SoMs have their own compatible. In > > such case - I should document it somewhere. > > I wasn't suggesting not having the compatible for it, but you don't > need it in this list because that is not valid. You have to list it > with the base board compatibles. The diff against v7 would be like this then: --- diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml index 1f440817fc03..7219c15f6185 100644 --- a/Documentation/devicetree/bindings/arm/fsl.yaml +++ b/Documentation/devicetree/bindings/arm/fsl.yaml @@ -161,7 +161,6 @@ properties: items: - enum: - fsl,imx6ul-14x14-evk # i.MX6 UltraLite 14x14 EVK Board - - kontron,imx6ul-n6310-som # Kontron N6310 SOM - const: fsl,imx6ul - description: Kontron N6310 S Board --- This passes the dtbs_check. I'll send v8
Re: [PATCH v6 3/4] dt-bindings: arm: fsl: Add Kontron i.MX6UL N6310 compatibles
On Wed, Aug 21, 2019 at 12:55 PM Krzysztof Kozlowski wrote: > > On Tue, Aug 20, 2019 at 03:27:39PM -0500, Rob Herring wrote: > > > I see. If I understand the schema correctly, this should look like: > > > > Looks correct, but a couple of comments. > > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml > > > b/Documentation/devicetree/bindings/arm/fsl.yaml > > > index 7294ac36f4c0..eb263d1ccf13 100644 > > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > > > @@ -161,6 +161,22 @@ properties: > > > items: > > >- enum: > > >- fsl,imx6ul-14x14-evk # i.MX6 UltraLite 14x14 EVK > > > Board > > > + - kontron,imx6ul-n6310-som # Kontron N6310 SOM > > > > Is the SOM ever used alone? If not, then no point in listing this here. > > SoM alone: no, because it requires some type of base board. However it > will be used by some customer designs with some amount of > changes/addons. > > Looking at other aproaches, usually SoMs have their own compatible. In > such case - I should document it somewhere. I wasn't suggesting not having the compatible for it, but you don't need it in this list because that is not valid. You have to list it with the base board compatibles. Rob
Re: [PATCH v6 3/4] dt-bindings: arm: fsl: Add Kontron i.MX6UL N6310 compatibles
On Tue, Aug 20, 2019 at 03:27:39PM -0500, Rob Herring wrote: > > I see. If I understand the schema correctly, this should look like: > > Looks correct, but a couple of comments. > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml > > b/Documentation/devicetree/bindings/arm/fsl.yaml > > index 7294ac36f4c0..eb263d1ccf13 100644 > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > > @@ -161,6 +161,22 @@ properties: > > items: > >- enum: > >- fsl,imx6ul-14x14-evk # i.MX6 UltraLite 14x14 EVK Board > > + - kontron,imx6ul-n6310-som # Kontron N6310 SOM > > Is the SOM ever used alone? If not, then no point in listing this here. SoM alone: no, because it requires some type of base board. However it will be used by some customer designs with some amount of changes/addons. Looking at other aproaches, usually SoMs have their own compatible. In such case - I should document it somewhere. > > > + - const: fsl,imx6ul > > + > > + - description: Kontron N6310 S Board > > +items: > > + - enum: > > + - kontron,imx6ul-n6310-s > > This could be a 'const' instead. It depends if you think there will > ever be more than one entry. Indeed, I'll make this and entry below for S 43 board const. Best regards, Krzysztof
Re: [PATCH v6 3/4] dt-bindings: arm: fsl: Add Kontron i.MX6UL N6310 compatibles
On Tue, Aug 20, 2019 at 3:21 PM Krzysztof Kozlowski wrote: > > On Tue, Aug 20, 2019 at 03:04:57PM -0500, Rob Herring wrote: > > On Tue, Aug 20, 2019 at 1:36 PM Krzysztof Kozlowski wrote: > > > > > > On Tue, 20 Aug 2019 at 18:59, Rob Herring wrote: > > > > > > > > On Tue, Aug 20, 2019 at 10:35 AM Krzysztof Kozlowski > > > > wrote: > > > > > > > > > > Add the compatibles for Kontron i.MX6UL N6310 SoM and boards. > > > > > > > > > > Signed-off-by: Krzysztof Kozlowski > > > > > > > > > > --- > > > > > > > > > > Changes since v5: > > > > > New patch > > > > > --- > > > > > Documentation/devicetree/bindings/arm/fsl.yaml | 3 +++ > > > > > 1 file changed, 3 insertions(+) > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml > > > > > b/Documentation/devicetree/bindings/arm/fsl.yaml > > > > > index 7294ac36f4c0..d07b3c06d7cf 100644 > > > > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > > > > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > > > > > @@ -161,6 +161,9 @@ properties: > > > > > items: > > > > >- enum: > > > > >- fsl,imx6ul-14x14-evk # i.MX6 UltraLite 14x14 > > > > > EVK Board > > > > > + - kontron,imx6ul-n6310-som # Kontron N6310 SOM > > > > > + - kontron,imx6ul-n6310-s# Kontron N6310 S Board > > > > > + - kontron,imx6ul-n6310-s-43 # Kontron N6310 S 43 Board > > > > > > > > This doesn't match what is in your dts files. Run 'make dtbs_check' and > > > > see. > > > > > > You mean the name does not match? I thought that '#' is a comment in > > > YAML... > > > > No, the number of compatible strings is the problem. > > I see. If I understand the schema correctly, this should look like: Looks correct, but a couple of comments. > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml > b/Documentation/devicetree/bindings/arm/fsl.yaml > index 7294ac36f4c0..eb263d1ccf13 100644 > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > @@ -161,6 +161,22 @@ properties: > items: >- enum: >- fsl,imx6ul-14x14-evk # i.MX6 UltraLite 14x14 EVK Board > + - kontron,imx6ul-n6310-som # Kontron N6310 SOM Is the SOM ever used alone? If not, then no point in listing this here. > + - const: fsl,imx6ul > + > + - description: Kontron N6310 S Board > +items: > + - enum: > + - kontron,imx6ul-n6310-s This could be a 'const' instead. It depends if you think there will ever be more than one entry. > + - const: kontron,imx6ul-n6310-som > + - const: fsl,imx6ul > + > + - description: Kontron N6310 S 43 Board > +items: > + - enum: > + - kontron,imx6ul-n6310-s-43 > + - const: kontron,imx6ul-n6310-s > + - const: kontron,imx6ul-n6310-som >- const: fsl,imx6ul > >- description: i.MX6ULL based Boards > > > It passes the dtbs_check. Is it correct? > > Best regards, > Krzysztof >
Re: [PATCH v6 3/4] dt-bindings: arm: fsl: Add Kontron i.MX6UL N6310 compatibles
On Tue, Aug 20, 2019 at 03:04:57PM -0500, Rob Herring wrote: > On Tue, Aug 20, 2019 at 1:36 PM Krzysztof Kozlowski wrote: > > > > On Tue, 20 Aug 2019 at 18:59, Rob Herring wrote: > > > > > > On Tue, Aug 20, 2019 at 10:35 AM Krzysztof Kozlowski > > > wrote: > > > > > > > > Add the compatibles for Kontron i.MX6UL N6310 SoM and boards. > > > > > > > > Signed-off-by: Krzysztof Kozlowski > > > > > > > > --- > > > > > > > > Changes since v5: > > > > New patch > > > > --- > > > > Documentation/devicetree/bindings/arm/fsl.yaml | 3 +++ > > > > 1 file changed, 3 insertions(+) > > > > > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml > > > > b/Documentation/devicetree/bindings/arm/fsl.yaml > > > > index 7294ac36f4c0..d07b3c06d7cf 100644 > > > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > > > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > > > > @@ -161,6 +161,9 @@ properties: > > > > items: > > > >- enum: > > > >- fsl,imx6ul-14x14-evk # i.MX6 UltraLite 14x14 EVK > > > > Board > > > > + - kontron,imx6ul-n6310-som # Kontron N6310 SOM > > > > + - kontron,imx6ul-n6310-s# Kontron N6310 S Board > > > > + - kontron,imx6ul-n6310-s-43 # Kontron N6310 S 43 Board > > > > > > This doesn't match what is in your dts files. Run 'make dtbs_check' and > > > see. > > > > You mean the name does not match? I thought that '#' is a comment in YAML... > > No, the number of compatible strings is the problem. I see. If I understand the schema correctly, this should look like: diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml index 7294ac36f4c0..eb263d1ccf13 100644 --- a/Documentation/devicetree/bindings/arm/fsl.yaml +++ b/Documentation/devicetree/bindings/arm/fsl.yaml @@ -161,6 +161,22 @@ properties: items: - enum: - fsl,imx6ul-14x14-evk # i.MX6 UltraLite 14x14 EVK Board + - kontron,imx6ul-n6310-som # Kontron N6310 SOM + - const: fsl,imx6ul + + - description: Kontron N6310 S Board +items: + - enum: + - kontron,imx6ul-n6310-s + - const: kontron,imx6ul-n6310-som + - const: fsl,imx6ul + + - description: Kontron N6310 S 43 Board +items: + - enum: + - kontron,imx6ul-n6310-s-43 + - const: kontron,imx6ul-n6310-s + - const: kontron,imx6ul-n6310-som - const: fsl,imx6ul - description: i.MX6ULL based Boards It passes the dtbs_check. Is it correct? Best regards, Krzysztof
Re: [PATCH v6 3/4] dt-bindings: arm: fsl: Add Kontron i.MX6UL N6310 compatibles
On Tue, Aug 20, 2019 at 1:36 PM Krzysztof Kozlowski wrote: > > On Tue, 20 Aug 2019 at 18:59, Rob Herring wrote: > > > > On Tue, Aug 20, 2019 at 10:35 AM Krzysztof Kozlowski > > wrote: > > > > > > Add the compatibles for Kontron i.MX6UL N6310 SoM and boards. > > > > > > Signed-off-by: Krzysztof Kozlowski > > > > > > --- > > > > > > Changes since v5: > > > New patch > > > --- > > > Documentation/devicetree/bindings/arm/fsl.yaml | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml > > > b/Documentation/devicetree/bindings/arm/fsl.yaml > > > index 7294ac36f4c0..d07b3c06d7cf 100644 > > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > > > @@ -161,6 +161,9 @@ properties: > > > items: > > >- enum: > > >- fsl,imx6ul-14x14-evk # i.MX6 UltraLite 14x14 EVK > > > Board > > > + - kontron,imx6ul-n6310-som # Kontron N6310 SOM > > > + - kontron,imx6ul-n6310-s# Kontron N6310 S Board > > > + - kontron,imx6ul-n6310-s-43 # Kontron N6310 S 43 Board > > > > This doesn't match what is in your dts files. Run 'make dtbs_check' and see. > > You mean the name does not match? I thought that '#' is a comment in YAML... No, the number of compatible strings is the problem. > The dtbs_check fail on missing dt-mk-schema. Any reason why it is not > in the scripts? Because it is not just that script, but the whole project of scripts, schemas and meta-schemas. Read the instructions in Documentation/devicetree/writing-schema.md(.rst in next). Rob
Re: [PATCH v6 3/4] dt-bindings: arm: fsl: Add Kontron i.MX6UL N6310 compatibles
On Tue, 20 Aug 2019 at 18:59, Rob Herring wrote: > > On Tue, Aug 20, 2019 at 10:35 AM Krzysztof Kozlowski wrote: > > > > Add the compatibles for Kontron i.MX6UL N6310 SoM and boards. > > > > Signed-off-by: Krzysztof Kozlowski > > > > --- > > > > Changes since v5: > > New patch > > --- > > Documentation/devicetree/bindings/arm/fsl.yaml | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml > > b/Documentation/devicetree/bindings/arm/fsl.yaml > > index 7294ac36f4c0..d07b3c06d7cf 100644 > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > > @@ -161,6 +161,9 @@ properties: > > items: > >- enum: > >- fsl,imx6ul-14x14-evk # i.MX6 UltraLite 14x14 EVK Board > > + - kontron,imx6ul-n6310-som # Kontron N6310 SOM > > + - kontron,imx6ul-n6310-s# Kontron N6310 S Board > > + - kontron,imx6ul-n6310-s-43 # Kontron N6310 S 43 Board > > This doesn't match what is in your dts files. Run 'make dtbs_check' and see. You mean the name does not match? I thought that '#' is a comment in YAML... The dtbs_check fail on missing dt-mk-schema. Any reason why it is not in the scripts? Best regards, Krzysztof
Re: [PATCH v6 3/4] dt-bindings: arm: fsl: Add Kontron i.MX6UL N6310 compatibles
On Tue, Aug 20, 2019 at 10:35 AM Krzysztof Kozlowski wrote: > > Add the compatibles for Kontron i.MX6UL N6310 SoM and boards. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v5: > New patch > --- > Documentation/devicetree/bindings/arm/fsl.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml > b/Documentation/devicetree/bindings/arm/fsl.yaml > index 7294ac36f4c0..d07b3c06d7cf 100644 > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > @@ -161,6 +161,9 @@ properties: > items: >- enum: >- fsl,imx6ul-14x14-evk # i.MX6 UltraLite 14x14 EVK Board > + - kontron,imx6ul-n6310-som # Kontron N6310 SOM > + - kontron,imx6ul-n6310-s# Kontron N6310 S Board > + - kontron,imx6ul-n6310-s-43 # Kontron N6310 S 43 Board This doesn't match what is in your dts files. Run 'make dtbs_check' and see. >- const: fsl,imx6ul > >- description: i.MX6ULL based Boards > -- > 2.7.4 >
[PATCH v6 3/4] dt-bindings: arm: fsl: Add Kontron i.MX6UL N6310 compatibles
Add the compatibles for Kontron i.MX6UL N6310 SoM and boards. Signed-off-by: Krzysztof Kozlowski --- Changes since v5: New patch --- Documentation/devicetree/bindings/arm/fsl.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml index 7294ac36f4c0..d07b3c06d7cf 100644 --- a/Documentation/devicetree/bindings/arm/fsl.yaml +++ b/Documentation/devicetree/bindings/arm/fsl.yaml @@ -161,6 +161,9 @@ properties: items: - enum: - fsl,imx6ul-14x14-evk # i.MX6 UltraLite 14x14 EVK Board + - kontron,imx6ul-n6310-som # Kontron N6310 SOM + - kontron,imx6ul-n6310-s# Kontron N6310 S Board + - kontron,imx6ul-n6310-s-43 # Kontron N6310 S 43 Board - const: fsl,imx6ul - description: i.MX6ULL based Boards -- 2.7.4
