Re: [PATCH v8 0/5] Support for Qualcomm UFS QMP PHY on SDM845
On Thu 30 Aug 03:44 PDT 2018, Vivek Gautam wrote: > On Thu, Aug 30, 2018 at 11:46 AM Bjorn Andersson > wrote: > > > > On Tue 31 Jul 03:09 PDT 2018, Can Guo wrote: > > > > > This patch series adds support for UFS QMP PHY on SDM845 and the > > > compatible string for it. This patch series depends on the current > > > proposed QMP V3 USB3 UNI PHY support for sdm845 driver [1], on > > > the DT bindings for the QMP V3 USB3 PHYs based dirver [2], and also > > > rebased on updated pipe_clk initialization sequence [3]. This series > > > can only be merged once the dependent patches do. > > > [1] > > > http://lists-archives.com/linux-kernel/29071659-dt-bindings-phy-qcom-qmp-update-bindings-for-sdm845.html > > > [2] > > > http://lists-archives.com/linux-kernel/29071660-phy-qcom-qmp-add-qmp-v3-usb3-uni-phy-support-for-sdm845.html > > > [3] https://patchwork.kernel.org/patch/10376551/ > > > > > > > Hi Can, > > > > We still have the issue that the older non-QMP phy driver takes a direct > > call to ufs_qcom_phy_set_tx_lane_enable(), which means that pointing > > UFSHCD to this phy implementation results in a kernel panic. > > Hi Bjorn, > > I have a series that removes couple of these function calls - > ufs_qcom_phy_set_tx_lane_enable(), and > ufs_qcom_phy_save_controller_version() from ufs-qcom, and > make phy-qcom-ufs-qmp-20nm as broken. > I can post it out if that sounds okay. > That sounds really good, please do sent that out. Regards, Bjorn
Re: [PATCH v8 0/5] Support for Qualcomm UFS QMP PHY on SDM845
On Thu, Aug 30, 2018 at 11:46 AM Bjorn Andersson wrote: > > On Tue 31 Jul 03:09 PDT 2018, Can Guo wrote: > > > This patch series adds support for UFS QMP PHY on SDM845 and the > > compatible string for it. This patch series depends on the current > > proposed QMP V3 USB3 UNI PHY support for sdm845 driver [1], on > > the DT bindings for the QMP V3 USB3 PHYs based dirver [2], and also > > rebased on updated pipe_clk initialization sequence [3]. This series > > can only be merged once the dependent patches do. > > [1] > > http://lists-archives.com/linux-kernel/29071659-dt-bindings-phy-qcom-qmp-update-bindings-for-sdm845.html > > [2] > > http://lists-archives.com/linux-kernel/29071660-phy-qcom-qmp-add-qmp-v3-usb3-uni-phy-support-for-sdm845.html > > [3] https://patchwork.kernel.org/patch/10376551/ > > > > Hi Can, > > We still have the issue that the older non-QMP phy driver takes a direct > call to ufs_qcom_phy_set_tx_lane_enable(), which means that pointing > UFSHCD to this phy implementation results in a kernel panic. Hi Bjorn, I have a series that removes couple of these function calls - ufs_qcom_phy_set_tx_lane_enable(), and ufs_qcom_phy_save_controller_version() from ufs-qcom, and make phy-qcom-ufs-qmp-20nm as broken. I can post it out if that sounds okay. Best regards Vivek [snip] -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
Re: [PATCH v8 0/5] Support for Qualcomm UFS QMP PHY on SDM845
On Tue 31 Jul 03:09 PDT 2018, Can Guo wrote: > This patch series adds support for UFS QMP PHY on SDM845 and the > compatible string for it. This patch series depends on the current > proposed QMP V3 USB3 UNI PHY support for sdm845 driver [1], on > the DT bindings for the QMP V3 USB3 PHYs based dirver [2], and also > rebased on updated pipe_clk initialization sequence [3]. This series > can only be merged once the dependent patches do. > [1] > http://lists-archives.com/linux-kernel/29071659-dt-bindings-phy-qcom-qmp-update-bindings-for-sdm845.html > [2] > http://lists-archives.com/linux-kernel/29071660-phy-qcom-qmp-add-qmp-v3-usb3-uni-phy-support-for-sdm845.html > [3] https://patchwork.kernel.org/patch/10376551/ > Hi Can, We still have the issue that the older non-QMP phy driver takes a direct call to ufs_qcom_phy_set_tx_lane_enable(), which means that pointing UFSHCD to this phy implementation results in a kernel panic. I do however think this series is good in itself and would like to see it merged. As any fix for this problem would be done on top of the patches in this series. Tested-by: Bjorn Andersson Regards, Bjorn
Re: [PATCH v8 0/5] Support for Qualcomm UFS QMP PHY on SDM845
On 2018-07-31 18:09, Can Guo wrote: This patch series adds support for UFS QMP PHY on SDM845 and the compatible string for it. This patch series depends on the current proposed QMP V3 USB3 UNI PHY support for sdm845 driver [1], on the DT bindings for the QMP V3 USB3 PHYs based dirver [2], and also rebased on updated pipe_clk initialization sequence [3]. This series can only be merged once the dependent patches do. [1] http://lists-archives.com/linux-kernel/29071659-dt-bindings-phy-qcom-qmp-update-bindings-for-sdm845.html [2] http://lists-archives.com/linux-kernel/29071660-phy-qcom-qmp-add-qmp-v3-usb3-uni-phy-support-for-sdm845.html [3] https://patchwork.kernel.org/patch/10376551/ Changes since v7: - Add one new change to update UFS PHY power on sequence - Incorporated review comments from Evan, Vivek and Manu. Changes since v6: - Add one new change to clean up some structs and field - Updates the PHY power control sequence. - Incorporated review comments from Vivek and Manu. Changes since v5: - Updates the PHY power control sequence. - Updates UFS PHY power on condition check. Changes since v4: - Adds 'ref_aux' clock back to SDM845 UFS PHY clock list. - Power on PHY before serdes configuration starts. - Updates the UFS PHY initialization sequence. - Updates a few UFS PHY registers. - Incorporated review comments from Vivek and Manu. Changes since v3: - Incorporated review comments from Vivek and Rob. Changes since v2: - Incorporated review comments from Vivek and Rob. - Remove "ref_aux" from sdm845 ufs phy clock list structure. Changes since v1: - Incorporated review comments from Vivek and Manu. - Update the commit title of patch 2. Can Guo (5): phy: Update PHY power control sequence phy: General struct and field cleanup phy: Add QMP phy based UFS phy support for sdm845 scsi: ufs: Power on phy after it is initialized dt-bindings: phy-qcom-qmp: Add UFS phy compatible string for sdm845 .../devicetree/bindings/phy/qcom-qmp-phy.txt | 4 +- drivers/phy/qualcomm/phy-qcom-qmp.c| 216 +++-- drivers/phy/qualcomm/phy-qcom-qmp.h| 15 ++ drivers/scsi/ufs/ufs-qcom.c| 4 +- drivers/scsi/ufs/ufs-qcom.h| 1 + 5 files changed, 219 insertions(+), 21 deletions(-)
[PATCH v8 0/5] Support for Qualcomm UFS QMP PHY on SDM845
This patch series adds support for UFS QMP PHY on SDM845 and the compatible string for it. This patch series depends on the current proposed QMP V3 USB3 UNI PHY support for sdm845 driver [1], on the DT bindings for the QMP V3 USB3 PHYs based dirver [2], and also rebased on updated pipe_clk initialization sequence [3]. This series can only be merged once the dependent patches do. [1] http://lists-archives.com/linux-kernel/29071659-dt-bindings-phy-qcom-qmp-update-bindings-for-sdm845.html [2] http://lists-archives.com/linux-kernel/29071660-phy-qcom-qmp-add-qmp-v3-usb3-uni-phy-support-for-sdm845.html [3] https://patchwork.kernel.org/patch/10376551/ Changes since v7: - Add one new change to update UFS PHY power on sequence - Incorporated review comments from Evan, Vivek and Manu. Changes since v6: - Add one new change to clean up some structs and field - Updates the PHY power control sequence. - Incorporated review comments from Vivek and Manu. Changes since v5: - Updates the PHY power control sequence. - Updates UFS PHY power on condition check. Changes since v4: - Adds 'ref_aux' clock back to SDM845 UFS PHY clock list. - Power on PHY before serdes configuration starts. - Updates the UFS PHY initialization sequence. - Updates a few UFS PHY registers. - Incorporated review comments from Vivek and Manu. Changes since v3: - Incorporated review comments from Vivek and Rob. Changes since v2: - Incorporated review comments from Vivek and Rob. - Remove "ref_aux" from sdm845 ufs phy clock list structure. Changes since v1: - Incorporated review comments from Vivek and Manu. - Update the commit title of patch 2. Can Guo (5): phy: Update PHY power control sequence phy: General struct and field cleanup phy: Add QMP phy based UFS phy support for sdm845 scsi: ufs: Power on phy after it is initialized dt-bindings: phy-qcom-qmp: Add UFS phy compatible string for sdm845 .../devicetree/bindings/phy/qcom-qmp-phy.txt | 4 +- drivers/phy/qualcomm/phy-qcom-qmp.c| 216 +++-- drivers/phy/qualcomm/phy-qcom-qmp.h| 15 ++ drivers/scsi/ufs/ufs-qcom.c| 4 +- drivers/scsi/ufs/ufs-qcom.h| 1 + 5 files changed, 219 insertions(+), 21 deletions(-) -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
