RE: [PATCH v9 0/9] Goodix touchscreen enhancements
> -Original Message- > From: Karsten Merker [mailto:mer...@debian.org] > Sent: 26 October, 2015 20:21 > To: Bastien Nocera; Tirdea, Irina > Cc: Dmitry Torokhov; Aleksei Mamlin; Karsten Merker; > linux-in...@vger.kernel.org; Mark Rutland; Purdila, Octavian; linux- > ker...@vger.kernel.org; devicet...@vger.kernel.org > Subject: Re: [PATCH v9 0/9] Goodix touchscreen enhancements > > On Mon, Oct 26, 2015 at 04:06:29PM +0100, Bastien Nocera wrote: > > On Mon, 2015-10-12 at 18:24 +0300, Irina Tirdea wrote: > > > > v9 only adds GPIOLIB dependency in Kconfig for patch 2: > > > "Input: goodix - reset device at init". There are no other code > > > changes from v8. > > > > > > Thanks for testing these changes, Bastien and Aleksei! > > > > > > Karsten, there is no need to rebase your series on top of v9. > > > > Are we waiting on anything else before merging this? I'd like it to be > > scheduled to be merged so I can start focusing on the subsequent and > > dependent patches for that same driver. > > Hello, > > AFAICS there is one open point (cf. > http://www.spinics.net/lists/linux-input/msg41567.html) which > Irina wanted to address in a v10 of the patchset (cf. > http://www.spinics.net/lists/linux-input/msg41642.html). > > Irina, how are your plans regarding the v10? It would be really > nice if the patches could go into kernel 4.4, but the merge > window opens on the coming weekend, so there is not much time > left. I can send v10 with the change mentioned above by the end of this week. However, as Dmitry already mentioned, there is another issue with the gpio ACPI layer that is blocking the entire patchset. > > Bastien, did you have time to look at v3 of the axis > swapping/inversion set? > (http://www.spinics.net/lists/linux-input/msg41628.html) > You had acked v2, but I had to do some small changes to address > Irina's review comments after you had acked it, so I didn't want > to carry your "acked-by" on to v3 without an ok from you. > > Regards, > Karsten > -- > Gem. Par. 28 Abs. 4 Bundesdatenschutzgesetz widerspreche ich der Nutzung > sowie der Weitergabe meiner personenbezogenen Daten für Zwecke der > Werbung sowie der Markt- oder Meinungsforschung.
RE: [PATCH v9 0/9] Goodix touchscreen enhancements
> -Original Message- > From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] > Sent: 27 October, 2015 1:33 > To: Karsten Merker > Cc: Bastien Nocera; Tirdea, Irina; Aleksei Mamlin; > linux-in...@vger.kernel.org; Mark Rutland; Purdila, Octavian; linux- > ker...@vger.kernel.org; devicet...@vger.kernel.org > Subject: Re: [PATCH v9 0/9] Goodix touchscreen enhancements > > On Mon, Oct 26, 2015 at 07:21:12PM +0100, Karsten Merker wrote: > > On Mon, Oct 26, 2015 at 04:06:29PM +0100, Bastien Nocera wrote: > > > On Mon, 2015-10-12 at 18:24 +0300, Irina Tirdea wrote: > > > > > > v9 only adds GPIOLIB dependency in Kconfig for patch 2: > > > > "Input: goodix - reset device at init". There are no other code > > > > changes from v8. > > > > > > > > Thanks for testing these changes, Bastien and Aleksei! > > > > > > > > Karsten, there is no need to rebase your series on top of v9. > > > > > > Are we waiting on anything else before merging this? I'd like it to be > > > scheduled to be merged so I can start focusing on the subsequent and > > > dependent patches for that same driver. > > > > Hello, > > > > AFAICS there is one open point (cf. > > http://www.spinics.net/lists/linux-input/msg41567.html) which > > Irina wanted to address in a v10 of the patchset (cf. > > http://www.spinics.net/lists/linux-input/msg41642.html). > > There is also the whole thing about insane handling of named gpios in > ACPI layer, which stops me from merging the reset code since these gpios > should be marked as optional and we should stop ignoring errors coming > from gpiolib. The ACPI layer change is quite complex, since it includes changing the drivers that use the gpio API before removing the fallback to indexed ACPI. Not sure that will not also break current drivers that already count on this fallback. Unfortunately, I do not have the time right now to get involved in fixing the ACPI core myself. Dmitry, is there anything I can do in the driver to get these patches merged? I could go back to using indexed gpios and add an additional property to specify if irq can be used as output or not (as suggested in one of the previous reviews). Thanks, Irina > > Thanks. > > -- > Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH v9 0/9] Goodix touchscreen enhancements
> -Original Message- > From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] > Sent: 27 October, 2015 1:33 > To: Karsten Merker > Cc: Bastien Nocera; Tirdea, Irina; Aleksei Mamlin; > linux-in...@vger.kernel.org; Mark Rutland; Purdila, Octavian; linux- > ker...@vger.kernel.org; devicet...@vger.kernel.org > Subject: Re: [PATCH v9 0/9] Goodix touchscreen enhancements > > On Mon, Oct 26, 2015 at 07:21:12PM +0100, Karsten Merker wrote: > > On Mon, Oct 26, 2015 at 04:06:29PM +0100, Bastien Nocera wrote: > > > On Mon, 2015-10-12 at 18:24 +0300, Irina Tirdea wrote: > > > > > > v9 only adds GPIOLIB dependency in Kconfig for patch 2: > > > > "Input: goodix - reset device at init". There are no other code > > > > changes from v8. > > > > > > > > Thanks for testing these changes, Bastien and Aleksei! > > > > > > > > Karsten, there is no need to rebase your series on top of v9. > > > > > > Are we waiting on anything else before merging this? I'd like it to be > > > scheduled to be merged so I can start focusing on the subsequent and > > > dependent patches for that same driver. > > > > Hello, > > > > AFAICS there is one open point (cf. > > http://www.spinics.net/lists/linux-input/msg41567.html) which > > Irina wanted to address in a v10 of the patchset (cf. > > http://www.spinics.net/lists/linux-input/msg41642.html). > > There is also the whole thing about insane handling of named gpios in > ACPI layer, which stops me from merging the reset code since these gpios > should be marked as optional and we should stop ignoring errors coming > from gpiolib. The ACPI layer change is quite complex, since it includes changing the drivers that use the gpio API before removing the fallback to indexed ACPI. Not sure that will not also break current drivers that already count on this fallback. Unfortunately, I do not have the time right now to get involved in fixing the ACPI core myself. Dmitry, is there anything I can do in the driver to get these patches merged? I could go back to using indexed gpios and add an additional property to specify if irq can be used as output or not (as suggested in one of the previous reviews). Thanks, Irina > > Thanks. > > -- > Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH v9 0/9] Goodix touchscreen enhancements
> -Original Message- > From: Karsten Merker [mailto:mer...@debian.org] > Sent: 26 October, 2015 20:21 > To: Bastien Nocera; Tirdea, Irina > Cc: Dmitry Torokhov; Aleksei Mamlin; Karsten Merker; > linux-in...@vger.kernel.org; Mark Rutland; Purdila, Octavian; linux- > ker...@vger.kernel.org; devicet...@vger.kernel.org > Subject: Re: [PATCH v9 0/9] Goodix touchscreen enhancements > > On Mon, Oct 26, 2015 at 04:06:29PM +0100, Bastien Nocera wrote: > > On Mon, 2015-10-12 at 18:24 +0300, Irina Tirdea wrote: > > > > v9 only adds GPIOLIB dependency in Kconfig for patch 2: > > > "Input: goodix - reset device at init". There are no other code > > > changes from v8. > > > > > > Thanks for testing these changes, Bastien and Aleksei! > > > > > > Karsten, there is no need to rebase your series on top of v9. > > > > Are we waiting on anything else before merging this? I'd like it to be > > scheduled to be merged so I can start focusing on the subsequent and > > dependent patches for that same driver. > > Hello, > > AFAICS there is one open point (cf. > http://www.spinics.net/lists/linux-input/msg41567.html) which > Irina wanted to address in a v10 of the patchset (cf. > http://www.spinics.net/lists/linux-input/msg41642.html). > > Irina, how are your plans regarding the v10? It would be really > nice if the patches could go into kernel 4.4, but the merge > window opens on the coming weekend, so there is not much time > left. I can send v10 with the change mentioned above by the end of this week. However, as Dmitry already mentioned, there is another issue with the gpio ACPI layer that is blocking the entire patchset. > > Bastien, did you have time to look at v3 of the axis > swapping/inversion set? > (http://www.spinics.net/lists/linux-input/msg41628.html) > You had acked v2, but I had to do some small changes to address > Irina's review comments after you had acked it, so I didn't want > to carry your "acked-by" on to v3 without an ok from you. > > Regards, > Karsten > -- > Gem. Par. 28 Abs. 4 Bundesdatenschutzgesetz widerspreche ich der Nutzung > sowie der Weitergabe meiner personenbezogenen Daten für Zwecke der > Werbung sowie der Markt- oder Meinungsforschung.
Re: [PATCH v9 0/9] Goodix touchscreen enhancements
On Mon, Oct 26, 2015 at 07:21:12PM +0100, Karsten Merker wrote: > On Mon, Oct 26, 2015 at 04:06:29PM +0100, Bastien Nocera wrote: > > On Mon, 2015-10-12 at 18:24 +0300, Irina Tirdea wrote: > > > > v9 only adds GPIOLIB dependency in Kconfig for patch 2: > > > "Input: goodix - reset device at init". There are no other code > > > changes from v8. > > > > > > Thanks for testing these changes, Bastien and Aleksei! > > > > > > Karsten, there is no need to rebase your series on top of v9. > > > > Are we waiting on anything else before merging this? I'd like it to be > > scheduled to be merged so I can start focusing on the subsequent and > > dependent patches for that same driver. > > Hello, > > AFAICS there is one open point (cf. > http://www.spinics.net/lists/linux-input/msg41567.html) which > Irina wanted to address in a v10 of the patchset (cf. > http://www.spinics.net/lists/linux-input/msg41642.html). There is also the whole thing about insane handling of named gpios in ACPI layer, which stops me from merging the reset code since these gpios should be marked as optional and we should stop ignoring errors coming from gpiolib. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v9 0/9] Goodix touchscreen enhancements
On Mon, 2015-10-26 at 19:21 +0100, Karsten Merker wrote: > On Mon, Oct 26, 2015 at 04:06:29PM +0100, Bastien Nocera wrote: > > On Mon, 2015-10-12 at 18:24 +0300, Irina Tirdea wrote: > > > > v9 only adds GPIOLIB dependency in Kconfig for patch 2: > > > "Input: goodix - reset device at init". There are no other code > > > changes from v8. > > > > > > Thanks for testing these changes, Bastien and Aleksei! > > > > > > Karsten, there is no need to rebase your series on top of v9. > > > > Are we waiting on anything else before merging this? I'd like it to > > be > > scheduled to be merged so I can start focusing on the subsequent > > and > > dependent patches for that same driver. > > Hello, > > AFAICS there is one open point (cf. > http://www.spinics.net/lists/linux-input/msg41567.html) which > Irina wanted to address in a v10 of the patchset (cf. > http://www.spinics.net/lists/linux-input/msg41642.html). > > Irina, how are your plans regarding the v10? It would be really > nice if the patches could go into kernel 4.4, but the merge > window opens on the coming weekend, so there is not much time > left. > > Bastien, did you have time to look at v3 of the axis > swapping/inversion set? > (http://www.spinics.net/lists/linux-input/msg41628.html) > You had acked v2, but I had to do some small changes to address > Irina's review comments after you had acked it, so I didn't want > to carry your "acked-by" on to v3 without an ok from you. I was waiting on at least Irina's patches being merged before testing your patches again. I have limited time to do testing on this (I have plenty more hardware that's sitting unloved here), and wanted to minimise the amount of time I'd spend testing it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v9 0/9] Goodix touchscreen enhancements
Hey, On Mon, 2015-10-12 at 18:24 +0300, Irina Tirdea wrote: > v9 only adds GPIOLIB dependency in Kconfig for patch 2: > "Input: goodix - reset device at init". There are no other code > changes from v8. > > Thanks for testing these changes, Bastien and Aleksei! > > Karsten, there is no need to rebase your series on top of v9. Are we waiting on anything else before merging this? I'd like it to be scheduled to be merged so I can start focusing on the subsequent and dependent patches for that same driver. Cheers -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v9 0/9] Goodix touchscreen enhancements
On Mon, Oct 26, 2015 at 07:21:12PM +0100, Karsten Merker wrote: > On Mon, Oct 26, 2015 at 04:06:29PM +0100, Bastien Nocera wrote: > > On Mon, 2015-10-12 at 18:24 +0300, Irina Tirdea wrote: > > > > v9 only adds GPIOLIB dependency in Kconfig for patch 2: > > > "Input: goodix - reset device at init". There are no other code > > > changes from v8. > > > > > > Thanks for testing these changes, Bastien and Aleksei! > > > > > > Karsten, there is no need to rebase your series on top of v9. > > > > Are we waiting on anything else before merging this? I'd like it to be > > scheduled to be merged so I can start focusing on the subsequent and > > dependent patches for that same driver. > > Hello, > > AFAICS there is one open point (cf. > http://www.spinics.net/lists/linux-input/msg41567.html) which > Irina wanted to address in a v10 of the patchset (cf. > http://www.spinics.net/lists/linux-input/msg41642.html). There is also the whole thing about insane handling of named gpios in ACPI layer, which stops me from merging the reset code since these gpios should be marked as optional and we should stop ignoring errors coming from gpiolib. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v9 0/9] Goodix touchscreen enhancements
On Mon, 2015-10-26 at 19:21 +0100, Karsten Merker wrote: > On Mon, Oct 26, 2015 at 04:06:29PM +0100, Bastien Nocera wrote: > > On Mon, 2015-10-12 at 18:24 +0300, Irina Tirdea wrote: > > > > v9 only adds GPIOLIB dependency in Kconfig for patch 2: > > > "Input: goodix - reset device at init". There are no other code > > > changes from v8. > > > > > > Thanks for testing these changes, Bastien and Aleksei! > > > > > > Karsten, there is no need to rebase your series on top of v9. > > > > Are we waiting on anything else before merging this? I'd like it to > > be > > scheduled to be merged so I can start focusing on the subsequent > > and > > dependent patches for that same driver. > > Hello, > > AFAICS there is one open point (cf. > http://www.spinics.net/lists/linux-input/msg41567.html) which > Irina wanted to address in a v10 of the patchset (cf. > http://www.spinics.net/lists/linux-input/msg41642.html). > > Irina, how are your plans regarding the v10? It would be really > nice if the patches could go into kernel 4.4, but the merge > window opens on the coming weekend, so there is not much time > left. > > Bastien, did you have time to look at v3 of the axis > swapping/inversion set? > (http://www.spinics.net/lists/linux-input/msg41628.html) > You had acked v2, but I had to do some small changes to address > Irina's review comments after you had acked it, so I didn't want > to carry your "acked-by" on to v3 without an ok from you. I was waiting on at least Irina's patches being merged before testing your patches again. I have limited time to do testing on this (I have plenty more hardware that's sitting unloved here), and wanted to minimise the amount of time I'd spend testing it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v9 0/9] Goodix touchscreen enhancements
Hey, On Mon, 2015-10-12 at 18:24 +0300, Irina Tirdea wrote: > v9 only adds GPIOLIB dependency in Kconfig for patch 2: > "Input: goodix - reset device at init". There are no other code > changes from v8. > > Thanks for testing these changes, Bastien and Aleksei! > > Karsten, there is no need to rebase your series on top of v9. Are we waiting on anything else before merging this? I'd like it to be scheduled to be merged so I can start focusing on the subsequent and dependent patches for that same driver. Cheers -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v9 0/9] Goodix touchscreen enhancements
v9 only adds GPIOLIB dependency in Kconfig for patch 2: "Input: goodix - reset device at init". There are no other code changes from v8. Thanks for testing these changes, Bastien and Aleksei! Karsten, there is no need to rebase your series on top of v9. Thanks, Irina Changes in v9: - add GPIOLIB to driver dependencies - add Tested-by tag from Bastien and Aleksei Changes in v8: - only allow new functionality for devices that declare named gpios (using _DSD properties in ACPI or named DT properties) Changes in v7: - add dmi quirk to skip gpio pins setup and functionality that depends on them for Onda v975w, WinBook TW100 and WinBook TW700. - add support for named gpio pins - rework the runtime pm patch to fix a couple of issues - sort includes using inverse Xmas tree ordering Changes in v6: - skip runtime power manangent calls in open/close if the device ACPI/DT configuration does not declare interrupt and reset gpio pins. - reset the device before starting i2c communication - add Bastien's ack to the first 2 patches Changes in v5: - add some more style cleanup (reorder includes, use error instead of ret for return values) - add runtime power management patch Changes in v4: - use dmi quirk to determine the order of irq and reset pins - use actual config length depending on device - add sysfs interface to dump config - initialize esd timeout from ACPI/DT properly Changes in v3: - dropped the first 3 patches that got merged - handle -EPROBE_DEFER and -ENOENT for gpio pins - skip functionality depending on the gpio pins if the pins are not properly initialized from ACPI/DT (reset, write config, power management, ESD) - dropped #ifdef CONFIG_PM_SLEEP and annotated with __maybe_unused instead - use sysfs property to set ESD timeout instead of ACPI/DT property - use request_firmware_nowait to read configuration firmware and use defaults if firmware is not found - use ACPI IDs to determine the order of the GPIO pins in the ACPI tables (interrupt pin first or reset pin first) Changes in v2: - use request_firmware instead of ACPI/DT property for config - dropped "input: goodix: add ACPI IDs for GT911 and GT9271" patch - add ACPI DSDT excerpt in commit message where necessary - add comments for suspend/resume sleep values - dropped the checkpatch fixes that did not make sense - added Bastien's ack to the first patch Irina Tirdea (9): Input: goodix - use actual config length for each device type Input: goodix - reset device at init Input: goodix - write configuration data to device Input: goodix - add power management support Input: goodix - use goodix_i2c_write_u8 instead of i2c_master_send Input: goodix - add support for ESD Input: goodix - add sysfs interface to dump config Input: goodix - add runtime power management support Input: goodix - sort includes using inverse Xmas tree order .../bindings/input/touchscreen/goodix.txt | 11 + drivers/input/touchscreen/Kconfig | 1 + drivers/input/touchscreen/goodix.c | 766 +++-- 3 files changed, 733 insertions(+), 45 deletions(-) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v9 0/9] Goodix touchscreen enhancements
v9 only adds GPIOLIB dependency in Kconfig for patch 2: "Input: goodix - reset device at init". There are no other code changes from v8. Thanks for testing these changes, Bastien and Aleksei! Karsten, there is no need to rebase your series on top of v9. Thanks, Irina Changes in v9: - add GPIOLIB to driver dependencies - add Tested-by tag from Bastien and Aleksei Changes in v8: - only allow new functionality for devices that declare named gpios (using _DSD properties in ACPI or named DT properties) Changes in v7: - add dmi quirk to skip gpio pins setup and functionality that depends on them for Onda v975w, WinBook TW100 and WinBook TW700. - add support for named gpio pins - rework the runtime pm patch to fix a couple of issues - sort includes using inverse Xmas tree ordering Changes in v6: - skip runtime power manangent calls in open/close if the device ACPI/DT configuration does not declare interrupt and reset gpio pins. - reset the device before starting i2c communication - add Bastien's ack to the first 2 patches Changes in v5: - add some more style cleanup (reorder includes, use error instead of ret for return values) - add runtime power management patch Changes in v4: - use dmi quirk to determine the order of irq and reset pins - use actual config length depending on device - add sysfs interface to dump config - initialize esd timeout from ACPI/DT properly Changes in v3: - dropped the first 3 patches that got merged - handle -EPROBE_DEFER and -ENOENT for gpio pins - skip functionality depending on the gpio pins if the pins are not properly initialized from ACPI/DT (reset, write config, power management, ESD) - dropped #ifdef CONFIG_PM_SLEEP and annotated with __maybe_unused instead - use sysfs property to set ESD timeout instead of ACPI/DT property - use request_firmware_nowait to read configuration firmware and use defaults if firmware is not found - use ACPI IDs to determine the order of the GPIO pins in the ACPI tables (interrupt pin first or reset pin first) Changes in v2: - use request_firmware instead of ACPI/DT property for config - dropped "input: goodix: add ACPI IDs for GT911 and GT9271" patch - add ACPI DSDT excerpt in commit message where necessary - add comments for suspend/resume sleep values - dropped the checkpatch fixes that did not make sense - added Bastien's ack to the first patch Irina Tirdea (9): Input: goodix - use actual config length for each device type Input: goodix - reset device at init Input: goodix - write configuration data to device Input: goodix - add power management support Input: goodix - use goodix_i2c_write_u8 instead of i2c_master_send Input: goodix - add support for ESD Input: goodix - add sysfs interface to dump config Input: goodix - add runtime power management support Input: goodix - sort includes using inverse Xmas tree order .../bindings/input/touchscreen/goodix.txt | 11 + drivers/input/touchscreen/Kconfig | 1 + drivers/input/touchscreen/goodix.c | 766 +++-- 3 files changed, 733 insertions(+), 45 deletions(-) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
