Re: [PATCH v9 02/11] dt-bindings: power: supply: add DT bindings for max77650

2019-04-17 Thread Sebastian Reichel
Hi,

On Thu, Apr 11, 2019 at 02:42:03PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski 
> 
> Add the DT binding document for the battery charger module of max77650.
> 
> Signed-off-by: Bartosz Golaszewski 
> ---
>  .../power/supply/max77650-charger.txt | 28 +++
>  1 file changed, 28 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/power/supply/max77650-charger.txt
> 
> diff --git 
> a/Documentation/devicetree/bindings/power/supply/max77650-charger.txt 
> b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt
> new file mode 100644
> index ..821a2240e70f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt
> @@ -0,0 +1,28 @@
> +Battery charger driver for MAX77650 PMIC from Maxim Integrated.
> +
> +This module is part of the MAX77650 MFD device. For more details
> +see Documentation/devicetree/bindings/mfd/max77650.txt.
> +
> +The charger is represented as a sub-node of the PMIC node on the device tree.
> +
> +Required properties:
> +
> +- compatible:Must be "maxim,max77650-charger"
> +
> +Optional properties:
> +
> +- input-voltage-min-microvolt:   Minimum CHGIN regulation voltage. Must 
> be one
> + of: 400, 410, 420, 430,
> + 440, 450, 460, 470.
> +- input-current-limit-microamp:  CHGIN input current limit (in 
> microamps). Must
> + be one of: 95000, 19, 285000, 38,
> + 475000.

The binding looks good to me.

> +Example:
> +
> +
> + charger {
> + compatible = "maxim,max77650-charger";
> + min-microvolt = <420>;
> + curr-lim-microamp = <285000>;
> + };

The example does not match the binding.

-- Sebastian


signature.asc
Description: PGP signature


[PATCH v9 02/11] dt-bindings: power: supply: add DT bindings for max77650

2019-04-11 Thread Bartosz Golaszewski
From: Bartosz Golaszewski 

Add the DT binding document for the battery charger module of max77650.

Signed-off-by: Bartosz Golaszewski 
---
 .../power/supply/max77650-charger.txt | 28 +++
 1 file changed, 28 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/power/supply/max77650-charger.txt

diff --git 
a/Documentation/devicetree/bindings/power/supply/max77650-charger.txt 
b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt
new file mode 100644
index ..821a2240e70f
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt
@@ -0,0 +1,28 @@
+Battery charger driver for MAX77650 PMIC from Maxim Integrated.
+
+This module is part of the MAX77650 MFD device. For more details
+see Documentation/devicetree/bindings/mfd/max77650.txt.
+
+The charger is represented as a sub-node of the PMIC node on the device tree.
+
+Required properties:
+
+- compatible:  Must be "maxim,max77650-charger"
+
+Optional properties:
+
+- input-voltage-min-microvolt: Minimum CHGIN regulation voltage. Must be one
+   of: 400, 410, 420, 430,
+   440, 450, 460, 470.
+- input-current-limit-microamp:CHGIN input current limit (in 
microamps). Must
+   be one of: 95000, 19, 285000, 38,
+   475000.
+
+Example:
+
+
+   charger {
+   compatible = "maxim,max77650-charger";
+   min-microvolt = <420>;
+   curr-lim-microamp = <285000>;
+   };
-- 
2.21.0