Re: [PATCH v9 02/22] pinctrl: tegra: Flush pinctrl writes during resume

[Linus Walleij]

On Fri, Aug 16, 2019 at 9:42 PM Sowjanya Komatineni
 wrote:

> This patch adds pinctrl register read to flush all the prior pinctrl
> writes and then adds barrier for pinctrl register read to complete
> during resume to make sure all pinctrl changes are effective.
>
> Acked-by: Thierry Reding 
> Reviewed-by: Dmitry Osipenko 
> Signed-off-by: Sowjanya Komatineni 

Patch applied.

Yours,
Linus Walleij

[PATCH v9 02/22] pinctrl: tegra: Flush pinctrl writes during resume

[Sowjanya Komatineni]

This patch adds pinctrl register read to flush all the prior pinctrl
writes and then adds barrier for pinctrl register read to complete
during resume to make sure all pinctrl changes are effective.

Acked-by: Thierry Reding 
Reviewed-by: Dmitry Osipenko 
Signed-off-by: Sowjanya Komatineni 
---
 drivers/pinctrl/tegra/pinctrl-tegra.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/drivers/pinctrl/tegra/pinctrl-tegra.c 
b/drivers/pinctrl/tegra/pinctrl-tegra.c
index 5e3c00137d71..e9a7cbb9aa33 100644
--- a/drivers/pinctrl/tegra/pinctrl-tegra.c
+++ b/drivers/pinctrl/tegra/pinctrl-tegra.c
@@ -677,6 +677,10 @@ static int tegra_pinctrl_resume(struct device *dev)
writel_relaxed(*backup_regs++, regs++);
}
 
+   /* flush all the prior writes */
+   readl_relaxed(pmx->regs[0]);
+   /* wait for pinctrl register read to complete */
+   rmb();
return 0;
 }
 
-- 
2.7.4