Re: [PATCH v9 7/7] dt-bindings: ufshcd-pltfrm: Add core reset string
On 2018-09-27 23:06, Rob Herring wrote: On Thu, Sep 20, 2018 at 09:28:00PM -0700, Can Guo wrote: From: Can Guo Add core reset support string for UFS. Signed-off-by: Amit Nischal Signed-off-by: Can Guo --- Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt b/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt index c39dfef..6b697c4 100644 --- a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt +++ b/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt @@ -11,6 +11,11 @@ Required properties: "qcom,ufshc" - interrupts: - reg : +- reset : reset specifier pair consists of phandle for the reset provider + and reset lines used by this controller. It is mandatory for + QCOM SDM845 platform. +- reset-names : reset signal name strings sorted in the same order as the + resets property. It is mandatory for QCOM SDM845 platform. This already exists as of 4.19 under optional properties. (And you can't add new required properties anyways.) Thank you Rob, I also found the newly merged change from Huawei on 4.19. Then our code would need a small change to parse the new reset-names string. Optional properties: - phys : phandle to UFS PHY node @@ -64,6 +69,8 @@ Example: clocks = < 0>, < 0>, < 0>; clock-names = "core_clk", "ref_clk", "iface_clk"; freq-table-hz = <1 2>, <0 0>, <0 0>; + resets = ; + reset-names = "core_reset"; And the name should be "rst" (or omitted). Sure, got it, thank you. phys = <>; phy-names = "ufsphy"; }; -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Re: [PATCH v9 7/7] dt-bindings: ufshcd-pltfrm: Add core reset string
On 2018-09-27 23:06, Rob Herring wrote: On Thu, Sep 20, 2018 at 09:28:00PM -0700, Can Guo wrote: From: Can Guo Add core reset support string for UFS. Signed-off-by: Amit Nischal Signed-off-by: Can Guo --- Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt b/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt index c39dfef..6b697c4 100644 --- a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt +++ b/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt @@ -11,6 +11,11 @@ Required properties: "qcom,ufshc" - interrupts: - reg : +- reset : reset specifier pair consists of phandle for the reset provider + and reset lines used by this controller. It is mandatory for + QCOM SDM845 platform. +- reset-names : reset signal name strings sorted in the same order as the + resets property. It is mandatory for QCOM SDM845 platform. This already exists as of 4.19 under optional properties. (And you can't add new required properties anyways.) Thank you Rob, I also found the newly merged change from Huawei on 4.19. Then our code would need a small change to parse the new reset-names string. Optional properties: - phys : phandle to UFS PHY node @@ -64,6 +69,8 @@ Example: clocks = < 0>, < 0>, < 0>; clock-names = "core_clk", "ref_clk", "iface_clk"; freq-table-hz = <1 2>, <0 0>, <0 0>; + resets = ; + reset-names = "core_reset"; And the name should be "rst" (or omitted). Sure, got it, thank you. phys = <>; phy-names = "ufsphy"; }; -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Re: [PATCH v9 7/7] dt-bindings: ufshcd-pltfrm: Add core reset string
On Thu, Sep 20, 2018 at 09:28:00PM -0700, Can Guo wrote: > From: Can Guo > > Add core reset support string for UFS. > > Signed-off-by: Amit Nischal > Signed-off-by: Can Guo > --- > Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt > b/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt > index c39dfef..6b697c4 100644 > --- a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt > +++ b/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt > @@ -11,6 +11,11 @@ Required properties: > "qcom,ufshc" > - interrupts: > - reg : > +- reset : reset specifier pair consists of phandle for the reset > provider > + and reset lines used by this controller. It is > mandatory for > + QCOM SDM845 platform. > +- reset-names : reset signal name strings sorted in the same order as > the > + resets property. It is mandatory for QCOM SDM845 platform. This already exists as of 4.19 under optional properties. (And you can't add new required properties anyways.) > > Optional properties: > - phys : phandle to UFS PHY node > @@ -64,6 +69,8 @@ Example: > clocks = < 0>, < 0>, < 0>; > clock-names = "core_clk", "ref_clk", "iface_clk"; > freq-table-hz = <1 2>, <0 0>, <0 0>; > + resets = ; > + reset-names = "core_reset"; And the name should be "rst" (or omitted). > phys = <>; > phy-names = "ufsphy"; > }; > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >
Re: [PATCH v9 7/7] dt-bindings: ufshcd-pltfrm: Add core reset string
On Thu, Sep 20, 2018 at 09:28:00PM -0700, Can Guo wrote: > From: Can Guo > > Add core reset support string for UFS. > > Signed-off-by: Amit Nischal > Signed-off-by: Can Guo > --- > Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt > b/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt > index c39dfef..6b697c4 100644 > --- a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt > +++ b/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt > @@ -11,6 +11,11 @@ Required properties: > "qcom,ufshc" > - interrupts: > - reg : > +- reset : reset specifier pair consists of phandle for the reset > provider > + and reset lines used by this controller. It is > mandatory for > + QCOM SDM845 platform. > +- reset-names : reset signal name strings sorted in the same order as > the > + resets property. It is mandatory for QCOM SDM845 platform. This already exists as of 4.19 under optional properties. (And you can't add new required properties anyways.) > > Optional properties: > - phys : phandle to UFS PHY node > @@ -64,6 +69,8 @@ Example: > clocks = < 0>, < 0>, < 0>; > clock-names = "core_clk", "ref_clk", "iface_clk"; > freq-table-hz = <1 2>, <0 0>, <0 0>; > + resets = ; > + reset-names = "core_reset"; And the name should be "rst" (or omitted). > phys = <>; > phy-names = "ufsphy"; > }; > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >
[PATCH v9 7/7] dt-bindings: ufshcd-pltfrm: Add core reset string
From: Can Guo Add core reset support string for UFS. Signed-off-by: Amit Nischal Signed-off-by: Can Guo --- Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt b/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt index c39dfef..6b697c4 100644 --- a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt +++ b/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt @@ -11,6 +11,11 @@ Required properties: "qcom,ufshc" - interrupts: - reg : +- reset : reset specifier pair consists of phandle for the reset provider + and reset lines used by this controller. It is mandatory for + QCOM SDM845 platform. +- reset-names : reset signal name strings sorted in the same order as the + resets property. It is mandatory for QCOM SDM845 platform. Optional properties: - phys : phandle to UFS PHY node @@ -64,6 +69,8 @@ Example: clocks = < 0>, < 0>, < 0>; clock-names = "core_clk", "ref_clk", "iface_clk"; freq-table-hz = <1 2>, <0 0>, <0 0>; + resets = ; + reset-names = "core_reset"; phys = <>; phy-names = "ufsphy"; }; -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
[PATCH v9 7/7] dt-bindings: ufshcd-pltfrm: Add core reset string
From: Can Guo Add core reset support string for UFS. Signed-off-by: Amit Nischal Signed-off-by: Can Guo --- Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt b/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt index c39dfef..6b697c4 100644 --- a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt +++ b/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt @@ -11,6 +11,11 @@ Required properties: "qcom,ufshc" - interrupts: - reg : +- reset : reset specifier pair consists of phandle for the reset provider + and reset lines used by this controller. It is mandatory for + QCOM SDM845 platform. +- reset-names : reset signal name strings sorted in the same order as the + resets property. It is mandatory for QCOM SDM845 platform. Optional properties: - phys : phandle to UFS PHY node @@ -64,6 +69,8 @@ Example: clocks = < 0>, < 0>, < 0>; clock-names = "core_clk", "ref_clk", "iface_clk"; freq-table-hz = <1 2>, <0 0>, <0 0>; + resets = ; + reset-names = "core_reset"; phys = <>; phy-names = "ufsphy"; }; -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
