Re: [PATCH wireless v2] scsi: megaraid: Remove unnecessary memset

[Kalle Valo]

Zheng Yongjun  wrote:

> memcpy operation is next to memset code, and the size to copy
> is equals to the size to memset, so the memset operation is
> unnecessary, remove it.
> 
> Signed-off-by: Zheng Yongjun 

Wrong title.

Patch set to Changes Requested.

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20210115014559.7803-1-zhengyongj...@huawei.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

[PATCH wireless v2] scsi: megaraid: Remove unnecessary memset

[Zheng Yongjun]

memcpy operation is next to memset code, and the size to copy
is equals to the size to memset, so the memset operation is
unnecessary, remove it.

Signed-off-by: Zheng Yongjun 
---
 drivers/net/wireless/ath/wcn36xx/smd.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c 
b/drivers/net/wireless/ath/wcn36xx/smd.c
index 273fed22711f..5447a6696c35 100644
--- a/drivers/net/wireless/ath/wcn36xx/smd.c
+++ b/drivers/net/wireless/ath/wcn36xx/smd.c
@@ -478,7 +478,6 @@ static void init_hal_msg(struct wcn36xx_hal_msg_header *hdr,
 
 #define PREPARE_HAL_BUF(send_buf, msg_body) \
do {\
-   memset(send_buf, 0, msg_body.header.len);   \
memcpy(send_buf, &msg_body, sizeof(msg_body));  \
} while (0) \
 
-- 
2.22.0