Hello, This is a cleanup and refactoring patchset for the hist printing code by adding hist_period_print functions and hpp_context. I believe it makes the code easy to maintain and to add new functionalities like upcoming group viewing and callchain accumulation.
Any comments are welcome, thanks. Namhyung v2 -> v3: * Rebase to current acme/perf/core * Move fprintf code to ui/stdio/hist.c (Arnaldo) * Add ack from Pekka Namhyung Kim (7): perf hists: Separate out hist print functions perf hists: Refactor some functions perf hists: Introduce hist_period_print functions perf hists: Handle field separator properly perf hists: Use hpp_functions->width to calculate the column widths perf ui/browser: Use hist_period_print functions perf gtk/browser: Use hist_period_print functions tools/perf/Makefile | 5 +- tools/perf/builtin-diff.c | 1 + tools/perf/ui/browsers/hists.c | 96 ++++-- tools/perf/ui/gtk/browser.c | 101 +++++- tools/perf/ui/gtk/gtk.h | 1 + tools/perf/ui/gtk/setup.c | 1 + tools/perf/ui/hist.c | 391 +++++++++++++++++++++++ tools/perf/ui/setup.c | 8 +- tools/perf/ui/stdio/hist.c | 498 +++++++++++++++++++++++++++++ tools/perf/ui/tui/setup.c | 4 + tools/perf/util/hist.c | 710 ++--------------------------------------- tools/perf/util/hist.h | 43 ++- 12 files changed, 1121 insertions(+), 738 deletions(-) create mode 100644 tools/perf/ui/hist.c create mode 100644 tools/perf/ui/stdio/hist.c -- 1.7.11.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/