Re: [PATCHv2 0/5] x86: Enumerate TME and PCONFIG, add MKTME_KEY_PROG helper
On 02/07/2018 04:59 AM, Kirill A. Shutemov wrote: > The patchset does some ground work for MKTME enabling: > - Adds two new cpufeatures: TME and PCONFIG; > - Detects if BIOS enabled TME and MKTME; > - Enumerates what PCONFIG targets are supported; > - Provides helper to program encryption keys into CPU; > > As part of TME enumeration we check of how many bits from physical address > are claimed for encryption key ID. This may be critical as we or guest VM > must not use these bits for physical address. For this kind of stuff, I'd really appreciate if you included some high-level descriptions. I'd assume that a reviewer has no idea what PCONFIG or MKTME is. It would also be really nice to say which hardware will implement this. Is it in particular CPUs today, for instance?
Re: [PATCHv2 0/5] x86: Enumerate TME and PCONFIG, add MKTME_KEY_PROG helper
On 02/07/2018 04:59 AM, Kirill A. Shutemov wrote: > The patchset does some ground work for MKTME enabling: > - Adds two new cpufeatures: TME and PCONFIG; > - Detects if BIOS enabled TME and MKTME; > - Enumerates what PCONFIG targets are supported; > - Provides helper to program encryption keys into CPU; > > As part of TME enumeration we check of how many bits from physical address > are claimed for encryption key ID. This may be critical as we or guest VM > must not use these bits for physical address. For this kind of stuff, I'd really appreciate if you included some high-level descriptions. I'd assume that a reviewer has no idea what PCONFIG or MKTME is. It would also be really nice to say which hardware will implement this. Is it in particular CPUs today, for instance?
[PATCHv2 0/5] x86: Enumerate TME and PCONFIG, add MKTME_KEY_PROG helper
The patchset does some ground work for MKTME enabling: - Adds two new cpufeatures: TME and PCONFIG; - Detects if BIOS enabled TME and MKTME; - Enumerates what PCONFIG targets are supported; - Provides helper to program encryption keys into CPU; As part of TME enumeration we check of how many bits from physical address are claimed for encryption key ID. This may be critical as we or guest VM must not use these bits for physical address. Please review and consider applying. v2: - Fixes for TME enumeration; - Add PCONFIG CPUID leaf support; - Add MKTME_KEY_PROG helper; [1] https://software.intel.com/sites/default/files/managed/a5/16/Multi-Key-Total-Memory-Encryption-Spec.pdf Kirill A. Shutemov (5): x86/cpufeatures: Add Intel Total Memory Encryption cpufeature x86/tme: Detect if TME and MKTME is activated by BIOS x86/cpufeatures: Add Intel PCONFIG cpufeature x86/pconfig: Detect PCONFIG targets x86/pconfig: Provide defines and helper to run MKTME_KEY_PROG leaf arch/x86/include/asm/cpufeatures.h | 2 + arch/x86/include/asm/intel_pconfig.h | 65 + arch/x86/kernel/cpu/Makefile | 2 +- arch/x86/kernel/cpu/intel.c | 94 arch/x86/kernel/cpu/intel_pconfig.c | 82 +++ 5 files changed, 244 insertions(+), 1 deletion(-) create mode 100644 arch/x86/include/asm/intel_pconfig.h create mode 100644 arch/x86/kernel/cpu/intel_pconfig.c -- 2.15.1
[PATCHv2 0/5] x86: Enumerate TME and PCONFIG, add MKTME_KEY_PROG helper
The patchset does some ground work for MKTME enabling: - Adds two new cpufeatures: TME and PCONFIG; - Detects if BIOS enabled TME and MKTME; - Enumerates what PCONFIG targets are supported; - Provides helper to program encryption keys into CPU; As part of TME enumeration we check of how many bits from physical address are claimed for encryption key ID. This may be critical as we or guest VM must not use these bits for physical address. Please review and consider applying. v2: - Fixes for TME enumeration; - Add PCONFIG CPUID leaf support; - Add MKTME_KEY_PROG helper; [1] https://software.intel.com/sites/default/files/managed/a5/16/Multi-Key-Total-Memory-Encryption-Spec.pdf Kirill A. Shutemov (5): x86/cpufeatures: Add Intel Total Memory Encryption cpufeature x86/tme: Detect if TME and MKTME is activated by BIOS x86/cpufeatures: Add Intel PCONFIG cpufeature x86/pconfig: Detect PCONFIG targets x86/pconfig: Provide defines and helper to run MKTME_KEY_PROG leaf arch/x86/include/asm/cpufeatures.h | 2 + arch/x86/include/asm/intel_pconfig.h | 65 + arch/x86/kernel/cpu/Makefile | 2 +- arch/x86/kernel/cpu/intel.c | 94 arch/x86/kernel/cpu/intel_pconfig.c | 82 +++ 5 files changed, 244 insertions(+), 1 deletion(-) create mode 100644 arch/x86/include/asm/intel_pconfig.h create mode 100644 arch/x86/kernel/cpu/intel_pconfig.c -- 2.15.1
