Re: [PATCHv3] tty: Added a CONFIG_TTY option to allow removal of TTY
On Mon, Nov 26, 2012 at 3:44 PM, Jiri Slaby wrote: > On 11/27/2012 12:38 AM, Greg Kroah-Hartman wrote: >> Can you rediff this once 3.8-rc1 is out and send it to me then? > > So if you are going to respin, please take care of the newly added > drivers like drivers/staging/fwserial. > > thanks, > -- > js Will do on both counts (wait until 3.8-rc1, rebase, and search for TTY uses in new drivers). - Joe Millenbach -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCHv3] tty: Added a CONFIG_TTY option to allow removal of TTY
On 11/27/2012 12:38 AM, Greg Kroah-Hartman wrote: > Can you rediff this once 3.8-rc1 is out and send it to me then? So if you are going to respin, please take care of the newly added drivers like drivers/staging/fwserial. thanks, -- js -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCHv3] tty: Added a CONFIG_TTY option to allow removal of TTY
On Thu, Nov 15, 2012 at 06:30:35PM -0800, Joe Millenbach wrote: > The option allows you to remove TTY and compile without errors. This > saves space on systems that won't support TTY interfaces anyway. > bloat-o-meter output is below. > > The bulk of this patch consists of Kconfig changes adding "depends on > TTY" to various serial devices and similar drivers that require the TTY > layer. Ideally, these dependencies would occur on a common intermediate > symbol such as SERIO, but most drivers "select SERIO" rather than > "depends on SERIO", and "select" does not respect dependencies. > > bloat-o-meter output filtered to not show removed entries with awk > '$3 != "-"' as the list was very long. > > add/remove: 0/385 grow/shrink: 2/18 up/down: 14/-54016 (-54002) > function old new delta > chr_dev_init 193 205 +12 > selinux_setprocattr 11671169 +2 > static.__warned 557 556 -1 > start_kernel 840 835 -5 > proc_root_init 167 162 -5 > unregister_console 165 157 -8 > sys_setsid 213 205 -8 > sys_vhangup 37 21 -16 > daemonize689 673 -16 > t_stop72 54 -18 > t_next 129 108 -21 > static.do_acct_process 838 806 -32 > release_task11571125 -32 > do_exit 23252288 -37 > t_start 269 221 -48 > static.__func__18289 18219 -70 > do_task_stat29622892 -70 > flush_unauthorized_files 740 614-126 > static._rs 14401280-160 > static.__key85608384-176 > > Signed-off-by: Joe Millenbach > Reviewed-by: Josh Triplett This is a nice idea, but I feel it's a bit too late in the 3.8 merge window cycle for me to add this to linux-next at this point in time. Can you rediff this once 3.8-rc1 is out and send it to me then? That way we can get a lot more testing in linux-next in order to make sure it's ready for 3.9? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCHv3] tty: Added a CONFIG_TTY option to allow removal of TTY
On Thu, Nov 15, 2012 at 06:30:35PM -0800, Joe Millenbach wrote: The option allows you to remove TTY and compile without errors. This saves space on systems that won't support TTY interfaces anyway. bloat-o-meter output is below. The bulk of this patch consists of Kconfig changes adding depends on TTY to various serial devices and similar drivers that require the TTY layer. Ideally, these dependencies would occur on a common intermediate symbol such as SERIO, but most drivers select SERIO rather than depends on SERIO, and select does not respect dependencies. bloat-o-meter output filtered to not show removed entries with awk '$3 != -' as the list was very long. add/remove: 0/385 grow/shrink: 2/18 up/down: 14/-54016 (-54002) function old new delta chr_dev_init 193 205 +12 selinux_setprocattr 11671169 +2 static.__warned 557 556 -1 start_kernel 840 835 -5 proc_root_init 167 162 -5 unregister_console 165 157 -8 sys_setsid 213 205 -8 sys_vhangup 37 21 -16 daemonize689 673 -16 t_stop72 54 -18 t_next 129 108 -21 static.do_acct_process 838 806 -32 release_task11571125 -32 do_exit 23252288 -37 t_start 269 221 -48 static.__func__18289 18219 -70 do_task_stat29622892 -70 flush_unauthorized_files 740 614-126 static._rs 14401280-160 static.__key85608384-176 Signed-off-by: Joe Millenbach jmillenb...@gmail.com Reviewed-by: Josh Triplett j...@joshtriplett.org This is a nice idea, but I feel it's a bit too late in the 3.8 merge window cycle for me to add this to linux-next at this point in time. Can you rediff this once 3.8-rc1 is out and send it to me then? That way we can get a lot more testing in linux-next in order to make sure it's ready for 3.9? thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCHv3] tty: Added a CONFIG_TTY option to allow removal of TTY
On 11/27/2012 12:38 AM, Greg Kroah-Hartman wrote: Can you rediff this once 3.8-rc1 is out and send it to me then? So if you are going to respin, please take care of the newly added drivers like drivers/staging/fwserial. thanks, -- js -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCHv3] tty: Added a CONFIG_TTY option to allow removal of TTY
On Mon, Nov 26, 2012 at 3:44 PM, Jiri Slaby jirisl...@gmail.com wrote: On 11/27/2012 12:38 AM, Greg Kroah-Hartman wrote: Can you rediff this once 3.8-rc1 is out and send it to me then? So if you are going to respin, please take care of the newly added drivers like drivers/staging/fwserial. thanks, -- js Will do on both counts (wait until 3.8-rc1, rebase, and search for TTY uses in new drivers). - Joe Millenbach -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCHv3] tty: Added a CONFIG_TTY option to allow removal of TTY
The option allows you to remove TTY and compile without errors. This saves space on systems that won't support TTY interfaces anyway. bloat-o-meter output is below. The bulk of this patch consists of Kconfig changes adding "depends on TTY" to various serial devices and similar drivers that require the TTY layer. Ideally, these dependencies would occur on a common intermediate symbol such as SERIO, but most drivers "select SERIO" rather than "depends on SERIO", and "select" does not respect dependencies. bloat-o-meter output filtered to not show removed entries with awk '$3 != "-"' as the list was very long. add/remove: 0/385 grow/shrink: 2/18 up/down: 14/-54016 (-54002) function old new delta chr_dev_init 193 205 +12 selinux_setprocattr 11671169 +2 static.__warned 557 556 -1 start_kernel 840 835 -5 proc_root_init 167 162 -5 unregister_console 165 157 -8 sys_setsid 213 205 -8 sys_vhangup 37 21 -16 daemonize689 673 -16 t_stop72 54 -18 t_next 129 108 -21 static.do_acct_process 838 806 -32 release_task11571125 -32 do_exit 23252288 -37 t_start 269 221 -48 static.__func__18289 18219 -70 do_task_stat29622892 -70 flush_unauthorized_files 740 614-126 static._rs 14401280-160 static.__key85608384-176 Signed-off-by: Joe Millenbach Reviewed-by: Josh Triplett --- v3: Incorporated feedback from Jiri Slaby: fixed compilation issues on non x86/x64 platforms by finding all calls to alloc_tty_driver and tty_alloc_driver, then added "depends on" or "selects" TTY to config options that enabled compilation of those files. Also rebased to newer kernel sources. v2: Incorporated feedback from Alan Cox: used "if TTY ... endif" to wrap long runs of symbols that all need "depends on TTY"; grouped all the stubbed-out functions together in linux/tty.h. arch/alpha/Kconfig|2 ++ arch/ia64/hp/sim/Kconfig |1 + arch/m68k/Kconfig.devices |2 +- arch/parisc/Kconfig |1 + arch/tile/Kconfig |1 + arch/um/Kconfig.common|1 + arch/xtensa/Kconfig |1 + drivers/bluetooth/Kconfig |1 + drivers/char/Kconfig |7 +++--- drivers/char/pcmcia/Kconfig |4 +-- drivers/i2c/busses/Kconfig|2 +- drivers/input/joystick/Kconfig|4 +++ drivers/input/keyboard/Kconfig| 10 +++- drivers/input/mouse/Kconfig |3 +++ drivers/input/serio/Kconfig |1 + drivers/input/touchscreen/Kconfig | 24 +- drivers/isdn/Kconfig |1 + drivers/isdn/capi/Kconfig |1 + drivers/isdn/gigaset/Kconfig |1 + drivers/isdn/hardware/mISDN/Kconfig |1 + drivers/lguest/Kconfig|2 +- drivers/media/radio/wl128x/Kconfig|2 +- drivers/misc/Kconfig |2 +- drivers/misc/ti-st/Kconfig|2 +- drivers/mmc/card/Kconfig |1 + drivers/net/caif/Kconfig |2 +- drivers/net/can/Kconfig |2 +- drivers/net/hamradio/Kconfig |4 +-- drivers/net/irda/Kconfig |2 +- drivers/net/ppp/Kconfig |3 +++ drivers/net/slip/Kconfig |1 + drivers/net/usb/Kconfig |4 +-- drivers/net/wan/Kconfig |2 +- drivers/pps/clients/Kconfig |2 +- drivers/s390/char/Kconfig |8 +++--- drivers/staging/ccg/Kconfig |2 +- drivers/staging/dgrp/Kconfig |2 +- drivers/staging/ipack/devices/Kconfig |2 +- drivers/tty/Kconfig | 13 ++ drivers/tty/Makefile |2 +- drivers/tty/hvc/Kconfig |3 +++ drivers/tty/serial/Kconfig|4 +++ drivers/usb/class/Kconfig |2 +- drivers/usb/gadget/Kconfig|6 + drivers/usb/serial/Kconfig|2 +- fs/proc/Makefile |3 ++- include/linux/console.h |5 include/linux/proc_fs.h
[PATCHv3] tty: Added a CONFIG_TTY option to allow removal of TTY
The option allows you to remove TTY and compile without errors. This saves space on systems that won't support TTY interfaces anyway. bloat-o-meter output is below. The bulk of this patch consists of Kconfig changes adding depends on TTY to various serial devices and similar drivers that require the TTY layer. Ideally, these dependencies would occur on a common intermediate symbol such as SERIO, but most drivers select SERIO rather than depends on SERIO, and select does not respect dependencies. bloat-o-meter output filtered to not show removed entries with awk '$3 != -' as the list was very long. add/remove: 0/385 grow/shrink: 2/18 up/down: 14/-54016 (-54002) function old new delta chr_dev_init 193 205 +12 selinux_setprocattr 11671169 +2 static.__warned 557 556 -1 start_kernel 840 835 -5 proc_root_init 167 162 -5 unregister_console 165 157 -8 sys_setsid 213 205 -8 sys_vhangup 37 21 -16 daemonize689 673 -16 t_stop72 54 -18 t_next 129 108 -21 static.do_acct_process 838 806 -32 release_task11571125 -32 do_exit 23252288 -37 t_start 269 221 -48 static.__func__18289 18219 -70 do_task_stat29622892 -70 flush_unauthorized_files 740 614-126 static._rs 14401280-160 static.__key85608384-176 Signed-off-by: Joe Millenbach jmillenb...@gmail.com Reviewed-by: Josh Triplett j...@joshtriplett.org --- v3: Incorporated feedback from Jiri Slaby: fixed compilation issues on non x86/x64 platforms by finding all calls to alloc_tty_driver and tty_alloc_driver, then added depends on or selects TTY to config options that enabled compilation of those files. Also rebased to newer kernel sources. v2: Incorporated feedback from Alan Cox: used if TTY ... endif to wrap long runs of symbols that all need depends on TTY; grouped all the stubbed-out functions together in linux/tty.h. arch/alpha/Kconfig|2 ++ arch/ia64/hp/sim/Kconfig |1 + arch/m68k/Kconfig.devices |2 +- arch/parisc/Kconfig |1 + arch/tile/Kconfig |1 + arch/um/Kconfig.common|1 + arch/xtensa/Kconfig |1 + drivers/bluetooth/Kconfig |1 + drivers/char/Kconfig |7 +++--- drivers/char/pcmcia/Kconfig |4 +-- drivers/i2c/busses/Kconfig|2 +- drivers/input/joystick/Kconfig|4 +++ drivers/input/keyboard/Kconfig| 10 +++- drivers/input/mouse/Kconfig |3 +++ drivers/input/serio/Kconfig |1 + drivers/input/touchscreen/Kconfig | 24 +- drivers/isdn/Kconfig |1 + drivers/isdn/capi/Kconfig |1 + drivers/isdn/gigaset/Kconfig |1 + drivers/isdn/hardware/mISDN/Kconfig |1 + drivers/lguest/Kconfig|2 +- drivers/media/radio/wl128x/Kconfig|2 +- drivers/misc/Kconfig |2 +- drivers/misc/ti-st/Kconfig|2 +- drivers/mmc/card/Kconfig |1 + drivers/net/caif/Kconfig |2 +- drivers/net/can/Kconfig |2 +- drivers/net/hamradio/Kconfig |4 +-- drivers/net/irda/Kconfig |2 +- drivers/net/ppp/Kconfig |3 +++ drivers/net/slip/Kconfig |1 + drivers/net/usb/Kconfig |4 +-- drivers/net/wan/Kconfig |2 +- drivers/pps/clients/Kconfig |2 +- drivers/s390/char/Kconfig |8 +++--- drivers/staging/ccg/Kconfig |2 +- drivers/staging/dgrp/Kconfig |2 +- drivers/staging/ipack/devices/Kconfig |2 +- drivers/tty/Kconfig | 13 ++ drivers/tty/Makefile |2 +- drivers/tty/hvc/Kconfig |3 +++ drivers/tty/serial/Kconfig|4 +++ drivers/usb/class/Kconfig |2 +- drivers/usb/gadget/Kconfig|6 + drivers/usb/serial/Kconfig|2 +- fs/proc/Makefile |3 ++- include/linux/console.h |5
