Re: [PATCHv3 10/27] PCI: mobiveil: fix the INTx process error

[Subrahmanya Lingappa]

Reviewed-by: Subrahmanya Lingappa 

On Tue, Jan 29, 2019 at 1:39 PM Z.q. Hou  wrote:
>
> From: Hou Zhiqiang 
>
> In the loop block, there is not code change the loop key,
> this patch updated the loop key by re-read the INTx status
> register.
>
> This patch also change to clear the handled INTx status.
>
> Note: Need MV to test this fix.
>
> Fixes: 9af6bcb11e12 ("PCI: mobiveil: Add Mobiveil PCIe Host
> Bridge IP driver")
> Signed-off-by: Hou Zhiqiang 
> Reviewed-by: Minghuan Lian 
> ---
> V3:
>  - No change
>
>  drivers/pci/controller/pcie-mobiveil.c | 13 +
>  1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pci/controller/pcie-mobiveil.c 
> b/drivers/pci/controller/pcie-mobiveil.c
> index 4ba458474e42..78e575e71f4d 100644
> --- a/drivers/pci/controller/pcie-mobiveil.c
> +++ b/drivers/pci/controller/pcie-mobiveil.c
> @@ -361,6 +361,7 @@ static void mobiveil_pcie_isr(struct irq_desc *desc)
> /* Handle INTx */
> if (intr_status & PAB_INTP_INTX_MASK) {
> shifted_status = csr_readl(pcie, PAB_INTP_AMBA_MISC_STAT);
> +   shifted_status &= PAB_INTP_INTX_MASK;
> shifted_status >>= PAB_INTX_START;
> do {
> for_each_set_bit(bit, _status, PCI_NUM_INTX) {
> @@ -372,12 +373,16 @@ static void mobiveil_pcie_isr(struct irq_desc *desc)
> dev_err_ratelimited(dev, "unexpected 
> IRQ, INT%d\n",
> bit);
>
> -   /* clear interrupt */
> -   csr_writel(pcie,
> -  shifted_status << PAB_INTX_START,
> +   /* clear interrupt handled */
> +   csr_writel(pcie, 1 << (PAB_INTX_START + bit),
>PAB_INTP_AMBA_MISC_STAT);
> }
> -   } while ((shifted_status >> PAB_INTX_START) != 0);
> +
> +   shifted_status = csr_readl(pcie,
> +  PAB_INTP_AMBA_MISC_STAT);
> +   shifted_status &= PAB_INTP_INTX_MASK;
> +   shifted_status >>= PAB_INTX_START;
> +   } while (shifted_status != 0);
> }
>
> /* read extra MSI status register */
> --
> 2.17.1
>

[PATCHv3 10/27] PCI: mobiveil: fix the INTx process error

[Z.q. Hou]

From: Hou Zhiqiang 

In the loop block, there is not code change the loop key,
this patch updated the loop key by re-read the INTx status
register.

This patch also change to clear the handled INTx status.

Note: Need MV to test this fix.

Fixes: 9af6bcb11e12 ("PCI: mobiveil: Add Mobiveil PCIe Host
Bridge IP driver")
Signed-off-by: Hou Zhiqiang 
Reviewed-by: Minghuan Lian 
---
V3:
 - No change

 drivers/pci/controller/pcie-mobiveil.c | 13 +
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/drivers/pci/controller/pcie-mobiveil.c 
b/drivers/pci/controller/pcie-mobiveil.c
index 4ba458474e42..78e575e71f4d 100644
--- a/drivers/pci/controller/pcie-mobiveil.c
+++ b/drivers/pci/controller/pcie-mobiveil.c
@@ -361,6 +361,7 @@ static void mobiveil_pcie_isr(struct irq_desc *desc)
/* Handle INTx */
if (intr_status & PAB_INTP_INTX_MASK) {
shifted_status = csr_readl(pcie, PAB_INTP_AMBA_MISC_STAT);
+   shifted_status &= PAB_INTP_INTX_MASK;
shifted_status >>= PAB_INTX_START;
do {
for_each_set_bit(bit, _status, PCI_NUM_INTX) {
@@ -372,12 +373,16 @@ static void mobiveil_pcie_isr(struct irq_desc *desc)
dev_err_ratelimited(dev, "unexpected 
IRQ, INT%d\n",
bit);
 
-   /* clear interrupt */
-   csr_writel(pcie,
-  shifted_status << PAB_INTX_START,
+   /* clear interrupt handled */
+   csr_writel(pcie, 1 << (PAB_INTX_START + bit),
   PAB_INTP_AMBA_MISC_STAT);
}
-   } while ((shifted_status >> PAB_INTX_START) != 0);
+
+   shifted_status = csr_readl(pcie,
+  PAB_INTP_AMBA_MISC_STAT);
+   shifted_status &= PAB_INTP_INTX_MASK;
+   shifted_status >>= PAB_INTX_START;
+   } while (shifted_status != 0);
}
 
/* read extra MSI status register */
-- 
2.17.1