RE: [PATCHv3 3/3] ASoC: simple-card: binding: update binding to support the new style.
Hi, > Subject: Re: [PATCHv3 3/3] ASoC: simple-card: binding: update binding to > support the new style. > > On 09/09/2014 03:09 PM, Mark Brown wrote: > > On Wed, Sep 03, 2014 at 10:23:41AM +0800, Xiubo Li wrote: > >> This update patch will split the DT node into old style and new style: > >> The new style will will be easier to add muti DAI links from old single > >> DAI link DTs. > > > >> This patch will maintian compatibility with the old DTs. > > > > Is everyone happy with this new style binding? > > > > If I read the diff correctly the only change in the syntax is moving the > bitclock-inversion and frame-inversion properties to DAI nodes also for > the new style bindings. > > I am Ok with that. > > The document does not indicate that the same properties could be also > placed to DAI link level like they used to, from where they would apply > to both DAI nodes. > I will post one new version of this patch with some very small fix, and I will also add this. > I am Ok with this too, but this breaks the backwards compatibility, > which I guess is generally considered a problem. However, I doubt anyone > but me has yet used this part of the new syntax and I am happy to fix my > dts files. > > Best regards, > Jyri > > ps. I could not find the corresponding code changes in the previous > patch, so I assume they are coming later. Yes, I have one patch about the new style in my local machine, for some reason I will post it later. Thanks, BRs Xiubo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCHv3 3/3] ASoC: simple-card: binding: update binding to support the new style.
On 09/09/2014 03:09 PM, Mark Brown wrote: On Wed, Sep 03, 2014 at 10:23:41AM +0800, Xiubo Li wrote: This update patch will split the DT node into old style and new style: The new style will will be easier to add muti DAI links from old single DAI link DTs. This patch will maintian compatibility with the old DTs. Is everyone happy with this new style binding? If I read the diff correctly the only change in the syntax is moving the bitclock-inversion and frame-inversion properties to DAI nodes also for the new style bindings. I am Ok with that. The document does not indicate that the same properties could be also placed to DAI link level like they used to, from where they would apply to both DAI nodes. I am Ok with this too, but this breaks the backwards compatibility, which I guess is generally considered a problem. However, I doubt anyone but me has yet used this part of the new syntax and I am happy to fix my dts files. Best regards, Jyri ps. I could not find the corresponding code changes in the previous patch, so I assume they are coming later. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCHv3 3/3] ASoC: simple-card: binding: update binding to support the new style.
On Wed, Sep 03, 2014 at 10:23:41AM +0800, Xiubo Li wrote: > This update patch will split the DT node into old style and new style: > The new style will will be easier to add muti DAI links from old single > DAI link DTs. > This patch will maintian compatibility with the old DTs. Is everyone happy with this new style binding? signature.asc Description: Digital signature
Re: [PATCHv3 3/3] ASoC: simple-card: binding: update binding to support the new style.
On Wed, Sep 03, 2014 at 10:23:41AM +0800, Xiubo Li wrote: This update patch will split the DT node into old style and new style: The new style will will be easier to add muti DAI links from old single DAI link DTs. This patch will maintian compatibility with the old DTs. Is everyone happy with this new style binding? signature.asc Description: Digital signature
Re: [PATCHv3 3/3] ASoC: simple-card: binding: update binding to support the new style.
On 09/09/2014 03:09 PM, Mark Brown wrote: On Wed, Sep 03, 2014 at 10:23:41AM +0800, Xiubo Li wrote: This update patch will split the DT node into old style and new style: The new style will will be easier to add muti DAI links from old single DAI link DTs. This patch will maintian compatibility with the old DTs. Is everyone happy with this new style binding? If I read the diff correctly the only change in the syntax is moving the bitclock-inversion and frame-inversion properties to DAI nodes also for the new style bindings. I am Ok with that. The document does not indicate that the same properties could be also placed to DAI link level like they used to, from where they would apply to both DAI nodes. I am Ok with this too, but this breaks the backwards compatibility, which I guess is generally considered a problem. However, I doubt anyone but me has yet used this part of the new syntax and I am happy to fix my dts files. Best regards, Jyri ps. I could not find the corresponding code changes in the previous patch, so I assume they are coming later. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCHv3 3/3] ASoC: simple-card: binding: update binding to support the new style.
Hi, Subject: Re: [PATCHv3 3/3] ASoC: simple-card: binding: update binding to support the new style. On 09/09/2014 03:09 PM, Mark Brown wrote: On Wed, Sep 03, 2014 at 10:23:41AM +0800, Xiubo Li wrote: This update patch will split the DT node into old style and new style: The new style will will be easier to add muti DAI links from old single DAI link DTs. This patch will maintian compatibility with the old DTs. Is everyone happy with this new style binding? If I read the diff correctly the only change in the syntax is moving the bitclock-inversion and frame-inversion properties to DAI nodes also for the new style bindings. I am Ok with that. The document does not indicate that the same properties could be also placed to DAI link level like they used to, from where they would apply to both DAI nodes. I will post one new version of this patch with some very small fix, and I will also add this. I am Ok with this too, but this breaks the backwards compatibility, which I guess is generally considered a problem. However, I doubt anyone but me has yet used this part of the new syntax and I am happy to fix my dts files. Best regards, Jyri ps. I could not find the corresponding code changes in the previous patch, so I assume they are coming later. Yes, I have one patch about the new style in my local machine, for some reason I will post it later. Thanks, BRs Xiubo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCHv3 3/3] ASoC: simple-card: binding: update binding to support the new style.
This update patch will split the DT node into old style and new style: The new style will will be easier to add muti DAI links from old single DAI link DTs. This patch will maintian compatibility with the old DTs. Signed-off-by: Xiubo Li --- .../devicetree/bindings/sound/simple-card.txt | 183 ++--- 1 file changed, 125 insertions(+), 58 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/simple-card.txt b/Documentation/devicetree/bindings/sound/simple-card.txt index c2e9841..8c1bd30 100644 --- a/Documentation/devicetree/bindings/sound/simple-card.txt +++ b/Documentation/devicetree/bindings/sound/simple-card.txt @@ -1,15 +1,19 @@ -Simple-Card: +Device-Tree bindings for Simple Card Simple-Card specifies audio DAI connections of SoC <-> codec. -Required properties: +=== Top level's properties and subnodes === +*** Required properties *** - compatible : "simple-audio-card" -Optional properties: - +*** Optional properties *** - simple-audio-card,name : User specified audio sound card name, one string property. +- simple-audio-card,format : CPU/CODEC common audio format. + "i2s", "right_j", "left_j" , "dsp_a" + "dsp_b", "ac97", "pdm", "msb", "lsb" + (This is used for single DAI link & old style.) - simple-audio-card,widgets: Please refer to widgets.txt. - simple-audio-card,routing: A list of the connections between audio components. Each entry is a pair of strings, the first being the @@ -17,63 +21,85 @@ Optional properties: source. - simple-audio-card,mclk-fs : Multiplication factor between stream rate and codec mclk. - -Optional subnodes: - -- simple-audio-card,dai-link : Container for dai-link level - properties and the CPU and CODEC - sub-nodes. This container may be - omitted when the card has only one - DAI link. See the examples and the - section bellow. - -Dai-link subnode properties and subnodes: - -If dai-link subnode is omitted and the subnode properties are directly -under "sound"-node the subnode property and subnode names have to be -prefixed with "simple-audio-card,"-prefix. - -Required dai-link subnodes: - -- cpu : CPU sub-node -- codec: CODEC sub-node - -Optional dai-link subnode properties: - +- simple-audio-card,frame-master : Indicates DAI link frame master. One phandle to a cpu + or codec subnode. + (This is used for single DAI link & old style.) +- simple-audio-card,bitclock-master: Indicates DAI link bit clock master. One phandle to a + cpu or codec subnode. + (This is used for single DAI link & old style.) + +*** Optional subnodes *** +- simple-audio-card,dai-link : Container for DAI link level properties and the CPU + and CODEC sub-nodes. This container may be omitted + when the card has only one DAI link and using the old + style. See the examples and the section bellow. +- simple-audio-card,cpu: CPU DAI sub-node. + (This is used for single DAI link & old style.) +- simple-audio-card,codec : CODEC DAI sub-node. + (This is used for single DAI link & old style.) + +=== DAI link node's properties and its subnodes === + +*** Required subnodes *** +- cpu : CPU DAI sub-node +- codec: CODEC DAI sub-node + +*** Optional properties *** - format : CPU/CODEC common audio format. "i2s", "right_j", "left_j" , "dsp_a" "dsp_b", "ac97", "pdm", "msb", "lsb" -- frame-master : Indicates dai-link frame master. - phandle to a cpu or codec subnode. -- bitclock-master : Indicates dai-link bit clock master. - phandle to a cpu or codec subnode. -- bitclock-inversion : bool property. Add this if the - dai-link uses bit
[PATCHv3 3/3] ASoC: simple-card: binding: update binding to support the new style.
This update patch will split the DT node into old style and new style: The new style will will be easier to add muti DAI links from old single DAI link DTs. This patch will maintian compatibility with the old DTs. Signed-off-by: Xiubo Li li.xi...@freescale.com --- .../devicetree/bindings/sound/simple-card.txt | 183 ++--- 1 file changed, 125 insertions(+), 58 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/simple-card.txt b/Documentation/devicetree/bindings/sound/simple-card.txt index c2e9841..8c1bd30 100644 --- a/Documentation/devicetree/bindings/sound/simple-card.txt +++ b/Documentation/devicetree/bindings/sound/simple-card.txt @@ -1,15 +1,19 @@ -Simple-Card: +Device-Tree bindings for Simple Card Simple-Card specifies audio DAI connections of SoC - codec. -Required properties: +=== Top level's properties and subnodes === +*** Required properties *** - compatible : simple-audio-card -Optional properties: - +*** Optional properties *** - simple-audio-card,name : User specified audio sound card name, one string property. +- simple-audio-card,format : CPU/CODEC common audio format. + i2s, right_j, left_j , dsp_a + dsp_b, ac97, pdm, msb, lsb + (This is used for single DAI link old style.) - simple-audio-card,widgets: Please refer to widgets.txt. - simple-audio-card,routing: A list of the connections between audio components. Each entry is a pair of strings, the first being the @@ -17,63 +21,85 @@ Optional properties: source. - simple-audio-card,mclk-fs : Multiplication factor between stream rate and codec mclk. - -Optional subnodes: - -- simple-audio-card,dai-link : Container for dai-link level - properties and the CPU and CODEC - sub-nodes. This container may be - omitted when the card has only one - DAI link. See the examples and the - section bellow. - -Dai-link subnode properties and subnodes: - -If dai-link subnode is omitted and the subnode properties are directly -under sound-node the subnode property and subnode names have to be -prefixed with simple-audio-card,-prefix. - -Required dai-link subnodes: - -- cpu : CPU sub-node -- codec: CODEC sub-node - -Optional dai-link subnode properties: - +- simple-audio-card,frame-master : Indicates DAI link frame master. One phandle to a cpu + or codec subnode. + (This is used for single DAI link old style.) +- simple-audio-card,bitclock-master: Indicates DAI link bit clock master. One phandle to a + cpu or codec subnode. + (This is used for single DAI link old style.) + +*** Optional subnodes *** +- simple-audio-card,dai-link : Container for DAI link level properties and the CPU + and CODEC sub-nodes. This container may be omitted + when the card has only one DAI link and using the old + style. See the examples and the section bellow. +- simple-audio-card,cpu: CPU DAI sub-node. + (This is used for single DAI link old style.) +- simple-audio-card,codec : CODEC DAI sub-node. + (This is used for single DAI link old style.) + +=== DAI link node's properties and its subnodes === + +*** Required subnodes *** +- cpu : CPU DAI sub-node +- codec: CODEC DAI sub-node + +*** Optional properties *** - format : CPU/CODEC common audio format. i2s, right_j, left_j , dsp_a dsp_b, ac97, pdm, msb, lsb -- frame-master : Indicates dai-link frame master. - phandle to a cpu or codec subnode. -- bitclock-master : Indicates dai-link bit clock master. - phandle to a cpu or codec subnode. -- bitclock-inversion : bool property. Add this if the - dai-link uses bit clock inversion. --
