Re: [Patch v2 1/7] crypto: qce: common: Add MAC failed error checking

[Bjorn Andersson]

On Sat 17 Apr 08:24 CDT 2021, Thara Gopinath wrote:

> MAC_FAILED gets set in the status register if authenthication fails
> for ccm algorithms(during decryption). Add support to catch and flag
> this error.
> 

Reviewed-by: Bjorn Andersson 

Regards,
Bjorn

> Signed-off-by: Thara Gopinath 
> ---
> 
> v1->v2:
>   - Split the error checking for -ENXIO and -EBADMSG into if-else clause
> so that the code is more readable as per Bjorn's review comment.
> 
>  drivers/crypto/qce/common.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/crypto/qce/common.c b/drivers/crypto/qce/common.c
> index dceb9579d87a..dd76175d5c62 100644
> --- a/drivers/crypto/qce/common.c
> +++ b/drivers/crypto/qce/common.c
> @@ -419,6 +419,8 @@ int qce_check_status(struct qce_device *qce, u32 *status)
>*/
>   if (*status & STATUS_ERRORS || !(*status & BIT(OPERATION_DONE_SHIFT)))
>   ret = -ENXIO;
> + else if (*status & BIT(MAC_FAILED_SHIFT))
> + ret = -EBADMSG;
>  
>   return ret;
>  }
> -- 
> 2.25.1
> 

[Patch v2 1/7] crypto: qce: common: Add MAC failed error checking

[Thara Gopinath]

MAC_FAILED gets set in the status register if authenthication fails
for ccm algorithms(during decryption). Add support to catch and flag
this error.

Signed-off-by: Thara Gopinath 
---

v1->v2:
- Split the error checking for -ENXIO and -EBADMSG into if-else clause
  so that the code is more readable as per Bjorn's review comment.

 drivers/crypto/qce/common.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/crypto/qce/common.c b/drivers/crypto/qce/common.c
index dceb9579d87a..dd76175d5c62 100644
--- a/drivers/crypto/qce/common.c
+++ b/drivers/crypto/qce/common.c
@@ -419,6 +419,8 @@ int qce_check_status(struct qce_device *qce, u32 *status)
 */
if (*status & STATUS_ERRORS || !(*status & BIT(OPERATION_DONE_SHIFT)))
ret = -ENXIO;
+   else if (*status & BIT(MAC_FAILED_SHIFT))
+   ret = -EBADMSG;
 
return ret;
 }
-- 
2.25.1