Re: [Patch v6 4/7] power: reset: add bindings for keystone reset driver

2014-05-22 Thread Ivan Khoronzhuk


On 05/22/2014 09:03 PM, Sergei Shtylyov wrote:

Hello.

On 05/22/2014 08:44 PM, Ivan Khoronzhuk wrote:


This node is intended to allow SoC reset in case of software reset
or appropriate watchdogs.



The Keystone SoCs can contain up to 4 watchdog timers to reset
SoC. Each watchdog timer event input is connected to the Reset Mux
block. The Reset Mux block can be configured to cause reset or not.



Additionally soft or hard reset can be configured.



Reviewed-by: Arnd Bergmann 
Signed-off-by: Ivan Khoronzhuk 
---
  .../bindings/power/reset/keystone-reset.txt| 67 
++

  1 file changed, 67 insertions(+)
  create mode 100644 
Documentation/devicetree/bindings/power/reset/keystone-reset.txt


diff --git 
a/Documentation/devicetree/bindings/power/reset/keystone-reset.txt 
b/Documentation/devicetree/bindings/power/reset/keystone-reset.txt

new file mode 100644
index 000..a8a0c31
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/reset/keystone-reset.txt
@@ -0,0 +1,67 @@
+* Device tree bindings for Texas Instruments keystone reset
+
+This node is intended to allow SoC reset in case of software reset
+of selected watchdogs.
+
+The Keystone SoCs can contain up to 4 watchdog timers to reset
+SoC. Each watchdog timer event input is connected to the Reset Mux
+block. The Reset Mux block can be configured to cause reset or not.
+
+Additionally soft or hard reset can be configured.
+
+Required properties:
+
+- compatible:ti,keystone-reset
+
+- ti,syscon-pll:phandle/offset pair. The phandle to syscon used to
+access pll controller registers and the offset to use
+reset control registers.
+
+- ti,syscon-dev:phandle/offset pair. The phandle to syscon used to
+access device state control registers and the offset
+in order to use mux block registers for all watchdogs.
+
+Optional properties:
+
+- ti,soft-reset:Boolean option indicating soft reset.
+By default hard reset is used.
+
+- ti,wdt_list:WDT list that can cause SoC reset. It's not 
related


   Hm, why underscore in this property while hyphens are used in the 
others? Hyphen is generally preferrable in the device tree names...


Yes. You are right. I'll correct
Thanks!




+to WDT driver, it's just needed to enable a SoC related
+reset that's triggered by one of WDTs. The list is
+in format: <0>, <2>; It can be in random order and
+begins from 0 to 3, as keystone can contain up to 4 SoC
+reset watchdogs and can be in random order.


WBR, Sergei



--
Regards,
Ivan Khoronzhuk

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [Patch v6 4/7] power: reset: add bindings for keystone reset driver

2014-05-22 Thread Sergei Shtylyov

Hello.

On 05/22/2014 08:44 PM, Ivan Khoronzhuk wrote:


This node is intended to allow SoC reset in case of software reset
or appropriate watchdogs.



The Keystone SoCs can contain up to 4 watchdog timers to reset
SoC. Each watchdog timer event input is connected to the Reset Mux
block. The Reset Mux block can be configured to cause reset or not.



Additionally soft or hard reset can be configured.



Reviewed-by: Arnd Bergmann 
Signed-off-by: Ivan Khoronzhuk 
---
  .../bindings/power/reset/keystone-reset.txt| 67 ++
  1 file changed, 67 insertions(+)
  create mode 100644 
Documentation/devicetree/bindings/power/reset/keystone-reset.txt



diff --git a/Documentation/devicetree/bindings/power/reset/keystone-reset.txt 
b/Documentation/devicetree/bindings/power/reset/keystone-reset.txt
new file mode 100644
index 000..a8a0c31
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/reset/keystone-reset.txt
@@ -0,0 +1,67 @@
+* Device tree bindings for Texas Instruments keystone reset
+
+This node is intended to allow SoC reset in case of software reset
+of selected watchdogs.
+
+The Keystone SoCs can contain up to 4 watchdog timers to reset
+SoC. Each watchdog timer event input is connected to the Reset Mux
+block. The Reset Mux block can be configured to cause reset or not.
+
+Additionally soft or hard reset can be configured.
+
+Required properties:
+
+- compatible:  ti,keystone-reset
+
+- ti,syscon-pll:   phandle/offset pair. The phandle to syscon used to
+   access pll controller registers and the offset to use
+   reset control registers.
+
+- ti,syscon-dev:   phandle/offset pair. The phandle to syscon used to
+   access device state control registers and the offset
+   in order to use mux block registers for all watchdogs.
+
+Optional properties:
+
+- ti,soft-reset:   Boolean option indicating soft reset.
+   By default hard reset is used.
+
+- ti,wdt_list: WDT list that can cause SoC reset. It's not related


   Hm, why underscore in this property while hyphens are used in the others? 
Hyphen is generally preferrable in the device tree names...



+   to WDT driver, it's just needed to enable a SoC related
+   reset that's triggered by one of WDTs. The list is
+   in format: <0>, <2>; It can be in random order and
+   begins from 0 to 3, as keystone can contain up to 4 SoC
+   reset watchdogs and can be in random order.


WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[Patch v6 4/7] power: reset: add bindings for keystone reset driver

2014-05-22 Thread Ivan Khoronzhuk
This node is intended to allow SoC reset in case of software reset
or appropriate watchdogs.

The Keystone SoCs can contain up to 4 watchdog timers to reset
SoC. Each watchdog timer event input is connected to the Reset Mux
block. The Reset Mux block can be configured to cause reset or not.

Additionally soft or hard reset can be configured.

Reviewed-by: Arnd Bergmann 
Signed-off-by: Ivan Khoronzhuk 
---
 .../bindings/power/reset/keystone-reset.txt| 67 ++
 1 file changed, 67 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/power/reset/keystone-reset.txt

diff --git a/Documentation/devicetree/bindings/power/reset/keystone-reset.txt 
b/Documentation/devicetree/bindings/power/reset/keystone-reset.txt
new file mode 100644
index 000..a8a0c31
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/reset/keystone-reset.txt
@@ -0,0 +1,67 @@
+* Device tree bindings for Texas Instruments keystone reset
+
+This node is intended to allow SoC reset in case of software reset
+of selected watchdogs.
+
+The Keystone SoCs can contain up to 4 watchdog timers to reset
+SoC. Each watchdog timer event input is connected to the Reset Mux
+block. The Reset Mux block can be configured to cause reset or not.
+
+Additionally soft or hard reset can be configured.
+
+Required properties:
+
+- compatible:  ti,keystone-reset
+
+- ti,syscon-pll:   phandle/offset pair. The phandle to syscon used to
+   access pll controller registers and the offset to use
+   reset control registers.
+
+- ti,syscon-dev:   phandle/offset pair. The phandle to syscon used to
+   access device state control registers and the offset
+   in order to use mux block registers for all watchdogs.
+
+Optional properties:
+
+- ti,soft-reset:   Boolean option indicating soft reset.
+   By default hard reset is used.
+
+- ti,wdt_list: WDT list that can cause SoC reset. It's not related
+   to WDT driver, it's just needed to enable a SoC related
+   reset that's triggered by one of WDTs. The list is
+   in format: <0>, <2>; It can be in random order and
+   begins from 0 to 3, as keystone can contain up to 4 SoC
+   reset watchdogs and can be in random order.
+
+Example 1:
+Setup keystone reset so that in case software reset or
+WDT0 is triggered it issues hard reset for SoC.
+
+pllctrl: pll-controller@0231 {
+   compatible = "ti,keystone-pllctrl", "syscon";
+   reg = <0x0231 0x200>;
+};
+
+devctrl: device-state-control@0262 {
+   compatible = "ti,keystone-devctrl", "syscon";
+   reg = <0x0262 0x1000>;
+};
+
+rstctrl: reset-controller {
+   compatible = "ti,keystone-reset";
+   ti,syscon-pll = <&pllctrl 0xe4>;
+   ti,syscon-dev = <&devctrl 0x328>;
+   ti,wdt_list = <0>;
+};
+
+Example 2:
+Setup keystone reset so that in case of software reset or
+WDT0 or WDT2 is triggered it issues soft reset for SoC.
+
+rstctrl: reset-controller {
+   compatible = "ti,keystone-reset";
+   ti,syscon-pll = <&pllctrl 0xe4>;
+   ti,syscon-dev = <&devctrl 0x328>;
+   ti,wdt_list = <0>, <2>;
+   ti,soft-reset;
+};
-- 
1.8.3.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/