Re: [RESEND PATCH 1/3] clk: si5351: Constify clock names and struct regmap_config
On 03/22, Max Filippov wrote: > On Fri, Mar 20, 2015 at 2:34 PM, Krzysztof Kozlowski > wrote: > > The regmap_config struct may be const because it is not modified by the > > driver and regmap_init() accepts pointer to const. > > > > Replace doubled const in the arrays of clock names with proper const > > pointer to const data. This fixes the warnings: > > > > drivers/clk/clk-si5351.c:71:25: warning: duplicate const > > drivers/clk/clk-si5351.c:74:25: warning: duplicate const > > drivers/clk/clk-si5351.c:77:25: warning: duplicate const > > drivers/clk/clk-si5351.c:80:25: warning: duplicate const > > > > Signed-off-by: Krzysztof Kozlowski > > --- > > drivers/clk/clk-si5351.c | 10 +- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > Reviewed-by: Max Filippov > Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RESEND PATCH 1/3] clk: si5351: Constify clock names and struct regmap_config
On 03/22, Max Filippov wrote: On Fri, Mar 20, 2015 at 2:34 PM, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: The regmap_config struct may be const because it is not modified by the driver and regmap_init() accepts pointer to const. Replace doubled const in the arrays of clock names with proper const pointer to const data. This fixes the warnings: drivers/clk/clk-si5351.c:71:25: warning: duplicate const drivers/clk/clk-si5351.c:74:25: warning: duplicate const drivers/clk/clk-si5351.c:77:25: warning: duplicate const drivers/clk/clk-si5351.c:80:25: warning: duplicate const Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/clk/clk-si5351.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Max Filippov jcmvb...@gmail.com Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RESEND PATCH 1/3] clk: si5351: Constify clock names and struct regmap_config
On Fri, Mar 20, 2015 at 2:34 PM, Krzysztof Kozlowski wrote: > The regmap_config struct may be const because it is not modified by the > driver and regmap_init() accepts pointer to const. > > Replace doubled const in the arrays of clock names with proper const > pointer to const data. This fixes the warnings: > > drivers/clk/clk-si5351.c:71:25: warning: duplicate const > drivers/clk/clk-si5351.c:74:25: warning: duplicate const > drivers/clk/clk-si5351.c:77:25: warning: duplicate const > drivers/clk/clk-si5351.c:80:25: warning: duplicate const > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/clk/clk-si5351.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Max Filippov -- Thanks. -- Max -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RESEND PATCH 1/3] clk: si5351: Constify clock names and struct regmap_config
On Fri, Mar 20, 2015 at 2:34 PM, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: The regmap_config struct may be const because it is not modified by the driver and regmap_init() accepts pointer to const. Replace doubled const in the arrays of clock names with proper const pointer to const data. This fixes the warnings: drivers/clk/clk-si5351.c:71:25: warning: duplicate const drivers/clk/clk-si5351.c:74:25: warning: duplicate const drivers/clk/clk-si5351.c:77:25: warning: duplicate const drivers/clk/clk-si5351.c:80:25: warning: duplicate const Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/clk/clk-si5351.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Max Filippov jcmvb...@gmail.com -- Thanks. -- Max -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[RESEND PATCH 1/3] clk: si5351: Constify clock names and struct regmap_config
The regmap_config struct may be const because it is not modified by the driver and regmap_init() accepts pointer to const. Replace doubled const in the arrays of clock names with proper const pointer to const data. This fixes the warnings: drivers/clk/clk-si5351.c:71:25: warning: duplicate const drivers/clk/clk-si5351.c:74:25: warning: duplicate const drivers/clk/clk-si5351.c:77:25: warning: duplicate const drivers/clk/clk-si5351.c:80:25: warning: duplicate const Signed-off-by: Krzysztof Kozlowski --- drivers/clk/clk-si5351.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/clk/clk-si5351.c b/drivers/clk/clk-si5351.c index 3b2a66f78755..44ea107cfc67 100644 --- a/drivers/clk/clk-si5351.c +++ b/drivers/clk/clk-si5351.c @@ -68,16 +68,16 @@ struct si5351_driver_data { struct si5351_hw_data *clkout; }; -static const char const *si5351_input_names[] = { +static const char * const si5351_input_names[] = { "xtal", "clkin" }; -static const char const *si5351_pll_names[] = { +static const char * const si5351_pll_names[] = { "plla", "pllb", "vxco" }; -static const char const *si5351_msynth_names[] = { +static const char * const si5351_msynth_names[] = { "ms0", "ms1", "ms2", "ms3", "ms4", "ms5", "ms6", "ms7" }; -static const char const *si5351_clkout_names[] = { +static const char * const si5351_clkout_names[] = { "clk0", "clk1", "clk2", "clk3", "clk4", "clk5", "clk6", "clk7" }; @@ -207,7 +207,7 @@ static bool si5351_regmap_is_writeable(struct device *dev, unsigned int reg) return true; } -static struct regmap_config si5351_regmap_config = { +static const struct regmap_config si5351_regmap_config = { .reg_bits = 8, .val_bits = 8, .cache_type = REGCACHE_RBTREE, -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[RESEND PATCH 1/3] clk: si5351: Constify clock names and struct regmap_config
The regmap_config struct may be const because it is not modified by the driver and regmap_init() accepts pointer to const. Replace doubled const in the arrays of clock names with proper const pointer to const data. This fixes the warnings: drivers/clk/clk-si5351.c:71:25: warning: duplicate const drivers/clk/clk-si5351.c:74:25: warning: duplicate const drivers/clk/clk-si5351.c:77:25: warning: duplicate const drivers/clk/clk-si5351.c:80:25: warning: duplicate const Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/clk/clk-si5351.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/clk/clk-si5351.c b/drivers/clk/clk-si5351.c index 3b2a66f78755..44ea107cfc67 100644 --- a/drivers/clk/clk-si5351.c +++ b/drivers/clk/clk-si5351.c @@ -68,16 +68,16 @@ struct si5351_driver_data { struct si5351_hw_data *clkout; }; -static const char const *si5351_input_names[] = { +static const char * const si5351_input_names[] = { xtal, clkin }; -static const char const *si5351_pll_names[] = { +static const char * const si5351_pll_names[] = { plla, pllb, vxco }; -static const char const *si5351_msynth_names[] = { +static const char * const si5351_msynth_names[] = { ms0, ms1, ms2, ms3, ms4, ms5, ms6, ms7 }; -static const char const *si5351_clkout_names[] = { +static const char * const si5351_clkout_names[] = { clk0, clk1, clk2, clk3, clk4, clk5, clk6, clk7 }; @@ -207,7 +207,7 @@ static bool si5351_regmap_is_writeable(struct device *dev, unsigned int reg) return true; } -static struct regmap_config si5351_regmap_config = { +static const struct regmap_config si5351_regmap_config = { .reg_bits = 8, .val_bits = 8, .cache_type = REGCACHE_RBTREE, -- 1.9.1 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/