Re: [RESEND PATCH 1/5] usb: mtu3: avoid TX data length truncated in SS/SSP mode
Hi, Greg On Thu, 2018-05-10 at 10:16 +0800, Chunfeng Yun wrote: > Hi, Greg > >Could you please pick up the series of patches, thanks a lot Please ignore it, I find a problem in [RESEND PATCH 4/5], and need send a new version. Very sorry > > On Sat, 2018-05-05 at 10:21 +0800, Chunfeng Yun wrote: > > The variable of 'count' is declared as u8, this will cause an issue > > due to value truncated when works in SS or SSP mode and data length > > is greater than 255, so change it as u32. > > > > Signed-off-by: Chunfeng Yun > > --- > > drivers/usb/mtu3/mtu3_gadget_ep0.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/usb/mtu3/mtu3_gadget_ep0.c > > b/drivers/usb/mtu3/mtu3_gadget_ep0.c > > index ebdcf7a..d67b540 100644 > > --- a/drivers/usb/mtu3/mtu3_gadget_ep0.c > > +++ b/drivers/usb/mtu3/mtu3_gadget_ep0.c > > @@ -546,7 +546,7 @@ static void ep0_tx_state(struct mtu3 *mtu) > > struct usb_request *req; > > u32 csr; > > u8 *src; > > - u8 count; > > + u32 count; > > u32 maxp; > > > > dev_dbg(mtu->dev, "%s\n", __func__); > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RESEND PATCH 1/5] usb: mtu3: avoid TX data length truncated in SS/SSP mode
Hi, Greg Could you please pick up the series of patches, thanks a lot On Sat, 2018-05-05 at 10:21 +0800, Chunfeng Yun wrote: > The variable of 'count' is declared as u8, this will cause an issue > due to value truncated when works in SS or SSP mode and data length > is greater than 255, so change it as u32. > > Signed-off-by: Chunfeng Yun > --- > drivers/usb/mtu3/mtu3_gadget_ep0.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/mtu3/mtu3_gadget_ep0.c > b/drivers/usb/mtu3/mtu3_gadget_ep0.c > index ebdcf7a..d67b540 100644 > --- a/drivers/usb/mtu3/mtu3_gadget_ep0.c > +++ b/drivers/usb/mtu3/mtu3_gadget_ep0.c > @@ -546,7 +546,7 @@ static void ep0_tx_state(struct mtu3 *mtu) > struct usb_request *req; > u32 csr; > u8 *src; > - u8 count; > + u32 count; > u32 maxp; > > dev_dbg(mtu->dev, "%s\n", __func__);
[RESEND PATCH 1/5] usb: mtu3: avoid TX data length truncated in SS/SSP mode
The variable of 'count' is declared as u8, this will cause an issue due to value truncated when works in SS or SSP mode and data length is greater than 255, so change it as u32. Signed-off-by: Chunfeng Yun --- drivers/usb/mtu3/mtu3_gadget_ep0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/mtu3/mtu3_gadget_ep0.c b/drivers/usb/mtu3/mtu3_gadget_ep0.c index ebdcf7a..d67b540 100644 --- a/drivers/usb/mtu3/mtu3_gadget_ep0.c +++ b/drivers/usb/mtu3/mtu3_gadget_ep0.c @@ -546,7 +546,7 @@ static void ep0_tx_state(struct mtu3 *mtu) struct usb_request *req; u32 csr; u8 *src; - u8 count; + u32 count; u32 maxp; dev_dbg(mtu->dev, "%s\n", __func__); -- 1.9.1
