Fwd: [RFC] kbuild: Build samples directory with make modules
Is there any specific reason that this patch is ignored still yet? Compiling the uImage and modules together add the support of samples? Shouldn't it be compiled as a module separately and that is correct behavior in case of if samples are compiled as loadable modules? Thanks, Mohsin Kazmi On Wed, Jul 17, 2013 at 2:15 AM, Jim Baxter wrote: > > On 16/07/13 20:37, Sam Ravnborg wrote: > > On Tue, Jul 16, 2013 at 07:29:50PM +0100, Jim Baxter wrote: > >> If CONFIG_SAMPLES is enabled with any of the sample > >> modules enabled, they are only built if the make command > >> includes uImage and modules (i.e. make uImage modules). > > > > With the current location samples are built when you build vmlinux. > > And vmlinux is implicit when you just type "make". > > > > With the suggestion you have samples are built when you do "make modules". > > IMO this is less logical than to built them with vmlinux as we do today. > > > > Sam > > > > Hi, > > I am building it with: > make uImage > make modules > > At least bitbake in Yocto and Openembedded is. > > Running make on it's own is the equivalent of: > make vmlinux modules > > which builds the samples directory, however if you run: > make vmlinux > make modules > > Then the Samples are not built, that is what I am trying to fix. > > Thank you, > Jim > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Fwd: [RFC] kbuild: Build samples directory with make modules
Is there any specific reason that this patch is ignored still yet? Compiling the uImage and modules together add the support of samples? Shouldn't it be compiled as a module separately and that is correct behavior in case of if samples are compiled as loadable modules? Thanks, Mohsin Kazmi On Wed, Jul 17, 2013 at 2:15 AM, Jim Baxter jim_bax...@mentor.com wrote: On 16/07/13 20:37, Sam Ravnborg wrote: On Tue, Jul 16, 2013 at 07:29:50PM +0100, Jim Baxter wrote: If CONFIG_SAMPLES is enabled with any of the sample modules enabled, they are only built if the make command includes uImage and modules (i.e. make uImage modules). With the current location samples are built when you build vmlinux. And vmlinux is implicit when you just type make. With the suggestion you have samples are built when you do make modules. IMO this is less logical than to built them with vmlinux as we do today. Sam Hi, I am building it with: make uImage make modules At least bitbake in Yocto and Openembedded is. Running make on it's own is the equivalent of: make vmlinux modules which builds the samples directory, however if you run: make vmlinux make modules Then the Samples are not built, that is what I am trying to fix. Thank you, Jim -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC] kbuild: Build samples directory with make modules
On 16/07/13 20:37, Sam Ravnborg wrote: > On Tue, Jul 16, 2013 at 07:29:50PM +0100, Jim Baxter wrote: >> If CONFIG_SAMPLES is enabled with any of the sample >> modules enabled, they are only built if the make command >> includes uImage and modules (i.e. make uImage modules). > > With the current location samples are built when you build vmlinux. > And vmlinux is implicit when you just type "make". > > With the suggestion you have samples are built when you do "make modules". > IMO this is less logical than to built them with vmlinux as we do today. > > Sam > Hi, I am building it with: make uImage make modules At least bitbake in Yocto and Openembedded is. Running make on it's own is the equivalent of: make vmlinux modules which builds the samples directory, however if you run: make vmlinux make modules Then the Samples are not built, that is what I am trying to fix. Thank you, Jim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC] kbuild: Build samples directory with make modules
On Tue, Jul 16, 2013 at 07:29:50PM +0100, Jim Baxter wrote: > If CONFIG_SAMPLES is enabled with any of the sample > modules enabled, they are only built if the make command > includes uImage and modules (i.e. make uImage modules). With the current location samples are built when you build vmlinux. And vmlinux is implicit when you just type "make". With the suggestion you have samples are built when you do "make modules". IMO this is less logical than to built them with vmlinux as we do today. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[RFC] kbuild: Build samples directory with make modules
If CONFIG_SAMPLES is enabled with any of the sample modules enabled, they are only built if the make command includes uImage and modules (i.e. make uImage modules). This patches allows the kernel and modules to be built separately, this is how openembedded and yocto build the kernel. Signed-off-by: Jim Baxter --- Makefile |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 29339b4..1acd69f 100644 --- a/Makefile +++ b/Makefile @@ -772,9 +772,6 @@ vmlinux: scripts/link-vmlinux.sh $(vmlinux-deps) FORCE ifdef CONFIG_HEADERS_CHECK $(Q)$(MAKE) -f $(srctree)/Makefile headers_check endif -ifdef CONFIG_SAMPLES - $(Q)$(MAKE) $(build)=samples -endif ifdef CONFIG_BUILD_DOCSRC $(Q)$(MAKE) $(build)=Documentation endif @@ -943,6 +940,9 @@ all: modules PHONY += modules modules: $(vmlinux-dirs) $(if $(KBUILD_BUILTIN),vmlinux) modules.builtin +ifdef CONFIG_SAMPLES + $(Q)$(MAKE) $(build)=samples +endif $(Q)$(AWK) '!x[$$0]++' $(vmlinux-dirs:%=$(objtree)/%/modules.order) > $(objtree)/modules.order @$(kecho) ' Building modules, stage 2.'; $(Q)$(MAKE) -f $(srctree)/scripts/Makefile.modpost -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[RFC] kbuild: Build samples directory with make modules
If CONFIG_SAMPLES is enabled with any of the sample modules enabled, they are only built if the make command includes uImage and modules (i.e. make uImage modules). This patches allows the kernel and modules to be built separately, this is how openembedded and yocto build the kernel. Signed-off-by: Jim Baxter jim_bax...@mentor.com --- Makefile |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 29339b4..1acd69f 100644 --- a/Makefile +++ b/Makefile @@ -772,9 +772,6 @@ vmlinux: scripts/link-vmlinux.sh $(vmlinux-deps) FORCE ifdef CONFIG_HEADERS_CHECK $(Q)$(MAKE) -f $(srctree)/Makefile headers_check endif -ifdef CONFIG_SAMPLES - $(Q)$(MAKE) $(build)=samples -endif ifdef CONFIG_BUILD_DOCSRC $(Q)$(MAKE) $(build)=Documentation endif @@ -943,6 +940,9 @@ all: modules PHONY += modules modules: $(vmlinux-dirs) $(if $(KBUILD_BUILTIN),vmlinux) modules.builtin +ifdef CONFIG_SAMPLES + $(Q)$(MAKE) $(build)=samples +endif $(Q)$(AWK) '!x[$$0]++' $(vmlinux-dirs:%=$(objtree)/%/modules.order) $(objtree)/modules.order @$(kecho) ' Building modules, stage 2.'; $(Q)$(MAKE) -f $(srctree)/scripts/Makefile.modpost -- 1.7.10.4 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC] kbuild: Build samples directory with make modules
On Tue, Jul 16, 2013 at 07:29:50PM +0100, Jim Baxter wrote: If CONFIG_SAMPLES is enabled with any of the sample modules enabled, they are only built if the make command includes uImage and modules (i.e. make uImage modules). With the current location samples are built when you build vmlinux. And vmlinux is implicit when you just type make. With the suggestion you have samples are built when you do make modules. IMO this is less logical than to built them with vmlinux as we do today. Sam -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC] kbuild: Build samples directory with make modules
On 16/07/13 20:37, Sam Ravnborg wrote: On Tue, Jul 16, 2013 at 07:29:50PM +0100, Jim Baxter wrote: If CONFIG_SAMPLES is enabled with any of the sample modules enabled, they are only built if the make command includes uImage and modules (i.e. make uImage modules). With the current location samples are built when you build vmlinux. And vmlinux is implicit when you just type make. With the suggestion you have samples are built when you do make modules. IMO this is less logical than to built them with vmlinux as we do today. Sam Hi, I am building it with: make uImage make modules At least bitbake in Yocto and Openembedded is. Running make on it's own is the equivalent of: make vmlinux modules which builds the samples directory, however if you run: make vmlinux make modules Then the Samples are not built, that is what I am trying to fix. Thank you, Jim -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
