Re: [RFC 05/19] devfreq: imx8m-ddrc: Change governor to powersave

[Dong Aisheng]

On Sat, Feb 20, 2021 at 12:03 AM Abel Vesa  wrote:
>
> By switching to powersave governor, we allow the imx8m-ddrc to always
> run at minimum rate needed by all the running masters.
>
> Signed-off-by: Abel Vesa 

Would you please help clarify a bit more why need use powersave by default?

Regards
Aisheng

> ---
>  drivers/devfreq/imx8m-ddrc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/devfreq/imx8m-ddrc.c b/drivers/devfreq/imx8m-ddrc.c
> index bc82d3653bff..3a6c04ba4f2e 100644
> --- a/drivers/devfreq/imx8m-ddrc.c
> +++ b/drivers/devfreq/imx8m-ddrc.c
> @@ -379,7 +379,7 @@ static int imx8m_ddrc_probe(struct platform_device *pdev)
>  {
> struct device *dev = >dev;
> struct imx8m_ddrc *priv;
> -   const char *gov = DEVFREQ_GOV_USERSPACE;
> +   const char *gov = DEVFREQ_GOV_POWERSAVE;
> int ret;
>
> priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> --
> 2.29.2
>

Re: [RFC 05/19] devfreq: imx8m-ddrc: Change governor to powersave

[Chanwoo Choi]

On 21. 2. 20. 오전 1:00, Abel Vesa wrote:

By switching to powersave governor, we allow the imx8m-ddrc to always
run at minimum rate needed by all the running masters.

Signed-off-by: Abel Vesa 
---
  drivers/devfreq/imx8m-ddrc.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/devfreq/imx8m-ddrc.c b/drivers/devfreq/imx8m-ddrc.c
index bc82d3653bff..3a6c04ba4f2e 100644
--- a/drivers/devfreq/imx8m-ddrc.c
+++ b/drivers/devfreq/imx8m-ddrc.c
@@ -379,7 +379,7 @@ static int imx8m_ddrc_probe(struct platform_device *pdev)
  {
struct device *dev = >dev;
struct imx8m_ddrc *priv;
-   const char *gov = DEVFREQ_GOV_USERSPACE;
+   const char *gov = DEVFREQ_GOV_POWERSAVE;
int ret;
  
  	priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);




Acked-by: Chanwoo Choi 

Thanks,
Chanwoo Choi

[RFC 05/19] devfreq: imx8m-ddrc: Change governor to powersave

[Abel Vesa]

By switching to powersave governor, we allow the imx8m-ddrc to always
run at minimum rate needed by all the running masters.

Signed-off-by: Abel Vesa 
---
 drivers/devfreq/imx8m-ddrc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/devfreq/imx8m-ddrc.c b/drivers/devfreq/imx8m-ddrc.c
index bc82d3653bff..3a6c04ba4f2e 100644
--- a/drivers/devfreq/imx8m-ddrc.c
+++ b/drivers/devfreq/imx8m-ddrc.c
@@ -379,7 +379,7 @@ static int imx8m_ddrc_probe(struct platform_device *pdev)
 {
struct device *dev = >dev;
struct imx8m_ddrc *priv;
-   const char *gov = DEVFREQ_GOV_USERSPACE;
+   const char *gov = DEVFREQ_GOV_POWERSAVE;
int ret;
 
priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
-- 
2.29.2