subject:"\[RFC PATCH\] x86\: Config options to assign versions in the PE\-COFF header"

Re: [RFC PATCH] x86: Config options to assign versions in the PE-COFF header

2017-04-13 Thread hpa

On April 13, 2017 8:51:19 PM PDT, Gary Lin  wrote:
>On Thu, Apr 13, 2017 at 03:21:20PM -0700, h...@zytor.com wrote:
>> On April 11, 2017 3:20:41 AM PDT, Gary Lin  wrote:
>> >This commit adds the new config options to allow the user to modify
>the
>> >following fields in the PE-COFF header.
>> >
>> >UINT16 MajorOperatingSystemVersion
>> >UINT16 MinorOperatingSystemVersion
>> >UINT16 MajorImageVersion
>> >UINT16 MinorImageVersion
>> >
>> >Those fields are mainly for the executables or libraries in Windows
>NT
>> >or higher to specify the minimum supported Windows version and the
>> >version of the image itself.
>> >
>> >Given the fact that those fields are ignored in UEFI, we can safely
>> >reuse
>> >those fields for other purposes, e.g. Security Version(*).
>> >
>> >(*) https://github.com/lcp/shim/wiki/Security-Version
>> >
>> >Cc: Thomas Gleixner 
>> >Cc: Ingo Molnar 
>> >Cc: "H. Peter Anvin" 
>> >Cc: Masahiro Yamada 
>> >Cc: Michal Marek 
>> >Cc: Matt Fleming 
>> >Cc: Ard Biesheuvel 
>> >Cc: Joey Lee 
>> >Cc: Vojtech Pavlik 
>> >Signed-off-by: Gary Lin 
>> >Tested-by: Joey Lee 
>> >---
>[snip]
>> 
>> Reusing PECOFF fields seems doubleplusunsafe: we don't own those
>fields, the UEFI forum does.  It would make a lot more sense to add
>these fields to the bzImage header directly or indirectly (via a
>pointer), the latter would be more economical since the bzImage header
>size is bounded.
>> 
>> We could even define it as a pointer to a "security information
>header" with its own size field, so it can be grown in the future as
>needed.
>Reusing PE-COFF simplifies the implementation since shim can parse the
>header directly. I can raise the issue to the UEFI forum to clarify the
>usage of those fields.
>
>Meanwhile, I'll also look into the bzImage header in case the PE-COFF
>header is really a NO-GO.
>
>Thanks,
>
>Gary Lin

If we are going to use the PE-COFF hear then you need to write a proposal and 
get the UEFI forum to sign off on it.
-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

Re: [RFC PATCH] x86: Config options to assign versions in the PE-COFF header

2017-04-13 Thread hpa

On April 13, 2017 8:51:19 PM PDT, Gary Lin  wrote:
>On Thu, Apr 13, 2017 at 03:21:20PM -0700, h...@zytor.com wrote:
>> On April 11, 2017 3:20:41 AM PDT, Gary Lin  wrote:
>> >This commit adds the new config options to allow the user to modify
>the
>> >following fields in the PE-COFF header.
>> >
>> >UINT16 MajorOperatingSystemVersion
>> >UINT16 MinorOperatingSystemVersion
>> >UINT16 MajorImageVersion
>> >UINT16 MinorImageVersion
>> >
>> >Those fields are mainly for the executables or libraries in Windows
>NT
>> >or higher to specify the minimum supported Windows version and the
>> >version of the image itself.
>> >
>> >Given the fact that those fields are ignored in UEFI, we can safely
>> >reuse
>> >those fields for other purposes, e.g. Security Version(*).
>> >
>> >(*) https://github.com/lcp/shim/wiki/Security-Version
>> >
>> >Cc: Thomas Gleixner 
>> >Cc: Ingo Molnar 
>> >Cc: "H. Peter Anvin" 
>> >Cc: Masahiro Yamada 
>> >Cc: Michal Marek 
>> >Cc: Matt Fleming 
>> >Cc: Ard Biesheuvel 
>> >Cc: Joey Lee 
>> >Cc: Vojtech Pavlik 
>> >Signed-off-by: Gary Lin 
>> >Tested-by: Joey Lee 
>> >---
>[snip]
>> 
>> Reusing PECOFF fields seems doubleplusunsafe: we don't own those
>fields, the UEFI forum does.  It would make a lot more sense to add
>these fields to the bzImage header directly or indirectly (via a
>pointer), the latter would be more economical since the bzImage header
>size is bounded.
>> 
>> We could even define it as a pointer to a "security information
>header" with its own size field, so it can be grown in the future as
>needed.
>Reusing PE-COFF simplifies the implementation since shim can parse the
>header directly. I can raise the issue to the UEFI forum to clarify the
>usage of those fields.
>
>Meanwhile, I'll also look into the bzImage header in case the PE-COFF
>header is really a NO-GO.
>
>Thanks,
>
>Gary Lin

If we are going to use the PE-COFF hear then you need to write a proposal and 
get the UEFI forum to sign off on it.
-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

Re: [RFC PATCH] x86: Config options to assign versions in the PE-COFF header

2017-04-13 Thread Gary Lin

On Thu, Apr 13, 2017 at 03:21:20PM -0700, h...@zytor.com wrote:
> On April 11, 2017 3:20:41 AM PDT, Gary Lin  wrote:
> >This commit adds the new config options to allow the user to modify the
> >following fields in the PE-COFF header.
> >
> >UINT16 MajorOperatingSystemVersion
> >UINT16 MinorOperatingSystemVersion
> >UINT16 MajorImageVersion
> >UINT16 MinorImageVersion
> >
> >Those fields are mainly for the executables or libraries in Windows NT
> >or higher to specify the minimum supported Windows version and the
> >version of the image itself.
> >
> >Given the fact that those fields are ignored in UEFI, we can safely
> >reuse
> >those fields for other purposes, e.g. Security Version(*).
> >
> >(*) https://github.com/lcp/shim/wiki/Security-Version
> >
> >Cc: Thomas Gleixner 
> >Cc: Ingo Molnar 
> >Cc: "H. Peter Anvin" 
> >Cc: Masahiro Yamada 
> >Cc: Michal Marek 
> >Cc: Matt Fleming 
> >Cc: Ard Biesheuvel 
> >Cc: Joey Lee 
> >Cc: Vojtech Pavlik 
> >Signed-off-by: Gary Lin 
> >Tested-by: Joey Lee 
> >---
[snip]
> 
> Reusing PECOFF fields seems doubleplusunsafe: we don't own those fields, the 
> UEFI forum does.  It would make a lot more sense to add these fields to the 
> bzImage header directly or indirectly (via a pointer), the latter would be 
> more economical since the bzImage header size is bounded.
> 
> We could even define it as a pointer to a "security information header" with 
> its own size field, so it can be grown in the future as needed.
Reusing PE-COFF simplifies the implementation since shim can parse the
header directly. I can raise the issue to the UEFI forum to clarify the
usage of those fields.

Meanwhile, I'll also look into the bzImage header in case the PE-COFF
header is really a NO-GO.

Thanks,

Gary Lin

Re: [RFC PATCH] x86: Config options to assign versions in the PE-COFF header

2017-04-13 Thread Gary Lin

On Thu, Apr 13, 2017 at 03:21:20PM -0700, h...@zytor.com wrote:
> On April 11, 2017 3:20:41 AM PDT, Gary Lin  wrote:
> >This commit adds the new config options to allow the user to modify the
> >following fields in the PE-COFF header.
> >
> >UINT16 MajorOperatingSystemVersion
> >UINT16 MinorOperatingSystemVersion
> >UINT16 MajorImageVersion
> >UINT16 MinorImageVersion
> >
> >Those fields are mainly for the executables or libraries in Windows NT
> >or higher to specify the minimum supported Windows version and the
> >version of the image itself.
> >
> >Given the fact that those fields are ignored in UEFI, we can safely
> >reuse
> >those fields for other purposes, e.g. Security Version(*).
> >
> >(*) https://github.com/lcp/shim/wiki/Security-Version
> >
> >Cc: Thomas Gleixner 
> >Cc: Ingo Molnar 
> >Cc: "H. Peter Anvin" 
> >Cc: Masahiro Yamada 
> >Cc: Michal Marek 
> >Cc: Matt Fleming 
> >Cc: Ard Biesheuvel 
> >Cc: Joey Lee 
> >Cc: Vojtech Pavlik 
> >Signed-off-by: Gary Lin 
> >Tested-by: Joey Lee 
> >---
[snip]
> 
> Reusing PECOFF fields seems doubleplusunsafe: we don't own those fields, the 
> UEFI forum does.  It would make a lot more sense to add these fields to the 
> bzImage header directly or indirectly (via a pointer), the latter would be 
> more economical since the bzImage header size is bounded.
> 
> We could even define it as a pointer to a "security information header" with 
> its own size field, so it can be grown in the future as needed.
Reusing PE-COFF simplifies the implementation since shim can parse the
header directly. I can raise the issue to the UEFI forum to clarify the
usage of those fields.

Meanwhile, I'll also look into the bzImage header in case the PE-COFF
header is really a NO-GO.

Thanks,

Gary Lin

Re: [RFC PATCH] x86: Config options to assign versions in the PE-COFF header

2017-04-13 Thread hpa

On April 11, 2017 3:20:41 AM PDT, Gary Lin  wrote:
>This commit adds the new config options to allow the user to modify the
>following fields in the PE-COFF header.
>
>UINT16 MajorOperatingSystemVersion
>UINT16 MinorOperatingSystemVersion
>UINT16 MajorImageVersion
>UINT16 MinorImageVersion
>
>Those fields are mainly for the executables or libraries in Windows NT
>or higher to specify the minimum supported Windows version and the
>version of the image itself.
>
>Given the fact that those fields are ignored in UEFI, we can safely
>reuse
>those fields for other purposes, e.g. Security Version(*).
>
>(*) https://github.com/lcp/shim/wiki/Security-Version
>
>Cc: Thomas Gleixner 
>Cc: Ingo Molnar 
>Cc: "H. Peter Anvin" 
>Cc: Masahiro Yamada 
>Cc: Michal Marek 
>Cc: Matt Fleming 
>Cc: Ard Biesheuvel 
>Cc: Joey Lee 
>Cc: Vojtech Pavlik 
>Signed-off-by: Gary Lin 
>Tested-by: Joey Lee 
>---
> arch/x86/Kconfig   |  24 +++
> arch/x86/boot/Makefile |  10 +++
>scripts/efiversion.pl  | 192
>+
> 3 files changed, 226 insertions(+)
> create mode 100755 scripts/efiversion.pl
>
>diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
>index 5bbdef151805..f281c0ff3ff6 100644
>--- a/arch/x86/Kconfig
>+++ b/arch/x86/Kconfig
>@@ -1803,6 +1803,30 @@ config EFI_STUB
> 
> See Documentation/efi-stub.txt for more information.
> 
>+config EFI_MAJOR_OS_VERSION
>+  hex "EFI Major OS Version"
>+  range 0x0 0x
>+  default "0x0"
>+  depends on EFI_STUB
>+
>+config EFI_MINOR_OS_VERSION
>+  hex "EFI Minor OS Version"
>+  range 0x0 0x
>+  default "0x0"
>+  depends on EFI_STUB
>+
>+config EFI_MAJOR_IMAGE_VERSION
>+  hex "EFI Major Image Version"
>+  range 0x0 0x
>+  default "0x0"
>+  depends on EFI_STUB
>+
>+config EFI_MINOR_IMAGE_VERSION
>+  hex "EFI Minor Image Version"
>+  range 0x0 0x
>+  default "0x0"
>+  depends on EFI_STUB
>+
> config EFI_MIXED
>   bool "EFI mixed-mode support"
>   depends on EFI_STUB && X86_64
>diff --git a/arch/x86/boot/Makefile b/arch/x86/boot/Makefile
>index 0d810fb15eac..b9de8b50f32a 100644
>--- a/arch/x86/boot/Makefile
>+++ b/arch/x86/boot/Makefile
>@@ -76,8 +76,18 @@ quiet_cmd_image = BUILD   $@
> cmd_image = $(obj)/tools/build $(obj)/setup.bin $(obj)/vmlinux.bin \
>  $(obj)/zoffset.h $@
> 
>+cmd_efiversion = scripts/efiversion.pl \
>+  --major-os=$(CONFIG_EFI_MAJOR_OS_VERSION) \
>+  --minor-os=$(CONFIG_EFI_MINOR_OS_VERSION) \
>+  --major-image=$(CONFIG_EFI_MAJOR_IMAGE_VERSION) \
>+  --minor-image=$(CONFIG_EFI_MINOR_IMAGE_VERSION) \
>+  $@
>+
>$(obj)/bzImage: $(obj)/setup.bin $(obj)/vmlinux.bin $(obj)/tools/build
>FORCE
>   $(call if_changed,image)
>+ifeq ($(CONFIG_EFI_STUB),y)
>+  $(call if_changed,efiversion,$@)
>+endif
>   @echo 'Kernel: $@ is ready' ' (#'`cat .version`')'
> 
> OBJCOPYFLAGS_vmlinux.bin := -O binary -R .note -R .comment -S
>diff --git a/scripts/efiversion.pl b/scripts/efiversion.pl
>new file mode 100755
>index ..fe730d10638a
>--- /dev/null
>+++ b/scripts/efiversion.pl
>@@ -0,0 +1,192 @@
>+#!/usr/bin/perl
>+
>+=head1 efiversion.pl
>+
>+efiversion.pl - show or modify the version fields in the EFI image
>+
>+=head1 SYNOPSIS
>+
>+efiversion.pl [OPTIONS] FILE
>+
>+=head1 OPTIONS
>+
>+=over 4
>+
>+=item B<--major-os=NUMBER>
>+
>+assign the major OS version
>+
>+=item B<--minor-os=NUMBER>
>+
>+assign the minor OS version
>+
>+=item B<--major-image=NUMBER>
>+
>+assign the major image version
>+
>+=item B<--minor-image=NUMBER>
>+
>+assign the minor image version
>+
>+=item B<--help, -h>
>+
>+print help
>+
>+=back
>+
>+=head1 DESCRIPTION
>+
>+A script to modify the version fields in the header of the EFI image
>+
>+Show the versions:
>+$ efiversion.pl sample.efi
>+
>+Modify the versions:
>+$ efiversion.pl --major-os=1 --minor-os=2 sample.efi
>+
>+=cut
>+
>+use strict;
>+use warnings;
>+use FileHandle;
>+use Getopt::Long;
>+Getopt::Long::Configure("no_ignore_case");
>+
>+my %options;
>+
>+sub usage($) {
>+  my $r = shift;
>+  eval "use Pod::Usage; pod2usage($r);";
>+  if ($@) {
>+  die "cannot display help, install perl(Pod::Usage)\n";
>+  }
>+}
>+
>+my $options;
>+my $major_os = '';
>+my $minor_os = '';
>+my $major_image = '';
>+my $minor_image = '';
>+my $help = '';
>+my $overwrite = '';
>+
>+GetOptions(
>+  "major-os=o" => \$major_os,
>+  "minor-os=o" => \$minor_os,
>+  "major-image=o" => \$major_image,
>+  "minor-image=o" => \$minor_image,
>+  "help|h" => \$help,
>+) or usage(1);
>+
>+usage(1) unless @ARGV;
>+usage(0) if ($help);
>+

Re: [RFC PATCH] x86: Config options to assign versions in the PE-COFF header

2017-04-13 Thread hpa

On April 11, 2017 3:20:41 AM PDT, Gary Lin  wrote:
>This commit adds the new config options to allow the user to modify the
>following fields in the PE-COFF header.
>
>UINT16 MajorOperatingSystemVersion
>UINT16 MinorOperatingSystemVersion
>UINT16 MajorImageVersion
>UINT16 MinorImageVersion
>
>Those fields are mainly for the executables or libraries in Windows NT
>or higher to specify the minimum supported Windows version and the
>version of the image itself.
>
>Given the fact that those fields are ignored in UEFI, we can safely
>reuse
>those fields for other purposes, e.g. Security Version(*).
>
>(*) https://github.com/lcp/shim/wiki/Security-Version
>
>Cc: Thomas Gleixner 
>Cc: Ingo Molnar 
>Cc: "H. Peter Anvin" 
>Cc: Masahiro Yamada 
>Cc: Michal Marek 
>Cc: Matt Fleming 
>Cc: Ard Biesheuvel 
>Cc: Joey Lee 
>Cc: Vojtech Pavlik 
>Signed-off-by: Gary Lin 
>Tested-by: Joey Lee 
>---
> arch/x86/Kconfig   |  24 +++
> arch/x86/boot/Makefile |  10 +++
>scripts/efiversion.pl  | 192
>+
> 3 files changed, 226 insertions(+)
> create mode 100755 scripts/efiversion.pl
>
>diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
>index 5bbdef151805..f281c0ff3ff6 100644
>--- a/arch/x86/Kconfig
>+++ b/arch/x86/Kconfig
>@@ -1803,6 +1803,30 @@ config EFI_STUB
> 
> See Documentation/efi-stub.txt for more information.
> 
>+config EFI_MAJOR_OS_VERSION
>+  hex "EFI Major OS Version"
>+  range 0x0 0x
>+  default "0x0"
>+  depends on EFI_STUB
>+
>+config EFI_MINOR_OS_VERSION
>+  hex "EFI Minor OS Version"
>+  range 0x0 0x
>+  default "0x0"
>+  depends on EFI_STUB
>+
>+config EFI_MAJOR_IMAGE_VERSION
>+  hex "EFI Major Image Version"
>+  range 0x0 0x
>+  default "0x0"
>+  depends on EFI_STUB
>+
>+config EFI_MINOR_IMAGE_VERSION
>+  hex "EFI Minor Image Version"
>+  range 0x0 0x
>+  default "0x0"
>+  depends on EFI_STUB
>+
> config EFI_MIXED
>   bool "EFI mixed-mode support"
>   depends on EFI_STUB && X86_64
>diff --git a/arch/x86/boot/Makefile b/arch/x86/boot/Makefile
>index 0d810fb15eac..b9de8b50f32a 100644
>--- a/arch/x86/boot/Makefile
>+++ b/arch/x86/boot/Makefile
>@@ -76,8 +76,18 @@ quiet_cmd_image = BUILD   $@
> cmd_image = $(obj)/tools/build $(obj)/setup.bin $(obj)/vmlinux.bin \
>  $(obj)/zoffset.h $@
> 
>+cmd_efiversion = scripts/efiversion.pl \
>+  --major-os=$(CONFIG_EFI_MAJOR_OS_VERSION) \
>+  --minor-os=$(CONFIG_EFI_MINOR_OS_VERSION) \
>+  --major-image=$(CONFIG_EFI_MAJOR_IMAGE_VERSION) \
>+  --minor-image=$(CONFIG_EFI_MINOR_IMAGE_VERSION) \
>+  $@
>+
>$(obj)/bzImage: $(obj)/setup.bin $(obj)/vmlinux.bin $(obj)/tools/build
>FORCE
>   $(call if_changed,image)
>+ifeq ($(CONFIG_EFI_STUB),y)
>+  $(call if_changed,efiversion,$@)
>+endif
>   @echo 'Kernel: $@ is ready' ' (#'`cat .version`')'
> 
> OBJCOPYFLAGS_vmlinux.bin := -O binary -R .note -R .comment -S
>diff --git a/scripts/efiversion.pl b/scripts/efiversion.pl
>new file mode 100755
>index ..fe730d10638a
>--- /dev/null
>+++ b/scripts/efiversion.pl
>@@ -0,0 +1,192 @@
>+#!/usr/bin/perl
>+
>+=head1 efiversion.pl
>+
>+efiversion.pl - show or modify the version fields in the EFI image
>+
>+=head1 SYNOPSIS
>+
>+efiversion.pl [OPTIONS] FILE
>+
>+=head1 OPTIONS
>+
>+=over 4
>+
>+=item B<--major-os=NUMBER>
>+
>+assign the major OS version
>+
>+=item B<--minor-os=NUMBER>
>+
>+assign the minor OS version
>+
>+=item B<--major-image=NUMBER>
>+
>+assign the major image version
>+
>+=item B<--minor-image=NUMBER>
>+
>+assign the minor image version
>+
>+=item B<--help, -h>
>+
>+print help
>+
>+=back
>+
>+=head1 DESCRIPTION
>+
>+A script to modify the version fields in the header of the EFI image
>+
>+Show the versions:
>+$ efiversion.pl sample.efi
>+
>+Modify the versions:
>+$ efiversion.pl --major-os=1 --minor-os=2 sample.efi
>+
>+=cut
>+
>+use strict;
>+use warnings;
>+use FileHandle;
>+use Getopt::Long;
>+Getopt::Long::Configure("no_ignore_case");
>+
>+my %options;
>+
>+sub usage($) {
>+  my $r = shift;
>+  eval "use Pod::Usage; pod2usage($r);";
>+  if ($@) {
>+  die "cannot display help, install perl(Pod::Usage)\n";
>+  }
>+}
>+
>+my $options;
>+my $major_os = '';
>+my $minor_os = '';
>+my $major_image = '';
>+my $minor_image = '';
>+my $help = '';
>+my $overwrite = '';
>+
>+GetOptions(
>+  "major-os=o" => \$major_os,
>+  "minor-os=o" => \$minor_os,
>+  "major-image=o" => \$major_image,
>+  "minor-image=o" => \$minor_image,
>+  "help|h" => \$help,
>+) or usage(1);
>+
>+usage(1) unless @ARGV;
>+usage(0) if ($help);
>+
>+sub not_ushort($)
>+{
>+  my ($number) = @_;
>+
>+  return 0 unless $number;
>+  return 1 if ($number < 0 or $number > 0x);
>+
>+  $overwrite = "y";
>+
>+  return 0;
>+}
>+
>+sub check_args
>+{
>+  return

Re: [RFC PATCH] x86: Config options to assign versions in the PE-COFF header

2017-04-11 Thread Gary Lin

On Tue, Apr 11, 2017 at 06:37:54PM +0100, Ard Biesheuvel wrote:
> On 11 April 2017 at 11:20, Gary Lin  wrote:
> > This commit adds the new config options to allow the user to modify the
> > following fields in the PE-COFF header.
> >
> > UINT16 MajorOperatingSystemVersion
> > UINT16 MinorOperatingSystemVersion
> > UINT16 MajorImageVersion
> > UINT16 MinorImageVersion
> >
> > Those fields are mainly for the executables or libraries in Windows NT
> > or higher to specify the minimum supported Windows version and the
> > version of the image itself.
> >
> > Given the fact that those fields are ignored in UEFI, we can safely reuse
> > those fields for other purposes, e.g. Security Version(*).
> >
> > (*) https://github.com/lcp/shim/wiki/Security-Version
> >
> > Cc: Thomas Gleixner 
> > Cc: Ingo Molnar 
> > Cc: "H. Peter Anvin" 
> > Cc: Masahiro Yamada 
> > Cc: Michal Marek 
> > Cc: Matt Fleming 
> > Cc: Ard Biesheuvel 
> > Cc: Joey Lee 
> > Cc: Vojtech Pavlik 
> > Signed-off-by: Gary Lin 
> > Tested-by: Joey Lee 
> > ---
> >  arch/x86/Kconfig   |  24 +++
> >  arch/x86/boot/Makefile |  10 +++
> >  scripts/efiversion.pl  | 192 
> > +
> >  3 files changed, 226 insertions(+)
> >  create mode 100755 scripts/efiversion.pl
> >
> > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> > index 5bbdef151805..f281c0ff3ff6 100644
> > --- a/arch/x86/Kconfig
> > +++ b/arch/x86/Kconfig
> > @@ -1803,6 +1803,30 @@ config EFI_STUB
> >
> >   See Documentation/efi-stub.txt for more information.
> >
> > +config EFI_MAJOR_OS_VERSION
> > +   hex "EFI Major OS Version"
> > +   range 0x0 0x
> > +   default "0x0"
> > +   depends on EFI_STUB
> > +
> > +config EFI_MINOR_OS_VERSION
> > +   hex "EFI Minor OS Version"
> > +   range 0x0 0x
> > +   default "0x0"
> > +   depends on EFI_STUB
> > +
> > +config EFI_MAJOR_IMAGE_VERSION
> > +   hex "EFI Major Image Version"
> > +   range 0x0 0x
> > +   default "0x0"
> > +   depends on EFI_STUB
> > +
> > +config EFI_MINOR_IMAGE_VERSION
> > +   hex "EFI Minor Image Version"
> > +   range 0x0 0x
> > +   default "0x0"
> > +   depends on EFI_STUB
> > +
> 
> Why is this x86 only?
> 
> >  config EFI_MIXED
> > bool "EFI mixed-mode support"
> > depends on EFI_STUB && X86_64
> > diff --git a/arch/x86/boot/Makefile b/arch/x86/boot/Makefile
> > index 0d810fb15eac..b9de8b50f32a 100644
> > --- a/arch/x86/boot/Makefile
> > +++ b/arch/x86/boot/Makefile
> > @@ -76,8 +76,18 @@ quiet_cmd_image = BUILD   $@
> >  cmd_image = $(obj)/tools/build $(obj)/setup.bin $(obj)/vmlinux.bin \
> >$(obj)/zoffset.h $@
> >
> > +cmd_efiversion = scripts/efiversion.pl \
> > +   --major-os=$(CONFIG_EFI_MAJOR_OS_VERSION) \
> > +   --minor-os=$(CONFIG_EFI_MINOR_OS_VERSION) \
> > +   --major-image=$(CONFIG_EFI_MAJOR_IMAGE_VERSION) \
> > +   --minor-image=$(CONFIG_EFI_MINOR_IMAGE_VERSION) \
> > +   $@
> > +
> >  $(obj)/bzImage: $(obj)/setup.bin $(obj)/vmlinux.bin $(obj)/tools/build 
> > FORCE
> > $(call if_changed,image)
> > +ifeq ($(CONFIG_EFI_STUB),y)
> > +   $(call if_changed,efiversion,$@)
> > +endif
> > @echo 'Kernel: $@ is ready' ' (#'`cat .version`')'
> >
> 
> Do we need a script? Can't we just use those defines in the PE/COFF
> header directly? I.e., something like
> 
> diff --git a/arch/x86/boot/header.S b/arch/x86/boot/header.S
> index 3dd5be33aaa7..da21b48a2d68 100644
> --- a/arch/x86/boot/header.S
> +++ b/arch/x86/boot/header.S
> @@ -156,10 +156,10 @@ extra_header_fields:
>  #endif
> .long   0x20# SectionAlignment
> .long   0x20# FileAlignment
> -   .word   0   # MajorOperatingSystemVersion
> -   .word   0   # MinorOperatingSystemVersion
> -   .word   0   # MajorImageVersion
> -   .word   0   # MinorImageVersion
> +   .word   CONFIG_EFI_MAJOR_OS_VERSION # MajorOperatingSystemVersion
> +   .word   CONFIG_EFI_MINOR_OS_VERSION # MinorOperatingSystemVersion
> +   .word   CONFIG_EFI_MAJOR_IMAGE_VERSION  # MajorImageVersion
> +   .word   CONFIG_EFI_MINOR_IMAGE_VERSION  # MinorImageVersion
> .word   0   # MajorSubsystemVersion
> .word   0   # MinorSubsystemVersion
> .long   0   # Win32VersionValue
> 
This looks much saner! I was using the script to modify and check EFI
images and

Re: [RFC PATCH] x86: Config options to assign versions in the PE-COFF header

2017-04-11 Thread Gary Lin

On Tue, Apr 11, 2017 at 06:37:54PM +0100, Ard Biesheuvel wrote:
> On 11 April 2017 at 11:20, Gary Lin  wrote:
> > This commit adds the new config options to allow the user to modify the
> > following fields in the PE-COFF header.
> >
> > UINT16 MajorOperatingSystemVersion
> > UINT16 MinorOperatingSystemVersion
> > UINT16 MajorImageVersion
> > UINT16 MinorImageVersion
> >
> > Those fields are mainly for the executables or libraries in Windows NT
> > or higher to specify the minimum supported Windows version and the
> > version of the image itself.
> >
> > Given the fact that those fields are ignored in UEFI, we can safely reuse
> > those fields for other purposes, e.g. Security Version(*).
> >
> > (*) https://github.com/lcp/shim/wiki/Security-Version
> >
> > Cc: Thomas Gleixner 
> > Cc: Ingo Molnar 
> > Cc: "H. Peter Anvin" 
> > Cc: Masahiro Yamada 
> > Cc: Michal Marek 
> > Cc: Matt Fleming 
> > Cc: Ard Biesheuvel 
> > Cc: Joey Lee 
> > Cc: Vojtech Pavlik 
> > Signed-off-by: Gary Lin 
> > Tested-by: Joey Lee 
> > ---
> >  arch/x86/Kconfig   |  24 +++
> >  arch/x86/boot/Makefile |  10 +++
> >  scripts/efiversion.pl  | 192 
> > +
> >  3 files changed, 226 insertions(+)
> >  create mode 100755 scripts/efiversion.pl
> >
> > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> > index 5bbdef151805..f281c0ff3ff6 100644
> > --- a/arch/x86/Kconfig
> > +++ b/arch/x86/Kconfig
> > @@ -1803,6 +1803,30 @@ config EFI_STUB
> >
> >   See Documentation/efi-stub.txt for more information.
> >
> > +config EFI_MAJOR_OS_VERSION
> > +   hex "EFI Major OS Version"
> > +   range 0x0 0x
> > +   default "0x0"
> > +   depends on EFI_STUB
> > +
> > +config EFI_MINOR_OS_VERSION
> > +   hex "EFI Minor OS Version"
> > +   range 0x0 0x
> > +   default "0x0"
> > +   depends on EFI_STUB
> > +
> > +config EFI_MAJOR_IMAGE_VERSION
> > +   hex "EFI Major Image Version"
> > +   range 0x0 0x
> > +   default "0x0"
> > +   depends on EFI_STUB
> > +
> > +config EFI_MINOR_IMAGE_VERSION
> > +   hex "EFI Minor Image Version"
> > +   range 0x0 0x
> > +   default "0x0"
> > +   depends on EFI_STUB
> > +
> 
> Why is this x86 only?
> 
> >  config EFI_MIXED
> > bool "EFI mixed-mode support"
> > depends on EFI_STUB && X86_64
> > diff --git a/arch/x86/boot/Makefile b/arch/x86/boot/Makefile
> > index 0d810fb15eac..b9de8b50f32a 100644
> > --- a/arch/x86/boot/Makefile
> > +++ b/arch/x86/boot/Makefile
> > @@ -76,8 +76,18 @@ quiet_cmd_image = BUILD   $@
> >  cmd_image = $(obj)/tools/build $(obj)/setup.bin $(obj)/vmlinux.bin \
> >$(obj)/zoffset.h $@
> >
> > +cmd_efiversion = scripts/efiversion.pl \
> > +   --major-os=$(CONFIG_EFI_MAJOR_OS_VERSION) \
> > +   --minor-os=$(CONFIG_EFI_MINOR_OS_VERSION) \
> > +   --major-image=$(CONFIG_EFI_MAJOR_IMAGE_VERSION) \
> > +   --minor-image=$(CONFIG_EFI_MINOR_IMAGE_VERSION) \
> > +   $@
> > +
> >  $(obj)/bzImage: $(obj)/setup.bin $(obj)/vmlinux.bin $(obj)/tools/build 
> > FORCE
> > $(call if_changed,image)
> > +ifeq ($(CONFIG_EFI_STUB),y)
> > +   $(call if_changed,efiversion,$@)
> > +endif
> > @echo 'Kernel: $@ is ready' ' (#'`cat .version`')'
> >
> 
> Do we need a script? Can't we just use those defines in the PE/COFF
> header directly? I.e., something like
> 
> diff --git a/arch/x86/boot/header.S b/arch/x86/boot/header.S
> index 3dd5be33aaa7..da21b48a2d68 100644
> --- a/arch/x86/boot/header.S
> +++ b/arch/x86/boot/header.S
> @@ -156,10 +156,10 @@ extra_header_fields:
>  #endif
> .long   0x20# SectionAlignment
> .long   0x20# FileAlignment
> -   .word   0   # MajorOperatingSystemVersion
> -   .word   0   # MinorOperatingSystemVersion
> -   .word   0   # MajorImageVersion
> -   .word   0   # MinorImageVersion
> +   .word   CONFIG_EFI_MAJOR_OS_VERSION # MajorOperatingSystemVersion
> +   .word   CONFIG_EFI_MINOR_OS_VERSION # MinorOperatingSystemVersion
> +   .word   CONFIG_EFI_MAJOR_IMAGE_VERSION  # MajorImageVersion
> +   .word   CONFIG_EFI_MINOR_IMAGE_VERSION  # MinorImageVersion
> .word   0   # MajorSubsystemVersion
> .word   0   # MinorSubsystemVersion
> .long   0   # Win32VersionValue
> 
This looks much saner! I was using the script to modify and check EFI
images and thought it's objcopy to generate the header. I'm happy to
know that I was wrong.

> (and again, why is this x86 only?)
> 
The reason is that I only tested on x86_64. I will add the patches for
ARM and ARM64 later.

Thanks,

Gary

Re: [RFC PATCH] x86: Config options to assign versions in the PE-COFF header

2017-04-11 Thread Ard Biesheuvel

On 11 April 2017 at 11:20, Gary Lin  wrote:
> This commit adds the new config options to allow the user to modify the
> following fields in the PE-COFF header.
>
> UINT16 MajorOperatingSystemVersion
> UINT16 MinorOperatingSystemVersion
> UINT16 MajorImageVersion
> UINT16 MinorImageVersion
>
> Those fields are mainly for the executables or libraries in Windows NT
> or higher to specify the minimum supported Windows version and the
> version of the image itself.
>
> Given the fact that those fields are ignored in UEFI, we can safely reuse
> those fields for other purposes, e.g. Security Version(*).
>
> (*) https://github.com/lcp/shim/wiki/Security-Version
>
> Cc: Thomas Gleixner 
> Cc: Ingo Molnar 
> Cc: "H. Peter Anvin" 
> Cc: Masahiro Yamada 
> Cc: Michal Marek 
> Cc: Matt Fleming 
> Cc: Ard Biesheuvel 
> Cc: Joey Lee 
> Cc: Vojtech Pavlik 
> Signed-off-by: Gary Lin 
> Tested-by: Joey Lee 
> ---
>  arch/x86/Kconfig   |  24 +++
>  arch/x86/boot/Makefile |  10 +++
>  scripts/efiversion.pl  | 192 
> +
>  3 files changed, 226 insertions(+)
>  create mode 100755 scripts/efiversion.pl
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 5bbdef151805..f281c0ff3ff6 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -1803,6 +1803,30 @@ config EFI_STUB
>
>   See Documentation/efi-stub.txt for more information.
>
> +config EFI_MAJOR_OS_VERSION
> +   hex "EFI Major OS Version"
> +   range 0x0 0x
> +   default "0x0"
> +   depends on EFI_STUB
> +
> +config EFI_MINOR_OS_VERSION
> +   hex "EFI Minor OS Version"
> +   range 0x0 0x
> +   default "0x0"
> +   depends on EFI_STUB
> +
> +config EFI_MAJOR_IMAGE_VERSION
> +   hex "EFI Major Image Version"
> +   range 0x0 0x
> +   default "0x0"
> +   depends on EFI_STUB
> +
> +config EFI_MINOR_IMAGE_VERSION
> +   hex "EFI Minor Image Version"
> +   range 0x0 0x
> +   default "0x0"
> +   depends on EFI_STUB
> +

Why is this x86 only?

>  config EFI_MIXED
> bool "EFI mixed-mode support"
> depends on EFI_STUB && X86_64
> diff --git a/arch/x86/boot/Makefile b/arch/x86/boot/Makefile
> index 0d810fb15eac..b9de8b50f32a 100644
> --- a/arch/x86/boot/Makefile
> +++ b/arch/x86/boot/Makefile
> @@ -76,8 +76,18 @@ quiet_cmd_image = BUILD   $@
>  cmd_image = $(obj)/tools/build $(obj)/setup.bin $(obj)/vmlinux.bin \
>$(obj)/zoffset.h $@
>
> +cmd_efiversion = scripts/efiversion.pl \
> +   --major-os=$(CONFIG_EFI_MAJOR_OS_VERSION) \
> +   --minor-os=$(CONFIG_EFI_MINOR_OS_VERSION) \
> +   --major-image=$(CONFIG_EFI_MAJOR_IMAGE_VERSION) \
> +   --minor-image=$(CONFIG_EFI_MINOR_IMAGE_VERSION) \
> +   $@
> +
>  $(obj)/bzImage: $(obj)/setup.bin $(obj)/vmlinux.bin $(obj)/tools/build FORCE
> $(call if_changed,image)
> +ifeq ($(CONFIG_EFI_STUB),y)
> +   $(call if_changed,efiversion,$@)
> +endif
> @echo 'Kernel: $@ is ready' ' (#'`cat .version`')'
>

Do we need a script? Can't we just use those defines in the PE/COFF
header directly? I.e., something like

diff --git a/arch/x86/boot/header.S b/arch/x86/boot/header.S
index 3dd5be33aaa7..da21b48a2d68 100644
--- a/arch/x86/boot/header.S
+++ b/arch/x86/boot/header.S
@@ -156,10 +156,10 @@ extra_header_fields:
 #endif
.long   0x20# SectionAlignment
.long   0x20# FileAlignment
-   .word   0   # MajorOperatingSystemVersion
-   .word   0   # MinorOperatingSystemVersion
-   .word   0   # MajorImageVersion
-   .word   0   # MinorImageVersion
+   .word   CONFIG_EFI_MAJOR_OS_VERSION # MajorOperatingSystemVersion
+   .word   CONFIG_EFI_MINOR_OS_VERSION # MinorOperatingSystemVersion
+   .word   CONFIG_EFI_MAJOR_IMAGE_VERSION  # MajorImageVersion
+   .word   CONFIG_EFI_MINOR_IMAGE_VERSION  # MinorImageVersion
.word   0   # MajorSubsystemVersion
.word   0   # MinorSubsystemVersion
.long   0   # Win32VersionValue

(and again, why is this x86 only?)




>  OBJCOPYFLAGS_vmlinux.bin := -O binary -R .note -R .comment -S
> diff --git a/scripts/efiversion.pl b/scripts/efiversion.pl
> new file mode 100755
> index ..fe730d10638a
> --- /dev/null
> +++ b/scripts/efiversion.pl
> @@ -0,0 +1,192 @@
> +#!/usr/bin/perl
> +
> +=head1 efiversion.pl
> +
> +efiversion.pl - show or modify the version

Re: [RFC PATCH] x86: Config options to assign versions in the PE-COFF header

2017-04-11 Thread Ard Biesheuvel

On 11 April 2017 at 11:20, Gary Lin  wrote:
> This commit adds the new config options to allow the user to modify the
> following fields in the PE-COFF header.
>
> UINT16 MajorOperatingSystemVersion
> UINT16 MinorOperatingSystemVersion
> UINT16 MajorImageVersion
> UINT16 MinorImageVersion
>
> Those fields are mainly for the executables or libraries in Windows NT
> or higher to specify the minimum supported Windows version and the
> version of the image itself.
>
> Given the fact that those fields are ignored in UEFI, we can safely reuse
> those fields for other purposes, e.g. Security Version(*).
>
> (*) https://github.com/lcp/shim/wiki/Security-Version
>
> Cc: Thomas Gleixner 
> Cc: Ingo Molnar 
> Cc: "H. Peter Anvin" 
> Cc: Masahiro Yamada 
> Cc: Michal Marek 
> Cc: Matt Fleming 
> Cc: Ard Biesheuvel 
> Cc: Joey Lee 
> Cc: Vojtech Pavlik 
> Signed-off-by: Gary Lin 
> Tested-by: Joey Lee 
> ---
>  arch/x86/Kconfig   |  24 +++
>  arch/x86/boot/Makefile |  10 +++
>  scripts/efiversion.pl  | 192 
> +
>  3 files changed, 226 insertions(+)
>  create mode 100755 scripts/efiversion.pl
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 5bbdef151805..f281c0ff3ff6 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -1803,6 +1803,30 @@ config EFI_STUB
>
>   See Documentation/efi-stub.txt for more information.
>
> +config EFI_MAJOR_OS_VERSION
> +   hex "EFI Major OS Version"
> +   range 0x0 0x
> +   default "0x0"
> +   depends on EFI_STUB
> +
> +config EFI_MINOR_OS_VERSION
> +   hex "EFI Minor OS Version"
> +   range 0x0 0x
> +   default "0x0"
> +   depends on EFI_STUB
> +
> +config EFI_MAJOR_IMAGE_VERSION
> +   hex "EFI Major Image Version"
> +   range 0x0 0x
> +   default "0x0"
> +   depends on EFI_STUB
> +
> +config EFI_MINOR_IMAGE_VERSION
> +   hex "EFI Minor Image Version"
> +   range 0x0 0x
> +   default "0x0"
> +   depends on EFI_STUB
> +

Why is this x86 only?

>  config EFI_MIXED
> bool "EFI mixed-mode support"
> depends on EFI_STUB && X86_64
> diff --git a/arch/x86/boot/Makefile b/arch/x86/boot/Makefile
> index 0d810fb15eac..b9de8b50f32a 100644
> --- a/arch/x86/boot/Makefile
> +++ b/arch/x86/boot/Makefile
> @@ -76,8 +76,18 @@ quiet_cmd_image = BUILD   $@
>  cmd_image = $(obj)/tools/build $(obj)/setup.bin $(obj)/vmlinux.bin \
>$(obj)/zoffset.h $@
>
> +cmd_efiversion = scripts/efiversion.pl \
> +   --major-os=$(CONFIG_EFI_MAJOR_OS_VERSION) \
> +   --minor-os=$(CONFIG_EFI_MINOR_OS_VERSION) \
> +   --major-image=$(CONFIG_EFI_MAJOR_IMAGE_VERSION) \
> +   --minor-image=$(CONFIG_EFI_MINOR_IMAGE_VERSION) \
> +   $@
> +
>  $(obj)/bzImage: $(obj)/setup.bin $(obj)/vmlinux.bin $(obj)/tools/build FORCE
> $(call if_changed,image)
> +ifeq ($(CONFIG_EFI_STUB),y)
> +   $(call if_changed,efiversion,$@)
> +endif
> @echo 'Kernel: $@ is ready' ' (#'`cat .version`')'
>

Do we need a script? Can't we just use those defines in the PE/COFF
header directly? I.e., something like

diff --git a/arch/x86/boot/header.S b/arch/x86/boot/header.S
index 3dd5be33aaa7..da21b48a2d68 100644
--- a/arch/x86/boot/header.S
+++ b/arch/x86/boot/header.S
@@ -156,10 +156,10 @@ extra_header_fields:
 #endif
.long   0x20# SectionAlignment
.long   0x20# FileAlignment
-   .word   0   # MajorOperatingSystemVersion
-   .word   0   # MinorOperatingSystemVersion
-   .word   0   # MajorImageVersion
-   .word   0   # MinorImageVersion
+   .word   CONFIG_EFI_MAJOR_OS_VERSION # MajorOperatingSystemVersion
+   .word   CONFIG_EFI_MINOR_OS_VERSION # MinorOperatingSystemVersion
+   .word   CONFIG_EFI_MAJOR_IMAGE_VERSION  # MajorImageVersion
+   .word   CONFIG_EFI_MINOR_IMAGE_VERSION  # MinorImageVersion
.word   0   # MajorSubsystemVersion
.word   0   # MinorSubsystemVersion
.long   0   # Win32VersionValue

(and again, why is this x86 only?)




>  OBJCOPYFLAGS_vmlinux.bin := -O binary -R .note -R .comment -S
> diff --git a/scripts/efiversion.pl b/scripts/efiversion.pl
> new file mode 100755
> index ..fe730d10638a
> --- /dev/null
> +++ b/scripts/efiversion.pl
> @@ -0,0 +1,192 @@
> +#!/usr/bin/perl
> +
> +=head1 efiversion.pl
> +
> +efiversion.pl - show or modify the version fields in the EFI image
> +
> +=head1 SYNOPSIS
> +
> +efiversion.pl [OPTIONS] FILE
> +
> +=head1 OPTIONS
> +
> +=over 4
> +
> +=item B<--major-os=NUMBER>
> +
> +assign the major OS version
> +
> +=item B<--minor-os=NUMBER>
> +
> +assign

[RFC PATCH] x86: Config options to assign versions in the PE-COFF header

2017-04-11 Thread Gary Lin

This commit adds the new config options to allow the user to modify the
following fields in the PE-COFF header.

UINT16 MajorOperatingSystemVersion
UINT16 MinorOperatingSystemVersion
UINT16 MajorImageVersion
UINT16 MinorImageVersion

Those fields are mainly for the executables or libraries in Windows NT
or higher to specify the minimum supported Windows version and the
version of the image itself.

Given the fact that those fields are ignored in UEFI, we can safely reuse
those fields for other purposes, e.g. Security Version(*).

(*) https://github.com/lcp/shim/wiki/Security-Version

Cc: Thomas Gleixner 
Cc: Ingo Molnar 
Cc: "H. Peter Anvin" 
Cc: Masahiro Yamada 
Cc: Michal Marek 
Cc: Matt Fleming 
Cc: Ard Biesheuvel 
Cc: Joey Lee 
Cc: Vojtech Pavlik 
Signed-off-by: Gary Lin 
Tested-by: Joey Lee 
---
 arch/x86/Kconfig   |  24 +++
 arch/x86/boot/Makefile |  10 +++
 scripts/efiversion.pl  | 192 +
 3 files changed, 226 insertions(+)
 create mode 100755 scripts/efiversion.pl

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 5bbdef151805..f281c0ff3ff6 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -1803,6 +1803,30 @@ config EFI_STUB
 
  See Documentation/efi-stub.txt for more information.
 
+config EFI_MAJOR_OS_VERSION
+   hex "EFI Major OS Version"
+   range 0x0 0x
+   default "0x0"
+   depends on EFI_STUB
+
+config EFI_MINOR_OS_VERSION
+   hex "EFI Minor OS Version"
+   range 0x0 0x
+   default "0x0"
+   depends on EFI_STUB
+
+config EFI_MAJOR_IMAGE_VERSION
+   hex "EFI Major Image Version"
+   range 0x0 0x
+   default "0x0"
+   depends on EFI_STUB
+
+config EFI_MINOR_IMAGE_VERSION
+   hex "EFI Minor Image Version"
+   range 0x0 0x
+   default "0x0"
+   depends on EFI_STUB
+
 config EFI_MIXED
bool "EFI mixed-mode support"
depends on EFI_STUB && X86_64
diff --git a/arch/x86/boot/Makefile b/arch/x86/boot/Makefile
index 0d810fb15eac..b9de8b50f32a 100644
--- a/arch/x86/boot/Makefile
+++ b/arch/x86/boot/Makefile
@@ -76,8 +76,18 @@ quiet_cmd_image = BUILD   $@
 cmd_image = $(obj)/tools/build $(obj)/setup.bin $(obj)/vmlinux.bin \
   $(obj)/zoffset.h $@
 
+cmd_efiversion = scripts/efiversion.pl \
+   --major-os=$(CONFIG_EFI_MAJOR_OS_VERSION) \
+   --minor-os=$(CONFIG_EFI_MINOR_OS_VERSION) \
+   --major-image=$(CONFIG_EFI_MAJOR_IMAGE_VERSION) \
+   --minor-image=$(CONFIG_EFI_MINOR_IMAGE_VERSION) \
+   $@
+
 $(obj)/bzImage: $(obj)/setup.bin $(obj)/vmlinux.bin $(obj)/tools/build FORCE
$(call if_changed,image)
+ifeq ($(CONFIG_EFI_STUB),y)
+   $(call if_changed,efiversion,$@)
+endif
@echo 'Kernel: $@ is ready' ' (#'`cat .version`')'
 
 OBJCOPYFLAGS_vmlinux.bin := -O binary -R .note -R .comment -S
diff --git a/scripts/efiversion.pl b/scripts/efiversion.pl
new file mode 100755
index ..fe730d10638a
--- /dev/null
+++ b/scripts/efiversion.pl
@@ -0,0 +1,192 @@
+#!/usr/bin/perl
+
+=head1 efiversion.pl
+
+efiversion.pl - show or modify the version fields in the EFI image
+
+=head1 SYNOPSIS
+
+efiversion.pl [OPTIONS] FILE
+
+=head1 OPTIONS
+
+=over 4
+
+=item B<--major-os=NUMBER>
+
+assign the major OS version
+
+=item B<--minor-os=NUMBER>
+
+assign the minor OS version
+
+=item B<--major-image=NUMBER>
+
+assign the major image version
+
+=item B<--minor-image=NUMBER>
+
+assign the minor image version
+
+=item B<--help, -h>
+
+print help
+
+=back
+
+=head1 DESCRIPTION
+
+A script to modify the version fields in the header of the EFI image
+
+Show the versions:
+$ efiversion.pl sample.efi
+
+Modify the versions:
+$ efiversion.pl --major-os=1 --minor-os=2 sample.efi
+
+=cut
+
+use strict;
+use warnings;
+use FileHandle;
+use Getopt::Long;
+Getopt::Long::Configure("no_ignore_case");
+
+my %options;
+
+sub usage($) {
+   my $r = shift;
+   eval "use Pod::Usage; pod2usage($r);";
+   if ($@) {
+   die "cannot display help, install perl(Pod::Usage)\n";
+   }
+}
+
+my $options;
+my $major_os = '';
+my $minor_os = '';
+my $major_image = '';
+my $minor_image = '';
+my $help = '';
+my $overwrite = '';
+
+GetOptions(
+   "major-os=o" => \$major_os,
+   "minor-os=o" => \$minor_os,
+   "major-image=o" => \$major_image,
+   "minor-image=o" => \$minor_image,
+   "help|h" => \$help,
+) or usage(1);
+
+usage(1) unless @ARGV;
+usage(0) if ($help);
+
+sub not_ushort($)
+{
+   my ($number) = @_;
+
+   return 0 unless $number;
+   return 1 if ($number < 0 or $number > 0x);
+
+   $overwrite = "y";
+
+   return 0;
+}
+
+sub check_args
+{
+

[RFC PATCH] x86: Config options to assign versions in the PE-COFF header

2017-04-11 Thread Gary Lin

This commit adds the new config options to allow the user to modify the
following fields in the PE-COFF header.

UINT16 MajorOperatingSystemVersion
UINT16 MinorOperatingSystemVersion
UINT16 MajorImageVersion
UINT16 MinorImageVersion

Those fields are mainly for the executables or libraries in Windows NT
or higher to specify the minimum supported Windows version and the
version of the image itself.

Given the fact that those fields are ignored in UEFI, we can safely reuse
those fields for other purposes, e.g. Security Version(*).

(*) https://github.com/lcp/shim/wiki/Security-Version

Cc: Thomas Gleixner 
Cc: Ingo Molnar 
Cc: "H. Peter Anvin" 
Cc: Masahiro Yamada 
Cc: Michal Marek 
Cc: Matt Fleming 
Cc: Ard Biesheuvel 
Cc: Joey Lee 
Cc: Vojtech Pavlik 
Signed-off-by: Gary Lin 
Tested-by: Joey Lee 
---
 arch/x86/Kconfig   |  24 +++
 arch/x86/boot/Makefile |  10 +++
 scripts/efiversion.pl  | 192 +
 3 files changed, 226 insertions(+)
 create mode 100755 scripts/efiversion.pl

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 5bbdef151805..f281c0ff3ff6 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -1803,6 +1803,30 @@ config EFI_STUB
 
  See Documentation/efi-stub.txt for more information.
 
+config EFI_MAJOR_OS_VERSION
+   hex "EFI Major OS Version"
+   range 0x0 0x
+   default "0x0"
+   depends on EFI_STUB
+
+config EFI_MINOR_OS_VERSION
+   hex "EFI Minor OS Version"
+   range 0x0 0x
+   default "0x0"
+   depends on EFI_STUB
+
+config EFI_MAJOR_IMAGE_VERSION
+   hex "EFI Major Image Version"
+   range 0x0 0x
+   default "0x0"
+   depends on EFI_STUB
+
+config EFI_MINOR_IMAGE_VERSION
+   hex "EFI Minor Image Version"
+   range 0x0 0x
+   default "0x0"
+   depends on EFI_STUB
+
 config EFI_MIXED
bool "EFI mixed-mode support"
depends on EFI_STUB && X86_64
diff --git a/arch/x86/boot/Makefile b/arch/x86/boot/Makefile
index 0d810fb15eac..b9de8b50f32a 100644
--- a/arch/x86/boot/Makefile
+++ b/arch/x86/boot/Makefile
@@ -76,8 +76,18 @@ quiet_cmd_image = BUILD   $@
 cmd_image = $(obj)/tools/build $(obj)/setup.bin $(obj)/vmlinux.bin \
   $(obj)/zoffset.h $@
 
+cmd_efiversion = scripts/efiversion.pl \
+   --major-os=$(CONFIG_EFI_MAJOR_OS_VERSION) \
+   --minor-os=$(CONFIG_EFI_MINOR_OS_VERSION) \
+   --major-image=$(CONFIG_EFI_MAJOR_IMAGE_VERSION) \
+   --minor-image=$(CONFIG_EFI_MINOR_IMAGE_VERSION) \
+   $@
+
 $(obj)/bzImage: $(obj)/setup.bin $(obj)/vmlinux.bin $(obj)/tools/build FORCE
$(call if_changed,image)
+ifeq ($(CONFIG_EFI_STUB),y)
+   $(call if_changed,efiversion,$@)
+endif
@echo 'Kernel: $@ is ready' ' (#'`cat .version`')'
 
 OBJCOPYFLAGS_vmlinux.bin := -O binary -R .note -R .comment -S
diff --git a/scripts/efiversion.pl b/scripts/efiversion.pl
new file mode 100755
index ..fe730d10638a
--- /dev/null
+++ b/scripts/efiversion.pl
@@ -0,0 +1,192 @@
+#!/usr/bin/perl
+
+=head1 efiversion.pl
+
+efiversion.pl - show or modify the version fields in the EFI image
+
+=head1 SYNOPSIS
+
+efiversion.pl [OPTIONS] FILE
+
+=head1 OPTIONS
+
+=over 4
+
+=item B<--major-os=NUMBER>
+
+assign the major OS version
+
+=item B<--minor-os=NUMBER>
+
+assign the minor OS version
+
+=item B<--major-image=NUMBER>
+
+assign the major image version
+
+=item B<--minor-image=NUMBER>
+
+assign the minor image version
+
+=item B<--help, -h>
+
+print help
+
+=back
+
+=head1 DESCRIPTION
+
+A script to modify the version fields in the header of the EFI image
+
+Show the versions:
+$ efiversion.pl sample.efi
+
+Modify the versions:
+$ efiversion.pl --major-os=1 --minor-os=2 sample.efi
+
+=cut
+
+use strict;
+use warnings;
+use FileHandle;
+use Getopt::Long;
+Getopt::Long::Configure("no_ignore_case");
+
+my %options;
+
+sub usage($) {
+   my $r = shift;
+   eval "use Pod::Usage; pod2usage($r);";
+   if ($@) {
+   die "cannot display help, install perl(Pod::Usage)\n";
+   }
+}
+
+my $options;
+my $major_os = '';
+my $minor_os = '';
+my $major_image = '';
+my $minor_image = '';
+my $help = '';
+my $overwrite = '';
+
+GetOptions(
+   "major-os=o" => \$major_os,
+   "minor-os=o" => \$minor_os,
+   "major-image=o" => \$major_image,
+   "minor-image=o" => \$minor_image,
+   "help|h" => \$help,
+) or usage(1);
+
+usage(1) unless @ARGV;
+usage(0) if ($help);
+
+sub not_ushort($)
+{
+   my ($number) = @_;
+
+   return 0 unless $number;
+   return 1 if ($number < 0 or $number > 0x);
+
+   $overwrite = "y";
+
+   return 0;
+}
+
+sub check_args
+{
+   return 0 if not_ushort($major_os);
+   return 0 if not_ushort($minor_os);
+   return 0 if not_ushort($major_image);
+   return 0 if not_ushort($minor_image);
+   return 1;
+}
+
+sub read_file($)

Re: [RFC PATCH] x86: Config options to assign versions in the PE-COFF header

Re: [RFC PATCH] x86: Config options to assign versions in the PE-COFF header

Re: [RFC PATCH] x86: Config options to assign versions in the PE-COFF header

Re: [RFC PATCH] x86: Config options to assign versions in the PE-COFF header

Re: [RFC PATCH] x86: Config options to assign versions in the PE-COFF header

Re: [RFC PATCH] x86: Config options to assign versions in the PE-COFF header

Re: [RFC PATCH] x86: Config options to assign versions in the PE-COFF header

Re: [RFC PATCH] x86: Config options to assign versions in the PE-COFF header

Re: [RFC PATCH] x86: Config options to assign versions in the PE-COFF header

Re: [RFC PATCH] x86: Config options to assign versions in the PE-COFF header

[RFC PATCH] x86: Config options to assign versions in the PE-COFF header

[RFC PATCH] x86: Config options to assign versions in the PE-COFF header

12 matches

Site Navigation

Mail list logo

Footer information