Re: [RFC PATCH 5/5] fsi/scom: Major overhaul
On Monday, 18 June 2018 2:46:33 PM AEST Benjamin Herrenschmidt wrote:
> On Mon, 2018-06-18 at 14:09 +1000, Alistair Popple wrote:
> > On Sunday, 17 June 2018 11:22:11 AM AEST Benjamin Herrenschmidt wrote:
> > > On Sun, 2018-06-17 at 11:17 +1000, Benjamin Herrenschmidt wrote:
> > > >
> > > > We have everything that cronus needs and more than pdbg needs afaik :-)
> >
> > Yep, has what we need and more (such as put scom under mask and indirect
> > scom).
> > Only other useful thing would be repeated getsom/putscom operations (eg.
> > read
> > the same scom address n times) as they would help with ADU access which can
> > do
> > autoincrement or scanscom (although we should just use the scan engine
> > directly
> > for that so not a big issue).
> >
> > > + for (retries = 0; retries < SCOM_MAX_RETRIES; retries++) {
> > > + rc = raw_get_scom(scom, value, addr, &status);
> > > + if (rc) {
> > > + /* Try resetting the bridge if FSI fails */
> > > + if (rc != -ENODEV && retries == 0) {
> > > + fsi_device_write(scom->fsi_dev,
> > > SCOM_FSI2PIB_RESET_REG,
> > > + &dummy, sizeof(uint32_t));
> > > + rc = -EBUSY;
> > > + } else
> > > + return rc;
> > > + } else
> > > + rc = handle_fsi2pib_status(scom, status);
> > > + if (rc && rc != -EBUSY)
> > > + break;
> > > + if (rc == 0) {
> > > + rc = handle_pib_status(scom,
> > > +(status &
> > > SCOM_STATUS_PIB_RESP_MASK)
> > > +>> SCOM_STATUS_PIB_RESP_SHIFT);
> > > + if (rc && rc != -EBUSY)
> > > + break;
> > > + }
> > > + if (rc == 0)
> > > + break;
> > > + msleep(1);
> > > + }
> >
> > The rc handling above took me a little while to grok but I didn't come up
> > with a
> > cleaner alternative and I think it's correct.
>
> Ack-by or Reviewed-by tag pls ? :-)
Oh, sure:
Reviewed-by: Alistair Popple
> Cheers,
> Ben.
>
> > - Alistair
> >
> > > >
> > > > That said, cronus does a bunch of other stupid things that I'm still
> > > > trying to figure out how to fix.
> > > >
> > > > We might need to create a /dev/cfam rather than going through that
> > > > magic sysfs "raw" file, and I wouldn't mind using a single IDA so that
> > > > all the devices below a given FSI slace (cfam itself, sbefifo, occ,
> > > > ...) have the same "number".
> > >
> > > Also while we're at reworking how all this is exposed to our broken
> > > userspace, I wouldn't mind putting all these dev entries under a
> > > directory, if I can figure out how to do that (I haven't really looked
> > > yet).
> > >
> > > /dev/fsi/{cfamN,sbefifoN,occN, ...} and possibly similar by-id and by-
> > > path that other subsystems use, so we have something more deterministic
> > > than the "random number" crap we do now.
> > >
> > > We can always keep hacks to do symlinks in our kernel tree until we
> > > have converted all our userspace users.
> > >
> > > We currently control the only userspace users of this, so now is a good
> > > time to cleanup how we expose things. This won't always be the case.
> > >
> > > Cheers,
> > > Ben.
> > >
> > >
> >
> >
>
Re: [RFC PATCH 5/5] fsi/scom: Major overhaul
On Mon, 2018-06-18 at 14:09 +1000, Alistair Popple wrote:
> On Sunday, 17 June 2018 11:22:11 AM AEST Benjamin Herrenschmidt wrote:
> > On Sun, 2018-06-17 at 11:17 +1000, Benjamin Herrenschmidt wrote:
> > >
> > > We have everything that cronus needs and more than pdbg needs afaik :-)
>
> Yep, has what we need and more (such as put scom under mask and indirect
> scom).
> Only other useful thing would be repeated getsom/putscom operations (eg. read
> the same scom address n times) as they would help with ADU access which can do
> autoincrement or scanscom (although we should just use the scan engine
> directly
> for that so not a big issue).
>
> > + for (retries = 0; retries < SCOM_MAX_RETRIES; retries++) {
> > + rc = raw_get_scom(scom, value, addr, &status);
> > + if (rc) {
> > + /* Try resetting the bridge if FSI fails */
> > + if (rc != -ENODEV && retries == 0) {
> > + fsi_device_write(scom->fsi_dev,
> > SCOM_FSI2PIB_RESET_REG,
> > +&dummy, sizeof(uint32_t));
> > + rc = -EBUSY;
> > + } else
> > + return rc;
> > + } else
> > + rc = handle_fsi2pib_status(scom, status);
> > + if (rc && rc != -EBUSY)
> > + break;
> > + if (rc == 0) {
> > + rc = handle_pib_status(scom,
> > + (status &
> > SCOM_STATUS_PIB_RESP_MASK)
> > + >> SCOM_STATUS_PIB_RESP_SHIFT);
> > + if (rc && rc != -EBUSY)
> > + break;
> > + }
> > + if (rc == 0)
> > + break;
> > + msleep(1);
> > + }
>
> The rc handling above took me a little while to grok but I didn't come up
> with a
> cleaner alternative and I think it's correct.
Ack-by or Reviewed-by tag pls ? :-)
Cheers,
Ben.
> - Alistair
>
> > >
> > > That said, cronus does a bunch of other stupid things that I'm still
> > > trying to figure out how to fix.
> > >
> > > We might need to create a /dev/cfam rather than going through that
> > > magic sysfs "raw" file, and I wouldn't mind using a single IDA so that
> > > all the devices below a given FSI slace (cfam itself, sbefifo, occ,
> > > ...) have the same "number".
> >
> > Also while we're at reworking how all this is exposed to our broken
> > userspace, I wouldn't mind putting all these dev entries under a
> > directory, if I can figure out how to do that (I haven't really looked
> > yet).
> >
> > /dev/fsi/{cfamN,sbefifoN,occN, ...} and possibly similar by-id and by-
> > path that other subsystems use, so we have something more deterministic
> > than the "random number" crap we do now.
> >
> > We can always keep hacks to do symlinks in our kernel tree until we
> > have converted all our userspace users.
> >
> > We currently control the only userspace users of this, so now is a good
> > time to cleanup how we expose things. This won't always be the case.
> >
> > Cheers,
> > Ben.
> >
> >
>
>
Re: [RFC PATCH 5/5] fsi/scom: Major overhaul
On Sunday, 17 June 2018 11:22:11 AM AEST Benjamin Herrenschmidt wrote:
> On Sun, 2018-06-17 at 11:17 +1000, Benjamin Herrenschmidt wrote:
> >
> > We have everything that cronus needs and more than pdbg needs afaik :-)
Yep, has what we need and more (such as put scom under mask and indirect scom).
Only other useful thing would be repeated getsom/putscom operations (eg. read
the same scom address n times) as they would help with ADU access which can do
autoincrement or scanscom (although we should just use the scan engine directly
for that so not a big issue).
> + for (retries = 0; retries < SCOM_MAX_RETRIES; retries++) {
> + rc = raw_get_scom(scom, value, addr, &status);
> + if (rc) {
> + /* Try resetting the bridge if FSI fails */
> + if (rc != -ENODEV && retries == 0) {
> + fsi_device_write(scom->fsi_dev,
> SCOM_FSI2PIB_RESET_REG,
> + &dummy, sizeof(uint32_t));
> + rc = -EBUSY;
> + } else
> + return rc;
> + } else
> + rc = handle_fsi2pib_status(scom, status);
> + if (rc && rc != -EBUSY)
> + break;
> + if (rc == 0) {
> + rc = handle_pib_status(scom,
> +(status &
> SCOM_STATUS_PIB_RESP_MASK)
> +>> SCOM_STATUS_PIB_RESP_SHIFT);
> + if (rc && rc != -EBUSY)
> + break;
> + }
> + if (rc == 0)
> + break;
> + msleep(1);
> + }
The rc handling above took me a little while to grok but I didn't come up with a
cleaner alternative and I think it's correct.
- Alistair
> >
> > That said, cronus does a bunch of other stupid things that I'm still
> > trying to figure out how to fix.
> >
> > We might need to create a /dev/cfam rather than going through that
> > magic sysfs "raw" file, and I wouldn't mind using a single IDA so that
> > all the devices below a given FSI slace (cfam itself, sbefifo, occ,
> > ...) have the same "number".
>
> Also while we're at reworking how all this is exposed to our broken
> userspace, I wouldn't mind putting all these dev entries under a
> directory, if I can figure out how to do that (I haven't really looked
> yet).
>
> /dev/fsi/{cfamN,sbefifoN,occN, ...} and possibly similar by-id and by-
> path that other subsystems use, so we have something more deterministic
> than the "random number" crap we do now.
>
> We can always keep hacks to do symlinks in our kernel tree until we
> have converted all our userspace users.
>
> We currently control the only userspace users of this, so now is a good
> time to cleanup how we expose things. This won't always be the case.
>
> Cheers,
> Ben.
>
>
Re: [RFC PATCH 5/5] fsi/scom: Major overhaul
On Sun, 2018-06-17 at 11:17 +1000, Benjamin Herrenschmidt wrote:
>
> We have everything that cronus needs and more than pdbg needs afaik :-)
>
> That said, cronus does a bunch of other stupid things that I'm still
> trying to figure out how to fix.
>
> We might need to create a /dev/cfam rather than going through that
> magic sysfs "raw" file, and I wouldn't mind using a single IDA so that
> all the devices below a given FSI slace (cfam itself, sbefifo, occ,
> ...) have the same "number".
Also while we're at reworking how all this is exposed to our broken
userspace, I wouldn't mind putting all these dev entries under a
directory, if I can figure out how to do that (I haven't really looked
yet).
/dev/fsi/{cfamN,sbefifoN,occN, ...} and possibly similar by-id and by-
path that other subsystems use, so we have something more deterministic
than the "random number" crap we do now.
We can always keep hacks to do symlinks in our kernel tree until we
have converted all our userspace users.
We currently control the only userspace users of this, so now is a good
time to cleanup how we expose things. This won't always be the case.
Cheers,
Ben.
Re: [RFC PATCH 5/5] fsi/scom: Major overhaul
On Sat, 2018-06-16 at 14:34 +0930, Joel Stanley wrote:
> On 12 June 2018 at 14:49, Benjamin Herrenschmidt
> wrote:
> > This was too hard to split ... this adds a number of features
> > to the SCOM user interface:
> >
> > - Support for indirect SCOMs
> >
> > - read()/write() interface now handle errors and retries
> >
> > - New ioctl() "raw" interface for use by debuggers
> >
> > Signed-off-by: Benjamin Herrenschmidt
>
> Looks okay to me. I will put it in the openbmc tree with Eddie's ack
> for more testing.
>
> I got a warning from the 0day infra, I made comments below.
>
> We should get Alistair review the ioctl interface to ensure we have
> everything that pdbg might need.
We have everything that cronus needs and more than pdbg needs afaik :-)
That said, cronus does a bunch of other stupid things that I'm still
trying to figure out how to fix.
We might need to create a /dev/cfam rather than going through that
magic sysfs "raw" file, and I wouldn't mind using a single IDA so that
all the devices below a given FSI slace (cfam itself, sbefifo, occ,
...) have the same "number".
>
> > +++ b/include/uapi/linux/fsi.h
> > @@ -0,0 +1,56 @@
> > +#ifndef _UAPI_LINUX_FSI_H
> > +#define _UAPI_LINUX_FSI_H
> > +
> > +#include
>
> This needs to include for the __u64 etc types.
>
> We should also put a licence in the header. Probably:
>
> /* SPDX-License-Identifier: GPL-2.0+ WITH Linux-syscall-note */
Yup.
Cheers,
Ben.
>
> Cheers,
>
> Joel
>
> > +
> > +/*
> > + * /dev/scom "raw" ioctl interface
> > + *
> > + * The driver supports a high level "read/write" interface which
> > + * handles retries and converts the status to Linux error codes,
> > + * however low level tools an debugger need to access the "raw"
> > + * HW status information and interpret it themselves, so this
> > + * ioctl interface is also provided for their use case.
> > + */
> > +
> > +/* Structure for SCOM read/write */
> > +struct scom_access {
> > + __u64 addr; /* SCOM address, supports indirect */
> > + __u64 data; /* SCOM data (in for write, out for read) */
> > + __u64 mask; /* Data mask for writes */
> > + __u32 intf_errors;/* Interface error flags */
> > +#define SCOM_INTF_ERR_PARITY 0x0001 /* Parity error */
> > +#define SCOM_INTF_ERR_PROTECTION 0x0002 /* Blocked by secure
> > boot */
> > +#define SCOM_INTF_ERR_ABORT0x0004 /* PIB reset during
> > access */
> > +#define SCOM_INTF_ERR_UNKNOWN 0x8000 /* Unknown error */
> > + /*
> > +* Note: Any other bit set in intf_errors need to be considered as
> > an
> > +* error. Future implementations may define new error conditions.
> > The
> > +* pib_status below is only valid if intf_errors is 0.
> > +*/
> > + __u8pib_status; /* 3-bit PIB status */
> > +#define SCOM_PIB_SUCCESS 0 /* Access successful */
> > +#define SCOM_PIB_BLOCKED 1 /* PIB blocked, pls retry */
> > +#define SCOM_PIB_OFFLINE 2 /* Chiplet offline */
> > +#define SCOM_PIB_PARTIAL 3 /* Partial good */
> > +#define SCOM_PIB_BAD_ADDR 4 /* Invalid address */
> > +#define SCOM_PIB_CLK_ERR 5 /* Clock error */
> > +#define SCOM_PIB_PARITY_ERR6 /* Parity error on the PIB bus */
> > +#define SCOM_PIB_TIMEOUT 7 /* Bus timeout */
> > + __u8pad;
> > +};
> > +
> > +/* Flags for SCOM check */
> > +#define SCOM_CHECK_SUPPORTED 0x0001 /* Interface supported */
> > +#define SCOM_CHECK_PROTECTED 0x0002 /* Interface blocked by
> > secure boot */
> > +
> > +/* Flags for SCOM reset */
> > +#define SCOM_RESET_INTF0x0001 /* Reset interface
> > */
> > +#define SCOM_RESET_PIB 0x0002 /* Reset PIB */
> > +
> > +#define FSI_SCOM_CHECK _IOR('s', 0x00, __u32)
> > +#define FSI_SCOM_READ _IOWR('s', 0x01, struct scom_access)
> > +#define FSI_SCOM_WRITE _IOWR('s', 0x02, struct scom_access)
> > +#define FSI_SCOM_RESET _IOW('s', 0x03, __u32)
> > +
> > +#endif /* _UAPI_LINUX_FSI_H */
> > --
> > 2.17.0
> >
Re: [RFC PATCH 5/5] fsi/scom: Major overhaul
On 12 June 2018 at 14:49, Benjamin Herrenschmidt
wrote:
> This was too hard to split ... this adds a number of features
> to the SCOM user interface:
>
> - Support for indirect SCOMs
>
> - read()/write() interface now handle errors and retries
>
> - New ioctl() "raw" interface for use by debuggers
>
> Signed-off-by: Benjamin Herrenschmidt
Looks okay to me. I will put it in the openbmc tree with Eddie's ack
for more testing.
I got a warning from the 0day infra, I made comments below.
We should get Alistair review the ioctl interface to ensure we have
everything that pdbg might need.
> +++ b/include/uapi/linux/fsi.h
> @@ -0,0 +1,56 @@
> +#ifndef _UAPI_LINUX_FSI_H
> +#define _UAPI_LINUX_FSI_H
> +
> +#include
This needs to include for the __u64 etc types.
We should also put a licence in the header. Probably:
/* SPDX-License-Identifier: GPL-2.0+ WITH Linux-syscall-note */
Cheers,
Joel
> +
> +/*
> + * /dev/scom "raw" ioctl interface
> + *
> + * The driver supports a high level "read/write" interface which
> + * handles retries and converts the status to Linux error codes,
> + * however low level tools an debugger need to access the "raw"
> + * HW status information and interpret it themselves, so this
> + * ioctl interface is also provided for their use case.
> + */
> +
> +/* Structure for SCOM read/write */
> +struct scom_access {
> + __u64 addr; /* SCOM address, supports indirect */
> + __u64 data; /* SCOM data (in for write, out for read) */
> + __u64 mask; /* Data mask for writes */
> + __u32 intf_errors;/* Interface error flags */
> +#define SCOM_INTF_ERR_PARITY 0x0001 /* Parity error */
> +#define SCOM_INTF_ERR_PROTECTION 0x0002 /* Blocked by secure boot
> */
> +#define SCOM_INTF_ERR_ABORT0x0004 /* PIB reset during access
> */
> +#define SCOM_INTF_ERR_UNKNOWN 0x8000 /* Unknown error */
> + /*
> +* Note: Any other bit set in intf_errors need to be considered as an
> +* error. Future implementations may define new error conditions. The
> +* pib_status below is only valid if intf_errors is 0.
> +*/
> + __u8pib_status; /* 3-bit PIB status */
> +#define SCOM_PIB_SUCCESS 0 /* Access successful */
> +#define SCOM_PIB_BLOCKED 1 /* PIB blocked, pls retry */
> +#define SCOM_PIB_OFFLINE 2 /* Chiplet offline */
> +#define SCOM_PIB_PARTIAL 3 /* Partial good */
> +#define SCOM_PIB_BAD_ADDR 4 /* Invalid address */
> +#define SCOM_PIB_CLK_ERR 5 /* Clock error */
> +#define SCOM_PIB_PARITY_ERR6 /* Parity error on the PIB bus */
> +#define SCOM_PIB_TIMEOUT 7 /* Bus timeout */
> + __u8pad;
> +};
> +
> +/* Flags for SCOM check */
> +#define SCOM_CHECK_SUPPORTED 0x0001 /* Interface supported */
> +#define SCOM_CHECK_PROTECTED 0x0002 /* Interface blocked by
> secure boot */
> +
> +/* Flags for SCOM reset */
> +#define SCOM_RESET_INTF0x0001 /* Reset interface */
> +#define SCOM_RESET_PIB 0x0002 /* Reset PIB */
> +
> +#define FSI_SCOM_CHECK _IOR('s', 0x00, __u32)
> +#define FSI_SCOM_READ _IOWR('s', 0x01, struct scom_access)
> +#define FSI_SCOM_WRITE _IOWR('s', 0x02, struct scom_access)
> +#define FSI_SCOM_RESET _IOW('s', 0x03, __u32)
> +
> +#endif /* _UAPI_LINUX_FSI_H */
> --
> 2.17.0
>
Re: [RFC PATCH 5/5] fsi/scom: Major overhaul
On 06/13/2018 06:00 PM, Benjamin Herrenschmidt wrote:
On Wed, 2018-06-13 at 09:57 -0500, Eddie James wrote:
On 06/12/2018 12:19 AM, Benjamin Herrenschmidt wrote:
This was too hard to split ... this adds a number of features
to the SCOM user interface:
- Support for indirect SCOMs
- read()/write() interface now handle errors and retries
- New ioctl() "raw" interface for use by debuggers
Signed-off-by: Benjamin Herrenschmidt
---
drivers/fsi/fsi-scom.c | 424 ---
include/uapi/linux/fsi.h | 56 ++
2 files changed, 450 insertions(+), 30 deletions(-)
create mode 100644 include/uapi/linux/fsi.h
diff --git a/drivers/fsi/fsi-scom.c b/drivers/fsi/fsi-scom.c
index e98573ecdae1..39c74351f1bf 100644
--- a/drivers/fsi/fsi-scom.c
+++ b/drivers/fsi/fsi-scom.c
@@ -24,6 +24,8 @@
#include
#include
+
+static int scom_reset(struct scom_device *scom, void __user *argp)
+{
+ uint32_t flags, dummy = -1;
+ int rc = 0;
+
+ if (get_user(flags, (__u32 __user *)argp))
+ return -EFAULT;
+ if (flags & SCOM_RESET_PIB)
+ rc = fsi_device_write(scom->fsi_dev, SCOM_PIB_RESET_REG, &dummy,
+ sizeof(uint32_t));
I realize this is a user requested flag but I believe the BMC is never
supposed to issue this type of reset, due to the possibility of breaking
stuff on the host side. Not sure if it should even be available?
It's for use by cronus or similar low level system debuggers.
Cheers,
Ben.
Cool, thanks.
Reviewed-by: Eddie James
Otherwise, looks good!
Thanks,
Eddie
+ if (!rc && (flags & (SCOM_RESET_PIB | SCOM_RESET_INTF)))
+ rc = fsi_device_write(scom->fsi_dev, SCOM_FSI2PIB_RESET_REG,
&dummy,
+ sizeof(uint32_t));
+ return rc;
+}
+
+static int scom_check(struct scom_device *scom, void __user *argp)
+{
+ /* Still need to find out how to get "protected" */
+ return put_user(SCOM_CHECK_SUPPORTED, (__u32 __user *)argp);
+}
+
+static long scom_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
+{
+ struct miscdevice *mdev = file->private_data;
+ struct scom_device *scom = to_scom_dev(mdev);
+ void __user *argp = (void __user *)arg;
+ int rc = -ENOTTY;
+
+ mutex_lock(&scom->lock);
+ switch(cmd) {
+ case FSI_SCOM_CHECK:
+ rc = scom_check(scom, argp);
+ break;
+ case FSI_SCOM_READ:
+ rc = scom_raw_read(scom, argp);
+ break;
+ case FSI_SCOM_WRITE:
+ rc = scom_raw_write(scom, argp);
+ break;
+ case FSI_SCOM_RESET:
+ rc = scom_reset(scom, argp);
+ break;
+ }
+ mutex_unlock(&scom->lock);
+ return rc;
+}
+
static const struct file_operations scom_fops = {
- .owner = THIS_MODULE,
- .llseek = scom_llseek,
- .read = scom_read,
- .write = scom_write,
+ .owner = THIS_MODULE,
+ .llseek = scom_llseek,
+ .read = scom_read,
+ .write = scom_write,
+ .unlocked_ioctl = scom_ioctl,
};
static int scom_probe(struct device *dev)
diff --git a/include/uapi/linux/fsi.h b/include/uapi/linux/fsi.h
new file mode 100644
index ..6008d93f2e48
--- /dev/null
+++ b/include/uapi/linux/fsi.h
@@ -0,0 +1,56 @@
+#ifndef _UAPI_LINUX_FSI_H
+#define _UAPI_LINUX_FSI_H
+
+#include
+
+/*
+ * /dev/scom "raw" ioctl interface
+ *
+ * The driver supports a high level "read/write" interface which
+ * handles retries and converts the status to Linux error codes,
+ * however low level tools an debugger need to access the "raw"
+ * HW status information and interpret it themselves, so this
+ * ioctl interface is also provided for their use case.
+ */
+
+/* Structure for SCOM read/write */
+struct scom_access {
+ __u64 addr; /* SCOM address, supports indirect */
+ __u64 data; /* SCOM data (in for write, out for read) */
+ __u64 mask; /* Data mask for writes */
+ __u32 intf_errors;/* Interface error flags */
+#define SCOM_INTF_ERR_PARITY 0x0001 /* Parity error */
+#define SCOM_INTF_ERR_PROTECTION 0x0002 /* Blocked by secure boot */
+#define SCOM_INTF_ERR_ABORT0x0004 /* PIB reset during access */
+#define SCOM_INTF_ERR_UNKNOWN 0x8000 /* Unknown error */
+ /*
+* Note: Any other bit set in intf_errors need to be considered as an
+* error. Future implementations may define new error conditions. The
+* pib_status below is only valid if intf_errors is 0.
+*/
+ __u8pib_status; /* 3-bit PIB status */
+#define SCOM_PIB_SUCCESS 0 /* Access successful */
+#define SCOM_PIB_BLOCKED 1 /* PIB blocked, pls retry */
+#define SCOM_PIB_OFFLINE 2 /* Chiplet
Re: [RFC PATCH 5/5] fsi/scom: Major overhaul
On Wed, 2018-06-13 at 09:57 -0500, Eddie James wrote:
>
> On 06/12/2018 12:19 AM, Benjamin Herrenschmidt wrote:
> > This was too hard to split ... this adds a number of features
> > to the SCOM user interface:
> >
> > - Support for indirect SCOMs
> >
> > - read()/write() interface now handle errors and retries
> >
> > - New ioctl() "raw" interface for use by debuggers
> >
> > Signed-off-by: Benjamin Herrenschmidt
> > ---
> > drivers/fsi/fsi-scom.c | 424 ---
> > include/uapi/linux/fsi.h | 56 ++
> > 2 files changed, 450 insertions(+), 30 deletions(-)
> > create mode 100644 include/uapi/linux/fsi.h
> >
> > diff --git a/drivers/fsi/fsi-scom.c b/drivers/fsi/fsi-scom.c
> > index e98573ecdae1..39c74351f1bf 100644
> > --- a/drivers/fsi/fsi-scom.c
> > +++ b/drivers/fsi/fsi-scom.c
> > @@ -24,6 +24,8 @@
> > #include
> > #include
> > +
> > +static int scom_reset(struct scom_device *scom, void __user *argp)
> > +{
> > + uint32_t flags, dummy = -1;
> > + int rc = 0;
> > +
> > + if (get_user(flags, (__u32 __user *)argp))
> > + return -EFAULT;
> > + if (flags & SCOM_RESET_PIB)
> > + rc = fsi_device_write(scom->fsi_dev, SCOM_PIB_RESET_REG, &dummy,
> > + sizeof(uint32_t));
>
> I realize this is a user requested flag but I believe the BMC is never
> supposed to issue this type of reset, due to the possibility of breaking
> stuff on the host side. Not sure if it should even be available?
It's for use by cronus or similar low level system debuggers.
Cheers,
Ben.
> Otherwise, looks good!
> Thanks,
> Eddie
>
> > + if (!rc && (flags & (SCOM_RESET_PIB | SCOM_RESET_INTF)))
> > + rc = fsi_device_write(scom->fsi_dev, SCOM_FSI2PIB_RESET_REG,
> > &dummy,
> > + sizeof(uint32_t));
> > + return rc;
> > +}
> > +
> > +static int scom_check(struct scom_device *scom, void __user *argp)
> > +{
> > + /* Still need to find out how to get "protected" */
> > + return put_user(SCOM_CHECK_SUPPORTED, (__u32 __user *)argp);
> > +}
> > +
> > +static long scom_ioctl(struct file *file, unsigned int cmd, unsigned long
> > arg)
> > +{
> > + struct miscdevice *mdev = file->private_data;
> > + struct scom_device *scom = to_scom_dev(mdev);
> > + void __user *argp = (void __user *)arg;
> > + int rc = -ENOTTY;
> > +
> > + mutex_lock(&scom->lock);
> > + switch(cmd) {
> > + case FSI_SCOM_CHECK:
> > + rc = scom_check(scom, argp);
> > + break;
> > + case FSI_SCOM_READ:
> > + rc = scom_raw_read(scom, argp);
> > + break;
> > + case FSI_SCOM_WRITE:
> > + rc = scom_raw_write(scom, argp);
> > + break;
> > + case FSI_SCOM_RESET:
> > + rc = scom_reset(scom, argp);
> > + break;
> > + }
> > + mutex_unlock(&scom->lock);
> > + return rc;
> > +}
> > +
> > static const struct file_operations scom_fops = {
> > - .owner = THIS_MODULE,
> > - .llseek = scom_llseek,
> > - .read = scom_read,
> > - .write = scom_write,
> > + .owner = THIS_MODULE,
> > + .llseek = scom_llseek,
> > + .read = scom_read,
> > + .write = scom_write,
> > + .unlocked_ioctl = scom_ioctl,
> > };
> >
> > static int scom_probe(struct device *dev)
> > diff --git a/include/uapi/linux/fsi.h b/include/uapi/linux/fsi.h
> > new file mode 100644
> > index ..6008d93f2e48
> > --- /dev/null
> > +++ b/include/uapi/linux/fsi.h
> > @@ -0,0 +1,56 @@
> > +#ifndef _UAPI_LINUX_FSI_H
> > +#define _UAPI_LINUX_FSI_H
> > +
> > +#include
> > +
> > +/*
> > + * /dev/scom "raw" ioctl interface
> > + *
> > + * The driver supports a high level "read/write" interface which
> > + * handles retries and converts the status to Linux error codes,
> > + * however low level tools an debugger need to access the "raw"
> > + * HW status information and interpret it themselves, so this
> > + * ioctl interface is also provided for their use case.
> > + */
> > +
> > +/* Structure for SCOM read/write */
> > +struct scom_access {
> > + __u64 addr; /* SCOM address, supports indirect */
> > + __u64 data; /* SCOM data (in for write, out for read) */
> > + __u64 mask; /* Data mask for writes */
> > + __u32 intf_errors;/* Interface error flags */
> > +#define SCOM_INTF_ERR_PARITY 0x0001 /* Parity error */
> > +#define SCOM_INTF_ERR_PROTECTION 0x0002 /* Blocked by secure boot */
> > +#define SCOM_INTF_ERR_ABORT0x0004 /* PIB reset during
> > access */
> > +#define SCOM_INTF_ERR_UNKNOWN 0x8000 /* Unknown error */
> > + /*
> > +* Note: Any other bit set in intf_errors need to be considered as an
> > +* error. Future implementations may define new error conditions. The
> > +* pib_status below is only valid if intf_errors is 0.
> > +*/
> > + __u8pib_status; /* 3-b
Re: [RFC PATCH 5/5] fsi/scom: Major overhaul
On 06/12/2018 12:19 AM, Benjamin Herrenschmidt wrote:
This was too hard to split ... this adds a number of features
to the SCOM user interface:
- Support for indirect SCOMs
- read()/write() interface now handle errors and retries
- New ioctl() "raw" interface for use by debuggers
Signed-off-by: Benjamin Herrenschmidt
---
drivers/fsi/fsi-scom.c | 424 ---
include/uapi/linux/fsi.h | 56 ++
2 files changed, 450 insertions(+), 30 deletions(-)
create mode 100644 include/uapi/linux/fsi.h
diff --git a/drivers/fsi/fsi-scom.c b/drivers/fsi/fsi-scom.c
index e98573ecdae1..39c74351f1bf 100644
--- a/drivers/fsi/fsi-scom.c
+++ b/drivers/fsi/fsi-scom.c
@@ -24,6 +24,8 @@
#include
#include
+
+static int scom_reset(struct scom_device *scom, void __user *argp)
+{
+ uint32_t flags, dummy = -1;
+ int rc = 0;
+
+ if (get_user(flags, (__u32 __user *)argp))
+ return -EFAULT;
+ if (flags & SCOM_RESET_PIB)
+ rc = fsi_device_write(scom->fsi_dev, SCOM_PIB_RESET_REG, &dummy,
+ sizeof(uint32_t));
I realize this is a user requested flag but I believe the BMC is never
supposed to issue this type of reset, due to the possibility of breaking
stuff on the host side. Not sure if it should even be available?
Otherwise, looks good!
Thanks,
Eddie
+ if (!rc && (flags & (SCOM_RESET_PIB | SCOM_RESET_INTF)))
+ rc = fsi_device_write(scom->fsi_dev, SCOM_FSI2PIB_RESET_REG,
&dummy,
+ sizeof(uint32_t));
+ return rc;
+}
+
+static int scom_check(struct scom_device *scom, void __user *argp)
+{
+ /* Still need to find out how to get "protected" */
+ return put_user(SCOM_CHECK_SUPPORTED, (__u32 __user *)argp);
+}
+
+static long scom_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
+{
+ struct miscdevice *mdev = file->private_data;
+ struct scom_device *scom = to_scom_dev(mdev);
+ void __user *argp = (void __user *)arg;
+ int rc = -ENOTTY;
+
+ mutex_lock(&scom->lock);
+ switch(cmd) {
+ case FSI_SCOM_CHECK:
+ rc = scom_check(scom, argp);
+ break;
+ case FSI_SCOM_READ:
+ rc = scom_raw_read(scom, argp);
+ break;
+ case FSI_SCOM_WRITE:
+ rc = scom_raw_write(scom, argp);
+ break;
+ case FSI_SCOM_RESET:
+ rc = scom_reset(scom, argp);
+ break;
+ }
+ mutex_unlock(&scom->lock);
+ return rc;
+}
+
static const struct file_operations scom_fops = {
- .owner = THIS_MODULE,
- .llseek = scom_llseek,
- .read = scom_read,
- .write = scom_write,
+ .owner = THIS_MODULE,
+ .llseek = scom_llseek,
+ .read = scom_read,
+ .write = scom_write,
+ .unlocked_ioctl = scom_ioctl,
};
static int scom_probe(struct device *dev)
diff --git a/include/uapi/linux/fsi.h b/include/uapi/linux/fsi.h
new file mode 100644
index ..6008d93f2e48
--- /dev/null
+++ b/include/uapi/linux/fsi.h
@@ -0,0 +1,56 @@
+#ifndef _UAPI_LINUX_FSI_H
+#define _UAPI_LINUX_FSI_H
+
+#include
+
+/*
+ * /dev/scom "raw" ioctl interface
+ *
+ * The driver supports a high level "read/write" interface which
+ * handles retries and converts the status to Linux error codes,
+ * however low level tools an debugger need to access the "raw"
+ * HW status information and interpret it themselves, so this
+ * ioctl interface is also provided for their use case.
+ */
+
+/* Structure for SCOM read/write */
+struct scom_access {
+ __u64 addr; /* SCOM address, supports indirect */
+ __u64 data; /* SCOM data (in for write, out for read) */
+ __u64 mask; /* Data mask for writes */
+ __u32 intf_errors;/* Interface error flags */
+#define SCOM_INTF_ERR_PARITY 0x0001 /* Parity error */
+#define SCOM_INTF_ERR_PROTECTION 0x0002 /* Blocked by secure boot */
+#define SCOM_INTF_ERR_ABORT0x0004 /* PIB reset during access */
+#define SCOM_INTF_ERR_UNKNOWN 0x8000 /* Unknown error */
+ /*
+* Note: Any other bit set in intf_errors need to be considered as an
+* error. Future implementations may define new error conditions. The
+* pib_status below is only valid if intf_errors is 0.
+*/
+ __u8pib_status; /* 3-bit PIB status */
+#define SCOM_PIB_SUCCESS 0 /* Access successful */
+#define SCOM_PIB_BLOCKED 1 /* PIB blocked, pls retry */
+#define SCOM_PIB_OFFLINE 2 /* Chiplet offline */
+#define SCOM_PIB_PARTIAL 3 /* Partial good */
+#define SCOM_PIB_BAD_ADDR 4 /* Invalid address */
+#define SCOM_PIB_CLK_ERR 5 /* Clock error */
+#define SCOM_PIB_PARITY_ERR6 /* Parit
[RFC PATCH 5/5] fsi/scom: Major overhaul
This was too hard to split ... this adds a number of features
to the SCOM user interface:
- Support for indirect SCOMs
- read()/write() interface now handle errors and retries
- New ioctl() "raw" interface for use by debuggers
Signed-off-by: Benjamin Herrenschmidt
---
drivers/fsi/fsi-scom.c | 424 ---
include/uapi/linux/fsi.h | 56 ++
2 files changed, 450 insertions(+), 30 deletions(-)
create mode 100644 include/uapi/linux/fsi.h
diff --git a/drivers/fsi/fsi-scom.c b/drivers/fsi/fsi-scom.c
index e98573ecdae1..39c74351f1bf 100644
--- a/drivers/fsi/fsi-scom.c
+++ b/drivers/fsi/fsi-scom.c
@@ -24,6 +24,8 @@
#include
#include
+#include
+
#define FSI_ENGID_SCOM 0x5
/* SCOM engine register set */
@@ -41,14 +43,36 @@
/* Status register bits */
#define SCOM_STATUS_ERR_SUMMARY0x8000
#define SCOM_STATUS_PROTECTION 0x0100
+#define SCOM_STATUS_PARITY 0x0400
#define SCOM_STATUS_PIB_ABORT 0x0010
#define SCOM_STATUS_PIB_RESP_MASK 0x7000
#define SCOM_STATUS_PIB_RESP_SHIFT 12
#define SCOM_STATUS_ANY_ERR(SCOM_STATUS_ERR_SUMMARY | \
SCOM_STATUS_PROTECTION | \
+SCOM_STATUS_PARITY | \
SCOM_STATUS_PIB_ABORT | \
SCOM_STATUS_PIB_RESP_MASK)
+/* SCOM address encodings */
+#define XSCOM_ADDR_IND_FLAGBIT_ULL(63)
+#define XSCOM_ADDR_INF_FORM1 BIT_ULL(60)
+
+/* SCOM indirect stuff */
+#define XSCOM_ADDR_DIRECT_PART 0x7fffull
+#define XSCOM_ADDR_INDIRECT_PART 0x000full
+#define XSCOM_DATA_IND_READBIT_ULL(63)
+#define XSCOM_DATA_IND_COMPLETEBIT_ULL(31)
+#define XSCOM_DATA_IND_ERR_MASK0x7000ull
+#define XSCOM_DATA_IND_ERR_SHIFT 28
+#define XSCOM_DATA_IND_DATA0xull
+#define XSCOM_DATA_IND_FORM1_DATA 0x000full
+#define XSCOM_ADDR_FORM1_LOW 0x000ull
+#define XSCOM_ADDR_FORM1_HI0xfffull
+#define XSCOM_ADDR_FORM1_HI_SHIFT 20
+
+/* Retries */
+#define SCOM_MAX_RETRIES 100 /* Retries on busy */
+#define SCOM_MAX_IND_RETRIES 10 /* Retries indirect not ready */
struct scom_device {
struct list_head link;
@@ -56,7 +80,7 @@ struct scom_device {
struct miscdevice mdev;
struct mutex lock;
charname[32];
- int idx;
+ int idx;
};
#define to_scom_dev(x) container_of((x), struct scom_device, mdev)
@@ -65,80 +89,304 @@ static struct list_head scom_devices;
static DEFINE_IDA(scom_ida);
-static int put_scom(struct scom_device *scom_dev, uint64_t value,
- uint32_t addr)
+static int __put_scom(struct scom_device *scom_dev, uint64_t value,
+ uint32_t addr, uint32_t *status)
{
- __be32 data;
+ __be32 data, raw_status;
int rc;
- mutex_lock(&scom_dev->lock);
-
data = cpu_to_be32((value >> 32) & 0x);
rc = fsi_device_write(scom_dev->fsi_dev, SCOM_DATA0_REG, &data,
sizeof(uint32_t));
if (rc)
- goto bail;
+ return rc;
data = cpu_to_be32(value & 0x);
rc = fsi_device_write(scom_dev->fsi_dev, SCOM_DATA1_REG, &data,
sizeof(uint32_t));
if (rc)
- goto bail;
+ return rc;
data = cpu_to_be32(SCOM_WRITE_CMD | addr);
rc = fsi_device_write(scom_dev->fsi_dev, SCOM_CMD_REG, &data,
sizeof(uint32_t));
- bail:
- mutex_unlock(&scom_dev->lock);
- return rc;
+ if (rc)
+ return rc;
+ rc = fsi_device_read(scom_dev->fsi_dev, SCOM_STATUS_REG, &raw_status,
+sizeof(uint32_t));
+ if (rc)
+ return rc;
+ *status = be32_to_cpu(raw_status);
+
+ return 0;
}
-static int get_scom(struct scom_device *scom_dev, uint64_t *value,
- uint32_t addr)
+static int __get_scom(struct scom_device *scom_dev, uint64_t *value,
+ uint32_t addr, uint32_t *status)
{
- __be32 result, data;
+ __be32 data, raw_status;
int rc;
- mutex_lock(&scom_dev->lock);
*value = 0ULL;
data = cpu_to_be32(SCOM_READ_CMD | addr);
rc = fsi_device_write(scom_dev->fsi_dev, SCOM_CMD_REG, &data,
sizeof(uint32_t));
if (rc)
- goto bail;
+ return rc;
+ rc = fsi_device_read(scom_dev->fsi_dev, SCOM_STATUS_REG, &raw_status,
+sizeof(uint32_t));
+ if (rc)
+ return rc;
- rc = fsi_device_read(scom_dev->fsi_dev, SCOM_DATA0_REG, &r
