Re: [RFC PATCH regulator] regulator: ready_mask_table[] can be static

2019-04-16 Thread Pascal PAILLET-LME
The same patch was proposed by YueHaibing

Acked-by: Pascal Paillet 

thank you,
pascal


Le 04/15/2019 06:52 PM, kbuild test robot a écrit :
> Fixes: 6cdae8173f67 ("regulator: Add support for stm32 power regulators")
> Signed-off-by: kbuild test robot 
> ---
>   stm32-pwr.c |6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/regulator/stm32-pwr.c b/drivers/regulator/stm32-pwr.c
> index e434b26..222d593 100644
> --- a/drivers/regulator/stm32-pwr.c
> +++ b/drivers/regulator/stm32-pwr.c
> @@ -32,7 +32,7 @@ enum {
>   STM32PWR_REG_NUM_REGS
>   };
>   
> -u32 ready_mask_table[STM32PWR_REG_NUM_REGS] = {
> +static u32 ready_mask_table[STM32PWR_REG_NUM_REGS] = {
>   [PWR_REG11] = REG_1_1_RDY,
>   [PWR_REG18] = REG_1_8_RDY,
>   [PWR_USB33] = USB_3_3_RDY,
> @@ -44,7 +44,7 @@ struct stm32_pwr_reg {
>   u32 ready_mask;
>   };
>   
> -int stm32_pwr_reg_is_ready(struct regulator_dev *rdev)
> +static int stm32_pwr_reg_is_ready(struct regulator_dev *rdev)
>   {
>   struct stm32_pwr_reg *priv = rdev_get_drvdata(rdev);
>   u32 val;
> @@ -54,7 +54,7 @@ int stm32_pwr_reg_is_ready(struct regulator_dev *rdev)
>   return (val & priv->ready_mask);
>   }
>   
> -int stm32_pwr_reg_is_enabled(struct regulator_dev *rdev)
> +static int stm32_pwr_reg_is_enabled(struct regulator_dev *rdev)
>   {
>   struct stm32_pwr_reg *priv = rdev_get_drvdata(rdev);
>   u32 val;
>


[RFC PATCH regulator] regulator: ready_mask_table[] can be static

2019-04-15 Thread kbuild test robot


Fixes: 6cdae8173f67 ("regulator: Add support for stm32 power regulators")
Signed-off-by: kbuild test robot 
---
 stm32-pwr.c |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/regulator/stm32-pwr.c b/drivers/regulator/stm32-pwr.c
index e434b26..222d593 100644
--- a/drivers/regulator/stm32-pwr.c
+++ b/drivers/regulator/stm32-pwr.c
@@ -32,7 +32,7 @@ enum {
STM32PWR_REG_NUM_REGS
 };
 
-u32 ready_mask_table[STM32PWR_REG_NUM_REGS] = {
+static u32 ready_mask_table[STM32PWR_REG_NUM_REGS] = {
[PWR_REG11] = REG_1_1_RDY,
[PWR_REG18] = REG_1_8_RDY,
[PWR_USB33] = USB_3_3_RDY,
@@ -44,7 +44,7 @@ struct stm32_pwr_reg {
u32 ready_mask;
 };
 
-int stm32_pwr_reg_is_ready(struct regulator_dev *rdev)
+static int stm32_pwr_reg_is_ready(struct regulator_dev *rdev)
 {
struct stm32_pwr_reg *priv = rdev_get_drvdata(rdev);
u32 val;
@@ -54,7 +54,7 @@ int stm32_pwr_reg_is_ready(struct regulator_dev *rdev)
return (val & priv->ready_mask);
 }
 
-int stm32_pwr_reg_is_enabled(struct regulator_dev *rdev)
+static int stm32_pwr_reg_is_enabled(struct regulator_dev *rdev)
 {
struct stm32_pwr_reg *priv = rdev_get_drvdata(rdev);
u32 val;