Re: [RFT][PATCH] mfd: pcf50633: Correct device name for pcf50633 regulator

[Mark Brown]

On Sat, Nov 30, 2013 at 12:21:03PM +0800, Axel Lin wrote:
> Change the device name of the regulator function to the one chosen for
> MODULE_ALIAS. This fixes kernel auto-module loading for the regulator 
> function.

Applied, thanks.


signature.asc
Description: Digital signature

Re: [RFT][PATCH] mfd: pcf50633: Correct device name for pcf50633 regulator

[Lee Jones]

On Sat, 30 Nov 2013, Axel Lin wrote:

> Change the device name of the regulator function to the one chosen for
> MODULE_ALIAS. This fixes kernel auto-module loading for the regulator 
> function.
> 
> Signed-off-by: Axel Lin 
> ---
> Hi,
> I don't have the hardware to test, but I think this needs fix.
> We have a similar fix in
> commit ec8da805c43a "mfd: tps6586x: correct device name of the regulator 
> cell".
> 
>  drivers/mfd/pcf50633-core.c| 2 +-
>  drivers/regulator/pcf50633-regulator.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Patch looks fine to me and I can't fine any other instances of the
name.

Acked-by: Lee Jones 

> diff --git a/drivers/mfd/pcf50633-core.c b/drivers/mfd/pcf50633-core.c
> index 6841d68..41ab5e3 100644
> --- a/drivers/mfd/pcf50633-core.c
> +++ b/drivers/mfd/pcf50633-core.c
> @@ -245,7 +245,7 @@ static int pcf50633_probe(struct i2c_client *client,
>   for (i = 0; i < PCF50633_NUM_REGULATORS; i++) {
>   struct platform_device *pdev;
>  
> - pdev = platform_device_alloc("pcf50633-regltr", i);
> + pdev = platform_device_alloc("pcf50633-regulator", i);
>   if (!pdev) {
>   dev_err(pcf->dev, "Cannot create regulator %d\n", i);
>   continue;
> diff --git a/drivers/regulator/pcf50633-regulator.c 
> b/drivers/regulator/pcf50633-regulator.c
> index d7da1c1..134f90e 100644
> --- a/drivers/regulator/pcf50633-regulator.c
> +++ b/drivers/regulator/pcf50633-regulator.c
> @@ -105,7 +105,7 @@ static int pcf50633_regulator_probe(struct 
> platform_device *pdev)
>  
>  static struct platform_driver pcf50633_regulator_driver = {
>   .driver = {
> - .name = "pcf50633-regltr",
> + .name = "pcf50633-regulator",
>   },
>   .probe = pcf50633_regulator_probe,
>  };

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [RFT][PATCH] mfd: pcf50633: Correct device name for pcf50633 regulator

[Lee Jones]

On Sat, 30 Nov 2013, Axel Lin wrote:

 Change the device name of the regulator function to the one chosen for
 MODULE_ALIAS. This fixes kernel auto-module loading for the regulator 
 function.
 
 Signed-off-by: Axel Lin axel@ingics.com
 ---
 Hi,
 I don't have the hardware to test, but I think this needs fix.
 We have a similar fix in
 commit ec8da805c43a mfd: tps6586x: correct device name of the regulator 
 cell.
 
  drivers/mfd/pcf50633-core.c| 2 +-
  drivers/regulator/pcf50633-regulator.c | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)

Patch looks fine to me and I can't fine any other instances of the
name.

Acked-by: Lee Jones lee.jo...@linaro.org

 diff --git a/drivers/mfd/pcf50633-core.c b/drivers/mfd/pcf50633-core.c
 index 6841d68..41ab5e3 100644
 --- a/drivers/mfd/pcf50633-core.c
 +++ b/drivers/mfd/pcf50633-core.c
 @@ -245,7 +245,7 @@ static int pcf50633_probe(struct i2c_client *client,
   for (i = 0; i  PCF50633_NUM_REGULATORS; i++) {
   struct platform_device *pdev;
  
 - pdev = platform_device_alloc(pcf50633-regltr, i);
 + pdev = platform_device_alloc(pcf50633-regulator, i);
   if (!pdev) {
   dev_err(pcf-dev, Cannot create regulator %d\n, i);
   continue;
 diff --git a/drivers/regulator/pcf50633-regulator.c 
 b/drivers/regulator/pcf50633-regulator.c
 index d7da1c1..134f90e 100644
 --- a/drivers/regulator/pcf50633-regulator.c
 +++ b/drivers/regulator/pcf50633-regulator.c
 @@ -105,7 +105,7 @@ static int pcf50633_regulator_probe(struct 
 platform_device *pdev)
  
  static struct platform_driver pcf50633_regulator_driver = {
   .driver = {
 - .name = pcf50633-regltr,
 + .name = pcf50633-regulator,
   },
   .probe = pcf50633_regulator_probe,
  };

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [RFT][PATCH] mfd: pcf50633: Correct device name for pcf50633 regulator

[Mark Brown]

On Sat, Nov 30, 2013 at 12:21:03PM +0800, Axel Lin wrote:
 Change the device name of the regulator function to the one chosen for
 MODULE_ALIAS. This fixes kernel auto-module loading for the regulator 
 function.

Applied, thanks.


signature.asc
Description: Digital signature

[RFT][PATCH] mfd: pcf50633: Correct device name for pcf50633 regulator

[Axel Lin]

Change the device name of the regulator function to the one chosen for
MODULE_ALIAS. This fixes kernel auto-module loading for the regulator function.

Signed-off-by: Axel Lin 
---
Hi,
I don't have the hardware to test, but I think this needs fix.
We have a similar fix in
commit ec8da805c43a "mfd: tps6586x: correct device name of the regulator cell".

 drivers/mfd/pcf50633-core.c| 2 +-
 drivers/regulator/pcf50633-regulator.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mfd/pcf50633-core.c b/drivers/mfd/pcf50633-core.c
index 6841d68..41ab5e3 100644
--- a/drivers/mfd/pcf50633-core.c
+++ b/drivers/mfd/pcf50633-core.c
@@ -245,7 +245,7 @@ static int pcf50633_probe(struct i2c_client *client,
for (i = 0; i < PCF50633_NUM_REGULATORS; i++) {
struct platform_device *pdev;
 
-   pdev = platform_device_alloc("pcf50633-regltr", i);
+   pdev = platform_device_alloc("pcf50633-regulator", i);
if (!pdev) {
dev_err(pcf->dev, "Cannot create regulator %d\n", i);
continue;
diff --git a/drivers/regulator/pcf50633-regulator.c 
b/drivers/regulator/pcf50633-regulator.c
index d7da1c1..134f90e 100644
--- a/drivers/regulator/pcf50633-regulator.c
+++ b/drivers/regulator/pcf50633-regulator.c
@@ -105,7 +105,7 @@ static int pcf50633_regulator_probe(struct platform_device 
*pdev)
 
 static struct platform_driver pcf50633_regulator_driver = {
.driver = {
-   .name = "pcf50633-regltr",
+   .name = "pcf50633-regulator",
},
.probe = pcf50633_regulator_probe,
 };
-- 
1.8.1.2



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[RFT][PATCH] mfd: pcf50633: Correct device name for pcf50633 regulator

[Axel Lin]

Change the device name of the regulator function to the one chosen for
MODULE_ALIAS. This fixes kernel auto-module loading for the regulator function.

Signed-off-by: Axel Lin axel@ingics.com
---
Hi,
I don't have the hardware to test, but I think this needs fix.
We have a similar fix in
commit ec8da805c43a mfd: tps6586x: correct device name of the regulator cell.

 drivers/mfd/pcf50633-core.c| 2 +-
 drivers/regulator/pcf50633-regulator.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mfd/pcf50633-core.c b/drivers/mfd/pcf50633-core.c
index 6841d68..41ab5e3 100644
--- a/drivers/mfd/pcf50633-core.c
+++ b/drivers/mfd/pcf50633-core.c
@@ -245,7 +245,7 @@ static int pcf50633_probe(struct i2c_client *client,
for (i = 0; i  PCF50633_NUM_REGULATORS; i++) {
struct platform_device *pdev;
 
-   pdev = platform_device_alloc(pcf50633-regltr, i);
+   pdev = platform_device_alloc(pcf50633-regulator, i);
if (!pdev) {
dev_err(pcf-dev, Cannot create regulator %d\n, i);
continue;
diff --git a/drivers/regulator/pcf50633-regulator.c 
b/drivers/regulator/pcf50633-regulator.c
index d7da1c1..134f90e 100644
--- a/drivers/regulator/pcf50633-regulator.c
+++ b/drivers/regulator/pcf50633-regulator.c
@@ -105,7 +105,7 @@ static int pcf50633_regulator_probe(struct platform_device 
*pdev)
 
 static struct platform_driver pcf50633_regulator_driver = {
.driver = {
-   .name = pcf50633-regltr,
+   .name = pcf50633-regulator,
},
.probe = pcf50633_regulator_probe,
 };
-- 
1.8.1.2



--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/