Re: [TRIVIAL PATCH 11/26] powerpc: Convert print_symbol to %pSR
On Thu, 2013-01-10 at 16:48 +1100, Benjamin Herrenschmidt wrote: > On Thu, 2012-12-13 at 11:58 +, Arnd Bergmann wrote: > > On Wednesday 12 December 2012, Joe Perches wrote: > > > Use the new vsprintf extension to avoid any possible > > > message interleaving. > > > > > > Convert the #ifdef DEBUG block to a single pr_debug. > > > > > > Signed-off-by: Joe Perches > > > > nice cleanup! > > ... which also breaks the build :-( > > > Acked-by: Arnd Bergmann > > I'll fix it up locally. OK, I didn't compile it. How does it break the build? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [TRIVIAL PATCH 11/26] powerpc: Convert print_symbol to %pSR
On Thu, 2013-01-10 at 16:48 +1100, Benjamin Herrenschmidt wrote: On Thu, 2012-12-13 at 11:58 +, Arnd Bergmann wrote: On Wednesday 12 December 2012, Joe Perches wrote: Use the new vsprintf extension to avoid any possible message interleaving. Convert the #ifdef DEBUG block to a single pr_debug. Signed-off-by: Joe Perches j...@perches.com nice cleanup! ... which also breaks the build :-( Acked-by: Arnd Bergmann a...@arndb.de I'll fix it up locally. OK, I didn't compile it. How does it break the build? -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [TRIVIAL PATCH 11/26] powerpc: Convert print_symbol to %pSR
On Thu, 2012-12-13 at 11:58 +, Arnd Bergmann wrote: > On Wednesday 12 December 2012, Joe Perches wrote: > > Use the new vsprintf extension to avoid any possible > > message interleaving. > > > > Convert the #ifdef DEBUG block to a single pr_debug. > > > > Signed-off-by: Joe Perches > > nice cleanup! ... which also breaks the build :-( > Acked-by: Arnd Bergmann I'll fix it up locally. Ben. > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [TRIVIAL PATCH 11/26] powerpc: Convert print_symbol to %pSR
On Thu, 2012-12-13 at 11:58 +, Arnd Bergmann wrote: On Wednesday 12 December 2012, Joe Perches wrote: Use the new vsprintf extension to avoid any possible message interleaving. Convert the #ifdef DEBUG block to a single pr_debug. Signed-off-by: Joe Perches j...@perches.com nice cleanup! ... which also breaks the build :-( Acked-by: Arnd Bergmann a...@arndb.de I'll fix it up locally. Ben. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [TRIVIAL PATCH 11/26] powerpc: Convert print_symbol to %pSR
On Wednesday 12 December 2012, Joe Perches wrote: > Use the new vsprintf extension to avoid any possible > message interleaving. > > Convert the #ifdef DEBUG block to a single pr_debug. > > Signed-off-by: Joe Perches nice cleanup! Acked-by: Arnd Bergmann -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [TRIVIAL PATCH 11/26] powerpc: Convert print_symbol to %pSR
On Wednesday 12 December 2012, Joe Perches wrote: Use the new vsprintf extension to avoid any possible message interleaving. Convert the #ifdef DEBUG block to a single pr_debug. Signed-off-by: Joe Perches j...@perches.com nice cleanup! Acked-by: Arnd Bergmann a...@arndb.de -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[TRIVIAL PATCH 11/26] powerpc: Convert print_symbol to %pSR
Use the new vsprintf extension to avoid any possible
message interleaving.
Convert the #ifdef DEBUG block to a single pr_debug.
Signed-off-by: Joe Perches
---
arch/powerpc/platforms/cell/spu_callbacks.c | 12 +---
1 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/arch/powerpc/platforms/cell/spu_callbacks.c
b/arch/powerpc/platforms/cell/spu_callbacks.c
index 75d6133..c5fe6d2 100644
--- a/arch/powerpc/platforms/cell/spu_callbacks.c
+++ b/arch/powerpc/platforms/cell/spu_callbacks.c
@@ -60,13 +60,11 @@ long spu_sys_callback(struct spu_syscall_block *s)
syscall = spu_syscall_table[s->nr_ret];
-#ifdef DEBUG
- print_symbol(KERN_DEBUG "SPU-syscall %s:", (unsigned long)syscall);
- printk("syscall%ld(%lx, %lx, %lx, %lx, %lx, %lx)\n",
- s->nr_ret,
- s->parm[0], s->parm[1], s->parm[2],
- s->parm[3], s->parm[4], s->parm[5]);
-#endif
+ pr_debug("SPU-syscall %pSR:syscall%ld(%lx, %lx, %lx, %lx, %lx, %lx)\n",
+syscall,
+s->nr_ret,
+s->parm[0], s->parm[1], s->parm[2],
+s->parm[3], s->parm[4], s->parm[5]);
return syscall(s->parm[0], s->parm[1], s->parm[2],
s->parm[3], s->parm[4], s->parm[5]);
--
1.7.8.112.g3fd21
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[TRIVIAL PATCH 11/26] powerpc: Convert print_symbol to %pSR
Use the new vsprintf extension to avoid any possible message interleaving. Convert the #ifdef DEBUG block to a single pr_debug. Signed-off-by: Joe Perches j...@perches.com --- arch/powerpc/platforms/cell/spu_callbacks.c | 12 +--- 1 files changed, 5 insertions(+), 7 deletions(-) diff --git a/arch/powerpc/platforms/cell/spu_callbacks.c b/arch/powerpc/platforms/cell/spu_callbacks.c index 75d6133..c5fe6d2 100644 --- a/arch/powerpc/platforms/cell/spu_callbacks.c +++ b/arch/powerpc/platforms/cell/spu_callbacks.c @@ -60,13 +60,11 @@ long spu_sys_callback(struct spu_syscall_block *s) syscall = spu_syscall_table[s-nr_ret]; -#ifdef DEBUG - print_symbol(KERN_DEBUG SPU-syscall %s:, (unsigned long)syscall); - printk(syscall%ld(%lx, %lx, %lx, %lx, %lx, %lx)\n, - s-nr_ret, - s-parm[0], s-parm[1], s-parm[2], - s-parm[3], s-parm[4], s-parm[5]); -#endif + pr_debug(SPU-syscall %pSR:syscall%ld(%lx, %lx, %lx, %lx, %lx, %lx)\n, +syscall, +s-nr_ret, +s-parm[0], s-parm[1], s-parm[2], +s-parm[3], s-parm[4], s-parm[5]); return syscall(s-parm[0], s-parm[1], s-parm[2], s-parm[3], s-parm[4], s-parm[5]); -- 1.7.8.112.g3fd21 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
