Re: [Xen-devel] [V0 PATCH] pvh: Disable PSE feature for now
On Tue, 28 Jan 2014 10:39:23 + "Jan Beulich" wrote: > >>> On 28.01.14 at 03:18, Mukesh Rathor > >>> wrote: > > Until now, xen did not expose PSE to pvh guest, but a patch was > > submitted to xen list to enable bunch of features for a pvh guest. > > PSE has not been looked into for PVH, so until we can do that and > > test it to make sure it works, disable the feature to avoid flood > > of bugs. > > > > Signed-off-by: Mukesh Rathor > > --- > > arch/x86/xen/enlighten.c |5 + > > 1 files changed, 5 insertions(+), 0 deletions(-) > > > > diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c > > index a4d7b64..4e952046 100644 > > --- a/arch/x86/xen/enlighten.c > > +++ b/arch/x86/xen/enlighten.c > > @@ -1497,6 +1497,11 @@ static void __init > > xen_pvh_early_guest_init(void) xen_have_vector_callback = 1; > > xen_pvh_set_cr_flags(0); > > > > +/* pvh guests are not quite ready for large pages yet */ > > +setup_clear_cpu_cap(X86_FEATURE_PSE); > > +setup_clear_cpu_cap(X86_FEATURE_PSE36); > > And why would you not want to also turn of 1Gb pages then? Right, that should be turned off too, but Konrad thinks we should leave them on in linux and deal with issues as they come. I've not tested them, or looked/thought about them, so had thought would be better to turn them on after I/someone gets to test them. thanks Mukesh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Xen-devel] [V0 PATCH] pvh: Disable PSE feature for now
>>> On 28.01.14 at 03:18, Mukesh Rathor wrote: > Until now, xen did not expose PSE to pvh guest, but a patch was submitted > to xen list to enable bunch of features for a pvh guest. PSE has not been > looked into for PVH, so until we can do that and test it to make sure it > works, disable the feature to avoid flood of bugs. > > Signed-off-by: Mukesh Rathor > --- > arch/x86/xen/enlighten.c |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c > index a4d7b64..4e952046 100644 > --- a/arch/x86/xen/enlighten.c > +++ b/arch/x86/xen/enlighten.c > @@ -1497,6 +1497,11 @@ static void __init xen_pvh_early_guest_init(void) > xen_have_vector_callback = 1; > xen_pvh_set_cr_flags(0); > > +/* pvh guests are not quite ready for large pages yet */ > +setup_clear_cpu_cap(X86_FEATURE_PSE); > +setup_clear_cpu_cap(X86_FEATURE_PSE36); And why would you not want to also turn of 1Gb pages then? Jan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Xen-devel] [V0 PATCH] pvh: Disable PSE feature for now
On 28.01.14 at 03:18, Mukesh Rathor mukesh.rat...@oracle.com wrote: Until now, xen did not expose PSE to pvh guest, but a patch was submitted to xen list to enable bunch of features for a pvh guest. PSE has not been looked into for PVH, so until we can do that and test it to make sure it works, disable the feature to avoid flood of bugs. Signed-off-by: Mukesh Rathor mukesh.rat...@oracle.com --- arch/x86/xen/enlighten.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c index a4d7b64..4e952046 100644 --- a/arch/x86/xen/enlighten.c +++ b/arch/x86/xen/enlighten.c @@ -1497,6 +1497,11 @@ static void __init xen_pvh_early_guest_init(void) xen_have_vector_callback = 1; xen_pvh_set_cr_flags(0); +/* pvh guests are not quite ready for large pages yet */ +setup_clear_cpu_cap(X86_FEATURE_PSE); +setup_clear_cpu_cap(X86_FEATURE_PSE36); And why would you not want to also turn of 1Gb pages then? Jan -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Xen-devel] [V0 PATCH] pvh: Disable PSE feature for now
On Tue, 28 Jan 2014 10:39:23 + Jan Beulich jbeul...@suse.com wrote: On 28.01.14 at 03:18, Mukesh Rathor mukesh.rat...@oracle.com wrote: Until now, xen did not expose PSE to pvh guest, but a patch was submitted to xen list to enable bunch of features for a pvh guest. PSE has not been looked into for PVH, so until we can do that and test it to make sure it works, disable the feature to avoid flood of bugs. Signed-off-by: Mukesh Rathor mukesh.rat...@oracle.com --- arch/x86/xen/enlighten.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c index a4d7b64..4e952046 100644 --- a/arch/x86/xen/enlighten.c +++ b/arch/x86/xen/enlighten.c @@ -1497,6 +1497,11 @@ static void __init xen_pvh_early_guest_init(void) xen_have_vector_callback = 1; xen_pvh_set_cr_flags(0); +/* pvh guests are not quite ready for large pages yet */ +setup_clear_cpu_cap(X86_FEATURE_PSE); +setup_clear_cpu_cap(X86_FEATURE_PSE36); And why would you not want to also turn of 1Gb pages then? Right, that should be turned off too, but Konrad thinks we should leave them on in linux and deal with issues as they come. I've not tested them, or looked/thought about them, so had thought would be better to turn them on after I/someone gets to test them. thanks Mukesh -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
