Re: [f2fs-dev] [PATCH v2] f2fs: move ioctl interface definitions to separated file

2020-10-30 Thread Chao Yu 

On 2020/10/31 0:55, Eric Biggers wrote:

On Fri, Oct 30, 2020 at 03:26:10PM +0800, Chao Yu wrote:

+
+struct f2fs_gc_range {
+   u32 sync;
+   u64 start;
+   u64 len;
+};


Userspace headers need to use __u32, __u64, etc. instead of u32, u64, etc.


Correct.



Did you try installing this header, and including it in a userspace program?


Let me do more test before next version.

Thanks,



- Eric
.

Re: [f2fs-dev] [PATCH v2] f2fs: move ioctl interface definitions to separated file

2020-10-30 Thread Eric Biggers 
On Fri, Oct 30, 2020 at 03:26:10PM +0800, Chao Yu wrote:
> +
> +struct f2fs_gc_range {
> + u32 sync;
> + u64 start;
> + u64 len;
> +};

Userspace headers need to use __u32, __u64, etc. instead of u32, u64, etc.

Did you try installing this header, and including it in a userspace program?

- Eric