Re: [linux-sunxi] [PATCH v2 3/6] ARM: sun4i: Convert to CCU

[Chen-Yu Tsai]

On Sat, Jan 6, 2018 at 12:10 AM, Kevin Hilman  wrote:
> On Wed, Dec 13, 2017 at 11:46 AM, Kevin Hilman  wrote:
>> On Wed, Dec 13, 2017 at 9:13 AM, Priit Laes  wrote:
>>> On Wed, Dec 13, 2017 at 05:09:33PM +, Priit Laes wrote:
 On Tue, Dec 12, 2017 at 01:24:52PM -0800, Kevin Hilman wrote:
 > On Tue, Dec 12, 2017 at 9:26 AM, Priit Laes  wrote:
 > > On Mon, Dec 11, 2017 at 02:22:30PM -0800, Kevin Hilman wrote:
 > >> On Sun, Mar 26, 2017 at 10:20 AM, Priit Laes  wrote:
 > >> > Convert sun4i-a10.dtsi to new CCU driver.
 > >> >
 > >> > Signed-off-by: Priit Laes 
 > >>
 > >> I finally got around to bisecting a mainline boot failure on
 > >> sun4i-a10-cubieboard that's been happening for quite a while.  Based
 > >> on on kernelci.org, it showed up sometime during the v4.15 merge
 > >> window[1].  It bisected down to this commit (in mainline as commit
 > >> 41193869f2bdb585ce09bfdd16d9482aadd560ad).
 > >>
 > >> When it fails, there is no output on the serial console, so I don't
 > >> know exactly how it's failing, just that it no longer boots.
 > >
 > > We tried out latest 4.15 with various compilers and it works:
 > > - gcc version 7.1.1 20170622 (Red Hat Cross 7.1.1-3) (GCC) - A10 Gemei 
 > > G9 tablet
 > > - gcc 7.2.0-debian - A10 Cubieboard
 >
 > And you can reproduce the bug with gcc5 or gcc6?

 Tried following commits on Gemei G9 (A10 tablet):
 * 4.15.0-rc3-00037-gd39a01eff9af - latest master
 * 4.14.0-rc1-2-g41193869f2bd - the exact commit, causing the issue.

 With the same Linaro toolchain:
 (gcc version 5.3.1 20160412 (Linaro GCC 5.3-2016.05))
>>>
>>> And I also tried the same dtb and zImage from kernelci page [1] and it 
>>> works with
>>> that too...
>>>
>>> https://storage.kernelci.org/mainline/master/v4.15-rc3/arm/sunxi_defconfig/
>>
>> Can you share a full boot-log (including all the u-boot output etc.)
>> so I can see exactly how the kernel is being loaded?Especially the
>> u-boot version?
>>
>> As $SUBJECT patch seems to be changing clocks around, perhaps this is
>> an issue where some u-boot dependency is uncovered, and older versions
>> of u-boot don't play well with this change.
>
> Ping.
>
> This is still failing in mainline, but passing int stable <= v4.14

Just did a test with clean builds of v4.15-rc7 with sunxi_defconfig
and U-boot 2018.01-rc3 with Cubieboard_defconfig. It successfully
boots to a prompt. My previous bootloader was U-boot 2017.05 with
some local modifications.

Here is the full boot log: https://wens.tw/cb-boot-log.txt

The boot script is:

setenv bootargs console=tty0 console=ttyS0,115200n8
root=/dev/mmcblk0p1 rootwait panic=10 earlycon=uart,mmio32,0x01c28000
consoleblank=0 drm.debug=0x1e
load ${devtype} ${devnum}:${distro_bootpart} ${kernel_addr_r} boot/zImage
load ${devtype} ${devnum}:${distro_bootpart} ${fdt_addr_r} boot/${fdtfile}
bootz ${kernel_addr_r} - ${fdt_addr_r}

Regards
ChenYu

Re: [linux-sunxi] [PATCH v2 3/6] ARM: sun4i: Convert to CCU

[Chen-Yu Tsai]

On Sat, Jan 6, 2018 at 12:10 AM, Kevin Hilman  wrote:
> On Wed, Dec 13, 2017 at 11:46 AM, Kevin Hilman  wrote:
>> On Wed, Dec 13, 2017 at 9:13 AM, Priit Laes  wrote:
>>> On Wed, Dec 13, 2017 at 05:09:33PM +, Priit Laes wrote:
 On Tue, Dec 12, 2017 at 01:24:52PM -0800, Kevin Hilman wrote:
 > On Tue, Dec 12, 2017 at 9:26 AM, Priit Laes  wrote:
 > > On Mon, Dec 11, 2017 at 02:22:30PM -0800, Kevin Hilman wrote:
 > >> On Sun, Mar 26, 2017 at 10:20 AM, Priit Laes  wrote:
 > >> > Convert sun4i-a10.dtsi to new CCU driver.
 > >> >
 > >> > Signed-off-by: Priit Laes 
 > >>
 > >> I finally got around to bisecting a mainline boot failure on
 > >> sun4i-a10-cubieboard that's been happening for quite a while.  Based
 > >> on on kernelci.org, it showed up sometime during the v4.15 merge
 > >> window[1].  It bisected down to this commit (in mainline as commit
 > >> 41193869f2bdb585ce09bfdd16d9482aadd560ad).
 > >>
 > >> When it fails, there is no output on the serial console, so I don't
 > >> know exactly how it's failing, just that it no longer boots.
 > >
 > > We tried out latest 4.15 with various compilers and it works:
 > > - gcc version 7.1.1 20170622 (Red Hat Cross 7.1.1-3) (GCC) - A10 Gemei 
 > > G9 tablet
 > > - gcc 7.2.0-debian - A10 Cubieboard
 >
 > And you can reproduce the bug with gcc5 or gcc6?

 Tried following commits on Gemei G9 (A10 tablet):
 * 4.15.0-rc3-00037-gd39a01eff9af - latest master
 * 4.14.0-rc1-2-g41193869f2bd - the exact commit, causing the issue.

 With the same Linaro toolchain:
 (gcc version 5.3.1 20160412 (Linaro GCC 5.3-2016.05))
>>>
>>> And I also tried the same dtb and zImage from kernelci page [1] and it 
>>> works with
>>> that too...
>>>
>>> https://storage.kernelci.org/mainline/master/v4.15-rc3/arm/sunxi_defconfig/
>>
>> Can you share a full boot-log (including all the u-boot output etc.)
>> so I can see exactly how the kernel is being loaded?Especially the
>> u-boot version?
>>
>> As $SUBJECT patch seems to be changing clocks around, perhaps this is
>> an issue where some u-boot dependency is uncovered, and older versions
>> of u-boot don't play well with this change.
>
> Ping.
>
> This is still failing in mainline, but passing int stable <= v4.14

Just did a test with clean builds of v4.15-rc7 with sunxi_defconfig
and U-boot 2018.01-rc3 with Cubieboard_defconfig. It successfully
boots to a prompt. My previous bootloader was U-boot 2017.05 with
some local modifications.

Here is the full boot log: https://wens.tw/cb-boot-log.txt

The boot script is:

setenv bootargs console=tty0 console=ttyS0,115200n8
root=/dev/mmcblk0p1 rootwait panic=10 earlycon=uart,mmio32,0x01c28000
consoleblank=0 drm.debug=0x1e
load ${devtype} ${devnum}:${distro_bootpart} ${kernel_addr_r} boot/zImage
load ${devtype} ${devnum}:${distro_bootpart} ${fdt_addr_r} boot/${fdtfile}
bootz ${kernel_addr_r} - ${fdt_addr_r}

Regards
ChenYu

Re: [linux-sunxi] [PATCH v2 3/6] ARM: sun4i: Convert to CCU

[Kevin Hilman]

On Wed, Dec 13, 2017 at 11:46 AM, Kevin Hilman  wrote:
> On Wed, Dec 13, 2017 at 9:13 AM, Priit Laes  wrote:
>> On Wed, Dec 13, 2017 at 05:09:33PM +, Priit Laes wrote:
>>> On Tue, Dec 12, 2017 at 01:24:52PM -0800, Kevin Hilman wrote:
>>> > On Tue, Dec 12, 2017 at 9:26 AM, Priit Laes  wrote:
>>> > > On Mon, Dec 11, 2017 at 02:22:30PM -0800, Kevin Hilman wrote:
>>> > >> On Sun, Mar 26, 2017 at 10:20 AM, Priit Laes  wrote:
>>> > >> > Convert sun4i-a10.dtsi to new CCU driver.
>>> > >> >
>>> > >> > Signed-off-by: Priit Laes 
>>> > >>
>>> > >> I finally got around to bisecting a mainline boot failure on
>>> > >> sun4i-a10-cubieboard that's been happening for quite a while.  Based
>>> > >> on on kernelci.org, it showed up sometime during the v4.15 merge
>>> > >> window[1].  It bisected down to this commit (in mainline as commit
>>> > >> 41193869f2bdb585ce09bfdd16d9482aadd560ad).
>>> > >>
>>> > >> When it fails, there is no output on the serial console, so I don't
>>> > >> know exactly how it's failing, just that it no longer boots.
>>> > >
>>> > > We tried out latest 4.15 with various compilers and it works:
>>> > > - gcc version 7.1.1 20170622 (Red Hat Cross 7.1.1-3) (GCC) - A10 Gemei 
>>> > > G9 tablet
>>> > > - gcc 7.2.0-debian - A10 Cubieboard
>>> >
>>> > And you can reproduce the bug with gcc5 or gcc6?
>>>
>>> Tried following commits on Gemei G9 (A10 tablet):
>>> * 4.15.0-rc3-00037-gd39a01eff9af - latest master
>>> * 4.14.0-rc1-2-g41193869f2bd - the exact commit, causing the issue.
>>>
>>> With the same Linaro toolchain:
>>> (gcc version 5.3.1 20160412 (Linaro GCC 5.3-2016.05))
>>
>> And I also tried the same dtb and zImage from kernelci page [1] and it works 
>> with
>> that too...
>>
>> https://storage.kernelci.org/mainline/master/v4.15-rc3/arm/sunxi_defconfig/
>
> Can you share a full boot-log (including all the u-boot output etc.)
> so I can see exactly how the kernel is being loaded?Especially the
> u-boot version?
>
> As $SUBJECT patch seems to be changing clocks around, perhaps this is
> an issue where some u-boot dependency is uncovered, and older versions
> of u-boot don't play well with this change.

Ping.

This is still failing in mainline, but passing int stable <= v4.14

Kevin

Re: [linux-sunxi] [PATCH v2 3/6] ARM: sun4i: Convert to CCU

[Kevin Hilman]

On Wed, Dec 13, 2017 at 11:46 AM, Kevin Hilman  wrote:
> On Wed, Dec 13, 2017 at 9:13 AM, Priit Laes  wrote:
>> On Wed, Dec 13, 2017 at 05:09:33PM +, Priit Laes wrote:
>>> On Tue, Dec 12, 2017 at 01:24:52PM -0800, Kevin Hilman wrote:
>>> > On Tue, Dec 12, 2017 at 9:26 AM, Priit Laes  wrote:
>>> > > On Mon, Dec 11, 2017 at 02:22:30PM -0800, Kevin Hilman wrote:
>>> > >> On Sun, Mar 26, 2017 at 10:20 AM, Priit Laes  wrote:
>>> > >> > Convert sun4i-a10.dtsi to new CCU driver.
>>> > >> >
>>> > >> > Signed-off-by: Priit Laes 
>>> > >>
>>> > >> I finally got around to bisecting a mainline boot failure on
>>> > >> sun4i-a10-cubieboard that's been happening for quite a while.  Based
>>> > >> on on kernelci.org, it showed up sometime during the v4.15 merge
>>> > >> window[1].  It bisected down to this commit (in mainline as commit
>>> > >> 41193869f2bdb585ce09bfdd16d9482aadd560ad).
>>> > >>
>>> > >> When it fails, there is no output on the serial console, so I don't
>>> > >> know exactly how it's failing, just that it no longer boots.
>>> > >
>>> > > We tried out latest 4.15 with various compilers and it works:
>>> > > - gcc version 7.1.1 20170622 (Red Hat Cross 7.1.1-3) (GCC) - A10 Gemei 
>>> > > G9 tablet
>>> > > - gcc 7.2.0-debian - A10 Cubieboard
>>> >
>>> > And you can reproduce the bug with gcc5 or gcc6?
>>>
>>> Tried following commits on Gemei G9 (A10 tablet):
>>> * 4.15.0-rc3-00037-gd39a01eff9af - latest master
>>> * 4.14.0-rc1-2-g41193869f2bd - the exact commit, causing the issue.
>>>
>>> With the same Linaro toolchain:
>>> (gcc version 5.3.1 20160412 (Linaro GCC 5.3-2016.05))
>>
>> And I also tried the same dtb and zImage from kernelci page [1] and it works 
>> with
>> that too...
>>
>> https://storage.kernelci.org/mainline/master/v4.15-rc3/arm/sunxi_defconfig/
>
> Can you share a full boot-log (including all the u-boot output etc.)
> so I can see exactly how the kernel is being loaded?Especially the
> u-boot version?
>
> As $SUBJECT patch seems to be changing clocks around, perhaps this is
> an issue where some u-boot dependency is uncovered, and older versions
> of u-boot don't play well with this change.

Ping.

This is still failing in mainline, but passing int stable <= v4.14

Kevin

Re: [linux-sunxi] [PATCH v2 3/6] ARM: sun4i: Convert to CCU

[Kevin Hilman]

On Wed, Dec 13, 2017 at 9:13 AM, Priit Laes  wrote:
> On Wed, Dec 13, 2017 at 05:09:33PM +, Priit Laes wrote:
>> On Tue, Dec 12, 2017 at 01:24:52PM -0800, Kevin Hilman wrote:
>> > On Tue, Dec 12, 2017 at 9:26 AM, Priit Laes  wrote:
>> > > On Mon, Dec 11, 2017 at 02:22:30PM -0800, Kevin Hilman wrote:
>> > >> On Sun, Mar 26, 2017 at 10:20 AM, Priit Laes  wrote:
>> > >> > Convert sun4i-a10.dtsi to new CCU driver.
>> > >> >
>> > >> > Signed-off-by: Priit Laes 
>> > >>
>> > >> I finally got around to bisecting a mainline boot failure on
>> > >> sun4i-a10-cubieboard that's been happening for quite a while.  Based
>> > >> on on kernelci.org, it showed up sometime during the v4.15 merge
>> > >> window[1].  It bisected down to this commit (in mainline as commit
>> > >> 41193869f2bdb585ce09bfdd16d9482aadd560ad).
>> > >>
>> > >> When it fails, there is no output on the serial console, so I don't
>> > >> know exactly how it's failing, just that it no longer boots.
>> > >
>> > > We tried out latest 4.15 with various compilers and it works:
>> > > - gcc version 7.1.1 20170622 (Red Hat Cross 7.1.1-3) (GCC) - A10 Gemei 
>> > > G9 tablet
>> > > - gcc 7.2.0-debian - A10 Cubieboard
>> >
>> > And you can reproduce the bug with gcc5 or gcc6?
>>
>> Tried following commits on Gemei G9 (A10 tablet):
>> * 4.15.0-rc3-00037-gd39a01eff9af - latest master
>> * 4.14.0-rc1-2-g41193869f2bd - the exact commit, causing the issue.
>>
>> With the same Linaro toolchain:
>> (gcc version 5.3.1 20160412 (Linaro GCC 5.3-2016.05))
>
> And I also tried the same dtb and zImage from kernelci page [1] and it works 
> with
> that too...
>
> https://storage.kernelci.org/mainline/master/v4.15-rc3/arm/sunxi_defconfig/

Can you share a full boot-log (including all the u-boot output etc.)
so I can see exactly how the kernel is being loaded?Especially the
u-boot version?

As $SUBJECT patch seems to be changing clocks around, perhaps this is
an issue where some u-boot dependency is uncovered, and older versions
of u-boot don't play well with this change.

Kevin

Re: [linux-sunxi] [PATCH v2 3/6] ARM: sun4i: Convert to CCU

[Kevin Hilman]

On Wed, Dec 13, 2017 at 9:13 AM, Priit Laes  wrote:
> On Wed, Dec 13, 2017 at 05:09:33PM +, Priit Laes wrote:
>> On Tue, Dec 12, 2017 at 01:24:52PM -0800, Kevin Hilman wrote:
>> > On Tue, Dec 12, 2017 at 9:26 AM, Priit Laes  wrote:
>> > > On Mon, Dec 11, 2017 at 02:22:30PM -0800, Kevin Hilman wrote:
>> > >> On Sun, Mar 26, 2017 at 10:20 AM, Priit Laes  wrote:
>> > >> > Convert sun4i-a10.dtsi to new CCU driver.
>> > >> >
>> > >> > Signed-off-by: Priit Laes 
>> > >>
>> > >> I finally got around to bisecting a mainline boot failure on
>> > >> sun4i-a10-cubieboard that's been happening for quite a while.  Based
>> > >> on on kernelci.org, it showed up sometime during the v4.15 merge
>> > >> window[1].  It bisected down to this commit (in mainline as commit
>> > >> 41193869f2bdb585ce09bfdd16d9482aadd560ad).
>> > >>
>> > >> When it fails, there is no output on the serial console, so I don't
>> > >> know exactly how it's failing, just that it no longer boots.
>> > >
>> > > We tried out latest 4.15 with various compilers and it works:
>> > > - gcc version 7.1.1 20170622 (Red Hat Cross 7.1.1-3) (GCC) - A10 Gemei 
>> > > G9 tablet
>> > > - gcc 7.2.0-debian - A10 Cubieboard
>> >
>> > And you can reproduce the bug with gcc5 or gcc6?
>>
>> Tried following commits on Gemei G9 (A10 tablet):
>> * 4.15.0-rc3-00037-gd39a01eff9af - latest master
>> * 4.14.0-rc1-2-g41193869f2bd - the exact commit, causing the issue.
>>
>> With the same Linaro toolchain:
>> (gcc version 5.3.1 20160412 (Linaro GCC 5.3-2016.05))
>
> And I also tried the same dtb and zImage from kernelci page [1] and it works 
> with
> that too...
>
> https://storage.kernelci.org/mainline/master/v4.15-rc3/arm/sunxi_defconfig/

Can you share a full boot-log (including all the u-boot output etc.)
so I can see exactly how the kernel is being loaded?Especially the
u-boot version?

As $SUBJECT patch seems to be changing clocks around, perhaps this is
an issue where some u-boot dependency is uncovered, and older versions
of u-boot don't play well with this change.

Kevin

Re: [linux-sunxi] [PATCH v2 3/6] ARM: sun4i: Convert to CCU

[Priit Laes]

On Wed, Dec 13, 2017 at 05:09:33PM +, Priit Laes wrote:
> On Tue, Dec 12, 2017 at 01:24:52PM -0800, Kevin Hilman wrote:
> > On Tue, Dec 12, 2017 at 9:26 AM, Priit Laes  wrote:
> > > On Mon, Dec 11, 2017 at 02:22:30PM -0800, Kevin Hilman wrote:
> > >> On Sun, Mar 26, 2017 at 10:20 AM, Priit Laes  wrote:
> > >> > Convert sun4i-a10.dtsi to new CCU driver.
> > >> >
> > >> > Signed-off-by: Priit Laes 
> > >>
> > >> I finally got around to bisecting a mainline boot failure on
> > >> sun4i-a10-cubieboard that's been happening for quite a while.  Based
> > >> on on kernelci.org, it showed up sometime during the v4.15 merge
> > >> window[1].  It bisected down to this commit (in mainline as commit
> > >> 41193869f2bdb585ce09bfdd16d9482aadd560ad).
> > >>
> > >> When it fails, there is no output on the serial console, so I don't
> > >> know exactly how it's failing, just that it no longer boots.
> > >
> > > We tried out latest 4.15 with various compilers and it works:
> > > - gcc version 7.1.1 20170622 (Red Hat Cross 7.1.1-3) (GCC) - A10 Gemei G9 
> > > tablet
> > > - gcc 7.2.0-debian - A10 Cubieboard
> > 
> > And you can reproduce the bug with gcc5 or gcc6?
> 
> Tried following commits on Gemei G9 (A10 tablet):
> * 4.15.0-rc3-00037-gd39a01eff9af - latest master
> * 4.14.0-rc1-2-g41193869f2bd - the exact commit, causing the issue.
> 
> With the same Linaro toolchain:
> (gcc version 5.3.1 20160412 (Linaro GCC 5.3-2016.05))

And I also tried the same dtb and zImage from kernelci page [1] and it works 
with
that too...

https://storage.kernelci.org/mainline/master/v4.15-rc3/arm/sunxi_defconfig/
> 
> > 
> > Very strange that a DT only patch would cause a gcc related regression
> > and if it does, it should be investigated.  I don't think requiring
> > gcc7 is an appropriate solution.
> > 
> > @Chen-Yu, @Maxime: are you guys OK with requiring gcc7 for working
> > upstream boot for A10?
> > 
> > Kevin
> > 
> > -- 
> > You received this message because you are subscribed to the Google Groups 
> > "linux-sunxi" group.
> > To unsubscribe from this group and stop receiving emails from it, send an 
> > email to linux-sunxi+unsubscr...@googlegroups.com.
> > For more options, visit https://groups.google.com/d/optout.
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "linux-sunxi" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to linux-sunxi+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

Re: [linux-sunxi] [PATCH v2 3/6] ARM: sun4i: Convert to CCU

[Priit Laes]

On Wed, Dec 13, 2017 at 05:09:33PM +, Priit Laes wrote:
> On Tue, Dec 12, 2017 at 01:24:52PM -0800, Kevin Hilman wrote:
> > On Tue, Dec 12, 2017 at 9:26 AM, Priit Laes  wrote:
> > > On Mon, Dec 11, 2017 at 02:22:30PM -0800, Kevin Hilman wrote:
> > >> On Sun, Mar 26, 2017 at 10:20 AM, Priit Laes  wrote:
> > >> > Convert sun4i-a10.dtsi to new CCU driver.
> > >> >
> > >> > Signed-off-by: Priit Laes 
> > >>
> > >> I finally got around to bisecting a mainline boot failure on
> > >> sun4i-a10-cubieboard that's been happening for quite a while.  Based
> > >> on on kernelci.org, it showed up sometime during the v4.15 merge
> > >> window[1].  It bisected down to this commit (in mainline as commit
> > >> 41193869f2bdb585ce09bfdd16d9482aadd560ad).
> > >>
> > >> When it fails, there is no output on the serial console, so I don't
> > >> know exactly how it's failing, just that it no longer boots.
> > >
> > > We tried out latest 4.15 with various compilers and it works:
> > > - gcc version 7.1.1 20170622 (Red Hat Cross 7.1.1-3) (GCC) - A10 Gemei G9 
> > > tablet
> > > - gcc 7.2.0-debian - A10 Cubieboard
> > 
> > And you can reproduce the bug with gcc5 or gcc6?
> 
> Tried following commits on Gemei G9 (A10 tablet):
> * 4.15.0-rc3-00037-gd39a01eff9af - latest master
> * 4.14.0-rc1-2-g41193869f2bd - the exact commit, causing the issue.
> 
> With the same Linaro toolchain:
> (gcc version 5.3.1 20160412 (Linaro GCC 5.3-2016.05))

And I also tried the same dtb and zImage from kernelci page [1] and it works 
with
that too...

https://storage.kernelci.org/mainline/master/v4.15-rc3/arm/sunxi_defconfig/
> 
> > 
> > Very strange that a DT only patch would cause a gcc related regression
> > and if it does, it should be investigated.  I don't think requiring
> > gcc7 is an appropriate solution.
> > 
> > @Chen-Yu, @Maxime: are you guys OK with requiring gcc7 for working
> > upstream boot for A10?
> > 
> > Kevin
> > 
> > -- 
> > You received this message because you are subscribed to the Google Groups 
> > "linux-sunxi" group.
> > To unsubscribe from this group and stop receiving emails from it, send an 
> > email to linux-sunxi+unsubscr...@googlegroups.com.
> > For more options, visit https://groups.google.com/d/optout.
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "linux-sunxi" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to linux-sunxi+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

Re: [linux-sunxi] [PATCH v2 3/6] ARM: sun4i: Convert to CCU

[Priit Laes]

On Tue, Dec 12, 2017 at 01:24:52PM -0800, Kevin Hilman wrote:
> On Tue, Dec 12, 2017 at 9:26 AM, Priit Laes  wrote:
> > On Mon, Dec 11, 2017 at 02:22:30PM -0800, Kevin Hilman wrote:
> >> On Sun, Mar 26, 2017 at 10:20 AM, Priit Laes  wrote:
> >> > Convert sun4i-a10.dtsi to new CCU driver.
> >> >
> >> > Signed-off-by: Priit Laes 
> >>
> >> I finally got around to bisecting a mainline boot failure on
> >> sun4i-a10-cubieboard that's been happening for quite a while.  Based
> >> on on kernelci.org, it showed up sometime during the v4.15 merge
> >> window[1].  It bisected down to this commit (in mainline as commit
> >> 41193869f2bdb585ce09bfdd16d9482aadd560ad).
> >>
> >> When it fails, there is no output on the serial console, so I don't
> >> know exactly how it's failing, just that it no longer boots.
> >
> > We tried out latest 4.15 with various compilers and it works:
> > - gcc version 7.1.1 20170622 (Red Hat Cross 7.1.1-3) (GCC) - A10 Gemei G9 
> > tablet
> > - gcc 7.2.0-debian - A10 Cubieboard
> 
> And you can reproduce the bug with gcc5 or gcc6?

Tried following commits on Gemei G9 (A10 tablet):
* 4.15.0-rc3-00037-gd39a01eff9af - latest master
* 4.14.0-rc1-2-g41193869f2bd - the exact commit, causing the issue.

With the same Linaro toolchain:
(gcc version 5.3.1 20160412 (Linaro GCC 5.3-2016.05))

> 
> Very strange that a DT only patch would cause a gcc related regression
> and if it does, it should be investigated.  I don't think requiring
> gcc7 is an appropriate solution.
> 
> @Chen-Yu, @Maxime: are you guys OK with requiring gcc7 for working
> upstream boot for A10?
> 
> Kevin
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "linux-sunxi" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to linux-sunxi+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

Re: [linux-sunxi] [PATCH v2 3/6] ARM: sun4i: Convert to CCU

[Priit Laes]

On Tue, Dec 12, 2017 at 01:24:52PM -0800, Kevin Hilman wrote:
> On Tue, Dec 12, 2017 at 9:26 AM, Priit Laes  wrote:
> > On Mon, Dec 11, 2017 at 02:22:30PM -0800, Kevin Hilman wrote:
> >> On Sun, Mar 26, 2017 at 10:20 AM, Priit Laes  wrote:
> >> > Convert sun4i-a10.dtsi to new CCU driver.
> >> >
> >> > Signed-off-by: Priit Laes 
> >>
> >> I finally got around to bisecting a mainline boot failure on
> >> sun4i-a10-cubieboard that's been happening for quite a while.  Based
> >> on on kernelci.org, it showed up sometime during the v4.15 merge
> >> window[1].  It bisected down to this commit (in mainline as commit
> >> 41193869f2bdb585ce09bfdd16d9482aadd560ad).
> >>
> >> When it fails, there is no output on the serial console, so I don't
> >> know exactly how it's failing, just that it no longer boots.
> >
> > We tried out latest 4.15 with various compilers and it works:
> > - gcc version 7.1.1 20170622 (Red Hat Cross 7.1.1-3) (GCC) - A10 Gemei G9 
> > tablet
> > - gcc 7.2.0-debian - A10 Cubieboard
> 
> And you can reproduce the bug with gcc5 or gcc6?

Tried following commits on Gemei G9 (A10 tablet):
* 4.15.0-rc3-00037-gd39a01eff9af - latest master
* 4.14.0-rc1-2-g41193869f2bd - the exact commit, causing the issue.

With the same Linaro toolchain:
(gcc version 5.3.1 20160412 (Linaro GCC 5.3-2016.05))

> 
> Very strange that a DT only patch would cause a gcc related regression
> and if it does, it should be investigated.  I don't think requiring
> gcc7 is an appropriate solution.
> 
> @Chen-Yu, @Maxime: are you guys OK with requiring gcc7 for working
> upstream boot for A10?
> 
> Kevin
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "linux-sunxi" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to linux-sunxi+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

Re: [linux-sunxi] [PATCH v2 3/6] ARM: sun4i: Convert to CCU

[Maxime Ripard]

On Tue, Dec 12, 2017 at 01:24:52PM -0800, Kevin Hilman wrote:
> On Tue, Dec 12, 2017 at 9:26 AM, Priit Laes  wrote:
> > On Mon, Dec 11, 2017 at 02:22:30PM -0800, Kevin Hilman wrote:
> >> On Sun, Mar 26, 2017 at 10:20 AM, Priit Laes  wrote:
> >> > Convert sun4i-a10.dtsi to new CCU driver.
> >> >
> >> > Signed-off-by: Priit Laes 
> >>
> >> I finally got around to bisecting a mainline boot failure on
> >> sun4i-a10-cubieboard that's been happening for quite a while.  Based
> >> on on kernelci.org, it showed up sometime during the v4.15 merge
> >> window[1].  It bisected down to this commit (in mainline as commit
> >> 41193869f2bdb585ce09bfdd16d9482aadd560ad).
> >>
> >> When it fails, there is no output on the serial console, so I don't
> >> know exactly how it's failing, just that it no longer boots.
> >
> > We tried out latest 4.15 with various compilers and it works:
> > - gcc version 7.1.1 20170622 (Red Hat Cross 7.1.1-3) (GCC) - A10 Gemei G9 
> > tablet
> > - gcc 7.2.0-debian - A10 Cubieboard
> 
> And you can reproduce the bug with gcc5 or gcc6?
> 
> Very strange that a DT only patch would cause a gcc related regression
> and if it does, it should be investigated.  I don't think requiring
> gcc7 is an appropriate solution.
> 
> @Chen-Yu, @Maxime: are you guys OK with requiring gcc7 for working
> upstream boot for A10?

I'd rather not set that kind of constraints and fix the issue instead.

Priit, can you test with an older compiler?
You can find one here:
http://toolchains.free-electrons.com/

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


signature.asc
Description: PGP signature

Re: [linux-sunxi] [PATCH v2 3/6] ARM: sun4i: Convert to CCU

[Maxime Ripard]

On Tue, Dec 12, 2017 at 01:24:52PM -0800, Kevin Hilman wrote:
> On Tue, Dec 12, 2017 at 9:26 AM, Priit Laes  wrote:
> > On Mon, Dec 11, 2017 at 02:22:30PM -0800, Kevin Hilman wrote:
> >> On Sun, Mar 26, 2017 at 10:20 AM, Priit Laes  wrote:
> >> > Convert sun4i-a10.dtsi to new CCU driver.
> >> >
> >> > Signed-off-by: Priit Laes 
> >>
> >> I finally got around to bisecting a mainline boot failure on
> >> sun4i-a10-cubieboard that's been happening for quite a while.  Based
> >> on on kernelci.org, it showed up sometime during the v4.15 merge
> >> window[1].  It bisected down to this commit (in mainline as commit
> >> 41193869f2bdb585ce09bfdd16d9482aadd560ad).
> >>
> >> When it fails, there is no output on the serial console, so I don't
> >> know exactly how it's failing, just that it no longer boots.
> >
> > We tried out latest 4.15 with various compilers and it works:
> > - gcc version 7.1.1 20170622 (Red Hat Cross 7.1.1-3) (GCC) - A10 Gemei G9 
> > tablet
> > - gcc 7.2.0-debian - A10 Cubieboard
> 
> And you can reproduce the bug with gcc5 or gcc6?
> 
> Very strange that a DT only patch would cause a gcc related regression
> and if it does, it should be investigated.  I don't think requiring
> gcc7 is an appropriate solution.
> 
> @Chen-Yu, @Maxime: are you guys OK with requiring gcc7 for working
> upstream boot for A10?

I'd rather not set that kind of constraints and fix the issue instead.

Priit, can you test with an older compiler?
You can find one here:
http://toolchains.free-electrons.com/

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


signature.asc
Description: PGP signature

Re: [linux-sunxi] [PATCH v2 3/6] ARM: sun4i: Convert to CCU

[Kevin Hilman]

On Tue, Dec 12, 2017 at 9:26 AM, Priit Laes  wrote:
> On Mon, Dec 11, 2017 at 02:22:30PM -0800, Kevin Hilman wrote:
>> On Sun, Mar 26, 2017 at 10:20 AM, Priit Laes  wrote:
>> > Convert sun4i-a10.dtsi to new CCU driver.
>> >
>> > Signed-off-by: Priit Laes 
>>
>> I finally got around to bisecting a mainline boot failure on
>> sun4i-a10-cubieboard that's been happening for quite a while.  Based
>> on on kernelci.org, it showed up sometime during the v4.15 merge
>> window[1].  It bisected down to this commit (in mainline as commit
>> 41193869f2bdb585ce09bfdd16d9482aadd560ad).
>>
>> When it fails, there is no output on the serial console, so I don't
>> know exactly how it's failing, just that it no longer boots.
>
> We tried out latest 4.15 with various compilers and it works:
> - gcc version 7.1.1 20170622 (Red Hat Cross 7.1.1-3) (GCC) - A10 Gemei G9 
> tablet
> - gcc 7.2.0-debian - A10 Cubieboard

And you can reproduce the bug with gcc5 or gcc6?

Very strange that a DT only patch would cause a gcc related regression
and if it does, it should be investigated.  I don't think requiring
gcc7 is an appropriate solution.

@Chen-Yu, @Maxime: are you guys OK with requiring gcc7 for working
upstream boot for A10?

Kevin

Re: [linux-sunxi] [PATCH v2 3/6] ARM: sun4i: Convert to CCU

[Kevin Hilman]

On Tue, Dec 12, 2017 at 9:26 AM, Priit Laes  wrote:
> On Mon, Dec 11, 2017 at 02:22:30PM -0800, Kevin Hilman wrote:
>> On Sun, Mar 26, 2017 at 10:20 AM, Priit Laes  wrote:
>> > Convert sun4i-a10.dtsi to new CCU driver.
>> >
>> > Signed-off-by: Priit Laes 
>>
>> I finally got around to bisecting a mainline boot failure on
>> sun4i-a10-cubieboard that's been happening for quite a while.  Based
>> on on kernelci.org, it showed up sometime during the v4.15 merge
>> window[1].  It bisected down to this commit (in mainline as commit
>> 41193869f2bdb585ce09bfdd16d9482aadd560ad).
>>
>> When it fails, there is no output on the serial console, so I don't
>> know exactly how it's failing, just that it no longer boots.
>
> We tried out latest 4.15 with various compilers and it works:
> - gcc version 7.1.1 20170622 (Red Hat Cross 7.1.1-3) (GCC) - A10 Gemei G9 
> tablet
> - gcc 7.2.0-debian - A10 Cubieboard

And you can reproduce the bug with gcc5 or gcc6?

Very strange that a DT only patch would cause a gcc related regression
and if it does, it should be investigated.  I don't think requiring
gcc7 is an appropriate solution.

@Chen-Yu, @Maxime: are you guys OK with requiring gcc7 for working
upstream boot for A10?

Kevin

Re: [linux-sunxi] [PATCH v2 3/6] ARM: sun4i: Convert to CCU

[Priit Laes]

On Mon, Dec 11, 2017 at 02:22:30PM -0800, Kevin Hilman wrote:
> On Sun, Mar 26, 2017 at 10:20 AM, Priit Laes  wrote:
> > Convert sun4i-a10.dtsi to new CCU driver.
> >
> > Signed-off-by: Priit Laes 
> 
> I finally got around to bisecting a mainline boot failure on
> sun4i-a10-cubieboard that's been happening for quite a while.  Based
> on on kernelci.org, it showed up sometime during the v4.15 merge
> window[1].  It bisected down to this commit (in mainline as commit
> 41193869f2bdb585ce09bfdd16d9482aadd560ad).
> 
> When it fails, there is no output on the serial console, so I don't
> know exactly how it's failing, just that it no longer boots.

We tried out latest 4.15 with various compilers and it works:
- gcc version 7.1.1 20170622 (Red Hat Cross 7.1.1-3) (GCC) - A10 Gemei G9 tablet
- gcc 7.2.0-debian - A10 Cubieboard

> 
> Kevin
> 
> [1] https://kernelci.org/boot/id/5a2e10cd59b51430a9afa173/
> 
> > ---
> >  arch/arm/boot/dts/sun4i-a10.dtsi | 636 
> >  1 file changed, 82 insertions(+), 554 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi 
> > b/arch/arm/boot/dts/sun4i-a10.dtsi
> > index ba20b48..0d8320a 100644
> > --- a/arch/arm/boot/dts/sun4i-a10.dtsi
> > +++ b/arch/arm/boot/dts/sun4i-a10.dtsi
> > @@ -45,7 +45,8 @@
> >
> >  #include 
> >
> > -#include 
> > +#include 
> > +#include 
> >  #include 
> >  #include 
> >
> > @@ -65,9 +66,9 @@
> > compatible = "allwinner,simple-framebuffer",
> >  "simple-framebuffer";
> > allwinner,pipeline = "de_be0-lcd0-hdmi";
> > -   clocks = <_gates 36>, <_gates 43>,
> > -<_gates 44>, <_be0_clk>,
> > -<_ch1_clk>, <_gates 26>;
> > +   clocks = < CLK_AHB_LCD0>, < CLK_AHB_HDMI1>,
> > +< CLK_AHB_DE_BE0>, < CLK_DE_BE0>,
> > +< CLK_TCON0_CH1>, < 
> > CLK_DRAM_DE_BE0>;
> > status = "disabled";
> > };
> >
> > @@ -75,10 +76,11 @@
> > compatible = "allwinner,simple-framebuffer",
> >  "simple-framebuffer";
> > allwinner,pipeline = "de_fe0-de_be0-lcd0-hdmi";
> > -   clocks = <_gates 36>, <_gates 43>,
> > -<_gates 44>, <_gates 46>,
> > -<_be0_clk>, <_fe0_clk>, 
> > <_ch1_clk>,
> > -<_gates 25>, <_gates 26>;
> > +   clocks = < CLK_AHB_LCD0>, < CLK_AHB_HDMI1>,
> > +< CLK_AHB_DE_BE0>, < 
> > CLK_AHB_DE_FE0>,
> > +< CLK_DE_BE0>, < CLK_DE_FE0>,
> > +< CLK_TCON0_CH1>,
> > +< CLK_DRAM_DE_FE0>, < 
> > CLK_DRAM_DE_BE0>;
> > status = "disabled";
> > };
> >
> > @@ -86,9 +88,10 @@
> > compatible = "allwinner,simple-framebuffer",
> >  "simple-framebuffer";
> > allwinner,pipeline = "de_fe0-de_be0-lcd0";
> > -   clocks = <_gates 36>, <_gates 44>, 
> > <_gates 46>,
> > -<_be0_clk>, <_fe0_clk>, 
> > <_ch0_clk>,
> > -<_gates 25>, <_gates 26>;
> > +   clocks = < CLK_AHB_LCD0>, < CLK_AHB_DE_BE0>,
> > +< CLK_AHB_DE_FE0>, < CLK_DE_BE0>,
> > +< CLK_DE_FE0>, < CLK_TCON0_CH1>,
> > +< CLK_DRAM_DE_FE0>, < 
> > CLK_DRAM_DE_BE0>;
> > status = "disabled";
> > };
> >
> > @@ -96,11 +99,11 @@
> > compatible = "allwinner,simple-framebuffer",
> >  "simple-framebuffer";
> > allwinner,pipeline = "de_fe0-de_be0-lcd0-tve0";
> > -   clocks = <_gates 34>, <_gates 36>,
> > -<_gates 44>, <_gates 46>,
> > -<_be0_clk>, <_fe0_clk>,
> > -<_ch1_clk>, <_gates 5>,
> > -<_gates 25>, <_gates 26>;
> > +   clocks = < CLK_AHB_TVE0>, < CLK_AHB_LCD0>,
> > +< CLK_AHB_DE_BE0>, < 
> > CLK_AHB_DE_FE0>,
> > +< CLK_DE_BE0>, < CLK_DE_FE0>,
> > +< CLK_TCON0_CH1>, < CLK_DRAM_TVE0>,
> > +< CLK_DRAM_DE_FE0>, < 
> > CLK_DRAM_DE_BE0>;
> > status = "disabled";
> > };
> > };
> > @@ -112,7 +115,7 @@
> > device_type = "cpu";
> >

Re: [linux-sunxi] [PATCH v2 3/6] ARM: sun4i: Convert to CCU

[Priit Laes]

On Mon, Dec 11, 2017 at 02:22:30PM -0800, Kevin Hilman wrote:
> On Sun, Mar 26, 2017 at 10:20 AM, Priit Laes  wrote:
> > Convert sun4i-a10.dtsi to new CCU driver.
> >
> > Signed-off-by: Priit Laes 
> 
> I finally got around to bisecting a mainline boot failure on
> sun4i-a10-cubieboard that's been happening for quite a while.  Based
> on on kernelci.org, it showed up sometime during the v4.15 merge
> window[1].  It bisected down to this commit (in mainline as commit
> 41193869f2bdb585ce09bfdd16d9482aadd560ad).
> 
> When it fails, there is no output on the serial console, so I don't
> know exactly how it's failing, just that it no longer boots.

We tried out latest 4.15 with various compilers and it works:
- gcc version 7.1.1 20170622 (Red Hat Cross 7.1.1-3) (GCC) - A10 Gemei G9 tablet
- gcc 7.2.0-debian - A10 Cubieboard

> 
> Kevin
> 
> [1] https://kernelci.org/boot/id/5a2e10cd59b51430a9afa173/
> 
> > ---
> >  arch/arm/boot/dts/sun4i-a10.dtsi | 636 
> >  1 file changed, 82 insertions(+), 554 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi 
> > b/arch/arm/boot/dts/sun4i-a10.dtsi
> > index ba20b48..0d8320a 100644
> > --- a/arch/arm/boot/dts/sun4i-a10.dtsi
> > +++ b/arch/arm/boot/dts/sun4i-a10.dtsi
> > @@ -45,7 +45,8 @@
> >
> >  #include 
> >
> > -#include 
> > +#include 
> > +#include 
> >  #include 
> >  #include 
> >
> > @@ -65,9 +66,9 @@
> > compatible = "allwinner,simple-framebuffer",
> >  "simple-framebuffer";
> > allwinner,pipeline = "de_be0-lcd0-hdmi";
> > -   clocks = <_gates 36>, <_gates 43>,
> > -<_gates 44>, <_be0_clk>,
> > -<_ch1_clk>, <_gates 26>;
> > +   clocks = < CLK_AHB_LCD0>, < CLK_AHB_HDMI1>,
> > +< CLK_AHB_DE_BE0>, < CLK_DE_BE0>,
> > +< CLK_TCON0_CH1>, < 
> > CLK_DRAM_DE_BE0>;
> > status = "disabled";
> > };
> >
> > @@ -75,10 +76,11 @@
> > compatible = "allwinner,simple-framebuffer",
> >  "simple-framebuffer";
> > allwinner,pipeline = "de_fe0-de_be0-lcd0-hdmi";
> > -   clocks = <_gates 36>, <_gates 43>,
> > -<_gates 44>, <_gates 46>,
> > -<_be0_clk>, <_fe0_clk>, 
> > <_ch1_clk>,
> > -<_gates 25>, <_gates 26>;
> > +   clocks = < CLK_AHB_LCD0>, < CLK_AHB_HDMI1>,
> > +< CLK_AHB_DE_BE0>, < 
> > CLK_AHB_DE_FE0>,
> > +< CLK_DE_BE0>, < CLK_DE_FE0>,
> > +< CLK_TCON0_CH1>,
> > +< CLK_DRAM_DE_FE0>, < 
> > CLK_DRAM_DE_BE0>;
> > status = "disabled";
> > };
> >
> > @@ -86,9 +88,10 @@
> > compatible = "allwinner,simple-framebuffer",
> >  "simple-framebuffer";
> > allwinner,pipeline = "de_fe0-de_be0-lcd0";
> > -   clocks = <_gates 36>, <_gates 44>, 
> > <_gates 46>,
> > -<_be0_clk>, <_fe0_clk>, 
> > <_ch0_clk>,
> > -<_gates 25>, <_gates 26>;
> > +   clocks = < CLK_AHB_LCD0>, < CLK_AHB_DE_BE0>,
> > +< CLK_AHB_DE_FE0>, < CLK_DE_BE0>,
> > +< CLK_DE_FE0>, < CLK_TCON0_CH1>,
> > +< CLK_DRAM_DE_FE0>, < 
> > CLK_DRAM_DE_BE0>;
> > status = "disabled";
> > };
> >
> > @@ -96,11 +99,11 @@
> > compatible = "allwinner,simple-framebuffer",
> >  "simple-framebuffer";
> > allwinner,pipeline = "de_fe0-de_be0-lcd0-tve0";
> > -   clocks = <_gates 34>, <_gates 36>,
> > -<_gates 44>, <_gates 46>,
> > -<_be0_clk>, <_fe0_clk>,
> > -<_ch1_clk>, <_gates 5>,
> > -<_gates 25>, <_gates 26>;
> > +   clocks = < CLK_AHB_TVE0>, < CLK_AHB_LCD0>,
> > +< CLK_AHB_DE_BE0>, < 
> > CLK_AHB_DE_FE0>,
> > +< CLK_DE_BE0>, < CLK_DE_FE0>,
> > +< CLK_TCON0_CH1>, < CLK_DRAM_TVE0>,
> > +< CLK_DRAM_DE_FE0>, < 
> > CLK_DRAM_DE_BE0>;
> > status = "disabled";
> > };
> > };
> > @@ -112,7 +115,7 @@
> > device_type = "cpu";
> > compatible = 

Re: [linux-sunxi] [PATCH v2 3/6] ARM: sun4i: Convert to CCU

[Priit Laes]

On Mon, Dec 11, 2017 at 02:22:30PM -0800, Kevin Hilman wrote:
> On Sun, Mar 26, 2017 at 10:20 AM, Priit Laes  wrote:
> > Convert sun4i-a10.dtsi to new CCU driver.
> >
> > Signed-off-by: Priit Laes 
> 
> I finally got around to bisecting a mainline boot failure on
> sun4i-a10-cubieboard that's been happening for quite a while.  Based
> on on kernelci.org, it showed up sometime during the v4.15 merge
> window[1].  It bisected down to this commit (in mainline as commit
> 41193869f2bdb585ce09bfdd16d9482aadd560ad).
> 
> When it fails, there is no output on the serial console, so I don't
> know exactly how it's failing, just that it no longer boots.

Yeah, lack of output really looks like something gone wrong in clock setup,
though the commit itself has been sitting in tree for a while and the
same board has gotten actually bunch of features enabled after my clock
patches (drm modesetting + hdmi support).

I noticed that you're using GCC 5.3.1. Can you try with newer toolchain?

Priit

> 
> Kevin
> 
> [1] https://kernelci.org/boot/id/5a2e10cd59b51430a9afa173/
> 
> > ---
> >  arch/arm/boot/dts/sun4i-a10.dtsi | 636 
> >  1 file changed, 82 insertions(+), 554 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi 
> > b/arch/arm/boot/dts/sun4i-a10.dtsi
> > index ba20b48..0d8320a 100644
> > --- a/arch/arm/boot/dts/sun4i-a10.dtsi
> > +++ b/arch/arm/boot/dts/sun4i-a10.dtsi
> > @@ -45,7 +45,8 @@
> >
> >  #include 
> >
> > -#include 
> > +#include 
> > +#include 
> >  #include 
> >  #include 
> >
> > @@ -65,9 +66,9 @@
> > compatible = "allwinner,simple-framebuffer",
> >  "simple-framebuffer";
> > allwinner,pipeline = "de_be0-lcd0-hdmi";
> > -   clocks = <_gates 36>, <_gates 43>,
> > -<_gates 44>, <_be0_clk>,
> > -<_ch1_clk>, <_gates 26>;
> > +   clocks = < CLK_AHB_LCD0>, < CLK_AHB_HDMI1>,
> > +< CLK_AHB_DE_BE0>, < CLK_DE_BE0>,
> > +< CLK_TCON0_CH1>, < 
> > CLK_DRAM_DE_BE0>;
> > status = "disabled";
> > };
> >
> > @@ -75,10 +76,11 @@
> > compatible = "allwinner,simple-framebuffer",
> >  "simple-framebuffer";
> > allwinner,pipeline = "de_fe0-de_be0-lcd0-hdmi";
> > -   clocks = <_gates 36>, <_gates 43>,
> > -<_gates 44>, <_gates 46>,
> > -<_be0_clk>, <_fe0_clk>, 
> > <_ch1_clk>,
> > -<_gates 25>, <_gates 26>;
> > +   clocks = < CLK_AHB_LCD0>, < CLK_AHB_HDMI1>,
> > +< CLK_AHB_DE_BE0>, < 
> > CLK_AHB_DE_FE0>,
> > +< CLK_DE_BE0>, < CLK_DE_FE0>,
> > +< CLK_TCON0_CH1>,
> > +< CLK_DRAM_DE_FE0>, < 
> > CLK_DRAM_DE_BE0>;
> > status = "disabled";
> > };
> >
> > @@ -86,9 +88,10 @@
> > compatible = "allwinner,simple-framebuffer",
> >  "simple-framebuffer";
> > allwinner,pipeline = "de_fe0-de_be0-lcd0";
> > -   clocks = <_gates 36>, <_gates 44>, 
> > <_gates 46>,
> > -<_be0_clk>, <_fe0_clk>, 
> > <_ch0_clk>,
> > -<_gates 25>, <_gates 26>;
> > +   clocks = < CLK_AHB_LCD0>, < CLK_AHB_DE_BE0>,
> > +< CLK_AHB_DE_FE0>, < CLK_DE_BE0>,
> > +< CLK_DE_FE0>, < CLK_TCON0_CH1>,
> > +< CLK_DRAM_DE_FE0>, < 
> > CLK_DRAM_DE_BE0>;
> > status = "disabled";
> > };
> >
> > @@ -96,11 +99,11 @@
> > compatible = "allwinner,simple-framebuffer",
> >  "simple-framebuffer";
> > allwinner,pipeline = "de_fe0-de_be0-lcd0-tve0";
> > -   clocks = <_gates 34>, <_gates 36>,
> > -<_gates 44>, <_gates 46>,
> > -<_be0_clk>, <_fe0_clk>,
> > -<_ch1_clk>, <_gates 5>,
> > -<_gates 25>, <_gates 26>;
> > +   clocks = < CLK_AHB_TVE0>, < CLK_AHB_LCD0>,
> > +< CLK_AHB_DE_BE0>, < 
> > CLK_AHB_DE_FE0>,
> > +< CLK_DE_BE0>, < CLK_DE_FE0>,
> > +< CLK_TCON0_CH1>, < CLK_DRAM_TVE0>,
> > +< CLK_DRAM_DE_FE0>, < 
> > CLK_DRAM_DE_BE0>;
> >  

Re: [linux-sunxi] [PATCH v2 3/6] ARM: sun4i: Convert to CCU

[Priit Laes]

On Mon, Dec 11, 2017 at 02:22:30PM -0800, Kevin Hilman wrote:
> On Sun, Mar 26, 2017 at 10:20 AM, Priit Laes  wrote:
> > Convert sun4i-a10.dtsi to new CCU driver.
> >
> > Signed-off-by: Priit Laes 
> 
> I finally got around to bisecting a mainline boot failure on
> sun4i-a10-cubieboard that's been happening for quite a while.  Based
> on on kernelci.org, it showed up sometime during the v4.15 merge
> window[1].  It bisected down to this commit (in mainline as commit
> 41193869f2bdb585ce09bfdd16d9482aadd560ad).
> 
> When it fails, there is no output on the serial console, so I don't
> know exactly how it's failing, just that it no longer boots.

Yeah, lack of output really looks like something gone wrong in clock setup,
though the commit itself has been sitting in tree for a while and the
same board has gotten actually bunch of features enabled after my clock
patches (drm modesetting + hdmi support).

I noticed that you're using GCC 5.3.1. Can you try with newer toolchain?

Priit

> 
> Kevin
> 
> [1] https://kernelci.org/boot/id/5a2e10cd59b51430a9afa173/
> 
> > ---
> >  arch/arm/boot/dts/sun4i-a10.dtsi | 636 
> >  1 file changed, 82 insertions(+), 554 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi 
> > b/arch/arm/boot/dts/sun4i-a10.dtsi
> > index ba20b48..0d8320a 100644
> > --- a/arch/arm/boot/dts/sun4i-a10.dtsi
> > +++ b/arch/arm/boot/dts/sun4i-a10.dtsi
> > @@ -45,7 +45,8 @@
> >
> >  #include 
> >
> > -#include 
> > +#include 
> > +#include 
> >  #include 
> >  #include 
> >
> > @@ -65,9 +66,9 @@
> > compatible = "allwinner,simple-framebuffer",
> >  "simple-framebuffer";
> > allwinner,pipeline = "de_be0-lcd0-hdmi";
> > -   clocks = <_gates 36>, <_gates 43>,
> > -<_gates 44>, <_be0_clk>,
> > -<_ch1_clk>, <_gates 26>;
> > +   clocks = < CLK_AHB_LCD0>, < CLK_AHB_HDMI1>,
> > +< CLK_AHB_DE_BE0>, < CLK_DE_BE0>,
> > +< CLK_TCON0_CH1>, < 
> > CLK_DRAM_DE_BE0>;
> > status = "disabled";
> > };
> >
> > @@ -75,10 +76,11 @@
> > compatible = "allwinner,simple-framebuffer",
> >  "simple-framebuffer";
> > allwinner,pipeline = "de_fe0-de_be0-lcd0-hdmi";
> > -   clocks = <_gates 36>, <_gates 43>,
> > -<_gates 44>, <_gates 46>,
> > -<_be0_clk>, <_fe0_clk>, 
> > <_ch1_clk>,
> > -<_gates 25>, <_gates 26>;
> > +   clocks = < CLK_AHB_LCD0>, < CLK_AHB_HDMI1>,
> > +< CLK_AHB_DE_BE0>, < 
> > CLK_AHB_DE_FE0>,
> > +< CLK_DE_BE0>, < CLK_DE_FE0>,
> > +< CLK_TCON0_CH1>,
> > +< CLK_DRAM_DE_FE0>, < 
> > CLK_DRAM_DE_BE0>;
> > status = "disabled";
> > };
> >
> > @@ -86,9 +88,10 @@
> > compatible = "allwinner,simple-framebuffer",
> >  "simple-framebuffer";
> > allwinner,pipeline = "de_fe0-de_be0-lcd0";
> > -   clocks = <_gates 36>, <_gates 44>, 
> > <_gates 46>,
> > -<_be0_clk>, <_fe0_clk>, 
> > <_ch0_clk>,
> > -<_gates 25>, <_gates 26>;
> > +   clocks = < CLK_AHB_LCD0>, < CLK_AHB_DE_BE0>,
> > +< CLK_AHB_DE_FE0>, < CLK_DE_BE0>,
> > +< CLK_DE_FE0>, < CLK_TCON0_CH1>,
> > +< CLK_DRAM_DE_FE0>, < 
> > CLK_DRAM_DE_BE0>;
> > status = "disabled";
> > };
> >
> > @@ -96,11 +99,11 @@
> > compatible = "allwinner,simple-framebuffer",
> >  "simple-framebuffer";
> > allwinner,pipeline = "de_fe0-de_be0-lcd0-tve0";
> > -   clocks = <_gates 34>, <_gates 36>,
> > -<_gates 44>, <_gates 46>,
> > -<_be0_clk>, <_fe0_clk>,
> > -<_ch1_clk>, <_gates 5>,
> > -<_gates 25>, <_gates 26>;
> > +   clocks = < CLK_AHB_TVE0>, < CLK_AHB_LCD0>,
> > +< CLK_AHB_DE_BE0>, < 
> > CLK_AHB_DE_FE0>,
> > +< CLK_DE_BE0>, < CLK_DE_FE0>,
> > +< CLK_TCON0_CH1>, < CLK_DRAM_TVE0>,
> > +< CLK_DRAM_DE_FE0>, < 
> > CLK_DRAM_DE_BE0>;
> > status = "disabled";
> >   

Re: [linux-sunxi] [PATCH v2 3/6] ARM: sun4i: Convert to CCU

[Kevin Hilman]

On Sun, Mar 26, 2017 at 10:20 AM, Priit Laes  wrote:
> Convert sun4i-a10.dtsi to new CCU driver.
>
> Signed-off-by: Priit Laes 

I finally got around to bisecting a mainline boot failure on
sun4i-a10-cubieboard that's been happening for quite a while.  Based
on on kernelci.org, it showed up sometime during the v4.15 merge
window[1].  It bisected down to this commit (in mainline as commit
41193869f2bdb585ce09bfdd16d9482aadd560ad).

When it fails, there is no output on the serial console, so I don't
know exactly how it's failing, just that it no longer boots.

Kevin

[1] https://kernelci.org/boot/id/5a2e10cd59b51430a9afa173/

> ---
>  arch/arm/boot/dts/sun4i-a10.dtsi | 636 
>  1 file changed, 82 insertions(+), 554 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi 
> b/arch/arm/boot/dts/sun4i-a10.dtsi
> index ba20b48..0d8320a 100644
> --- a/arch/arm/boot/dts/sun4i-a10.dtsi
> +++ b/arch/arm/boot/dts/sun4i-a10.dtsi
> @@ -45,7 +45,8 @@
>
>  #include 
>
> -#include 
> +#include 
> +#include 
>  #include 
>  #include 
>
> @@ -65,9 +66,9 @@
> compatible = "allwinner,simple-framebuffer",
>  "simple-framebuffer";
> allwinner,pipeline = "de_be0-lcd0-hdmi";
> -   clocks = <_gates 36>, <_gates 43>,
> -<_gates 44>, <_be0_clk>,
> -<_ch1_clk>, <_gates 26>;
> +   clocks = < CLK_AHB_LCD0>, < CLK_AHB_HDMI1>,
> +< CLK_AHB_DE_BE0>, < CLK_DE_BE0>,
> +< CLK_TCON0_CH1>, < CLK_DRAM_DE_BE0>;
> status = "disabled";
> };
>
> @@ -75,10 +76,11 @@
> compatible = "allwinner,simple-framebuffer",
>  "simple-framebuffer";
> allwinner,pipeline = "de_fe0-de_be0-lcd0-hdmi";
> -   clocks = <_gates 36>, <_gates 43>,
> -<_gates 44>, <_gates 46>,
> -<_be0_clk>, <_fe0_clk>, 
> <_ch1_clk>,
> -<_gates 25>, <_gates 26>;
> +   clocks = < CLK_AHB_LCD0>, < CLK_AHB_HDMI1>,
> +< CLK_AHB_DE_BE0>, < CLK_AHB_DE_FE0>,
> +< CLK_DE_BE0>, < CLK_DE_FE0>,
> +< CLK_TCON0_CH1>,
> +< CLK_DRAM_DE_FE0>, < 
> CLK_DRAM_DE_BE0>;
> status = "disabled";
> };
>
> @@ -86,9 +88,10 @@
> compatible = "allwinner,simple-framebuffer",
>  "simple-framebuffer";
> allwinner,pipeline = "de_fe0-de_be0-lcd0";
> -   clocks = <_gates 36>, <_gates 44>, 
> <_gates 46>,
> -<_be0_clk>, <_fe0_clk>, 
> <_ch0_clk>,
> -<_gates 25>, <_gates 26>;
> +   clocks = < CLK_AHB_LCD0>, < CLK_AHB_DE_BE0>,
> +< CLK_AHB_DE_FE0>, < CLK_DE_BE0>,
> +< CLK_DE_FE0>, < CLK_TCON0_CH1>,
> +< CLK_DRAM_DE_FE0>, < 
> CLK_DRAM_DE_BE0>;
> status = "disabled";
> };
>
> @@ -96,11 +99,11 @@
> compatible = "allwinner,simple-framebuffer",
>  "simple-framebuffer";
> allwinner,pipeline = "de_fe0-de_be0-lcd0-tve0";
> -   clocks = <_gates 34>, <_gates 36>,
> -<_gates 44>, <_gates 46>,
> -<_be0_clk>, <_fe0_clk>,
> -<_ch1_clk>, <_gates 5>,
> -<_gates 25>, <_gates 26>;
> +   clocks = < CLK_AHB_TVE0>, < CLK_AHB_LCD0>,
> +< CLK_AHB_DE_BE0>, < CLK_AHB_DE_FE0>,
> +< CLK_DE_BE0>, < CLK_DE_FE0>,
> +< CLK_TCON0_CH1>, < CLK_DRAM_TVE0>,
> +< CLK_DRAM_DE_FE0>, < 
> CLK_DRAM_DE_BE0>;
> status = "disabled";
> };
> };
> @@ -112,7 +115,7 @@
> device_type = "cpu";
> compatible = "arm,cortex-a8";
> reg = <0x0>;
> -   clocks = <>;
> +   clocks = < CLK_CPU>;
> clock-latency = <244144>; /* 8 32k periods */
> operating-points = <
> /* kHzuV */
> @@ -168,18 +171,6 @@
> #size-cells = <1>;
> ranges;
>
> -   /*
> -* This is a 

Re: [linux-sunxi] [PATCH v2 3/6] ARM: sun4i: Convert to CCU

[Kevin Hilman]

On Sun, Mar 26, 2017 at 10:20 AM, Priit Laes  wrote:
> Convert sun4i-a10.dtsi to new CCU driver.
>
> Signed-off-by: Priit Laes 

I finally got around to bisecting a mainline boot failure on
sun4i-a10-cubieboard that's been happening for quite a while.  Based
on on kernelci.org, it showed up sometime during the v4.15 merge
window[1].  It bisected down to this commit (in mainline as commit
41193869f2bdb585ce09bfdd16d9482aadd560ad).

When it fails, there is no output on the serial console, so I don't
know exactly how it's failing, just that it no longer boots.

Kevin

[1] https://kernelci.org/boot/id/5a2e10cd59b51430a9afa173/

> ---
>  arch/arm/boot/dts/sun4i-a10.dtsi | 636 
>  1 file changed, 82 insertions(+), 554 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi 
> b/arch/arm/boot/dts/sun4i-a10.dtsi
> index ba20b48..0d8320a 100644
> --- a/arch/arm/boot/dts/sun4i-a10.dtsi
> +++ b/arch/arm/boot/dts/sun4i-a10.dtsi
> @@ -45,7 +45,8 @@
>
>  #include 
>
> -#include 
> +#include 
> +#include 
>  #include 
>  #include 
>
> @@ -65,9 +66,9 @@
> compatible = "allwinner,simple-framebuffer",
>  "simple-framebuffer";
> allwinner,pipeline = "de_be0-lcd0-hdmi";
> -   clocks = <_gates 36>, <_gates 43>,
> -<_gates 44>, <_be0_clk>,
> -<_ch1_clk>, <_gates 26>;
> +   clocks = < CLK_AHB_LCD0>, < CLK_AHB_HDMI1>,
> +< CLK_AHB_DE_BE0>, < CLK_DE_BE0>,
> +< CLK_TCON0_CH1>, < CLK_DRAM_DE_BE0>;
> status = "disabled";
> };
>
> @@ -75,10 +76,11 @@
> compatible = "allwinner,simple-framebuffer",
>  "simple-framebuffer";
> allwinner,pipeline = "de_fe0-de_be0-lcd0-hdmi";
> -   clocks = <_gates 36>, <_gates 43>,
> -<_gates 44>, <_gates 46>,
> -<_be0_clk>, <_fe0_clk>, 
> <_ch1_clk>,
> -<_gates 25>, <_gates 26>;
> +   clocks = < CLK_AHB_LCD0>, < CLK_AHB_HDMI1>,
> +< CLK_AHB_DE_BE0>, < CLK_AHB_DE_FE0>,
> +< CLK_DE_BE0>, < CLK_DE_FE0>,
> +< CLK_TCON0_CH1>,
> +< CLK_DRAM_DE_FE0>, < 
> CLK_DRAM_DE_BE0>;
> status = "disabled";
> };
>
> @@ -86,9 +88,10 @@
> compatible = "allwinner,simple-framebuffer",
>  "simple-framebuffer";
> allwinner,pipeline = "de_fe0-de_be0-lcd0";
> -   clocks = <_gates 36>, <_gates 44>, 
> <_gates 46>,
> -<_be0_clk>, <_fe0_clk>, 
> <_ch0_clk>,
> -<_gates 25>, <_gates 26>;
> +   clocks = < CLK_AHB_LCD0>, < CLK_AHB_DE_BE0>,
> +< CLK_AHB_DE_FE0>, < CLK_DE_BE0>,
> +< CLK_DE_FE0>, < CLK_TCON0_CH1>,
> +< CLK_DRAM_DE_FE0>, < 
> CLK_DRAM_DE_BE0>;
> status = "disabled";
> };
>
> @@ -96,11 +99,11 @@
> compatible = "allwinner,simple-framebuffer",
>  "simple-framebuffer";
> allwinner,pipeline = "de_fe0-de_be0-lcd0-tve0";
> -   clocks = <_gates 34>, <_gates 36>,
> -<_gates 44>, <_gates 46>,
> -<_be0_clk>, <_fe0_clk>,
> -<_ch1_clk>, <_gates 5>,
> -<_gates 25>, <_gates 26>;
> +   clocks = < CLK_AHB_TVE0>, < CLK_AHB_LCD0>,
> +< CLK_AHB_DE_BE0>, < CLK_AHB_DE_FE0>,
> +< CLK_DE_BE0>, < CLK_DE_FE0>,
> +< CLK_TCON0_CH1>, < CLK_DRAM_TVE0>,
> +< CLK_DRAM_DE_FE0>, < 
> CLK_DRAM_DE_BE0>;
> status = "disabled";
> };
> };
> @@ -112,7 +115,7 @@
> device_type = "cpu";
> compatible = "arm,cortex-a8";
> reg = <0x0>;
> -   clocks = <>;
> +   clocks = < CLK_CPU>;
> clock-latency = <244144>; /* 8 32k periods */
> operating-points = <
> /* kHzuV */
> @@ -168,18 +171,6 @@
> #size-cells = <1>;
> ranges;
>
> -   /*
> -* This is a dummy clock, to be used as