Re: [linux-sunxi] [PATCH v4 09/10] ARM: dtsi: axp81x: add GPIO DT node
Hi, On Tue, Dec 05, 2017 at 05:24:47PM +0800, Chen-Yu Tsai wrote: > On Fri, Dec 1, 2017 at 9:44 PM, Quentin Schulz >wrote: > > This adds DT node for the GPIO/pinctrl part present in AXP813/AXP818. > > > > Signed-off-by: Quentin Schulz > > --- > > arch/arm/boot/dts/axp81x.dtsi | 6 ++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/arch/arm/boot/dts/axp81x.dtsi b/arch/arm/boot/dts/axp81x.dtsi > > index 73b761f..0ef959d 100644 > > --- a/arch/arm/boot/dts/axp81x.dtsi > > +++ b/arch/arm/boot/dts/axp81x.dtsi > > @@ -48,6 +48,12 @@ > > interrupt-controller; > > #interrupt-cells = <1>; > > > > + axp_gpio: axp-gpio { > > + compatible = "x-powers,axp813-gpio"; > > + gpio-controller; > > + #gpio-cells = <2>; > > What about interrupt-controller for directly referenced interrupts from > the GPIO pins? There's a bit more to it to enable interrupts. You would probably need to set up a chained interrupt controller in the GPIO driver, and in the DTS with a interrupt-parent and interrupts properties pointing to the AXP device itself. > Otherwise, > > Acked-by: Chen-Yu Tsai Applied 9 and 10, thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com signature.asc Description: PGP signature
Re: [linux-sunxi] [PATCH v4 09/10] ARM: dtsi: axp81x: add GPIO DT node
Hi, On Tue, Dec 05, 2017 at 05:24:47PM +0800, Chen-Yu Tsai wrote: > On Fri, Dec 1, 2017 at 9:44 PM, Quentin Schulz > wrote: > > This adds DT node for the GPIO/pinctrl part present in AXP813/AXP818. > > > > Signed-off-by: Quentin Schulz > > --- > > arch/arm/boot/dts/axp81x.dtsi | 6 ++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/arch/arm/boot/dts/axp81x.dtsi b/arch/arm/boot/dts/axp81x.dtsi > > index 73b761f..0ef959d 100644 > > --- a/arch/arm/boot/dts/axp81x.dtsi > > +++ b/arch/arm/boot/dts/axp81x.dtsi > > @@ -48,6 +48,12 @@ > > interrupt-controller; > > #interrupt-cells = <1>; > > > > + axp_gpio: axp-gpio { > > + compatible = "x-powers,axp813-gpio"; > > + gpio-controller; > > + #gpio-cells = <2>; > > What about interrupt-controller for directly referenced interrupts from > the GPIO pins? There's a bit more to it to enable interrupts. You would probably need to set up a chained interrupt controller in the GPIO driver, and in the DTS with a interrupt-parent and interrupts properties pointing to the AXP device itself. > Otherwise, > > Acked-by: Chen-Yu Tsai Applied 9 and 10, thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com signature.asc Description: PGP signature
Re: [linux-sunxi] [PATCH v4 09/10] ARM: dtsi: axp81x: add GPIO DT node
On Fri, Dec 1, 2017 at 9:44 PM, Quentin Schulzwrote: > This adds DT node for the GPIO/pinctrl part present in AXP813/AXP818. > > Signed-off-by: Quentin Schulz > --- > arch/arm/boot/dts/axp81x.dtsi | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/boot/dts/axp81x.dtsi b/arch/arm/boot/dts/axp81x.dtsi > index 73b761f..0ef959d 100644 > --- a/arch/arm/boot/dts/axp81x.dtsi > +++ b/arch/arm/boot/dts/axp81x.dtsi > @@ -48,6 +48,12 @@ > interrupt-controller; > #interrupt-cells = <1>; > > + axp_gpio: axp-gpio { > + compatible = "x-powers,axp813-gpio"; > + gpio-controller; > + #gpio-cells = <2>; What about interrupt-controller for directly referenced interrupts from the GPIO pins? Otherwise, Acked-by: Chen-Yu Tsai > + }; > + > regulators { > /* Default work frequency for buck regulators */ > x-powers,dcdc-freq = <3000>; > -- > git-series 0.9.1 > > -- > You received this message because you are subscribed to the Google Groups > "linux-sunxi" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to linux-sunxi+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout.
Re: [linux-sunxi] [PATCH v4 09/10] ARM: dtsi: axp81x: add GPIO DT node
On Fri, Dec 1, 2017 at 9:44 PM, Quentin Schulz wrote: > This adds DT node for the GPIO/pinctrl part present in AXP813/AXP818. > > Signed-off-by: Quentin Schulz > --- > arch/arm/boot/dts/axp81x.dtsi | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/boot/dts/axp81x.dtsi b/arch/arm/boot/dts/axp81x.dtsi > index 73b761f..0ef959d 100644 > --- a/arch/arm/boot/dts/axp81x.dtsi > +++ b/arch/arm/boot/dts/axp81x.dtsi > @@ -48,6 +48,12 @@ > interrupt-controller; > #interrupt-cells = <1>; > > + axp_gpio: axp-gpio { > + compatible = "x-powers,axp813-gpio"; > + gpio-controller; > + #gpio-cells = <2>; What about interrupt-controller for directly referenced interrupts from the GPIO pins? Otherwise, Acked-by: Chen-Yu Tsai > + }; > + > regulators { > /* Default work frequency for buck regulators */ > x-powers,dcdc-freq = <3000>; > -- > git-series 0.9.1 > > -- > You received this message because you are subscribed to the Google Groups > "linux-sunxi" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to linux-sunxi+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout.