Re: [linux-sunxi] [RFC PATCH 2/9] ARM: sunxi: add Allwinner ARMv5 SoCs
On Sat, Jan 20, 2018 at 02:22:06PM +1100, Julian Calaby wrote: > Hi Icenowy, > > On Sat, Jan 20, 2018 at 2:10 PM, Icenowy Zheng wrote: > > > > > > 于 2018年1月20日 GMT+08:00 上午11:06:40, Julian Calaby > > 写到: > >>Hi Icenowy, > >> > >>On Sat, Jan 20, 2018 at 10:17 AM, Icenowy Zheng > >>wrote: > >>> Add option for Allwinner ARMv5 SoCs and a SoC suniv (which is a die > >>used > >>> for many new F-series products, including F1C100A, F1C100s, F1C200s, > >>> F1C500, F1C600). > >>> > >>> Signed-off-by: Icenowy Zheng > >>> --- > >>> arch/arm/mach-sunxi/Kconfig| 13 + > >>> arch/arm/mach-sunxi/Makefile | 1 + > >>> arch/arm/mach-sunxi/sunxi_v5.c | 22 ++ > >>> 3 files changed, 36 insertions(+) > >>> create mode 100644 arch/arm/mach-sunxi/sunxi_v5.c > >>> > >>> diff --git a/arch/arm/mach-sunxi/Kconfig > >>b/arch/arm/mach-sunxi/Kconfig > >>> index 65509a35935f..78ac9ce70641 100644 > >>> --- a/arch/arm/mach-sunxi/Kconfig > >>> +++ b/arch/arm/mach-sunxi/Kconfig > >>> @@ -59,3 +59,16 @@ config MACH_SUN9I > >>> select ARM_GIC > >>> > >>> endif > >>> + > >>> +menuconfig ARCH_SUNXI_V5 > >>> + bool "Allwinner SoCs" > >> > >>That name seems a little too generic. Maybe "Allwinner ARMv5 SoCs"? > > > > This is already required by armv5. > > > > Allwinner currently has only ARMv5,7,8 SoCs. ARMv8 is under > > arm64 architecture, and ARMv5 and v7 cannot be selected at the same time. > > I'm going to try to back my way out of this hole by saying that they > should be more descriptive anyway (and it'll give clueless kconfiggers > a hint as to why they're not seeing their SoC listed) > > However you're right, if both cannot be visible at the same time, then > it really doesn't matter if they both have the same name. > > Sorry for the noise, This is definitely not noise, and I agree with you, having whether you're enabling the v5 or v7 SoCs will hopefully allow to end up in a situation where you search for hours why it won't boot. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com signature.asc Description: PGP signature
Re: [linux-sunxi] [RFC PATCH 2/9] ARM: sunxi: add Allwinner ARMv5 SoCs
Hi Icenowy, On Sat, Jan 20, 2018 at 2:10 PM, Icenowy Zheng wrote: > > > 于 2018年1月20日 GMT+08:00 上午11:06:40, Julian Calaby 写到: >>Hi Icenowy, >> >>On Sat, Jan 20, 2018 at 10:17 AM, Icenowy Zheng >>wrote: >>> Add option for Allwinner ARMv5 SoCs and a SoC suniv (which is a die >>used >>> for many new F-series products, including F1C100A, F1C100s, F1C200s, >>> F1C500, F1C600). >>> >>> Signed-off-by: Icenowy Zheng >>> --- >>> arch/arm/mach-sunxi/Kconfig| 13 + >>> arch/arm/mach-sunxi/Makefile | 1 + >>> arch/arm/mach-sunxi/sunxi_v5.c | 22 ++ >>> 3 files changed, 36 insertions(+) >>> create mode 100644 arch/arm/mach-sunxi/sunxi_v5.c >>> >>> diff --git a/arch/arm/mach-sunxi/Kconfig >>b/arch/arm/mach-sunxi/Kconfig >>> index 65509a35935f..78ac9ce70641 100644 >>> --- a/arch/arm/mach-sunxi/Kconfig >>> +++ b/arch/arm/mach-sunxi/Kconfig >>> @@ -59,3 +59,16 @@ config MACH_SUN9I >>> select ARM_GIC >>> >>> endif >>> + >>> +menuconfig ARCH_SUNXI_V5 >>> + bool "Allwinner SoCs" >> >>That name seems a little too generic. Maybe "Allwinner ARMv5 SoCs"? > > This is already required by armv5. > > Allwinner currently has only ARMv5,7,8 SoCs. ARMv8 is under > arm64 architecture, and ARMv5 and v7 cannot be selected at the same time. I'm going to try to back my way out of this hole by saying that they should be more descriptive anyway (and it'll give clueless kconfiggers a hint as to why they're not seeing their SoC listed) However you're right, if both cannot be visible at the same time, then it really doesn't matter if they both have the same name. Sorry for the noise, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/
Re: [linux-sunxi] [RFC PATCH 2/9] ARM: sunxi: add Allwinner ARMv5 SoCs
于 2018年1月20日 GMT+08:00 上午11:06:40, Julian Calaby 写到: >Hi Icenowy, > >On Sat, Jan 20, 2018 at 10:17 AM, Icenowy Zheng >wrote: >> Add option for Allwinner ARMv5 SoCs and a SoC suniv (which is a die >used >> for many new F-series products, including F1C100A, F1C100s, F1C200s, >> F1C500, F1C600). >> >> Signed-off-by: Icenowy Zheng >> --- >> arch/arm/mach-sunxi/Kconfig| 13 + >> arch/arm/mach-sunxi/Makefile | 1 + >> arch/arm/mach-sunxi/sunxi_v5.c | 22 ++ >> 3 files changed, 36 insertions(+) >> create mode 100644 arch/arm/mach-sunxi/sunxi_v5.c >> >> diff --git a/arch/arm/mach-sunxi/Kconfig >b/arch/arm/mach-sunxi/Kconfig >> index 65509a35935f..78ac9ce70641 100644 >> --- a/arch/arm/mach-sunxi/Kconfig >> +++ b/arch/arm/mach-sunxi/Kconfig >> @@ -59,3 +59,16 @@ config MACH_SUN9I >> select ARM_GIC >> >> endif >> + >> +menuconfig ARCH_SUNXI_V5 >> + bool "Allwinner SoCs" > >That name seems a little too generic. Maybe "Allwinner ARMv5 SoCs"? This is already required by armv5. Allwinner currently has only ARMv5,7,8 SoCs. ARMv8 is under arm64 architecture, and ARMv5 and v7 cannot be selected at the same time. > >Thanks,
Re: [linux-sunxi] [RFC PATCH 2/9] ARM: sunxi: add Allwinner ARMv5 SoCs
Hi Icenowy, On Sat, Jan 20, 2018 at 10:17 AM, Icenowy Zheng wrote: > Add option for Allwinner ARMv5 SoCs and a SoC suniv (which is a die used > for many new F-series products, including F1C100A, F1C100s, F1C200s, > F1C500, F1C600). > > Signed-off-by: Icenowy Zheng > --- > arch/arm/mach-sunxi/Kconfig| 13 + > arch/arm/mach-sunxi/Makefile | 1 + > arch/arm/mach-sunxi/sunxi_v5.c | 22 ++ > 3 files changed, 36 insertions(+) > create mode 100644 arch/arm/mach-sunxi/sunxi_v5.c > > diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig > index 65509a35935f..78ac9ce70641 100644 > --- a/arch/arm/mach-sunxi/Kconfig > +++ b/arch/arm/mach-sunxi/Kconfig > @@ -59,3 +59,16 @@ config MACH_SUN9I > select ARM_GIC > > endif > + > +menuconfig ARCH_SUNXI_V5 > + bool "Allwinner SoCs" That name seems a little too generic. Maybe "Allwinner ARMv5 SoCs"? Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/
